Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/35070/?format=api
{ "id": 35070, "url": "http://patches.dpdk.org/api/patches/35070/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1518107653-15466-2-git-send-email-matan@mellanox.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1518107653-15466-2-git-send-email-matan@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1518107653-15466-2-git-send-email-matan@mellanox.com", "date": "2018-02-08T16:34:11", "name": "[dpdk-dev,v5,1/3] net/failsafe: fix hotplug alarm cancel", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "085ebc75e9a29dde7f9cf4ffb6f7bce432cef3d9", "submitter": { "id": 796, "url": "http://patches.dpdk.org/api/people/796/?format=api", "name": "Matan Azrad", "email": "matan@mellanox.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1518107653-15466-2-git-send-email-matan@mellanox.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/35070/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/35070/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 877FB1B81F;\n\tThu, 8 Feb 2018 17:34:33 +0100 (CET)", "from EUR02-HE1-obe.outbound.protection.outlook.com\n\t(mail-eopbgr10089.outbound.protection.outlook.com [40.107.1.89])\n\tby dpdk.org (Postfix) with ESMTP id C10A51B80A;\n\tThu, 8 Feb 2018 17:34:31 +0100 (CET)", "from mellanox.com (37.142.13.130) by\n\tDB6PR0501MB2664.eurprd05.prod.outlook.com (2603:10a6:4:80::22) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.464.11;\n\tThu, 8 Feb 2018 16:34:29 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n\ts=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=hW3qRv22BVQOTg0XGF2MEMyJQK4DI3usj8g+pLuMXfw=;\n\tb=r1Iwg5UMDn4AvzYWXtcka2peLv3CJ4ff1pkgrAsjhYPZceEMJfATiPObdBY6jqbSJf2gZmBGnmuJ9Owtbpj1kFGL0fMOOaMFFd0AgkzQ8VvMJ1mIUEASzYYyqUlJYBu6zfOvLwUH0D9mAlH6Ih8xqNKb0BaMNx+Iso0DFH9XYug=", "Authentication-Results": "spf=none (sender IP is )\n\tsmtp.mailfrom=matan@mellanox.com; ", "From": "Matan Azrad <matan@mellanox.com>", "To": "Gaetan Rivet <gaetan.rivet@6wind.com>", "Cc": "dev@dpdk.org,\n\tstable@dpdk.org", "Date": "Thu, 8 Feb 2018 16:34:11 +0000", "Message-Id": "<1518107653-15466-2-git-send-email-matan@mellanox.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1518107653-15466-1-git-send-email-matan@mellanox.com>", "References": "<1518092427-4333-1-git-send-email-matan@mellanox.com>\n\t<1518107653-15466-1-git-send-email-matan@mellanox.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[37.142.13.130]", "X-ClientProxiedBy": "HE1PR0102CA0023.eurprd01.prod.exchangelabs.com\n\t(2603:10a6:7:14::36) To DB6PR0501MB2664.eurprd05.prod.outlook.com\n\t(2603:10a6:4:80::22)", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-HT": "Tenant", "X-MS-Office365-Filtering-Correlation-Id": "d0a13ba1-f8a5-4a00-bc9b-08d56f11d3fb", "X-Microsoft-Antispam": "UriScan:; BCL:0; PCL:0;\n\tRULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603307)(7153060)(7193020);\n\tSRVR:DB6PR0501MB2664; ", "X-Microsoft-Exchange-Diagnostics": [ "1; DB6PR0501MB2664;\n\t3:aSHLY7D2PFmUOffs1TZUGUrzeHHjPJKWLl3WPNB6MuPWe28/7j9JzskivMewWvg4J6/MTm/F584owN0nkL0GMJPBWsBJJmJLRjxy1A1OXyzppJNYo5RVEtLgvRQxqnVhXaJY8tzGt0zGqCfiqFR4OOf2i/oCfWuz67Ol5HtE/+2uDef7kUQLtu7fwxTA02P0P7bQ8L+HxmAvUjmmN7cq8oacypsqgqiiXTlE+cVaNBzMMIRA8594LQ9Bvyk/oXc0;\n\t25:C4HTBTtlQg/XAIy+H9AQOXf8OVUnNn+q4Zmprnu5yzVcLo2bRYvVIwK6baLQodksLVlYmW9sZdM4O4fBRgMli70yuUWDQjPOMRygv60gbCaMNi+KfBGrDHMFvZbkU1t8Y7WICIjagI14Qbv3qo+5lTLaW6OIbHnV7QY4+7rWrRJowrUTbG8sykWSqqI9kYM0xg8qifW9Nu6UyljD/cyUD+r076p3GgMxPP1/NN2F03Nb9Cj7RUPhRNSixGaSIfXjuBeVqOoulgjseEzDMqjuh0dCrLUNTIkea9EXcB3Siq2J0rKc/ETW7xANVnCQo+blhW/UFKV8A1gb7nhJHNSLVQ==;\n\t31:m7usGu9prkTXxQreuDB7lK4DHd8hhSGv1c4p89OclitoUcMn+hvLsdIKCrD2Gj/26newORNh1D1mz37ezyCgFG7Ekzk5yh5GDRVs9gqyW1XaRYmjV5Z3z+gjwn/mhFKRAduV9OXQeSPn1wbRLXzsGev8h0ztF8W1qQSTtug9aVfRMki27cA1yBoP3jdBBaHAE1J1SNxZpFghtWzg8Fk4rKVz37b3mQung6JGL/hLp5U=", "1; DB6PR0501MB2664;\n\t20:DH2I9hu4uozvLwz1kdXPvXl/2VS35SqNpJEZ6G9Yf2awEaRin4DdSOFVTf78zkaLMUEmHTJCQb/oUgEx1wu8MoWXGpf1b0gpeusOspeOR+gNRZncZZd0iBagdZoMpQyT3QrGKQgrYHPydsJ7ym3LpUv5mo6muGEOtVRrRDrEx9Pvz7MJAyky9c1An2LkmogcJcxFhxx6TqTNgEURpiIMacPOeDsU8BBHJCOnYDpdMBzT54pxgSwqp9qFD44D9CT/OSpfst+wKX/6HAnFGHYGYJ3Y91SX8Zy8cpSOELerqTsVm1StdFBHFhjJYczxmSlh/dIBWGEqoO2pPGVwZ/eP/ffwtqSZr7/liUAWZJITP98EyNJJVEyqd2R91zkFXxs/QgQG8KtoUADNue+itbqYD/D/tm8CJFEr4U3juKkLpwrgmr+9NazLi6W+qcw9V0QDOQ0m7NsV8/RhymQcGtklTEsjcKjceoFlZn/nvj1P6O9SPM6WxICAB57mtXTvtjV4;\n\t4:I7h2XI4LvPW53uAVBt5nZalbOapanlcR45aPdMPGNyPoGNM9r7k3f0GFIjfS9Z48WyXLFOAARcm2q7QWbTQGowe1OKOcws3aztt5Zifzq1NlC83ipem6+PHljmyzdZqFtZ+hYiRDSAh6Kdhbd1C8YGvoodsZ496x2/a3E5CiikvH/TDf8K/bHqmNZDMzvXJoj/bqW07UimXRqYsvyJl42yzMkQ2mScTy3dYfPdgI8y0s1Kw/zTSGpv0snFsznKbfEPv8SIaubZv242RQqLqkPA==", "=?us-ascii?Q?1; DB6PR0501MB2664;\n\t23:UxmjR+aDBVF3CtVhqM0Pihd1Zb5/jjFLUf+Ry6m?=\n\tWWZVR6G+ifAmVSdO1jaxabZMt038f9hy7yJmsli8D+AaBcGlIjDz/J7BbMu2lfbMX8sXwvjEqERNald3eALNgCvA1COeiLno8GJeo1ZqbfdVWAoMkkqtHvr1NW74YCaSJIhXhfSf7gDbp9zR4eiksRv+cbZH11KNA82n/X5LpDJyBue+LPW2iubuISYePHpjmoVl/TRkUUXOv3ROC39Fekeh3uWSoF1P/r3FkgcdVyw9Z54e1tRTMWsTaeWeIsE0KQ5Y4eL4rI3U0/vZ1R9X6Frqp4OFdWgZ560DqSpubUO3fA1W48rJDQKWAxqenGaegJMNAE190UAp0Ffn28U02KS9NS2lZmouSw5x9BCufbyZuy9zhz2lJGvOaTXQ63vUD2sXdCQUtoTPGCKc9EOarrNWuSEpEELGvHKUsChQaCdgr4NX5ASC37hFd8eas0Uy6/AsP61uT52jqkhvjogVTqW7NN/SqLD5N9jgJhrgzxzU2R7XRIeWwCKmdk4Y7cZpHvRAlxygf1reNKbT5CUdPz/eJzYL5hMnIAGDs8bZ8025qMKELC5z9mnadJMnhaWKRlNzQ6pEGrv37VCBN8GkXYVZT3nBjwat1BOXPwKHkZ2wPnoNqQTYtu0ZHeT6IDVtgEMEetm3p/Sqf6rhdkcvZdC3gd5bTKBob+8+r+O83zygAug2qS06GWYUaXRyFp1wARsCwGanY7+KhMbIEVUGhnkVsnj1ODHR8fg+n/snyPuVQeiiDdCQQeT1EKuQRXvJHuZC6XbzsHScOD7UYxQ2kg0ugD6JI2ppjhF6OU9VDaVAeFAuHcqSaEc+9PDWxgc3B5zxHzQ+1kW+F9uzTzbSC2e6MauE8djYuC1CIMhZGB8EcWSAkUNdQLbPuzcYLePIBHXKqoFO0UtiqJXk4BtHy7saa0bR0cEq+KnRMu5Rcvtvg0u0xXU7TcRXOn5WS2bH7m6lgmApc+LbzhbAEcwQ3xaXF6cXugHKC0J5c8zEfBaD1VAGyruCKkHwMWg+eyLZ3hAORCa2a2fmsQ4R/tLAEf25CB3PZrbpN3v8NGJ7VhTOp78wLwi0SfDT5cRtgVOuv/DxVjWjpyeO2qQhFz+M+B9PVRagHflbg22rA9tAO8c2eEUkkqr2CLz3H1P1mnbCIRnqJJF5Bpq8HcdgJtSPOAJm1", "1; DB6PR0501MB2664;\n\t6:SLU4Cl3QFsftLbgm9LIUrt/pG7tyrhkfj0nAViBnVSqUUkHJ55LjSJXighFsvCwKzgMCftFMb3UYChDd8930kcHQz09nOE76JWFhbersHGh7vYWpNYF/t9+DiNDzWaB9+wrq2bdhAQU9nc1QugXofqDDeRQ+RFq98Lvhw6xe2JYeMq7r7+BMiqnVIA4YL3URaaSvd/te0mXAB9MIzp9hsGGT2mqcY+9YGyZve3HMNCrxov3hfWOTyiByknpPCdPqMW7dR8FFE1YVO0zTBpB01W7+LLwBUOJigWFL/igs0w9JqwTn3RIHnRnyi3GdimMJWLq9WgfowyFH520r4Au/iIArOUzSHfCeoVsbDlOwMYI=;\n\t5:qqE1pxoDz0rEi76VS4tJWbE3eIUw3oToI5/vHc0sB5Vph29HyFKNUC4JC+QfndBo3IsZUaQ8Jdvs6L10lRvMy97J3lMokDY2lJu5F+WqfeUYPgn+fe2V5xrUl75+PMx2D5lvqDjnH/9ywuNvzDPRwbqCuZYYLrThxbBpmpIbUMU=;\n\t24:4MJoLqKb5rwCDRrYJSq9ne6HIBl+VhuoeVx/WUXwHwF1aFkCwJLyRXf2ctnWS2Ybqsis5VhL5MdHIaToXt2US7wCHGrBhxfHVRrFohyOu8I=;\n\t7:SrjqRGvPdAYz9dGjkj7awTwVQQTuvZ5EnwZdpnhwLmPzhlGzrLgsVfbrVBPlUZKw7hiCLPVTtcHuS1WhPnjlfCQR1a6+HoWkDOFnkwkpLKVAdVHqpF8p5zLKvDkrHn3H3/drPqcFAwAKFcP4TwfL5NpKSbOhjT/aN4bKwBRbsCyNoHueS72JJzRFzwbirIxidYyKpwOZ9jzzn0pUEQQ0Q/IRvtSgoV55rv8J52tnA0T07uZgI1ykkkh64wi/aHyT" ], "X-MS-TrafficTypeDiagnostic": "DB6PR0501MB2664:", "X-Microsoft-Antispam-PRVS": "<DB6PR0501MB2664C67C70723661CB6DC185D2F30@DB6PR0501MB2664.eurprd05.prod.outlook.com>", "X-Exchange-Antispam-Report-Test": "UriScan:;", "X-Exchange-Antispam-Report-CFA-Test": "BCL:0; PCL:0;\n\tRULEID:(6040501)(2401047)(8121501046)(5005006)(3231101)(2400082)(944501161)(3002001)(10201501046)(93006095)(93001095)(6055026)(6041288)(20161123564045)(20161123560045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011);\n\tSRVR:DB6PR0501MB2664; BCL:0; PCL:0; RULEID:; SRVR:DB6PR0501MB2664; ", "X-Forefront-PRVS": "0577AD41D6", "X-Forefront-Antispam-Report": "SFV:NSPM;\n\tSFS:(10009020)(366004)(396003)(39380400002)(376002)(346002)(39860400002)(189003)(199004)(316002)(6916009)(2950100002)(105586002)(3846002)(6116002)(4720700003)(6666003)(478600001)(25786009)(47776003)(5660300001)(2906002)(106356001)(16526019)(16586007)(66066001)(186003)(33026002)(8676002)(81156014)(50226002)(21086003)(86362001)(36756003)(69596002)(26005)(8936002)(50466002)(48376002)(386003)(305945005)(81166006)(97736004)(55016002)(51416003)(52116002)(53936002)(68736007)(7736002)(7696005)(59450400001)(76176011)(4326008);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0501MB2664; H:mellanox.com; FPR:;\n\tSPF:None; \n\tPTR:InfoNoRecords; MX:1; A:1; LANG:en; ", "Received-SPF": "None (protection.outlook.com: mellanox.com does not designate\n\tpermitted sender hosts)", "SpamDiagnosticOutput": "1:99", "SpamDiagnosticMetadata": "NSPM", "X-OriginatorOrg": "Mellanox.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "08 Feb 2018 16:34:29.5816\n\t(UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "d0a13ba1-f8a5-4a00-bc9b-08d56f11d3fb", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "a652971c-7d2e-4d9b-a6a4-d149256f461b", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DB6PR0501MB2664", "Subject": "[dpdk-dev] [PATCH v5 1/3] net/failsafe: fix hotplug alarm cancel", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The hot-plug alarm mechanism of fail-safe PMD is responsible for\nhandling removed devices during a plug-out event and to restore them\nback to activity following a plug-in event.\n\nFail-safe sets a flag called \"pending_alarm\" to validate that only one\nalarm callback is pending at any time. While this flag is required to\navoid simultaneous initiations of the alarm thread - it should not be\nconsidered during alarm thread cancellation.\n\nSo, when failsafe_hotplug_alarm_cancel() was called while the alarm\ncallback was being executed the alarm mechanism was not stopped.\n\nSkip checking the \"pending_alarm\" flag to allow alarm thread\ncancellation all the times.\n\nFixes: ebea83f899d8 (\"net/failsafe: add plug-in support\")\nCc: stable@dpdk.org\n\nSigned-off-by: Matan Azrad <matan@mellanox.com>\n---\n drivers/net/failsafe/failsafe.c | 18 ++++++++----------\n 1 file changed, 8 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/failsafe/failsafe.c b/drivers/net/failsafe/failsafe.c\nindex 2665a39..7b2cdbb 100644\n--- a/drivers/net/failsafe/failsafe.c\n+++ b/drivers/net/failsafe/failsafe.c\n@@ -85,16 +85,14 @@\n {\n \tint ret = 0;\n \n-\tif (PRIV(dev)->pending_alarm) {\n-\t\trte_errno = 0;\n-\t\trte_eal_alarm_cancel(fs_hotplug_alarm, dev);\n-\t\tif (rte_errno) {\n-\t\t\tERROR(\"rte_eal_alarm_cancel failed (errno: %s)\",\n-\t\t\t strerror(rte_errno));\n-\t\t\tret = -rte_errno;\n-\t\t} else {\n-\t\t\tPRIV(dev)->pending_alarm = 0;\n-\t\t}\n+\trte_errno = 0;\n+\trte_eal_alarm_cancel(fs_hotplug_alarm, dev);\n+\tif (rte_errno) {\n+\t\tERROR(\"rte_eal_alarm_cancel failed (errno: %s)\",\n+\t\t strerror(rte_errno));\n+\t\tret = -rte_errno;\n+\t} else {\n+\t\tPRIV(dev)->pending_alarm = 0;\n \t}\n \treturn ret;\n }\n", "prefixes": [ "dpdk-dev", "v5", "1/3" ] }