Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 34966,
    "url": "http://patches.dpdk.org/api/patches/34966/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180205121642.26428-6-stefanha@redhat.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20180205121642.26428-6-stefanha@redhat.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20180205121642.26428-6-stefanha@redhat.com",
    "date": "2018-02-05T12:16:39",
    "name": "[dpdk-dev,5/8] vhost: reject invalid log base mmap_offset values",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "53905602ebec8600faf4cf9b369dc1494c866196",
    "submitter": {
        "id": 933,
        "url": "http://patches.dpdk.org/api/people/933/?format=api",
        "name": "Stefan Hajnoczi",
        "email": "stefanha@redhat.com"
    },
    "delegate": {
        "id": 2642,
        "url": "http://patches.dpdk.org/api/users/2642/?format=api",
        "username": "mcoquelin",
        "first_name": "Maxime",
        "last_name": "Coquelin",
        "email": "maxime.coquelin@redhat.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180205121642.26428-6-stefanha@redhat.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/34966/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/34966/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 553871B35F;\n\tMon,  5 Feb 2018 13:17:17 +0100 (CET)",
            "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id 1FA1B1B335\n\tfor <dev@dpdk.org>; Mon,  5 Feb 2018 13:17:16 +0100 (CET)",
            "from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 861E181DF3;\n\tMon,  5 Feb 2018 12:17:15 +0000 (UTC)",
            "from localhost (ovpn-117-200.ams2.redhat.com [10.36.117.200])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 4594E18BA8;\n\tMon,  5 Feb 2018 12:17:14 +0000 (UTC)"
        ],
        "From": "Stefan Hajnoczi <stefanha@redhat.com>",
        "To": "dev@dpdk.org",
        "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>,\n\tYuanhan Liu <yliu@fridaylinux.org>, Stefan Hajnoczi <stefanha@redhat.com>",
        "Date": "Mon,  5 Feb 2018 12:16:39 +0000",
        "Message-Id": "<20180205121642.26428-6-stefanha@redhat.com>",
        "In-Reply-To": "<20180205121642.26428-1-stefanha@redhat.com>",
        "References": "<20180205121642.26428-1-stefanha@redhat.com>",
        "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.14",
        "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]); Mon, 05 Feb 2018 12:17:15 +0000 (UTC)",
        "Subject": "[dpdk-dev] [PATCH 5/8] vhost: reject invalid log base mmap_offset\n\tvalues",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "If the log base mmap_offset is larger than mmap_size then it points\noutside the mmap region.  We must not write to memory outside the mmap\nregion, so validate mmap_offset in vhost_user_set_log_base().\n\nSigned-off-by: Stefan Hajnoczi <stefanha@redhat.com>\n---\n lib/librte_vhost/vhost_user.c | 9 +++++++++\n 1 file changed, 9 insertions(+)",
    "diff": "diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c\nindex 48b493d70..fd47404ce 100644\n--- a/lib/librte_vhost/vhost_user.c\n+++ b/lib/librte_vhost/vhost_user.c\n@@ -1005,6 +1005,15 @@ vhost_user_set_log_base(struct virtio_net *dev, struct VhostUserMsg *msg)\n \n \tsize = msg->payload.log.mmap_size;\n \toff  = msg->payload.log.mmap_offset;\n+\n+\t/* Don't allow mmap_offset to point outside the mmap region */\n+\tif (off > size) {\n+\t\tRTE_LOG(ERR, VHOST_CONFIG,\n+\t\t\t\"log offset %#\"PRIx64\" exceeds log size %#\"PRIx64\"\\n\",\n+\t\t\toff, size);\n+\t\treturn -1;\n+\t}\n+\n \tRTE_LOG(INFO, VHOST_CONFIG,\n \t\t\"log mmap size: %\"PRId64\", offset: %\"PRId64\"\\n\",\n \t\tsize, off);\n",
    "prefixes": [
        "dpdk-dev",
        "5/8"
    ]
}