Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/34944/?format=api
{ "id": 34944, "url": "http://patches.dpdk.org/api/patches/34944/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1517818656-136529-1-git-send-email-beilei.xing@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1517818656-136529-1-git-send-email-beilei.xing@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1517818656-136529-1-git-send-email-beilei.xing@intel.com", "date": "2018-02-05T08:17:36", "name": "[dpdk-dev,v2] net/i40e: fix issue about interrupt", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "24c638aff47ea3b65344e26144e72a949f923699", "submitter": { "id": 410, "url": "http://patches.dpdk.org/api/people/410/?format=api", "name": "Xing, Beilei", "email": "beilei.xing@intel.com" }, "delegate": { "id": 24, "url": "http://patches.dpdk.org/api/users/24/?format=api", "username": "helin_zhang", "first_name": "Helin", "last_name": "Zhang", "email": "helin.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1517818656-136529-1-git-send-email-beilei.xing@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/34944/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/34944/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 30ED11B2E2;\n\tMon, 5 Feb 2018 09:17:02 +0100 (CET)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id CF99D1B2DC;\n\tMon, 5 Feb 2018 09:16:59 +0100 (CET)", "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t05 Feb 2018 00:16:58 -0800", "from unknown (HELO dpdk9.sh.intel.com) ([10.67.118.52])\n\tby orsmga008.jf.intel.com with ESMTP; 05 Feb 2018 00:16:57 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.46,464,1511856000\"; d=\"scan'208\";a=\"15479642\"", "From": "Beilei Xing <beilei.xing@intel.com>", "To": "qi.z.zhang@intel.com,\n\tjingjing.wu@intel.com", "Cc": "dev@dpdk.org,\n\tstable@dpdk.org", "Date": "Mon, 5 Feb 2018 16:17:36 +0800", "Message-Id": "<1517818656-136529-1-git-send-email-beilei.xing@intel.com>", "X-Mailer": "git-send-email 2.5.5", "In-Reply-To": "<1517818365-136358-1-git-send-email-beilei.xing@intel.com>", "References": "<1517818365-136358-1-git-send-email-beilei.xing@intel.com>", "Subject": "[dpdk-dev] [PATCH v2] net/i40e: fix issue about interrupt", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch fixes interval error and corrects macros\nwhen enable rx interrupt mode. The patch also fixes\na logical error during support multiple driver.\n\nFixes: be6c228d4da3 (\"i40e: support Rx interrupt\")\nFixes: b20aa3aee390 (\"net/i40e: fix multiple driver support issue\")\nCc: stable@dpdk.org\n\nSigned-off-by: Beilei Xing <beilei.xing@intel.com>\n---\n\nv2 change:\n - fix logical error during support multiple driver.\n\n drivers/net/i40e/i40e_ethdev.c | 21 +++++++++------------\n 1 file changed, 9 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c\nindex a60fd60..a4dea44 100644\n--- a/drivers/net/i40e/i40e_ethdev.c\n+++ b/drivers/net/i40e/i40e_ethdev.c\n@@ -1869,7 +1869,7 @@ i40e_vsi_enable_queues_intr(struct i40e_vsi *vsi)\n \tstruct i40e_pf *pf = I40E_VSI_TO_PF(vsi);\n \tuint16_t msix_intr, i;\n \n-\tif (rte_intr_allow_others(intr_handle) || !pf->support_multi_driver)\n+\tif (rte_intr_allow_others(intr_handle) && !pf->support_multi_driver)\n \t\tfor (i = 0; i < vsi->nb_msix; i++) {\n \t\t\tmsix_intr = vsi->msix_intr + i;\n \t\t\tI40E_WRITE_REG(hw, I40E_PFINT_DYN_CTLN(msix_intr - 1),\n@@ -1896,7 +1896,7 @@ i40e_vsi_disable_queues_intr(struct i40e_vsi *vsi)\n \tstruct i40e_pf *pf = I40E_VSI_TO_PF(vsi);\n \tuint16_t msix_intr, i;\n \n-\tif (rte_intr_allow_others(intr_handle) || !pf->support_multi_driver)\n+\tif (rte_intr_allow_others(intr_handle) && !pf->support_multi_driver)\n \t\tfor (i = 0; i < vsi->nb_msix; i++) {\n \t\t\tmsix_intr = vsi->msix_intr + i;\n \t\t\tI40E_WRITE_REG(hw, I40E_PFINT_DYN_CTLN(msix_intr - 1),\n@@ -11126,20 +11126,16 @@ i40e_dev_rx_queue_intr_enable(struct rte_eth_dev *dev, uint16_t queue_id)\n \tmsix_intr = intr_handle->intr_vec[queue_id];\n \tif (msix_intr == I40E_MISC_VEC_ID)\n \t\tI40E_WRITE_REG(hw, I40E_PFINT_DYN_CTL0,\n-\t\t\t I40E_PFINT_DYN_CTLN_INTENA_MASK |\n-\t\t\t I40E_PFINT_DYN_CTLN_CLEARPBA_MASK |\n-\t\t\t (0 << I40E_PFINT_DYN_CTLN_ITR_INDX_SHIFT) |\n-\t\t\t (interval <<\n-\t\t\t\tI40E_PFINT_DYN_CTLN_INTERVAL_SHIFT));\n+\t\t\t I40E_PFINT_DYN_CTL0_INTENA_MASK |\n+\t\t\t I40E_PFINT_DYN_CTL0_CLEARPBA_MASK |\n+\t\t\t I40E_PFINT_DYN_CTL0_ITR_INDX_MASK);\n \telse\n \t\tI40E_WRITE_REG(hw,\n \t\t\t I40E_PFINT_DYN_CTLN(msix_intr -\n \t\t\t\t\t\t I40E_RX_VEC_START),\n \t\t\t I40E_PFINT_DYN_CTLN_INTENA_MASK |\n \t\t\t I40E_PFINT_DYN_CTLN_CLEARPBA_MASK |\n-\t\t\t (0 << I40E_PFINT_DYN_CTLN_ITR_INDX_SHIFT) |\n-\t\t\t (interval <<\n-\t\t\t\tI40E_PFINT_DYN_CTLN_INTERVAL_SHIFT));\n+\t\t\t I40E_PFINT_DYN_CTLN_ITR_INDX_MASK);\n \n \tI40E_WRITE_FLUSH(hw);\n \trte_intr_enable(&pci_dev->intr_handle);\n@@ -11157,12 +11153,13 @@ i40e_dev_rx_queue_intr_disable(struct rte_eth_dev *dev, uint16_t queue_id)\n \n \tmsix_intr = intr_handle->intr_vec[queue_id];\n \tif (msix_intr == I40E_MISC_VEC_ID)\n-\t\tI40E_WRITE_REG(hw, I40E_PFINT_DYN_CTL0, 0);\n+\t\tI40E_WRITE_REG(hw, I40E_PFINT_DYN_CTL0,\n+\t\t\t I40E_PFINT_DYN_CTL0_ITR_INDX_MASK);\n \telse\n \t\tI40E_WRITE_REG(hw,\n \t\t\t I40E_PFINT_DYN_CTLN(msix_intr -\n \t\t\t\t\t\t I40E_RX_VEC_START),\n-\t\t\t 0);\n+\t\t\t I40E_PFINT_DYN_CTLN_ITR_INDX_MASK);\n \tI40E_WRITE_FLUSH(hw);\n \n \treturn 0;\n", "prefixes": [ "dpdk-dev", "v2" ] }