Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/34934/?format=api
{ "id": 34934, "url": "http://patches.dpdk.org/api/patches/34934/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/B73B41DFFD120A45AEE57672FCA463BA01975CE1@shsmsx102.ccr.corp.intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<B73B41DFFD120A45AEE57672FCA463BA01975CE1@shsmsx102.ccr.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/B73B41DFFD120A45AEE57672FCA463BA01975CE1@shsmsx102.ccr.corp.intel.com", "date": "2018-02-05T01:51:38", "name": "[dpdk-dev] app/testpmd:vlan filter fail", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "185599418843d02afb500d7497e7a08460963c9f", "submitter": { "id": 879, "url": "http://patches.dpdk.org/api/people/879/?format=api", "name": "Yanglong Wu", "email": "yanglong.wu@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/B73B41DFFD120A45AEE57672FCA463BA01975CE1@shsmsx102.ccr.corp.intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/34934/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/34934/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9A7431B1BA;\n\tMon, 5 Feb 2018 02:51:45 +0100 (CET)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id 364A41B1B0\n\tfor <dev@dpdk.org>; Mon, 5 Feb 2018 02:51:43 +0100 (CET)", "from orsmga006.jf.intel.com ([10.7.209.51])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t04 Feb 2018 17:51:41 -0800", "from fmsmsx106.amr.corp.intel.com ([10.18.124.204])\n\tby orsmga006.jf.intel.com with ESMTP; 04 Feb 2018 17:51:40 -0800", "from shsmsx101.ccr.corp.intel.com (10.239.4.153) by\n\tFMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP\n\tServer (TLS) id 14.3.319.2; Sun, 4 Feb 2018 17:51:40 -0800", "from shsmsx102.ccr.corp.intel.com ([169.254.2.124]) by\n\tSHSMSX101.ccr.corp.intel.com ([169.254.1.253]) with mapi id\n\t14.03.0319.002; Mon, 5 Feb 2018 09:51:39 +0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.46,462,1511856000\"; d=\"scan'208\";a=\"15835077\"", "From": "\"Wu, Yanglong\" <yanglong.wu@intel.com>", "To": "Shahaf Shuler <shahafs@mellanox.com>, \"dev@dpdk.org\" <dev@dpdk.org>", "CC": "\"Lu, Wenzhuo\" <wenzhuo.lu@intel.com>", "Thread-Topic": "[PATCH] app/testpmd:vlan filter fail", "Thread-Index": "AQHTm+RjZ+iGej6hEECmzpQoDbs9ZKOTRHuAgAHLLcA=", "Date": "Mon, 5 Feb 2018 01:51:38 +0000", "Message-ID": "<B73B41DFFD120A45AEE57672FCA463BA01975CE1@shsmsx102.ccr.corp.intel.com>", "References": "<20180202050950.64400-1-yanglong.wu@intel.com>\n\t<VI1PR05MB3149C807F252B3988ECCD9D0C3FF0@VI1PR05MB3149.eurprd05.prod.outlook.com>", "In-Reply-To": "<VI1PR05MB3149C807F252B3988ECCD9D0C3FF0@VI1PR05MB3149.eurprd05.prod.outlook.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "dlp-product": "dlpe-windows", "dlp-version": "11.0.0.116", "dlp-reaction": "no-action", "x-titus-metadata-40": "eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTk2NmNhOGUtZjZkNC00Mjk1LWJmZWItNTBjY2EwMzRjMWIwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Ik5nUSt3TzlzM2VwcUNGb1c3ZVhTZHA0QmNWUmpIUHNENExFV2s5UmYzS0U9In0=", "x-ctpclassification": "CTP_NT", "x-originating-ip": "[10.239.127.40]", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Subject": "Re: [dpdk-dev] [PATCH] app/testpmd:vlan filter fail", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Hi,\nThanks for your review. I got it!\n\nYanglong Wu\n-----Original Message-----\nFrom: Shahaf Shuler [mailto:shahafs@mellanox.com] \nSent: Sunday, February 4, 2018 2:27 PM\nTo: Wu, Yanglong <yanglong.wu@intel.com>; dev@dpdk.org\nCc: Lu, Wenzhuo <wenzhuo.lu@intel.com>\nSubject: RE: [PATCH] app/testpmd:vlan filter fail\n\nHi Wu,\n\nIndeed there is an issue here, but this is not the right fix.\n\nFriday, February 2, 2018 7:10 AM, Yanglong Wu:\n> Subject: [PATCH] app/testpmd:vlan filter fail\n> \n> Removing out port_conf.rxmode.hw_vlan_filter = 1 will let it equal to \n> 0 and port_conf.rxmode.offloads is assigned as 0 again if \n> hw_vlan_filter = 1. So it will always lead to fail for vlan filter \n> setting\n> \n> Fix:0074d02fc(convert to new Rx offloads API)\n> Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>\n> ---\n> app/test-pmd/testpmd.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index \n> 5dc8ccac5..0751e573c 100644\n> --- a/app/test-pmd/testpmd.c\n> +++ b/app/test-pmd/testpmd.c\n> @@ -2328,7 +2328,7 @@ init_port_dcb_config(portid_t pid,\n> \tretval = get_eth_dcb_conf(&port_conf, dcb_mode, num_tcs, pfc_en);\n> \tif (retval < 0)\n> \t\treturn retval;\n> -\tport_conf.rxmode.offloads |= DEV_RX_OFFLOAD_VLAN_FILTER;\n> +\tport_conf.rxmode.hw_vlan_filter = 1;\n\nThe VLAN filter resets because the rxmode.ignore_offload_bitfield is not set. If it was set, the ethdev rxmode convert functions would have convert the new flag to the old API (rxmode.hw_vlan_filter).\n\nAm not much familiar with this configuration but here is a suggested fix:\n\n\nThe port_conf for the dcb configuration will inherit the same configuration of the port (which has the ignore_offload_bitfield set).\nOtherwise, at least the rxmode.ignore_offload_bitfield must be set. \n> \n> \t/**\n> \t * Write the configuration into the device.\n> --\n> 2.11.0", "diff": "diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex d8ac43268..caf282386 100644 \n--- a/app/test-pmd/testpmd.c \n+++ b/app/test-pmd/testpmd.c \n@@ -2324,6 +2324,8 @@ init_port_dcb_config(portid_t pid, \n rte_port = &ports[pid]; \n \n memset(&port_conf, 0, sizeof(struct rte_eth_conf)); \n+ port_conf.rxmode = rte_port->dev_conf.rxmode; \n+ port_conf.txmode = rte_port->dev_conf.txmode; \n /* Enter DCB configuration status */ \n dcb_config = 1; \n \n", "prefixes": [ "dpdk-dev" ] }