Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/34933/?format=api
{ "id": 34933, "url": "http://patches.dpdk.org/api/patches/34933/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1517791895-3061-6-git-send-email-xiangxia.m.yue@gmail.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1517791895-3061-6-git-send-email-xiangxia.m.yue@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1517791895-3061-6-git-send-email-xiangxia.m.yue@gmail.com", "date": "2018-02-05T00:51:35", "name": "[dpdk-dev,v3,5/5] net/ixgbe: remove the unnecessary call rte_intr_enable.", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "214e5e7c6ced06839cf061cb8195298437fbf9c0", "submitter": { "id": 834, "url": "http://patches.dpdk.org/api/people/834/?format=api", "name": "Tonghao Zhang", "email": "xiangxia.m.yue@gmail.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1517791895-3061-6-git-send-email-xiangxia.m.yue@gmail.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/34933/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/34933/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 38C561B2A7;\n\tMon, 5 Feb 2018 01:52:01 +0100 (CET)", "from mail-pg0-f65.google.com (mail-pg0-f65.google.com\n\t[74.125.83.65]) by dpdk.org (Postfix) with ESMTP id 047051B2B1\n\tfor <dev@dpdk.org>; Mon, 5 Feb 2018 01:52:00 +0100 (CET)", "by mail-pg0-f65.google.com with SMTP id g2so1224187pgn.7\n\tfor <dev@dpdk.org>; Sun, 04 Feb 2018 16:51:59 -0800 (PST)", "from local.opencloud.tech.localdomain ([23.102.225.250])\n\tby smtp.gmail.com with ESMTPSA id\n\tb84sm9432835pfj.11.2018.02.04.16.51.57\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSun, 04 Feb 2018 16:51:58 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=n6Qv8Sna7lHLy4f4ImtqKytEQV86XQ4nhgRztuoNpNc=;\n\tb=Gd2PQvlzX2pk6T88agJ72n9EVRfYsaVTb1MDGtf7esHtGvVNwTlyw4ZlO9cSx8D0r/\n\tUsqIksFHi5jqLIk/oj3K5KOlNZeELvgRYZ6wSazJb5CHRlbUZMTziUUF6vlRiC3QTOSI\n\tpU/l7Xb2NToxUoK4IzpO4y/O2NbwFAOvdXI1W+PG2ZW0lFDdCWsgb54XaJ3mXzVPDkJ+\n\tKMqlbeZ92uPui4fjs/92iX8G+36i02XugH66zl9D/g+ue4nMm9/6ZEIlKis4j+JvEOpu\n\tbNGgtxQOE/yoXPT0+WXNbdGStm7QoVA8u7xYIAcmFq9BjM23T0gmHiPQw+dgv6YftHqf\n\t5VwQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=n6Qv8Sna7lHLy4f4ImtqKytEQV86XQ4nhgRztuoNpNc=;\n\tb=XyEMr13ddjctIkOM66Wsy8a5IVsSlod43sjsQHgRA/RK2z/mOi8j4NoAynh7eqnjWL\n\tzQ23bGVAlAyyrdY7bg0w8jxqosc9aTRmgSkaQxPWKqUt2C6u9L0QeKG0w05ISjTs8xSL\n\trY6XYnxtlwkwFSJ1xqOfIyUz89x15xKUofbWEcM1vrAE2reIhEp7fm4vEyPTg2DeBrcP\n\tyU/LCKg5mCaWnVsvFucy8846+dCRpVGZEvNXN8fATRu/BLScAP+5+yyt7MCrtbH5sz6A\n\tIAhLaKJ5phCBn4s0U7tP8r09AYo/AddNnf79NFdXsslSAR5MktvBL5dzZRtxNo/ZzOMF\n\tcuiA==", "X-Gm-Message-State": "APf1xPDMiQyQxTjUeHGA9+BhrKYHI41VWALd6vLDL1SJGEBRzUxkwydR\n\tHbGfvCiq+H7ReH5QJ18o1dI=", "X-Google-Smtp-Source": "AH8x226UZ0vwMNjPcuuUR/3nEUGKiNPIE7k1oMyoKrZ5cimOXFMuafM/IpCOolj1aewRw+RTEQ0jSw==", "X-Received": "by 10.98.73.70 with SMTP id w67mr832954pfa.61.1517791919317;\n\tSun, 04 Feb 2018 16:51:59 -0800 (PST)", "From": "xiangxia.m.yue@gmail.com", "To": "beilei.xing@intel.com, wei.dai@intel.com, helin.zhang@intel.com,\n\twenzhuo.lu@intel.com", "Cc": "dev@dpdk.org,\n\tTonghao Zhang <xiangxia.m.yue@gmail.com>", "Date": "Sun, 4 Feb 2018 16:51:35 -0800", "Message-Id": "<1517791895-3061-6-git-send-email-xiangxia.m.yue@gmail.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1517791895-3061-1-git-send-email-xiangxia.m.yue@gmail.com>", "References": "<1517791895-3061-1-git-send-email-xiangxia.m.yue@gmail.com>", "Subject": "[dpdk-dev] [PATCH v3 5/5] net/ixgbe: remove the unnecessary call\n\trte_intr_enable.", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Tonghao Zhang <xiangxia.m.yue@gmail.com>\n\nWhen binding the ixgbe pf or vf to vfio and call the\nrte_eth_dev_rx_intr_enable frequently, the interrupt setting\n(msi_set_mask_bit) will take more CPU as show below. rte_intr_enable\ncalls the ioctl to map the fd to interrupts frequently.\n\nperf top:\n5.45% [kernel] [k] msi_set_mask_bit\n\nIt is unnecessary to call the rte_intr_enable in\nixgbe_dev_rx_queue_intr_enable. Because the fds has been mapped to\ninterrupt and not unmapped in ixgbe_dev_rx_queue_intr_disable.\n\nWith the patch, msi_set_mask_bit is not listed in perl anymore.\n\nSigned-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>\n---\n drivers/net/ixgbe/ixgbe_ethdev.c | 11 +----------\n 1 file changed, 1 insertion(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex 7928144..ef01e0c 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -4253,7 +4253,7 @@ static int ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev,\n */\n static int\n ixgbe_dev_interrupt_action(struct rte_eth_dev *dev,\n-\t\t\t struct rte_intr_handle *intr_handle)\n+\t\t\t __rte_unused struct rte_intr_handle *intr_handle)\n {\n \tstruct ixgbe_interrupt *intr =\n \t\tIXGBE_DEV_PRIVATE_TO_INTR(dev->data->dev_private);\n@@ -4304,7 +4304,6 @@ static int ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev,\n \n \tPMD_DRV_LOG(DEBUG, \"enable intr immediately\");\n \tixgbe_enable_intr(dev);\n-\trte_intr_enable(intr_handle);\n \n \treturn 0;\n }\n@@ -4327,8 +4326,6 @@ static int ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev,\n ixgbe_dev_interrupt_delayed_handler(void *param)\n {\n \tstruct rte_eth_dev *dev = (struct rte_eth_dev *)param;\n-\tstruct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);\n-\tstruct rte_intr_handle *intr_handle = &pci_dev->intr_handle;\n \tstruct ixgbe_interrupt *intr =\n \t\tIXGBE_DEV_PRIVATE_TO_INTR(dev->data->dev_private);\n \tstruct ixgbe_hw *hw =\n@@ -4366,7 +4363,6 @@ static int ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev,\n \n \tPMD_DRV_LOG(DEBUG, \"enable intr in delayed handler S[%08x]\", eicr);\n \tixgbe_enable_intr(dev);\n-\trte_intr_enable(intr_handle);\n }\n \n /**\n@@ -5607,8 +5603,6 @@ static void ixgbevf_set_vfta_all(struct rte_eth_dev *dev, bool on)\n \tRTE_SET_USED(queue_id);\n \tIXGBE_WRITE_REG(hw, IXGBE_VTEIMS, intr->mask);\n \n-\trte_intr_enable(intr_handle);\n-\n \treturn 0;\n }\n \n@@ -5635,8 +5629,6 @@ static void ixgbevf_set_vfta_all(struct rte_eth_dev *dev, bool on)\n static int\n ixgbe_dev_rx_queue_intr_enable(struct rte_eth_dev *dev, uint16_t queue_id)\n {\n-\tstruct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);\n-\tstruct rte_intr_handle *intr_handle = &pci_dev->intr_handle;\n \tuint32_t mask;\n \tstruct ixgbe_hw *hw =\n \t\tIXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n@@ -5656,7 +5648,6 @@ static void ixgbevf_set_vfta_all(struct rte_eth_dev *dev, bool on)\n \t\tmask &= (1 << (queue_id - 32));\n \t\tIXGBE_WRITE_REG(hw, IXGBE_EIMS_EX(1), mask);\n \t}\n-\trte_intr_enable(intr_handle);\n \n \treturn 0;\n }\n", "prefixes": [ "dpdk-dev", "v3", "5/5" ] }