Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 34908,
    "url": "http://patches.dpdk.org/api/patches/34908/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180203145523.28013-1-dharton@cisco.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20180203145523.28013-1-dharton@cisco.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20180203145523.28013-1-dharton@cisco.com",
    "date": "2018-02-03T14:55:23",
    "name": "[dpdk-dev] net/virtio: Fix crash in virtio_dev_free_mbufs",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "cd5ff3009ee4defa91f40354a3176ac33affb4c8",
    "submitter": {
        "id": 252,
        "url": "http://patches.dpdk.org/api/people/252/?format=api",
        "name": "David Harton",
        "email": "dharton@cisco.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180203145523.28013-1-dharton@cisco.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/34908/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/34908/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 50893293C;\n\tSat,  3 Feb 2018 15:55:29 +0100 (CET)",
            "from alln-iport-4.cisco.com (alln-iport-4.cisco.com\n\t[173.37.142.91]) by dpdk.org (Postfix) with ESMTP id 215AD25B3\n\tfor <dev@dpdk.org>; Sat,  3 Feb 2018 15:55:27 +0100 (CET)",
            "from rcdn-core-11.cisco.com ([173.37.93.147])\n\tby alln-iport-4.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t03 Feb 2018 14:55:27 +0000",
            "from cpp-rtpbld-31.cisco.com (cpp-rtpbld-31.cisco.com\n\t[172.18.5.114])\n\tby rcdn-core-11.cisco.com (8.14.5/8.14.5) with ESMTP id\n\tw13EtQAm008361; Sat, 3 Feb 2018 14:55:26 GMT",
            "by cpp-rtpbld-31.cisco.com (Postfix, from userid 140087)\n\tid A78EA760; Sat,  3 Feb 2018 09:55:26 -0500 (EST)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n\td=cisco.com; i=@cisco.com; l=854; q=dns/txt; s=iport;\n\tt=1517669728; x=1518879328;\n\th=from:to:cc:subject:date:message-id;\n\tbh=1TgJGh3iVgKCwuC+brsuMXwLviEOIK723Dt8zXc713w=;\n\tb=GRyjVmXMExsxbybyJvZ2RFE9yrMb4ZkUx19byzt3o3aTtKJhQyDxcVWH\n\tMTbhbmwplbYY12dndj9KbQ7lOOGnWEzU4cMzb56iIlCL158ipxOhTFXra\n\tMSfIX6Oqektg8sYbSvXcRvmDxyZ4klbirxcg6ehy+D0G7JRANoCYTRTXX I=;",
        "X-IronPort-AV": "E=Sophos;i=\"5.46,455,1511827200\"; d=\"scan'208\";a=\"65812582\"",
        "From": "David C Harton <dharton@cisco.com>",
        "To": "yliu@fridaylinux.org, maxime.coquelin@redhat.com, tiwei.bie@intel.com",
        "Cc": "dev@dpdk.org, David C Harton <dharton@cisco.com>, olivier.matz@6wind.com",
        "Date": "Sat,  3 Feb 2018 09:55:23 -0500",
        "Message-Id": "<20180203145523.28013-1-dharton@cisco.com>",
        "X-Mailer": "git-send-email 2.10.3.dirty",
        "Subject": "[dpdk-dev] [PATCH] net/virtio: Fix crash in virtio_dev_free_mbufs",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "virtio_dev_free_mbufs was recently modified to free the\nvirtqueues but failed to check whether the array was\nallocated.  Added a check to ensure vqs was non-null.\n\nFixes: bdb32afbb610 (\"net/virtio: rationalize queue flushing\")\nCc: olivier.matz@6wind.com\n\nSigned-off-by: David C Harton <dharton@cisco.com>\n---\n drivers/net/virtio/virtio_ethdev.c | 3 +++\n 1 file changed, 3 insertions(+)",
    "diff": "diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c\nindex 2082d6a..884f74a 100644\n--- a/drivers/net/virtio/virtio_ethdev.c\n+++ b/drivers/net/virtio/virtio_ethdev.c\n@@ -1975,6 +1975,9 @@ static void virtio_dev_free_mbufs(struct rte_eth_dev *dev)\n \tstruct rte_mbuf *buf;\n \tint queue_type;\n \n+\tif (hw->vqs == NULL)\n+\t\treturn;\n+\n \tfor (i = 0; i < nr_vq; i++) {\n \t\tvq = hw->vqs[i];\n \t\tif (!vq)\n",
    "prefixes": [
        "dpdk-dev"
    ]
}