Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/34901/?format=api
{ "id": 34901, "url": "http://patches.dpdk.org/api/patches/34901/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1517623898-53443-1-git-send-email-malleshx.koujalagi@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1517623898-53443-1-git-send-email-malleshx.koujalagi@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1517623898-53443-1-git-send-email-malleshx.koujalagi@intel.com", "date": "2018-02-03T02:11:38", "name": "[dpdk-dev] net/null:Different mac address support", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a2661b0f9d96bcf7ce634cecea1ac6263225189e", "submitter": { "id": 967, "url": "http://patches.dpdk.org/api/people/967/?format=api", "name": "Mallesh Koujalagi", "email": "malleshx.koujalagi@intel.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1517623898-53443-1-git-send-email-malleshx.koujalagi@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/34901/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/34901/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C84852B8B;\n\tSat, 3 Feb 2018 03:43:02 +0100 (CET)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n\tby dpdk.org (Postfix) with ESMTP id 4AF2629D6\n\tfor <dev@dpdk.org>; Sat, 3 Feb 2018 03:43:00 +0100 (CET)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t02 Feb 2018 18:42:59 -0800", "from dna-skx3.jf.intel.com ([10.54.81.137])\n\tby fmsmga006.fm.intel.com with ESMTP; 02 Feb 2018 18:42:58 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.46,452,1511856000\"; d=\"scan'208\";a=\"200998583\"", "From": "Mallesh Koujalagi <malleshx.koujalagi@intel.com>", "To": "dev@dpdk.org", "Cc": "mtetsuyah@gmail.com, ferruh.yigit@intel.com, malleshx.koujalagi@intel.com", "Date": "Fri, 2 Feb 2018 18:11:38 -0800", "Message-Id": "<1517623898-53443-1-git-send-email-malleshx.koujalagi@intel.com>", "X-Mailer": "git-send-email 2.7.4", "Subject": "[dpdk-dev] [PATCH] net/null:Different mac address support", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "After attaching two Null device to ovs, seeing \"00.00.00.00.00.00\" mac\naddress for both null devices. Fix this issue, by setting different mac\naddress.\n\nSigned-off-by: Mallesh Koujalagi <malleshx.koujalagi@intel.com>\n---\n drivers/net/null/rte_eth_null.c | 23 +++++++++++++++++++++--\n 1 file changed, 21 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c\nindex 9385ffd..98ac115 100644\n--- a/drivers/net/null/rte_eth_null.c\n+++ b/drivers/net/null/rte_eth_null.c\n@@ -85,8 +85,17 @@ struct pmd_internals {\n \tuint8_t rss_key[40]; /**< 40-byte hash key. */\n };\n \n+static struct ether_addr base_eth_addr = {\n+\t.addr_bytes = {\n+\t\t0x4E /* N */,\n+\t\t0x55 /* U */,\n+\t\t0x4C /* L */,\n+\t\t0x4C /* L */,\n+\t\t0x00,\n+\t\t0x00\n+\t}\n+};\n \n-static struct ether_addr eth_addr = { .addr_bytes = {0} };\n static struct rte_eth_link pmd_link = {\n \t.link_speed = ETH_SPEED_NUM_10G,\n \t.link_duplex = ETH_LINK_FULL_DUPLEX,\n@@ -492,6 +501,7 @@ eth_dev_null_create(struct rte_vdev_device *dev,\n \tstruct rte_eth_dev_data *data = NULL;\n \tstruct pmd_internals *internals = NULL;\n \tstruct rte_eth_dev *eth_dev = NULL;\n+\tstruct ether_addr *eth_addr = NULL;\n \n \tstatic const uint8_t default_rss_key[40] = {\n \t\t0x6D, 0x5A, 0x56, 0xDA, 0x25, 0x5B, 0x0E, 0xC2, 0x41, 0x67, 0x25, 0x3D,\n@@ -519,6 +529,15 @@ eth_dev_null_create(struct rte_vdev_device *dev,\n \t\trte_free(data);\n \t\treturn -ENOMEM;\n \t}\n+\teth_addr = rte_zmalloc_socket(rte_vdev_device_name(dev),\n+\t\t\tsizeof(*eth_addr), 0, dev->device.numa_node);\n+\tif (eth_addr == NULL) {\n+\t\trte_eth_dev_release_port(eth_dev);\n+\t\trte_free(data);\n+\t\treturn -ENOMEM;\n+\t}\n+\t*eth_addr = base_eth_addr;\n+\teth_addr->addr_bytes[5] = eth_dev->data->port_id;\n \n \t/* now put it all together\n \t * - store queue data in internals,\n@@ -543,7 +562,7 @@ eth_dev_null_create(struct rte_vdev_device *dev,\n \tdata->nb_rx_queues = (uint16_t)nb_rx_queues;\n \tdata->nb_tx_queues = (uint16_t)nb_tx_queues;\n \tdata->dev_link = pmd_link;\n-\tdata->mac_addrs = ð_addr;\n+\tdata->mac_addrs = eth_addr;\n \n \teth_dev->data = data;\n \teth_dev->dev_ops = &ops;\n", "prefixes": [ "dpdk-dev" ] }