Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/34896/?format=api
{ "id": 34896, "url": "http://patches.dpdk.org/api/patches/34896/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180202164050.13017-2-adrien.mazarguil@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180202164050.13017-2-adrien.mazarguil@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180202164050.13017-2-adrien.mazarguil@6wind.com", "date": "2018-02-02T16:46:12", "name": "[dpdk-dev,v2,1/4] net/mlx: add debug checks to glue structure", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d5f297931ae90177d8d565cf3d27446d2fa1e0cc", "submitter": { "id": 165, "url": "http://patches.dpdk.org/api/people/165/?format=api", "name": "Adrien Mazarguil", "email": "adrien.mazarguil@6wind.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180202164050.13017-2-adrien.mazarguil@6wind.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/34896/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/34896/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2BAE41B026;\n\tFri, 2 Feb 2018 17:46:27 +0100 (CET)", "from mail-wm0-f66.google.com (mail-wm0-f66.google.com\n\t[74.125.82.66]) by dpdk.org (Postfix) with ESMTP id 97DF2199B6\n\tfor <dev@dpdk.org>; Fri, 2 Feb 2018 17:46:25 +0100 (CET)", "by mail-wm0-f66.google.com with SMTP id v123so13651819wmd.5\n\tfor <dev@dpdk.org>; Fri, 02 Feb 2018 08:46:25 -0800 (PST)", "from 6wind.com (host.78.145.23.62.rev.coltfrance.com.\n\t[62.23.145.78]) by smtp.gmail.com with ESMTPSA id\n\tp4sm3124942wrb.59.2018.02.02.08.46.24\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 02 Feb 2018 08:46:24 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to;\n\tbh=FoYO4RFdz1WFapMg7Vm8naPO8VRMtNKzLpvorsM4tRQ=;\n\tb=jRjpKpF1/hDCmHDBlxcmNTn7uipayjnAk9UTmECZct1kQYSMXF7NBoYm44JwxbodsI\n\tYsstM6rwSv0OYuM0wD/O6XeZbK8RskXBimrDli/hF8Mb9rTVAnNT3nZsCyT5awwbqeB8\n\tbS3NSaBKv7UcuDK3DqY3gfnOfuMll/FDkRAnqdZrJG2fuZpxbVlJ2qAmug7LfIL84LT8\n\tjwzDQT40onl1Y5IQpSOq0pHFy9YWx1e6Fnl/dPm10Xdr5aV8EDmR3UFcBqFpfZJaV/DG\n\tGmSO/WZ1u1tT74h3EEUhK1DLGoB+FUnUd4A+l002tGi1toog2jpmmLxcKovchXPfWLSY\n\tGWOg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to;\n\tbh=FoYO4RFdz1WFapMg7Vm8naPO8VRMtNKzLpvorsM4tRQ=;\n\tb=TNeleMNGFOkL/ms+xUB7iig7OGMMMPXjaaIngSyvHK2ZmSnU1iCCLdF9BNwHTngkWg\n\thlQTYEVfzFwGAPN9pFLdy7aaq7QScSfpUuRM8gimXUlqkwCvIXKK+QdN8skl55JxlJpu\n\tVaqg1HLVtkwODTXWvhJ3WSecF7gwIe1OeV74zuplMhJ6eJC72GQ6fAkIdMRAq1lIuO6L\n\tnjnMpvnnuyHV83Ye32NOJ+GDPCU8OHF4kQLSDuz1g5zXVdYr0mW7TAsDCR2yyPN2VKAX\n\tJ6oFWSJ8L0Ac1Gsd46kz5NnAq9E+AGXqWuuOhHsfDaQAqKmu5LXFr8gyXUAVhninS8pK\n\tX2/g==", "X-Gm-Message-State": "AKwxytcipI21p8qSb90G2r/S/2FAxNX9X1qVoNGPIhcA3PhCXRUxwL7R\n\tba1CsnPoG0t5Gxw0ccS1pCezRE4a", "X-Google-Smtp-Source": "AH8x225g42rtq5VIXdEF1lzC96KgzqxnBZjWzI5+PxHpZ1SYsp1mmexIzGR00WL4hHVT9dexvp6dEQ==", "X-Received": "by 10.28.26.21 with SMTP id a21mr27379175wma.158.1517589985286; \n\tFri, 02 Feb 2018 08:46:25 -0800 (PST)", "Date": "Fri, 2 Feb 2018 17:46:12 +0100", "From": "Adrien Mazarguil <adrien.mazarguil@6wind.com>", "To": "Shahaf Shuler <shahafs@mellanox.com>", "Cc": "Nelio Laranjeiro <nelio.laranjeiro@6wind.com>, dev@dpdk.org,\n\tMarcelo Ricardo Leitner <mleitner@redhat.com>", "Message-ID": "<20180202164050.13017-2-adrien.mazarguil@6wind.com>", "References": "<20180202144736.8239-1-adrien.mazarguil@6wind.com>\n\t<20180202164050.13017-1-adrien.mazarguil@6wind.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=us-ascii", "Content-Disposition": "inline", "In-Reply-To": "<20180202164050.13017-1-adrien.mazarguil@6wind.com>", "X-Mailer": "git-send-email 2.11.0", "Subject": "[dpdk-dev] [PATCH v2 1/4] net/mlx: add debug checks to glue\n\tstructure", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This code should catch mistakes early if a glue structure member is added\nwithout a corresponding implementation in the library.\n\nSigned-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>\n---\n drivers/net/mlx4/mlx4.c | 9 +++++++++\n drivers/net/mlx5/mlx5.c | 9 +++++++++\n 2 files changed, 18 insertions(+)", "diff": "diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c\nindex 50a55ee52..201d39b6e 100644\n--- a/drivers/net/mlx4/mlx4.c\n+++ b/drivers/net/mlx4/mlx4.c\n@@ -799,6 +799,15 @@ rte_mlx4_pmd_init(void)\n \t\treturn;\n \tassert(mlx4_glue);\n #endif\n+#ifndef NDEBUG\n+\t/* Glue structure must not contain any NULL pointers. */\n+\t{\n+\t\tunsigned int i;\n+\n+\t\tfor (i = 0; i != sizeof(*mlx4_glue) / sizeof(void *); ++i)\n+\t\t\tassert(((const void *const *)mlx4_glue)[i]);\n+\t}\n+#endif\n \tmlx4_glue->fork_init();\n \trte_pci_register(&mlx4_driver);\n }\ndiff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c\nindex 544599b01..050cfac0d 100644\n--- a/drivers/net/mlx5/mlx5.c\n+++ b/drivers/net/mlx5/mlx5.c\n@@ -1142,6 +1142,15 @@ rte_mlx5_pmd_init(void)\n \t\treturn;\n \tassert(mlx5_glue);\n #endif\n+#ifndef NDEBUG\n+\t/* Glue structure must not contain any NULL pointers. */\n+\t{\n+\t\tunsigned int i;\n+\n+\t\tfor (i = 0; i != sizeof(*mlx5_glue) / sizeof(void *); ++i)\n+\t\t\tassert(((const void *const *)mlx5_glue)[i]);\n+\t}\n+#endif\n \tmlx5_glue->fork_init();\n \trte_pci_register(&mlx5_driver);\n }\n", "prefixes": [ "dpdk-dev", "v2", "1/4" ] }