Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/34890/?format=api
{ "id": 34890, "url": "http://patches.dpdk.org/api/patches/34890/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180202145128.6331-1-marko.kovacevic@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180202145128.6331-1-marko.kovacevic@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180202145128.6331-1-marko.kovacevic@intel.com", "date": "2018-02-02T14:51:28", "name": "[dpdk-dev,v3] eal: add error check for core options", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6b2cc7e4d40fa187edc452a2099129c3e2094d34", "submitter": { "id": 853, "url": "http://patches.dpdk.org/api/people/853/?format=api", "name": "Kovacevic, Marko", "email": "marko.kovacevic@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180202145128.6331-1-marko.kovacevic@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/34890/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/34890/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B62994D3A;\n\tFri, 2 Feb 2018 15:51:53 +0100 (CET)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id AE0C529D6;\n\tFri, 2 Feb 2018 15:51:51 +0100 (CET)", "from fmsmga007.fm.intel.com ([10.253.24.52])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t02 Feb 2018 06:51:50 -0800", "from silpixa00399502.ir.intel.com (HELO\n\tsilpixa00399502.ger.corp.intel.com) ([10.237.223.218])\n\tby fmsmga007.fm.intel.com with ESMTP; 02 Feb 2018 06:51:48 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.46,448,1511856000\"; d=\"scan'208\";a=\"14863619\"", "From": "Marko Kovacevic <marko.kovacevic@intel.com>", "To": "dev@dpdk.org", "Cc": "anatoly.burakov@intel.com, vipin.varghese@intel.com,\n\tbruce.richardson@intel.com, stable@dpdk.org,\n\tMarko Kovacevic <marko.kovacevic@intel.com>", "Date": "Fri, 2 Feb 2018 14:51:28 +0000", "Message-Id": "<20180202145128.6331-1-marko.kovacevic@intel.com>", "X-Mailer": "git-send-email 2.9.5", "In-Reply-To": "<20180201170732.3225-1-marko.kovacevic@intel.com>", "References": "<20180201170732.3225-1-marko.kovacevic@intel.com>", "Subject": "[dpdk-dev] [PATCH v3] eal: add error check for core options", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Error information on current core usage list, mask or map\nwere incomplete. Added states to differentiate core usage\nand to inform user.\n\nSigned-off-by: Marko Kovacevic <marko.kovacevic@intel.com>\nReviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>\n\n---\n\nV3:\n - Changed to reflect the coding guidelines - Bruce\n - update the documentation for better clarity - Bruce\n - Added back the reviewer information - Anatoly\n\nV2:\n - Cleaned up the logging for error cases - Anatoly\n---\n doc/guides/testpmd_app_ug/run_app.rst | 4 ++++\n lib/librte_eal/common/eal_common_options.c | 36 +++++++++++++++++++++++++++---\n 2 files changed, 37 insertions(+), 3 deletions(-)", "diff": "diff --git a/doc/guides/testpmd_app_ug/run_app.rst b/doc/guides/testpmd_app_ug/run_app.rst\nindex 46da1df..85e725f 100644\n--- a/doc/guides/testpmd_app_ug/run_app.rst\n+++ b/doc/guides/testpmd_app_ug/run_app.rst\n@@ -62,6 +62,10 @@ See the DPDK Getting Started Guides for more information on these options.\n The grouping ``()`` can be omitted for single element group.\n The ``@`` can be omitted if cpus and lcores have the same value.\n \n+.. Note::\n+ At a given instance only one core option ``--lcores``, ``-l`` or ``-c`` can be used.\n+\n+\n * ``--master-lcore ID``\n \n Core ID that is used as master.\ndiff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c\nindex b6d2762..66f0868 100644\n--- a/lib/librte_eal/common/eal_common_options.c\n+++ b/lib/librte_eal/common/eal_common_options.c\n@@ -57,6 +57,9 @@\n #include \"eal_filesystem.h\"\n \n #define BITS_PER_HEX 4\n+#define LCORE_OPT_LST 1\n+#define LCORE_OPT_MSK 2\n+#define LCORE_OPT_MAP 3\n \n const char\n eal_short_options[] =\n@@ -1028,7 +1031,16 @@ eal_parse_common_option(int opt, const char *optarg,\n \t\t\tRTE_LOG(ERR, EAL, \"invalid coremask\\n\");\n \t\t\treturn -1;\n \t\t}\n-\t\tcore_parsed = 1;\n+\n+\t\tif (core_parsed) {\n+\t\t\tRTE_LOG(ERR, EAL, \"Option -c is ignored, because (%s) is set!\\n\",\n+\t\t\t\t(core_parsed == LCORE_OPT_LST) ? \"-l\" :\n+\t\t\t\t(core_parsed == LCORE_OPT_MAP) ? \"--lcore\" :\n+\t\t\t\t\"-c\");\n+\t\t\treturn -1;\n+\t\t}\n+\n+\t\tcore_parsed = LCORE_OPT_MSK;\n \t\tbreak;\n \t/* corelist */\n \tcase 'l':\n@@ -1036,7 +1048,16 @@ eal_parse_common_option(int opt, const char *optarg,\n \t\t\tRTE_LOG(ERR, EAL, \"invalid core list\\n\");\n \t\t\treturn -1;\n \t\t}\n-\t\tcore_parsed = 1;\n+\n+\t\tif (core_parsed) {\n+\t\t\tRTE_LOG(ERR, EAL, \"Option -l is ignored, because (%s) is set!\\n\",\n+\t\t\t\t(core_parsed == LCORE_OPT_MSK) ? \"-c\" :\n+\t\t\t\t(core_parsed == LCORE_OPT_MAP) ? \"--lcore\" :\n+\t\t\t\t\"-l\");\n+\t\t\treturn -1;\n+\t\t}\n+\n+\t\tcore_parsed = LCORE_OPT_LST;\n \t\tbreak;\n \t/* service coremask */\n \tcase 's':\n@@ -1156,7 +1177,16 @@ eal_parse_common_option(int opt, const char *optarg,\n \t\t\t\tOPT_LCORES \"\\n\");\n \t\t\treturn -1;\n \t\t}\n-\t\tcore_parsed = 1;\n+\n+\t\tif (core_parsed) {\n+\t\t\tRTE_LOG(ERR, EAL, \"Option --lcore is ignored, because (%s) is set!\\n\",\n+\t\t\t\t(core_parsed == LCORE_OPT_LST) ? \"-l\" :\n+\t\t\t\t(core_parsed == LCORE_OPT_MSK) ? \"-c\" :\n+\t\t\t\t\"--lcore\");\n+\t\t\treturn -1;\n+\t\t}\n+\n+\t\tcore_parsed = LCORE_OPT_MAP;\n \t\tbreak;\n \n \t/* don't know what to do, leave this to caller */\n", "prefixes": [ "dpdk-dev", "v3" ] }