Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/34495/?format=api
{ "id": 34495, "url": "http://patches.dpdk.org/api/patches/34495/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1516899647-8541-5-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1516899647-8541-5-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1516899647-8541-5-git-send-email-arybchenko@solarflare.com", "date": "2018-01-25T17:00:45", "name": "[dpdk-dev,4/6] net/sfc: prepare to merge init logs with main log type", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "02ff08e642865b7c176e2586bac89891f7b03af1", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1516899647-8541-5-git-send-email-arybchenko@solarflare.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/34495/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/34495/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4F0FB1B2B1;\n\tThu, 25 Jan 2018 18:01:14 +0100 (CET)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 882CB1B1D5\n\tfor <dev@dpdk.org>; Thu, 25 Jan 2018 18:01:02 +0100 (CET)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with\n\tESMTPS id 5E4B4940095; Thu, 25 Jan 2018 17:01:00 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1044.25; Thu, 25 Jan 2018 09:00:57 -0800", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1044.25 via Frontend Transport; Thu, 25 Jan 2018 09:00:57 -0800", "from uklogin.uk.solarflarecom.com (uklogin.uk.solarflarecom.com\n\t[10.17.10.10])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tw0PH0uCk024571; Thu, 25 Jan 2018 17:00:56 GMT", "from uklogin.uk.solarflarecom.com (localhost.localdomain\n\t[127.0.0.1])\n\tby uklogin.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tw0PH0uQO008590; Thu, 25 Jan 2018 17:00:56 GMT" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "CC": "Ivan Malov <ivan.malov@oktetlabs.ru>", "Date": "Thu, 25 Jan 2018 17:00:45 +0000", "Message-ID": "<1516899647-8541-5-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.2.3", "In-Reply-To": "<1516899647-8541-1-git-send-email-arybchenko@solarflare.com>", "References": "<1516899647-8541-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-MDID": "1516899660-0H2eQ0SY-kYL", "Subject": "[dpdk-dev] [PATCH 4/6] net/sfc: prepare to merge init logs with\n\tmain log type", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Ivan Malov <ivan.malov@oktetlabs.ru>\n\nConversion to dynamic logging done in the previous patches\nmakes it possible to simplify internal controls for init\nlogging. This patch allows to prepare for such a change.\nIt makes init-unrelated messages use NOTICE level so that\nthe following patch will be able to convert init logging\nto use INFO level and remain silent by default.\n\nSigned-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\nReviewed-by: Andy Moreton <amoreton@solarflare.com>\n---\n drivers/net/sfc/sfc.c | 6 +++---\n drivers/net/sfc/sfc_ethdev.c | 10 +++++-----\n drivers/net/sfc/sfc_intr.c | 6 +++---\n drivers/net/sfc/sfc_mcdi.c | 6 +++---\n drivers/net/sfc/sfc_rx.c | 2 +-\n drivers/net/sfc/sfc_tx.c | 2 +-\n 6 files changed, 16 insertions(+), 16 deletions(-)", "diff": "diff --git a/drivers/net/sfc/sfc.c b/drivers/net/sfc/sfc.c\nindex d31b0b1..2381505 100644\n--- a/drivers/net/sfc/sfc.c\n+++ b/drivers/net/sfc/sfc.c\n@@ -344,7 +344,7 @@ sfc_start(struct sfc_adapter *sa)\n \tcase SFC_ADAPTER_CONFIGURED:\n \t\tbreak;\n \tcase SFC_ADAPTER_STARTED:\n-\t\tsfc_info(sa, \"already started\");\n+\t\tsfc_notice(sa, \"already started\");\n \t\treturn 0;\n \tdefault:\n \t\trc = EINVAL;\n@@ -383,7 +383,7 @@ sfc_stop(struct sfc_adapter *sa)\n \tcase SFC_ADAPTER_STARTED:\n \t\tbreak;\n \tcase SFC_ADAPTER_CONFIGURED:\n-\t\tsfc_info(sa, \"already stopped\");\n+\t\tsfc_notice(sa, \"already stopped\");\n \t\treturn;\n \tdefault:\n \t\tsfc_err(sa, \"stop in unexpected state %u\", sa->state);\n@@ -454,7 +454,7 @@ sfc_schedule_restart(struct sfc_adapter *sa)\n \telse if (rc != 0)\n \t\tsfc_err(sa, \"cannot arm restart alarm (rc=%d)\", rc);\n \telse\n-\t\tsfc_info(sa, \"restart scheduled\");\n+\t\tsfc_notice(sa, \"restart scheduled\");\n }\n \n int\ndiff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c\nindex a244d27..83175e6 100644\n--- a/drivers/net/sfc/sfc_ethdev.c\n+++ b/drivers/net/sfc/sfc_ethdev.c\n@@ -272,7 +272,7 @@ sfc_dev_link_update(struct rte_eth_dev *dev, int wait_to_complete)\n \t}\n \n \tif (old_link.link_status != current_link.link_status)\n-\t\tsfc_info(sa, \"Link status is %s\",\n+\t\tsfc_notice(sa, \"Link status is %s\",\n \t\t\t current_link.link_status ? \"UP\" : \"DOWN\");\n \n \treturn old_link.link_status == current_link.link_status ? 0 : -1;\n@@ -945,8 +945,8 @@ sfc_mac_addr_set(struct rte_eth_dev *dev, struct ether_addr *mac_addr)\n \t}\n \n \tif (sa->state != SFC_ADAPTER_STARTED) {\n-\t\tsfc_info(sa, \"the port is not started\");\n-\t\tsfc_info(sa, \"the new MAC address will be set on port start\");\n+\t\tsfc_notice(sa, \"the port is not started\");\n+\t\tsfc_notice(sa, \"the new MAC address will be set on port start\");\n \n \t\tgoto unlock;\n \t}\n@@ -1751,7 +1751,7 @@ sfc_eth_dev_set_ops(struct rte_eth_dev *dev)\n \t\tgoto fail_dp_rx_name;\n \t}\n \n-\tsfc_info(sa, \"use %s Rx datapath\", sa->dp_rx_name);\n+\tsfc_notice(sa, \"use %s Rx datapath\", sa->dp_rx_name);\n \n \tdev->rx_pkt_burst = sa->dp_rx->pkt_burst;\n \n@@ -1790,7 +1790,7 @@ sfc_eth_dev_set_ops(struct rte_eth_dev *dev)\n \t\tgoto fail_dp_tx_name;\n \t}\n \n-\tsfc_info(sa, \"use %s Tx datapath\", sa->dp_tx_name);\n+\tsfc_notice(sa, \"use %s Tx datapath\", sa->dp_tx_name);\n \n \tdev->tx_pkt_burst = sa->dp_tx->pkt_burst;\n \ndiff --git a/drivers/net/sfc/sfc_intr.c b/drivers/net/sfc/sfc_intr.c\nindex d6c8492..fbdc7ee 100644\n--- a/drivers/net/sfc/sfc_intr.c\n+++ b/drivers/net/sfc/sfc_intr.c\n@@ -86,7 +86,7 @@ sfc_intr_line_handler(void *cb_arg)\n \n exit:\n \tif (lsc_seq != sa->port.lsc_seq) {\n-\t\tsfc_info(sa, \"link status change event: link %s\",\n+\t\tsfc_notice(sa, \"link status change event: link %s\",\n \t\t\t sa->eth_dev->data->dev_link.link_status ?\n \t\t\t \"UP\" : \"DOWN\");\n \t\t_rte_eth_dev_callback_process(sa->eth_dev,\n@@ -130,7 +130,7 @@ sfc_intr_message_handler(void *cb_arg)\n \n exit:\n \tif (lsc_seq != sa->port.lsc_seq) {\n-\t\tsfc_info(sa, \"link status change event\");\n+\t\tsfc_notice(sa, \"link status change event\");\n \t\t_rte_eth_dev_callback_process(sa->eth_dev,\n \t\t\t\t\t RTE_ETH_EVENT_INTR_LSC,\n \t\t\t\t\t NULL);\n@@ -251,7 +251,7 @@ sfc_intr_configure(struct sfc_adapter *sa)\n \tintr->handler = NULL;\n \tintr->lsc_intr = (sa->eth_dev->data->dev_conf.intr_conf.lsc != 0);\n \tif (!intr->lsc_intr) {\n-\t\tsfc_info(sa, \"LSC tracking using interrupts is disabled\");\n+\t\tsfc_notice(sa, \"LSC tracking using interrupts is disabled\");\n \t\tgoto done;\n \t}\n \ndiff --git a/drivers/net/sfc/sfc_mcdi.c b/drivers/net/sfc/sfc_mcdi.c\nindex 9d92b8c..895c2f5 100644\n--- a/drivers/net/sfc/sfc_mcdi.c\n+++ b/drivers/net/sfc/sfc_mcdi.c\n@@ -176,7 +176,7 @@ sfc_mcdi_do_log(const struct sfc_adapter *sa,\n \t\t\t * at the end which is required by netlogdecode.\n \t\t\t */\n \t\t\tbuffer[position] = '\\0';\n-\t\t\tsfc_info(sa, \"%s \\\\\", buffer);\n+\t\t\tsfc_notice(sa, \"%s \\\\\", buffer);\n \t\t\t/* Preserve prefix for the next log message */\n \t\t\tposition = pfxsize;\n \t\t}\n@@ -201,7 +201,7 @@ sfc_mcdi_logger(void *arg, efx_log_msg_t type,\n \tif (!sa->mcdi.logging)\n \t\treturn;\n \n-\t/* The format including prefix added by sfc_info() is the format\n+\t/* The format including prefix added by sfc_notice() is the format\n \t * consumed by the Solarflare netlogdecode tool.\n \t */\n \tpfxsize = snprintf(buffer, sizeof(buffer), \"MCDI RPC %s:\",\n@@ -212,7 +212,7 @@ sfc_mcdi_logger(void *arg, efx_log_msg_t type,\n \tstart = sfc_mcdi_do_log(sa, buffer, data, data_size, pfxsize, start);\n \tif (start != pfxsize) {\n \t\tbuffer[start] = '\\0';\n-\t\tsfc_info(sa, \"%s\", buffer);\n+\t\tsfc_notice(sa, \"%s\", buffer);\n \t}\n }\n \ndiff --git a/drivers/net/sfc/sfc_rx.c b/drivers/net/sfc/sfc_rx.c\nindex abc53fb..f7aaab0 100644\n--- a/drivers/net/sfc/sfc_rx.c\n+++ b/drivers/net/sfc/sfc_rx.c\n@@ -608,7 +608,7 @@ sfc_rx_qflush(struct sfc_adapter *sa, unsigned int sw_index)\n \t\t\tsfc_err(sa, \"RxQ %u flush failed\", sw_index);\n \n \t\tif (rxq->state & SFC_RXQ_FLUSHED)\n-\t\t\tsfc_info(sa, \"RxQ %u flushed\", sw_index);\n+\t\t\tsfc_notice(sa, \"RxQ %u flushed\", sw_index);\n \t}\n \n \tsa->dp_rx->qpurge(rxq->dp);\ndiff --git a/drivers/net/sfc/sfc_tx.c b/drivers/net/sfc/sfc_tx.c\nindex 757b03b..0035c5c 100644\n--- a/drivers/net/sfc/sfc_tx.c\n+++ b/drivers/net/sfc/sfc_tx.c\n@@ -606,7 +606,7 @@ sfc_tx_qstop(struct sfc_adapter *sa, unsigned int sw_index)\n \t\t\tsfc_err(sa, \"TxQ %u flush timed out\", sw_index);\n \n \t\tif (txq->state & SFC_TXQ_FLUSHED)\n-\t\t\tsfc_info(sa, \"TxQ %u flushed\", sw_index);\n+\t\t\tsfc_notice(sa, \"TxQ %u flushed\", sw_index);\n \t}\n \n \tsa->dp_tx->qreap(txq->dp);\n", "prefixes": [ "dpdk-dev", "4/6" ] }