Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/34463/?format=api
{ "id": 34463, "url": "http://patches.dpdk.org/api/patches/34463/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1516873582-169644-1-git-send-email-harry.van.haaren@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1516873582-169644-1-git-send-email-harry.van.haaren@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1516873582-169644-1-git-send-email-harry.van.haaren@intel.com", "date": "2018-01-25T09:46:22", "name": "[dpdk-dev] event/sw: add dynamic logging support", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "73575255692948d7d0b97ba0b69a0fb5af6479f5", "submitter": { "id": 317, "url": "http://patches.dpdk.org/api/people/317/?format=api", "name": "Van Haaren, Harry", "email": "harry.van.haaren@intel.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1516873582-169644-1-git-send-email-harry.van.haaren@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/34463/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/34463/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0257E1D7;\n\tThu, 25 Jan 2018 10:46:36 +0100 (CET)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id 0701D1B16C\n\tfor <dev@dpdk.org>; Thu, 25 Jan 2018 10:46:34 +0100 (CET)", "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t25 Jan 2018 01:46:33 -0800", "from silpixa00398672.ir.intel.com ([10.237.223.111])\n\tby orsmga008.jf.intel.com with ESMTP; 25 Jan 2018 01:46:32 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.46,411,1511856000\"; d=\"scan'208\";a=\"12935911\"", "From": "Harry van Haaren <harry.van.haaren@intel.com>", "To": "dev@dpdk.org", "Cc": "Harry van Haaren <harry.van.haaren@intel.com>,\n\tjerin.jacob@caviumnetworks.com", "Date": "Thu, 25 Jan 2018 09:46:22 +0000", "Message-Id": "<1516873582-169644-1-git-send-email-harry.van.haaren@intel.com>", "X-Mailer": "git-send-email 2.7.4", "Subject": "[dpdk-dev] [PATCH] event/sw: add dynamic logging support", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This commit enables dynamic logging with the SW pmd.\nThe string \"pmd.event.sw\" is used to change the verbosity\nof the logging output, as per the newly defined log naming.\n\nSigned-off-by: Harry van Haaren <harry.van.haaren@intel.com>\n\n---\n\n@Maintainer:\nCc: jerin.jacob@caviumnetworks.com\nThis patch is not required for 18.02\n\n---\n config/common_base | 1 -\n drivers/event/sw/sw_evdev.c | 12 ++++++++++++\n drivers/event/sw/sw_evdev.h | 21 +--------------------\n drivers/event/sw/sw_evdev_log.h | 23 +++++++++++++++++++++++\n 4 files changed, 36 insertions(+), 21 deletions(-)\n create mode 100644 drivers/event/sw/sw_evdev_log.h", "diff": "diff --git a/config/common_base b/config/common_base\nindex 170a389..0bf87aa 100644\n--- a/config/common_base\n+++ b/config/common_base\n@@ -585,7 +585,6 @@ CONFIG_RTE_LIBRTE_PMD_SKELETON_EVENTDEV_DEBUG=n\n # Compile PMD for software event device\n #\n CONFIG_RTE_LIBRTE_PMD_SW_EVENTDEV=y\n-CONFIG_RTE_LIBRTE_PMD_SW_EVENTDEV_DEBUG=n\n \n #\n # Compile PMD for octeontx sso event device\ndiff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c\nindex f9daf4f..6672fd8 100644\n--- a/drivers/event/sw/sw_evdev.c\n+++ b/drivers/event/sw/sw_evdev.c\n@@ -929,3 +929,15 @@ static struct rte_vdev_driver evdev_sw_pmd_drv = {\n RTE_PMD_REGISTER_VDEV(EVENTDEV_NAME_SW_PMD, evdev_sw_pmd_drv);\n RTE_PMD_REGISTER_PARAM_STRING(event_sw, NUMA_NODE_ARG \"=<int> \"\n \t\tSCHED_QUANTA_ARG \"=<int>\" CREDIT_QUANTA_ARG \"=<int>\");\n+\n+/* declared extern in header, for access from other .c files */\n+int eventdev_sw_log_level;\n+\n+RTE_INIT(evdev_sw_init_log);\n+static void\n+evdev_sw_init_log(void)\n+{\n+\teventdev_sw_log_level = rte_log_register(\"pmd.event.sw\");\n+\tif (eventdev_sw_log_level >= 0)\n+\t\trte_log_set_level(eventdev_sw_log_level, RTE_LOG_NOTICE);\n+}\ndiff --git a/drivers/event/sw/sw_evdev.h b/drivers/event/sw/sw_evdev.h\nindex 7498707..d90b96d 100644\n--- a/drivers/event/sw/sw_evdev.h\n+++ b/drivers/event/sw/sw_evdev.h\n@@ -5,6 +5,7 @@\n #ifndef _SW_EVDEV_H_\n #define _SW_EVDEV_H_\n \n+#include \"sw_evdev_log.h\"\n #include <rte_eventdev.h>\n #include <rte_eventdev_pmd_vdev.h>\n #include <rte_atomic.h>\n@@ -64,26 +65,6 @@ static const uint8_t sw_qe_flag_map[] = {\n \t\tQE_FLAG_VALID | QE_FLAG_COMPLETE | QE_FLAG_NOT_EOP,\n };\n \n-#ifdef RTE_LIBRTE_PMD_EVDEV_SW_DEBUG\n-#define SW_LOG_INFO(fmt, args...) \\\n-\tRTE_LOG(INFO, EVENTDEV, \"[%s] %s() line %u: \" fmt \"\\n\", \\\n-\t\t\tSW_PMD_NAME, \\\n-\t\t\t__func__, __LINE__, ## args)\n-\n-#define SW_LOG_DBG(fmt, args...) \\\n-\tRTE_LOG(DEBUG, EVENTDEV, \"[%s] %s() line %u: \" fmt \"\\n\", \\\n-\t\t\tSW_PMD_NAME, \\\n-\t\t\t__func__, __LINE__, ## args)\n-#else\n-#define SW_LOG_INFO(fmt, args...)\n-#define SW_LOG_DBG(fmt, args...)\n-#endif\n-\n-#define SW_LOG_ERR(fmt, args...) \\\n-\tRTE_LOG(ERR, EVENTDEV, \"[%s] %s() line %u: \" fmt \"\\n\", \\\n-\t\t\tSW_PMD_NAME, \\\n-\t\t\t__func__, __LINE__, ## args)\n-\n /* Records basic event stats at a given point. Used in port and qid structs */\n struct sw_point_stats {\n \tuint64_t rx_pkts;\ndiff --git a/drivers/event/sw/sw_evdev_log.h b/drivers/event/sw/sw_evdev_log.h\nnew file mode 100644\nindex 0000000..f76825a\n--- /dev/null\n+++ b/drivers/event/sw/sw_evdev_log.h\n@@ -0,0 +1,23 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(c) 2018 Intel Corporation\n+ */\n+\n+#ifndef _SW_EVDEV_LOG_H_\n+#define _SW_EVDEV_LOG_H_\n+\n+extern int eventdev_sw_log_level;\n+\n+#define SW_LOG_IMPL(level, fmt, args...) \\\n+\trte_log(RTE_LOG_ ## level, eventdev_sw_log_level, \"%s\" fmt \"\\n\", \\\n+\t\t\t__func__, ##args)\n+\n+#define SW_LOG_INFO(fmt, args...) \\\n+\tSW_LOG_IMPL(INFO, fmt, ## args)\n+\n+#define SW_LOG_DBG(fmt, args...) \\\n+\tSW_LOG_IMPL(DEBUG, fmt, ## args)\n+\n+#define SW_LOG_ERR(fmt, args...) \\\n+\tSW_LOG_IMPL(ERR, fmt, ## args)\n+\n+#endif /* _SW_EVDEV_LOG_H_ */\n", "prefixes": [ "dpdk-dev" ] }