Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 34305,
    "url": "http://patches.dpdk.org/api/patches/34305/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1516700843-131786-1-git-send-email-jianfeng.tan@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1516700843-131786-1-git-send-email-jianfeng.tan@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1516700843-131786-1-git-send-email-jianfeng.tan@intel.com",
    "date": "2018-01-23T09:47:23",
    "name": "[dpdk-dev] net/virtio-user: fix segfault as features change",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "7a7023f39493687b1fb5cf7a4a576d42f1b20d01",
    "submitter": {
        "id": 313,
        "url": "http://patches.dpdk.org/api/people/313/?format=api",
        "name": "Jianfeng Tan",
        "email": "jianfeng.tan@intel.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1516700843-131786-1-git-send-email-jianfeng.tan@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/34305/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/34305/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 077951B017;\n\tTue, 23 Jan 2018 10:45:37 +0100 (CET)",
            "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id 8596A1B015\n\tfor <dev@dpdk.org>; Tue, 23 Jan 2018 10:45:35 +0100 (CET)",
            "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t23 Jan 2018 01:45:34 -0800",
            "from dpdk06.sh.intel.com ([10.67.110.196])\n\tby orsmga008.jf.intel.com with ESMTP; 23 Jan 2018 01:45:32 -0800"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.46,400,1511856000\"; d=\"scan'208\";a=\"12333710\"",
        "From": "Jianfeng Tan <jianfeng.tan@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "yuanhan.liu@linux.intel.com, maxime.coquelin@redhat.com,\n\tJianfeng Tan <jianfeng.tan@intel.com>",
        "Date": "Tue, 23 Jan 2018 09:47:23 +0000",
        "Message-Id": "<1516700843-131786-1-git-send-email-jianfeng.tan@intel.com>",
        "X-Mailer": "git-send-email 2.7.4",
        "Subject": "[dpdk-dev] [PATCH] net/virtio-user: fix segfault as features change",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Since commit 59fe5e17d93 (\"vhost: propagate set features handling error\"),\nvhost does not allow to set different features without reset.\n\nThe virito-user driver fails to reset the device in below commit.\n\nTo fix, we send the reset message as stopping the device.\n\nFixes: c12a26ee209e (\"net/virtio-user: fix not properly reset device\")\n\nReported-by: Lei Yao <lei.a.yao@intel.com>\nReported-by: Tiwei Bie <tiwei.bie@intel.com>\nSigned-off-by: Jianfeng Tan <jianfeng.tan@intel.com>\n---\n drivers/net/virtio/virtio_user/virtio_user_dev.c | 5 +++++\n 1 file changed, 5 insertions(+)",
    "diff": "diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c\nindex 7a70c18..3b5f737 100644\n--- a/drivers/net/virtio/virtio_user/virtio_user_dev.c\n+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c\n@@ -142,6 +142,11 @@ int virtio_user_stop_device(struct virtio_user_dev *dev)\n \tfor (i = 0; i < dev->max_queue_pairs; ++i)\n \t\tdev->ops->enable_qp(dev, i, 0);\n \n+\tif (dev->ops->send_request(dev, VHOST_USER_RESET_OWNER, NULL) < 0) {\n+\t\tPMD_DRV_LOG(INFO, \"Failed to reset the device\\n\");\n+\t\treturn -1;\n+\t}\n+\n \treturn 0;\n }\n \n",
    "prefixes": [
        "dpdk-dev"
    ]
}