Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/34204/?format=api
{ "id": 34204, "url": "http://patches.dpdk.org/api/patches/34204/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180122014807.24654-2-nhorman@tuxdriver.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180122014807.24654-2-nhorman@tuxdriver.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180122014807.24654-2-nhorman@tuxdriver.com", "date": "2018-01-22T01:48:03", "name": "[dpdk-dev,[PATCH,v5] 1/5] buildtools: Add tool to check EXPERIMENTAL api exports", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e7c9d2de61469cfb750ea334f942fdf98aa068f0", "submitter": { "id": 32, "url": "http://patches.dpdk.org/api/people/32/?format=api", "name": "Neil Horman", "email": "nhorman@tuxdriver.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180122014807.24654-2-nhorman@tuxdriver.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/34204/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/34204/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 545791B018;\n\tMon, 22 Jan 2018 02:49:01 +0100 (CET)", "from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])\n\tby dpdk.org (Postfix) with ESMTP id 5C807199B0\n\tfor <dev@dpdk.org>; Mon, 22 Jan 2018 02:48:56 +0100 (CET)", "from cpe-2606-a000-111b-4011-eaa3-4b92-4a68-8f24.dyn6.twc.com\n\t([2606:a000:111b:4011:eaa3:4b92:4a68:8f24]\n\thelo=hmswarspite.think-freely.org)\n\tby smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63)\n\t(envelope-from <nhorman@tuxdriver.com>)\n\tid 1edRE5-000688-Fm; Sun, 21 Jan 2018 20:48:52 -0500", "from hmswarspite.think-freely.org (localhost [127.0.0.1])\n\tby hmswarspite.think-freely.org (8.15.2/8.15.2) with ESMTP id\n\tw0M1mCxl024802; Sun, 21 Jan 2018 20:48:12 -0500", "(from nhorman@localhost)\n\tby hmswarspite.think-freely.org (8.15.2/8.15.2/Submit) id\n\tw0M1mC6u024801; Sun, 21 Jan 2018 20:48:12 -0500" ], "From": "Neil Horman <nhorman@tuxdriver.com>", "To": "dev@dpdk.org", "Cc": "Neil Horman <nhorman@tuxdriver.com>,\n\tThomas Monjalon <thomas@monjalon.net>, \n\t\"Mcnamara, John\" <john.mcnamara@intel.com>,\n\tBruce Richardson <bruce.richardson@intel.com>", "Date": "Sun, 21 Jan 2018 20:48:03 -0500", "Message-Id": "<20180122014807.24654-2-nhorman@tuxdriver.com>", "X-Mailer": "git-send-email 2.14.3", "In-Reply-To": "<20180122014807.24654-1-nhorman@tuxdriver.com>", "References": "<20171201185628.16261-1-nhorman@tuxdriver.com>\n\t<20180122014807.24654-1-nhorman@tuxdriver.com>", "X-Spam-Score": "-2.9 (--)", "X-Spam-Status": "No", "Subject": "[dpdk-dev] [[PATCH v5] 1/5] buildtools: Add tool to check\n\tEXPERIMENTAL api exports", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This tools reads the given version map for a directory, and checks to\nensure that, for each symbol listed in the export list, the corresponding\ndefinition is tagged as __rte_experimental, erroring out if its not. In this\nway, we can ensure that the EXPERIMENTAL api is kept in sync with the tags\n\nSigned-off-by: Neil Horman <nhorman@tuxdriver.com>\nCC: Thomas Monjalon <thomas@monjalon.net>\nCC: \"Mcnamara, John\" <john.mcnamara@intel.com>\nCC: Bruce Richardson <bruce.richardson@intel.com>\n---\n MAINTAINERS | 1 +\n buildtools/check-experimental-syms.sh | 32 ++++++++++++++++++++++++++++++++\n 2 files changed, 33 insertions(+)\n create mode 100755 buildtools/check-experimental-syms.sh", "diff": "diff --git a/MAINTAINERS b/MAINTAINERS\nindex b51c2d096..446d2545d 100644\n--- a/MAINTAINERS\n+++ b/MAINTAINERS\n@@ -77,6 +77,7 @@ M: Neil Horman <nhorman@tuxdriver.com>\n F: lib/librte_compat/\n F: doc/guides/rel_notes/deprecation.rst\n F: devtools/validate-abi.sh\n+F: buildtools/check-experimental-syms.sh\n \n Driver information\n F: buildtools/pmdinfogen/\ndiff --git a/buildtools/check-experimental-syms.sh b/buildtools/check-experimental-syms.sh\nnew file mode 100755\nindex 000000000..7d21de35c\n--- /dev/null\n+++ b/buildtools/check-experimental-syms.sh\n@@ -0,0 +1,32 @@\n+#!/bin/sh\n+\n+# SPDX-License-Identifier: BSD-3-Clause\n+\n+MAPFILE=$1\n+OBJFILE=$2\n+\n+if [ -d $MAPFILE ]\n+then\n+\texit 0\n+fi\n+\n+for i in `awk 'BEGIN {found=0}\n+\t\t/.*EXPERIMENTAL.*/ {found=1}\n+\t\t/.*}.*;/ {found=0}\n+\t\t/.*;/ {if (found == 1) print $1}' $MAPFILE`\n+do\n+\tSYM=`echo $i | sed -e\"s/;//\"`\n+\tobjdump -t $OBJFILE | grep -q \"\\.text.*$SYM\"\n+\tIN_TEXT=$?\n+\tobjdump -t $OBJFILE | grep -q \"\\.text\\.experimental.*$SYM\"\n+\tIN_EXP=$?\n+\tif [ $IN_TEXT -eq 0 -a $IN_EXP -ne 0 ]\n+\tthen\n+\t\techo \"$SYM is not flagged as experimental\"\n+\t\techo \"but is listed in version map\"\n+\t\techo \"Please add __rte_experimental to the definition of $SYM\"\n+\t\texit 1\n+\tfi\n+done\n+exit 0\n+\n", "prefixes": [ "dpdk-dev", "[PATCH", "v5" ] }