Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 34184,
    "url": "http://patches.dpdk.org/api/patches/34184/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180121185956.32970-5-ferruh.yigit@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20180121185956.32970-5-ferruh.yigit@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20180121185956.32970-5-ferruh.yigit@intel.com",
    "date": "2018-01-21T18:59:47",
    "name": "[dpdk-dev,v6,05/14] net/dpaa2: use ethdev linkstatus helper functions",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "89b8a432e29c632d9f3a3e35011c67642b3fdaca",
    "submitter": {
        "id": 324,
        "url": "http://patches.dpdk.org/api/people/324/?format=api",
        "name": "Ferruh Yigit",
        "email": "ferruh.yigit@intel.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180121185956.32970-5-ferruh.yigit@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/34184/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/34184/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D30031B161;\n\tSun, 21 Jan 2018 20:00:21 +0100 (CET)",
            "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id CAF31199B5\n\tfor <dev@dpdk.org>; Sun, 21 Jan 2018 20:00:10 +0100 (CET)",
            "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t21 Jan 2018 11:00:10 -0800",
            "from silpixa00372839.ir.intel.com (HELO\n\tsilpixa00372839.ger.corp.intel.com) ([10.237.222.154])\n\tby orsmga002.jf.intel.com with ESMTP; 21 Jan 2018 11:00:08 -0800"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.46,392,1511856000\"; d=\"scan'208\";a=\"28253637\"",
        "From": "Ferruh Yigit <ferruh.yigit@intel.com>",
        "To": "Bruce Richardson <bruce.richardson@intel.com>,\n\tKonstantin Ananyev <konstantin.ananyev@intel.com>,\n\tHemant Agrawal <hemant.agrawal@nxp.com>,\n\tShreyansh Jain <shreyansh.jain@nxp.com>",
        "Cc": "dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,\n\tStephen Hemminger <stephen@networkplumber.org>",
        "Date": "Sun, 21 Jan 2018 18:59:47 +0000",
        "Message-Id": "<20180121185956.32970-5-ferruh.yigit@intel.com>",
        "X-Mailer": "git-send-email 2.14.3",
        "In-Reply-To": "<20180121185956.32970-1-ferruh.yigit@intel.com>",
        "References": "<20180116183755.24542-1-stephen@networkplumber.org>\n\t<20180121185956.32970-1-ferruh.yigit@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v6 05/14] net/dpaa2: use ethdev linkstatus helper\n\tfunctions",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Stephen Hemminger <stephen@networkplumber.org>\n\nUse new helper function to update the link status.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nSigned-off-by: Ferruh Yigit <ferruh.yigit@intel.com>\n---\nv6:\n* Use correct APIs\n* Keep logic exact same, only use new APIs to get/set link\n---\n drivers/net/dpaa2/dpaa2_ethdev.c | 77 +++++++---------------------------------\n 1 file changed, 12 insertions(+), 65 deletions(-)",
    "diff": "diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c\nindex a0a3d5264..9a3a4182b 100644\n--- a/drivers/net/dpaa2/dpaa2_ethdev.c\n+++ b/drivers/net/dpaa2/dpaa2_ethdev.c\n@@ -57,58 +57,6 @@ static int dpaa2_dev_set_link_up(struct rte_eth_dev *dev);\n static int dpaa2_dev_set_link_down(struct rte_eth_dev *dev);\n static int dpaa2_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu);\n \n-/**\n- * Atomically reads the link status information from global\n- * structure rte_eth_dev.\n- *\n- * @param dev\n- *   - Pointer to the structure rte_eth_dev to read from.\n- *   - Pointer to the buffer to be saved with the link status.\n- *\n- * @return\n- *   - On success, zero.\n- *   - On failure, negative value.\n- */\n-static inline int\n-dpaa2_dev_atomic_read_link_status(struct rte_eth_dev *dev,\n-\t\t\t\t  struct rte_eth_link *link)\n-{\n-\tstruct rte_eth_link *dst = link;\n-\tstruct rte_eth_link *src = &dev->data->dev_link;\n-\n-\tif (rte_atomic64_cmpset((uint64_t *)dst, *(uint64_t *)dst,\n-\t\t\t\t*(uint64_t *)src) == 0)\n-\t\treturn -1;\n-\n-\treturn 0;\n-}\n-\n-/**\n- * Atomically writes the link status information into global\n- * structure rte_eth_dev.\n- *\n- * @param dev\n- *   - Pointer to the structure rte_eth_dev to read from.\n- *   - Pointer to the buffer to be saved with the link status.\n- *\n- * @return\n- *   - On success, zero.\n- *   - On failure, negative value.\n- */\n-static inline int\n-dpaa2_dev_atomic_write_link_status(struct rte_eth_dev *dev,\n-\t\t\t\t   struct rte_eth_link *link)\n-{\n-\tstruct rte_eth_link *dst = &dev->data->dev_link;\n-\tstruct rte_eth_link *src = link;\n-\n-\tif (rte_atomic64_cmpset((uint64_t *)dst, *(uint64_t *)dst,\n-\t\t\t\t*(uint64_t *)src) == 0)\n-\t\treturn -1;\n-\n-\treturn 0;\n-}\n-\n static int\n dpaa2_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on)\n {\n@@ -821,7 +769,9 @@ dpaa2_dev_stop(struct rte_eth_dev *dev)\n \tstruct dpaa2_dev_priv *priv = dev->data->dev_private;\n \tstruct fsl_mc_io *dpni = (struct fsl_mc_io *)priv->hw;\n \tint ret;\n-\tstruct rte_eth_link link;\n+\tstruct rte_eth_link link = {\n+\t\t.link_status = ETH_LINK_DOWN,\n+\t};\n \tstruct rte_intr_handle *intr_handle = dev->intr_handle;\n \n \tPMD_INIT_FUNC_TRACE();\n@@ -851,8 +801,7 @@ dpaa2_dev_stop(struct rte_eth_dev *dev)\n \t}\n \n \t/* clear the recorded link status */\n-\tmemset(&link, 0, sizeof(link));\n-\tdpaa2_dev_atomic_write_link_status(dev, &link);\n+\trte_eth_linkstatus_set(dev, &link);\n }\n \n static void\n@@ -862,7 +811,9 @@ dpaa2_dev_close(struct rte_eth_dev *dev)\n \tstruct dpaa2_dev_priv *priv = dev->data->dev_private;\n \tstruct fsl_mc_io *dpni = (struct fsl_mc_io *)priv->hw;\n \tint i, ret;\n-\tstruct rte_eth_link link;\n+\tstruct rte_eth_link link = {\n+\t\t.link_status = ETH_LINK_DOWN,\n+\t};\n \tstruct dpaa2_queue *dpaa2_q;\n \n \tPMD_INIT_FUNC_TRACE();\n@@ -883,8 +834,7 @@ dpaa2_dev_close(struct rte_eth_dev *dev)\n \t\treturn;\n \t}\n \n-\tmemset(&link, 0, sizeof(link));\n-\tdpaa2_dev_atomic_write_link_status(dev, &link);\n+\trte_eth_linkstatus_set(dev, &link);\n }\n \n static void\n@@ -1342,8 +1292,7 @@ dpaa2_dev_link_update(struct rte_eth_dev *dev,\n \t\tRTE_LOG(ERR, PMD, \"dpni is NULL\\n\");\n \t\treturn 0;\n \t}\n-\tmemset(&old, 0, sizeof(old));\n-\tdpaa2_dev_atomic_read_link_status(dev, &old);\n+\trte_eth_linkstatus_get(dev, &old);\n \n \tret = dpni_get_link_state(dpni, CMD_PRI_LOW, priv->token, &state);\n \tif (ret < 0) {\n@@ -1365,12 +1314,10 @@ dpaa2_dev_link_update(struct rte_eth_dev *dev,\n \telse\n \t\tlink.link_duplex = ETH_LINK_FULL_DUPLEX;\n \n-\tdpaa2_dev_atomic_write_link_status(dev, &link);\n+\trte_eth_linkstatus_set(dev, &link);\n \n-\tif (link.link_status)\n-\t\tPMD_DRV_LOG(INFO, \"Port %d Link is Up\\n\", dev->data->port_id);\n-\telse\n-\t\tPMD_DRV_LOG(INFO, \"Port %d Link is Down\", dev->data->port_id);\n+\tPMD_DRV_LOG(INFO, \"Port %d Link is %s\\n\", dev->data->port_id,\n+\t\t    link.link_status ? \"Up\" : \"Down\");\n \treturn 0;\n }\n \n",
    "prefixes": [
        "dpdk-dev",
        "v6",
        "05/14"
    ]
}