Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/34064/?format=api
http://patches.dpdk.org/api/patches/34064/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1516330925-27845-1-git-send-email-rosen.xu@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1516330925-27845-1-git-send-email-rosen.xu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1516330925-27845-1-git-send-email-rosen.xu@intel.com", "date": "2018-01-19T03:02:05", "name": "[dpdk-dev] net/i40e/avf/ixgbe: remove unnecessary mbuf field initialization in PMD", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "e382d96c8a6e3013f1485fba47d02f8deb1643a4", "submitter": { "id": 946, "url": "http://patches.dpdk.org/api/people/946/?format=api", "name": "Xu, Rosen", "email": "rosen.xu@intel.com" }, "delegate": { "id": 24, "url": "http://patches.dpdk.org/api/users/24/?format=api", "username": "helin_zhang", "first_name": "Helin", "last_name": "Zhang", "email": "helin.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1516330925-27845-1-git-send-email-rosen.xu@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/34064/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/34064/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DB1A41B2C1;\n\tFri, 19 Jan 2018 04:04:22 +0100 (CET)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id BE6361B2A8;\n\tFri, 19 Jan 2018 04:04:20 +0100 (CET)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t18 Jan 2018 19:04:18 -0800", "from dpdkx8602.sh.intel.com ([10.67.110.200])\n\tby FMSMGA003.fm.intel.com with ESMTP; 18 Jan 2018 19:04:16 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.46,380,1511856000\"; d=\"scan'208\";a=\"20941923\"", "From": "Rosen Xu <rosen.xu@intel.com>", "To": "beilei.xing@intel.com,\n\tqi.z.zhang@intel.com,\n\twenzhuo.lu@intel.com", "Cc": "dev@dpdk.org,\n\tstable@dpdk.org", "Date": "Fri, 19 Jan 2018 11:02:05 +0800", "Message-Id": "<1516330925-27845-1-git-send-email-rosen.xu@intel.com>", "X-Mailer": "git-send-email 1.8.3.1", "Subject": "[dpdk-dev] [PATCH] net/i40e/avf/ixgbe: remove unnecessary mbuf\n\tfield initialization in PMD", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Set the value of m->refcnt to 1, m->nb_segs to 1 and m->next to NULL\nwhen the mbuf is initialized or stored inside the mempool (unused).\nAll of these are done in rte_pktmbuf_pool_create() and rte_pktmbuf_prefree_seg().\nSo we remove the redundant code from i40e, ixgbe and avf module.\n\nFixes: 8f094a9ac5d7 (\"mbuf: set mbuf fields while in pool\")\nCc: stable@dpdk.org\n\nSigned-off-by: Rosen Xu <rosen.xu@intel.com>\n---\n drivers/net/avf/avf_rxtx.c | 6 ------\n drivers/net/i40e/i40e_rxtx.c | 6 ------\n drivers/net/ixgbe/ixgbe_rxtx.c | 1 -\n 3 files changed, 13 deletions(-)", "diff": "diff --git a/drivers/net/avf/avf_rxtx.c b/drivers/net/avf/avf_rxtx.c\nindex e0c4583..b9051d6 100644\n--- a/drivers/net/avf/avf_rxtx.c\n+++ b/drivers/net/avf/avf_rxtx.c\n@@ -221,10 +221,7 @@\n \t\t\treturn -ENOMEM;\n \t\t}\n \n-\t\trte_mbuf_refcnt_set(mbuf, 1);\n-\t\tmbuf->next = NULL;\n \t\tmbuf->data_off = RTE_PKTMBUF_HEADROOM;\n-\t\tmbuf->nb_segs = 1;\n \t\tmbuf->port = rxq->port_id;\n \n \t\tdma_addr =\n@@ -1239,10 +1236,7 @@\n \t\t\trte_prefetch0(rxep[i + 1]);\n \n \t\tmb = rxep[i];\n-\t\trte_mbuf_refcnt_set(mb, 1);\n-\t\tmb->next = NULL;\n \t\tmb->data_off = RTE_PKTMBUF_HEADROOM;\n-\t\tmb->nb_segs = 1;\n \t\tmb->port = rxq->port_id;\n \t\tdma_addr = rte_cpu_to_le_64(rte_mbuf_data_iova_default(mb));\n \t\trxdp[i].read.hdr_addr = 0;\ndiff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c\nindex 23256b7..b578957 100644\n--- a/drivers/net/i40e/i40e_rxtx.c\n+++ b/drivers/net/i40e/i40e_rxtx.c\n@@ -550,10 +550,7 @@\n \t\t\trte_prefetch0(rxep[i + 1].mbuf);\n \n \t\tmb = rxep[i].mbuf;\n-\t\trte_mbuf_refcnt_set(mb, 1);\n-\t\tmb->next = NULL;\n \t\tmb->data_off = RTE_PKTMBUF_HEADROOM;\n-\t\tmb->nb_segs = 1;\n \t\tmb->port = rxq->port_id;\n \t\tdma_addr = rte_cpu_to_le_64(\\\n \t\t\trte_mbuf_data_iova_default(mb));\n@@ -2411,10 +2408,7 @@\n \t\t\treturn -ENOMEM;\n \t\t}\n \n-\t\trte_mbuf_refcnt_set(mbuf, 1);\n-\t\tmbuf->next = NULL;\n \t\tmbuf->data_off = RTE_PKTMBUF_HEADROOM;\n-\t\tmbuf->nb_segs = 1;\n \t\tmbuf->port = rxq->port_id;\n \n \t\tdma_addr =\ndiff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c\nindex 4b38247..72da571 100644\n--- a/drivers/net/ixgbe/ixgbe_rxtx.c\n+++ b/drivers/net/ixgbe/ixgbe_rxtx.c\n@@ -1629,7 +1629,6 @@ uint16_t ixgbe_xmit_fixed_burst_vec(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t\t\tmb->port = rxq->port_id;\n \t\t}\n \n-\t\trte_mbuf_refcnt_set(mb, 1);\n \t\tmb->data_off = RTE_PKTMBUF_HEADROOM;\n \n \t\t/* populate the descriptors */\n", "prefixes": [ "dpdk-dev" ] }{ "id": 34064, "url": "