Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/33688/?format=api
http://patches.dpdk.org/api/patches/33688/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/d7a73c699d9bd683e0258cf73d254e6bfe42a05d.1515776290.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<d7a73c699d9bd683e0258cf73d254e6bfe42a05d.1515776290.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/d7a73c699d9bd683e0258cf73d254e6bfe42a05d.1515776290.git.anatoly.burakov@intel.com", "date": "2018-01-12T17:23:16", "name": "[dpdk-dev,v2] member: fix memory leak on error", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "711c8ea8a1a547525a030c0c0ce944263ad0363f", "submitter": { "id": 4, "url": "http://patches.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/d7a73c699d9bd683e0258cf73d254e6bfe42a05d.1515776290.git.anatoly.burakov@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/33688/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/33688/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 247A2A48C;\n\tFri, 12 Jan 2018 18:23:21 +0100 (CET)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id D18F5727A\n\tfor <dev@dpdk.org>; Fri, 12 Jan 2018 18:23:19 +0100 (CET)", "from fmsmga007.fm.intel.com ([10.253.24.52])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t12 Jan 2018 09:23:18 -0800", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby fmsmga007.fm.intel.com with ESMTP; 12 Jan 2018 09:23:17 -0800", "from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com\n\t[10.237.217.45])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tw0CHNGNA002687; Fri, 12 Jan 2018 17:23:16 GMT", "from sivswdev01.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev01.ir.intel.com with ESMTP id w0CHNGSJ012375;\n\tFri, 12 Jan 2018 17:23:16 GMT", "(from aburakov@localhost)\n\tby sivswdev01.ir.intel.com with LOCAL id w0CHNGKh012371;\n\tFri, 12 Jan 2018 17:23:16 GMT" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.46,349,1511856000\"; d=\"scan'208\";a=\"9147289\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "Yipeng Wang <yipeng1.wang@intel.com>,\n\tSameh Gobriel <sameh.gobriel@intel.com>", "Date": "Fri, 12 Jan 2018 17:23:16 +0000", "Message-Id": "<d7a73c699d9bd683e0258cf73d254e6bfe42a05d.1515776290.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "In-Reply-To": "<5c0a540f8917604a86e18f8da77fa0c2013b7fde.1513865858.git.anatoly.burakov@intel.com>", "References": "<5c0a540f8917604a86e18f8da77fa0c2013b7fde.1513865858.git.anatoly.burakov@intel.com>", "Subject": "[dpdk-dev] [PATCH v2] member: fix memory leak on error", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "rte_member may have allocated a tailq entry or setum before failure,\nso free them.\n\nFixes: 857ed6c68cf2 (\"member: implement main API\")\nCc: yipeng1.wang@intel.com\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n\nNotes:\n v2: free setsum as well\n\n lib/librte_member/rte_member.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/librte_member/rte_member.c b/lib/librte_member/rte_member.c\nindex 0c4c144..bc4cef6 100644\n--- a/lib/librte_member/rte_member.c\n+++ b/lib/librte_member/rte_member.c\n@@ -162,8 +162,9 @@ rte_member_create(const struct rte_member_parameters *params)\n \treturn setsum;\n \n error_unlock_exit:\n+\trte_free(te);\n+\trte_free(setsum);\n \trte_rwlock_write_unlock(RTE_EAL_TAILQ_RWLOCK);\n-\trte_member_free(setsum);\n \treturn NULL;\n }\n \n", "prefixes": [ "dpdk-dev", "v2" ] }{ "id": 33688, "url": "