Patch Comment List
List patch comments
GET /api/patches/336/comments/?format=api
[ { "id": 959, "web_url": "http://patches.dpdk.org/comment/959/", "msgid": "<2846511.VthLZyxgb4@xps13>", "list_archive_url": "https://inbox.dpdk.org/dev/2846511.VthLZyxgb4@xps13", "date": "2014-09-24T15:14:58", "subject": "Re: [dpdk-dev] [memnic PATCH 3/7] pmd: use helper macros", "submitter": { "id": 1, "url": "http://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "content": "2014-09-11 07:47, Hiroshi Shimamoto:\n> Do not touch pktmbuf directly.\n> \n> Instead of direct access, use rte_pktmbuf_pkt_len() and rte_pktmbuf_data_len()\n> to access the property.\n\nI guess this change is for compatibility with DPDK 1.8.\nDoes it have an impact on performance?", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 27321AFCA;\n\tWed, 24 Sep 2014 17:08:54 +0200 (CEST)", "from mail-wg0-f51.google.com (mail-wg0-f51.google.com\n\t[74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 170E16896\n\tfor <dev@dpdk.org>; Wed, 24 Sep 2014 17:08:53 +0200 (CEST)", "by mail-wg0-f51.google.com with SMTP id z12so2543324wgg.10\n\tfor <dev@dpdk.org>; Wed, 24 Sep 2014 08:15:06 -0700 (PDT)", "from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])\n\tby mx.google.com with ESMTPSA id\n\ty15sm9732wib.20.2014.09.24.08.15.05 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 24 Sep 2014 08:15:05 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:organization\n\t:user-agent:in-reply-to:references:mime-version\n\t:content-transfer-encoding:content-type;\n\tbh=XlybWir89ZIhHMgWbFRLhrL+qGAi2vOyeHnYTLyVOOQ=;\n\tb=fbwLIbe3HIub4yjYuvL1WHSlZYB7PgsbzPKHro7iDDzLTpjpDc3JX8oO85sql1nwgC\n\t07s+xTvfJqPYtrbbpDquoEEmUT/lXVzWLlp6ndrx7vojfbXgU+4aqi+ilfnuTHCXdu8s\n\tn8R+JtDWBWLAIosbdz4n46wJsNltCyHUZ4TtH8Gv6GMuP0iQ/oCTpNQbeCJHQZDAGJeh\n\t9oQZ4vqWwYPkvaLH+vAqoQaNNqYJcPCrogXgwZpnEPmDmkfDnWPthgrSxh5Sy9jXczLg\n\ttYQwfUXaDTjiPeQTQnkg7ChuBvYl/QvcDJhG5LhlxD3WOmdKDE4SX3XH5W+hcEvAwxt8\n\tIKVg==", "X-Gm-Message-State": "ALoCoQky7Ax2N0LD6ZmF6t/4N6qFmcKToINKH3D/GI+c7UgD/bnTDHa0y12h50D5LUi6goZrbL8u", "X-Received": "by 10.180.104.7 with SMTP id ga7mr12384664wib.36.1411571706559; \n\tWed, 24 Sep 2014 08:15:06 -0700 (PDT)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>", "Date": "Wed, 24 Sep 2014 17:14:58 +0200", "Message-ID": "<2846511.VthLZyxgb4@xps13>", "Organization": "6WIND", "User-Agent": "KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; )", "In-Reply-To": "<7F861DC0615E0C47A872E6F3C5FCDDBD011A9915@BPXM14GP.gisp.nec.co.jp>", "References": "<7F861DC0615E0C47A872E6F3C5FCDDBD011A9915@BPXM14GP.gisp.nec.co.jp>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "7Bit", "Content-Type": "text/plain; charset=\"us-ascii\"", "Cc": "dev@dpdk.org, Hayato Momma <h-momma@ce.jp.nec.com>", "Subject": "Re: [dpdk-dev] [memnic PATCH 3/7] pmd: use helper macros", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 977, "web_url": "http://patches.dpdk.org/comment/977/", "msgid": "<7F861DC0615E0C47A872E6F3C5FCDDBD02AD9E6D@BPXM14GP.gisp.nec.co.jp>", "list_archive_url": "https://inbox.dpdk.org/dev/7F861DC0615E0C47A872E6F3C5FCDDBD02AD9E6D@BPXM14GP.gisp.nec.co.jp", "date": "2014-09-25T00:01:20", "subject": "Re: [dpdk-dev] [memnic PATCH 3/7] pmd: use helper macros", "submitter": { "id": 38, "url": "http://patches.dpdk.org/api/people/38/?format=api", "name": "Hiroshi Shimamoto", "email": "h-shimamoto@ct.jp.nec.com" }, "content": "> Subject: Re: [dpdk-dev] [memnic PATCH 3/7] pmd: use helper macros\n> \n> 2014-09-11 07:47, Hiroshi Shimamoto:\n> > Do not touch pktmbuf directly.\n> >\n> > Instead of direct access, use rte_pktmbuf_pkt_len() and rte_pktmbuf_data_len()\n> > to access the property.\n> \n> I guess this change is for compatibility with DPDK 1.8.\n\nYep, I had the thought need to prepare upcoming code.\n\n> Does it have an impact on performance?\n\nNo, it must not.\n\nthanks,\nHiroshi\n\n> \n> --\n> Thomas", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 5264F5922;\n\tThu, 25 Sep 2014 01:55:27 +0200 (CEST)", "from tyo202.gate.nec.co.jp (TYO202.gate.nec.co.jp [210.143.35.52])\n\tby dpdk.org (Postfix) with ESMTP id B0A8E1F5\n\tfor <dev@dpdk.org>; Thu, 25 Sep 2014 01:55:24 +0200 (CEST)", "from mailgate3.nec.co.jp ([10.7.69.160])\n\tby tyo202.gate.nec.co.jp (8.13.8/8.13.4) with ESMTP id s8P01aLd010446;\n\tThu, 25 Sep 2014 09:01:36 +0900 (JST)", "from mailsv3.nec.co.jp (imss63.nec.co.jp [10.7.69.158]) by\n\tmailgate3.nec.co.jp (8.11.7/3.7W-MAILGATE-NEC) with ESMTP\n\tid s8P01a229636; Thu, 25 Sep 2014 09:01:36 +0900 (JST)", "from mail03.kamome.nec.co.jp (mail03.kamome.nec.co.jp [10.25.43.7])\n\tby mailsv3.nec.co.jp (8.13.8/8.13.4) with ESMTP id s8P01a1S020321;\n\tThu, 25 Sep 2014 09:01:36 +0900 (JST)", "from bpxc99gp.gisp.nec.co.jp ([10.38.151.144] [10.38.151.144]) by\n\tmail02.kamome.nec.co.jp with ESMTP id BT-MMP-2098380;\n\tThu, 25 Sep 2014 09:01:21 +0900", "from BPXM14GP.gisp.nec.co.jp ([169.254.1.136]) by\n\tBPXC16GP.gisp.nec.co.jp ([10.38.151.144]) with mapi id 14.03.0174.002;\n\tThu, 25 Sep 2014 09:01:20 +0900" ], "From": "Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>", "To": "Thomas Monjalon <thomas.monjalon@6wind.com>", "Thread-Topic": "[dpdk-dev] [memnic PATCH 3/7] pmd: use helper macros", "Thread-Index": "AQHP2ApVisbzPHO6qUmpJSBKkNhvgpwQ9vJQ", "Date": "Thu, 25 Sep 2014 00:01:20 +0000", "Message-ID": "<7F861DC0615E0C47A872E6F3C5FCDDBD02AD9E6D@BPXM14GP.gisp.nec.co.jp>", "References": "<7F861DC0615E0C47A872E6F3C5FCDDBD011A9915@BPXM14GP.gisp.nec.co.jp>\n\t<2846511.VthLZyxgb4@xps13>", "In-Reply-To": "<2846511.VthLZyxgb4@xps13>", "Accept-Language": "ja-JP, en-US", "Content-Language": "ja-JP", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[10.205.5.123]", "Content-Type": "text/plain; charset=\"iso-2022-jp\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Cc": "\"dev@dpdk.org\" <dev@dpdk.org>, Hayato Momma <h-momma@ce.jp.nec.com>", "Subject": "Re: [dpdk-dev] [memnic PATCH 3/7] pmd: use helper macros", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]