Patch Comment List
List patch comments
GET /api/patches/335/comments/?format=api
[ { "id": 958, "web_url": "http://patches.dpdk.org/comment/958/", "msgid": "<1413585.BJq9NQufLh@xps13>", "list_archive_url": "https://inbox.dpdk.org/dev/1413585.BJq9NQufLh@xps13", "date": "2014-09-24T15:13:07", "subject": "Re: [dpdk-dev] [memnic PATCH 2/7] pmd: remove needless assignment", "submitter": { "id": 1, "url": "http://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "content": "2014-09-11 07:47, Hiroshi Shimamoto:\n> Because these assignment are done in rte_pktmbuf_alloc(), get rid of them.\n\nIs it increasing the performances?", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 245E1AFCA;\n\tWed, 24 Sep 2014 17:07:05 +0200 (CEST)", "from mail-we0-f173.google.com (mail-we0-f173.google.com\n\t[74.125.82.173]) by dpdk.org (Postfix) with ESMTP id 51E586896\n\tfor <dev@dpdk.org>; Wed, 24 Sep 2014 17:07:03 +0200 (CEST)", "by mail-we0-f173.google.com with SMTP id x48so4966116wes.4\n\tfor <dev@dpdk.org>; Wed, 24 Sep 2014 08:13:16 -0700 (PDT)", "from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])\n\tby mx.google.com with ESMTPSA id\n\tmx5sm6116814wic.0.2014.09.24.08.13.14 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 24 Sep 2014 08:13:15 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:organization\n\t:user-agent:in-reply-to:references:mime-version\n\t:content-transfer-encoding:content-type;\n\tbh=9Y2zaCGhfbdpPZowppYpCo3ggEwrvAOlme11aujk5Sc=;\n\tb=U9Hro+XVJFwK6JBYFRbCWP0gCaiE3e4xHM89ULOenTPer35XE50Co9nlSyNM6kHzzz\n\t5cqtydQKW4vVwPOiQRL9R6+b87p+8d84GO4e3U/XWLicMkXS4SQ6wCp9XBFiPfun3mCJ\n\tDFEogkKrINARjpiV2n7tGKJRaujV4c/UGJASSwr9mmDPlpbKcjLDcdBxZE64RbdPR0li\n\tPA/5va85QvPS3RvKu3oI36HBeq7IeYGhqXsMtistR2Xyqu9UwoVf5SBv9EyVfKSIoz31\n\t388Ic4U9IcVIuK9j9nBmqBhNvkUhtzjaVIlsCYMdZbwsLr4+cjkzt/clxH24p/RMG1S+\n\t7IyQ==", "X-Gm-Message-State": "ALoCoQn4GhJBfEY7JvQpNrJtVGsjPp0Cb0W0vXre7FUgFFa5gkpTy786jWU+Yxr9fra8/uHbKlrU", "X-Received": "by 10.194.59.17 with SMTP id v17mr8803058wjq.98.1411571596802;\n\tWed, 24 Sep 2014 08:13:16 -0700 (PDT)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>", "Date": "Wed, 24 Sep 2014 17:13:07 +0200", "Message-ID": "<1413585.BJq9NQufLh@xps13>", "Organization": "6WIND", "User-Agent": "KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; )", "In-Reply-To": "<7F861DC0615E0C47A872E6F3C5FCDDBD011A98F1@BPXM14GP.gisp.nec.co.jp>", "References": "<7F861DC0615E0C47A872E6F3C5FCDDBD011A98F1@BPXM14GP.gisp.nec.co.jp>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "7Bit", "Content-Type": "text/plain; charset=\"us-ascii\"", "Cc": "dev@dpdk.org, Hayato Momma <h-momma@ce.jp.nec.com>", "Subject": "Re: [dpdk-dev] [memnic PATCH 2/7] pmd: remove needless assignment", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 976, "web_url": "http://patches.dpdk.org/comment/976/", "msgid": "<7F861DC0615E0C47A872E6F3C5FCDDBD02AD9E2A@BPXM14GP.gisp.nec.co.jp>", "list_archive_url": "https://inbox.dpdk.org/dev/7F861DC0615E0C47A872E6F3C5FCDDBD02AD9E2A@BPXM14GP.gisp.nec.co.jp", "date": "2014-09-24T23:58:17", "subject": "Re: [dpdk-dev] [memnic PATCH 2/7] pmd: remove needless assignment", "submitter": { "id": 38, "url": "http://patches.dpdk.org/api/people/38/?format=api", "name": "Hiroshi Shimamoto", "email": "h-shimamoto@ct.jp.nec.com" }, "content": "> Subject: Re: [dpdk-dev] [memnic PATCH 2/7] pmd: remove needless assignment\n> \n> 2014-09-11 07:47, Hiroshi Shimamoto:\n> > Because these assignment are done in rte_pktmbuf_alloc(), get rid of them.\n> \n> Is it increasing the performances?\n\nI hadn't tried to test, because I don't think it can be noticed.\nJust clean up, removing a few redundant instructions.\n\nthanks,\nHiroshi\n\n> \n> --\n> Thomas", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 50F5D5922;\n\tThu, 25 Sep 2014 01:52:25 +0200 (CEST)", "from tyo202.gate.nec.co.jp (TYO202.gate.nec.co.jp [210.143.35.52])\n\tby dpdk.org (Postfix) with ESMTP id 574E31F5\n\tfor <dev@dpdk.org>; Thu, 25 Sep 2014 01:52:24 +0200 (CEST)", "from mailgate3.nec.co.jp ([10.7.69.195])\n\tby tyo202.gate.nec.co.jp (8.13.8/8.13.4) with ESMTP id s8ONwY8T008007;\n\tThu, 25 Sep 2014 08:58:34 +0900 (JST)", "from mailsv4.nec.co.jp (imss63.nec.co.jp [10.7.69.158]) by\n\tmailgate3.nec.co.jp (8.11.7/3.7W-MAILGATE-NEC) with ESMTP\n\tid s8ONwYx28396; Thu, 25 Sep 2014 08:58:34 +0900 (JST)", "from mail01b.kamome.nec.co.jp (mail01b.kamome.nec.co.jp\n\t[10.25.43.2])\n\tby mailsv4.nec.co.jp (8.13.8/8.13.4) with ESMTP id s8ONwYNX027661;\n\tThu, 25 Sep 2014 08:58:34 +0900 (JST)", "from bpxc99gp.gisp.nec.co.jp ([10.38.151.145] [10.38.151.145]) by\n\tmail01b.kamome.nec.co.jp with ESMTP id BT-MMP-2085225;\n\tThu, 25 Sep 2014 08:58:19 +0900", "from BPXM14GP.gisp.nec.co.jp ([169.254.1.136]) by\n\tBPXC17GP.gisp.nec.co.jp ([10.38.151.145]) with mapi id 14.03.0174.002;\n\tThu, 25 Sep 2014 08:58:18 +0900" ], "From": "Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>", "To": "Thomas Monjalon <thomas.monjalon@6wind.com>", "Thread-Topic": "[dpdk-dev] [memnic PATCH 2/7] pmd: remove needless assignment", "Thread-Index": "AQHP2AoToTRmaGrCd02p/74ZHu8Hr5wQ9dxQ", "Date": "Wed, 24 Sep 2014 23:58:17 +0000", "Message-ID": "<7F861DC0615E0C47A872E6F3C5FCDDBD02AD9E2A@BPXM14GP.gisp.nec.co.jp>", "References": "<7F861DC0615E0C47A872E6F3C5FCDDBD011A98F1@BPXM14GP.gisp.nec.co.jp>\n\t<1413585.BJq9NQufLh@xps13>", "In-Reply-To": "<1413585.BJq9NQufLh@xps13>", "Accept-Language": "ja-JP, en-US", "Content-Language": "ja-JP", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[10.205.5.123]", "Content-Type": "text/plain; charset=\"iso-2022-jp\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Cc": "\"dev@dpdk.org\" <dev@dpdk.org>, Hayato Momma <h-momma@ce.jp.nec.com>", "Subject": "Re: [dpdk-dev] [memnic PATCH 2/7] pmd: remove needless assignment", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]