Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/3305/?format=api
http://patches.dpdk.org/api/patches/3305/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1423839795-29450-2-git-send-email-david.marchand@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1423839795-29450-2-git-send-email-david.marchand@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1423839795-29450-2-git-send-email-david.marchand@6wind.com", "date": "2015-02-13T15:03:13", "name": "[dpdk-dev,v2,1/3] devargs: indent and cleanup", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "03781c418726c7ef1ab64d4a442d4a50b0821200", "submitter": { "id": 3, "url": "http://patches.dpdk.org/api/people/3/?format=api", "name": "David Marchand", "email": "david.marchand@6wind.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1423839795-29450-2-git-send-email-david.marchand@6wind.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/3305/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/3305/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 13410B4CC;\n\tFri, 13 Feb 2015 16:03:24 +0100 (CET)", "from mail-wi0-f181.google.com (mail-wi0-f181.google.com\n\t[209.85.212.181]) by dpdk.org (Postfix) with ESMTP id D83F0B4C9\n\tfor <dev@dpdk.org>; Fri, 13 Feb 2015 16:03:21 +0100 (CET)", "by mail-wi0-f181.google.com with SMTP id r20so12758436wiv.2\n\tfor <dev@dpdk.org>; Fri, 13 Feb 2015 07:03:21 -0800 (PST)", "from alcyon.dev.6wind.com (6wind.net2.nerim.net. [213.41.180.237])\n\tby mx.google.com with ESMTPSA id\n\te18sm10413605wjz.27.2015.02.13.07.03.20 for <dev@dpdk.org>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 13 Feb 2015 07:03:20 -0800 (PST)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=vwe5ViVz7fIiespbpIbLBc9UgosaI6xGf0EgHaizTtY=;\n\tb=lXeT41umdR8Z7yvzCqj+zi2k8l/7LfYHWVAVpsP6639/ldxkQulEjcEQ6b377nBr+y\n\tIUbYiTwgTBq6SacbOFqwrpBEpBfv2+pZKjtv7MS6u9f2il4TKfXn/ZWTdCasK32DnihY\n\txBVuxp48EMHN0w8Z0VQ7Iqt1oFkYbonInHJAjq2IWPsNLNoyCcraCaVi0fNCLYr3shxm\n\tHh1xkhZRB7eNdqqWX5NblzMmuKU85eHD4P+OkH1W28NtC/9uQnOnLpR/umo2YIjPgp7A\n\t8LihcZA4BKF5tnQMWaBBKj8AcIDE7aHtOZ2SUhrl2ZW0y/HGLKW1iQ8IqFky04lByBuS\n\tKO5A==", "X-Gm-Message-State": "ALoCoQn6KSwDn+wuBrJZ6UO0ZkKmzyQX9dZveS8ATW3poj8nLoRpGnog+dthH5tryTIaV5QdTohf", "X-Received": "by 10.180.90.16 with SMTP id bs16mr7593166wib.16.1423839801697; \n\tFri, 13 Feb 2015 07:03:21 -0800 (PST)", "From": "David Marchand <david.marchand@6wind.com>", "To": "dev@dpdk.org", "Date": "Fri, 13 Feb 2015 16:03:13 +0100", "Message-Id": "<1423839795-29450-2-git-send-email-david.marchand@6wind.com>", "X-Mailer": "git-send-email 1.7.10.4", "In-Reply-To": "<1423839795-29450-1-git-send-email-david.marchand@6wind.com>", "References": "<1420635809-30976-1-git-send-email-david.marchand@6wind.com>\n\t<1423839795-29450-1-git-send-email-david.marchand@6wind.com>", "Subject": "[dpdk-dev] [PATCH v2 1/3] devargs: indent and cleanup", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Prepare for next commit.\nFix some indent issues, refactor error code.\n\nSigned-off-by: David Marchand <david.marchand@6wind.com>\n---\n lib/librte_eal/common/eal_common_devargs.c | 27 ++++++++++++++-------------\n 1 file changed, 14 insertions(+), 13 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/common/eal_common_devargs.c\nindex 4c7d11a..8c9b31a 100644\n--- a/lib/librte_eal/common/eal_common_devargs.c\n+++ b/lib/librte_eal/common/eal_common_devargs.c\n@@ -48,7 +48,7 @@ struct rte_devargs_list devargs_list =\n int\n rte_eal_devargs_add(enum rte_devtype devtype, const char *devargs_str)\n {\n-\tstruct rte_devargs *devargs;\n+\tstruct rte_devargs *devargs = NULL;\n \tchar buf[RTE_DEVARGS_LEN];\n \tchar *sep;\n \tint ret;\n@@ -57,14 +57,14 @@ rte_eal_devargs_add(enum rte_devtype devtype, const char *devargs_str)\n \tif (ret < 0 || ret >= (int)sizeof(buf)) {\n \t\tRTE_LOG(ERR, EAL, \"user device args too large: <%s>\\n\",\n \t\t\tdevargs_str);\n-\t\treturn -1;\n+\t\tgoto fail;\n \t}\n \n \t/* use malloc instead of rte_malloc as it's called early at init */\n \tdevargs = malloc(sizeof(*devargs));\n \tif (devargs == NULL) {\n \t\tRTE_LOG(ERR, EAL, \"cannot allocate devargs\\n\");\n-\t\treturn -1;\n+\t\tgoto fail;\n \t}\n \tmemset(devargs, 0, sizeof(*devargs));\n \tdevargs->type = devtype;\n@@ -81,28 +81,29 @@ rte_eal_devargs_add(enum rte_devtype devtype, const char *devargs_str)\n \tcase RTE_DEVTYPE_BLACKLISTED_PCI:\n \t\t/* try to parse pci identifier */\n \t\tif (eal_parse_pci_BDF(buf, &devargs->pci.addr) != 0 &&\n-\t\t\teal_parse_pci_DomBDF(buf, &devargs->pci.addr) != 0) {\n-\t\t\tRTE_LOG(ERR, EAL,\n-\t\t\t\t\"invalid PCI identifier <%s>\\n\", buf);\n-\t\t\tfree(devargs);\n-\t\t\treturn -1;\n+\t\t eal_parse_pci_DomBDF(buf, &devargs->pci.addr) != 0) {\n+\t\t\tRTE_LOG(ERR, EAL, \"invalid PCI identifier <%s>\\n\", buf);\n+\t\t\tgoto fail;\n \t\t}\n \t\tbreak;\n \tcase RTE_DEVTYPE_VIRTUAL:\n \t\t/* save driver name */\n \t\tret = snprintf(devargs->virtual.drv_name,\n-\t\t\tsizeof(devargs->virtual.drv_name), \"%s\", buf);\n+\t\t\t sizeof(devargs->virtual.drv_name), \"%s\", buf);\n \t\tif (ret < 0 || ret >= (int)sizeof(devargs->virtual.drv_name)) {\n-\t\t\tRTE_LOG(ERR, EAL,\n-\t\t\t\t\"driver name too large: <%s>\\n\", buf);\n-\t\t\tfree(devargs);\n-\t\t\treturn -1;\n+\t\t\tRTE_LOG(ERR, EAL, \"driver name too large: <%s>\\n\", buf);\n+\t\t\tgoto fail;\n \t\t}\n \t\tbreak;\n \t}\n \n \tTAILQ_INSERT_TAIL(&devargs_list, devargs, next);\n \treturn 0;\n+\n+fail:\n+\tif (devargs)\n+\t\tfree(devargs);\n+\treturn -1;\n }\n \n /* count the number of devices of a specified type */\n", "prefixes": [ "dpdk-dev", "v2", "1/3" ] }{ "id": 3305, "url": "