Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 32928,
    "url": "http://patches.dpdk.org/api/patches/32928/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1515170817-136539-2-git-send-email-xiao.w.wang@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1515170817-136539-2-git-send-email-xiao.w.wang@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1515170817-136539-2-git-send-email-xiao.w.wang@intel.com",
    "date": "2018-01-05T16:46:55",
    "name": "[dpdk-dev,v5,1/3] net/virtio: make control queue thread-safe",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "fc17cf6dd88911693e842e3c6dc11ee8efc680ea",
    "submitter": {
        "id": 281,
        "url": "http://patches.dpdk.org/api/people/281/?format=api",
        "name": "Xiao Wang",
        "email": "xiao.w.wang@intel.com"
    },
    "delegate": {
        "id": 355,
        "url": "http://patches.dpdk.org/api/users/355/?format=api",
        "username": "yliu",
        "first_name": "Yuanhan",
        "last_name": "Liu",
        "email": "yuanhan.liu@linux.intel.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1515170817-136539-2-git-send-email-xiao.w.wang@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/32928/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/32928/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E0B051B01D;\n\tFri,  5 Jan 2018 09:11:31 +0100 (CET)",
            "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id 11C6C7D19\n\tfor <dev@dpdk.org>; Fri,  5 Jan 2018 09:11:29 +0100 (CET)",
            "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t05 Jan 2018 00:11:28 -0800",
            "from dpdk-xiao-1.sh.intel.com ([10.67.110.153])\n\tby orsmga002.jf.intel.com with ESMTP; 05 Jan 2018 00:11:27 -0800"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.46,317,1511856000\"; d=\"scan'208\";a=\"24547582\"",
        "From": "Xiao Wang <xiao.w.wang@intel.com>",
        "To": "tiwei.bie@intel.com",
        "Cc": "dev@dpdk.org, yliu@fridaylinux.org, stephen@networkplumber.org,\n\tXiao Wang <xiao.w.wang@intel.com>",
        "Date": "Fri,  5 Jan 2018 08:46:55 -0800",
        "Message-Id": "<1515170817-136539-2-git-send-email-xiao.w.wang@intel.com>",
        "X-Mailer": "git-send-email 1.8.3.1",
        "In-Reply-To": "<1515170817-136539-1-git-send-email-xiao.w.wang@intel.com>",
        "References": "<1515081578-30649-3-git-send-email-xiao.w.wang@intel.com>\n\t<1515170817-136539-1-git-send-email-xiao.w.wang@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v5 1/3] net/virtio: make control queue thread-safe",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The virtio_send_command function may be called from app's configuration\nroutine, but also from an interrupt handler called when live migration is\ndone on the backup side. So this patch makes control queue thread-safe\nfirst.\n\nSigned-off-by: Xiao Wang <xiao.w.wang@intel.com>\n---\n drivers/net/virtio/virtio_ethdev.c | 7 ++++++-\n drivers/net/virtio/virtio_rxtx.c   | 1 +\n drivers/net/virtio/virtio_rxtx.h   | 1 +\n 3 files changed, 8 insertions(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c\nindex e0328f6..ac73950 100644\n--- a/drivers/net/virtio/virtio_ethdev.c\n+++ b/drivers/net/virtio/virtio_ethdev.c\n@@ -177,6 +177,8 @@ struct rte_virtio_xstats_name_off {\n \t\tPMD_INIT_LOG(ERR, \"Control queue is not supported.\");\n \t\treturn -1;\n \t}\n+\n+\trte_spinlock_lock(&cvq->sl);\n \tvq = cvq->vq;\n \thead = vq->vq_desc_head_idx;\n \n@@ -184,8 +186,10 @@ struct rte_virtio_xstats_name_off {\n \t\t\"vq->hw->cvq = %p vq = %p\",\n \t\tvq->vq_desc_head_idx, status, vq->hw->cvq, vq);\n \n-\tif ((vq->vq_free_cnt < ((uint32_t)pkt_num + 2)) || (pkt_num < 1))\n+\tif (vq->vq_free_cnt < pkt_num + 2 || pkt_num < 1) {\n+\t\trte_spinlock_unlock(&cvq->sl);\n \t\treturn -1;\n+\t}\n \n \tmemcpy(cvq->virtio_net_hdr_mz->addr, ctrl,\n \t\tsizeof(struct virtio_pmd_ctrl));\n@@ -261,6 +265,7 @@ struct rte_virtio_xstats_name_off {\n \n \tresult = cvq->virtio_net_hdr_mz->addr;\n \n+\trte_spinlock_unlock(&cvq->sl);\n \treturn result->status;\n }\n \ndiff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c\nindex 390c137..6a24fde 100644\n--- a/drivers/net/virtio/virtio_rxtx.c\n+++ b/drivers/net/virtio/virtio_rxtx.c\n@@ -407,6 +407,7 @@\n \tstruct virtio_hw *hw = dev->data->dev_private;\n \n \tif (hw->cvq && hw->cvq->vq) {\n+\t\trte_spinlock_init(&hw->cvq->sl);\n \t\tVIRTQUEUE_DUMP((struct virtqueue *)hw->cvq->vq);\n \t}\n }\ndiff --git a/drivers/net/virtio/virtio_rxtx.h b/drivers/net/virtio/virtio_rxtx.h\nindex 54f1e84..71b5798 100644\n--- a/drivers/net/virtio/virtio_rxtx.h\n+++ b/drivers/net/virtio/virtio_rxtx.h\n@@ -84,6 +84,7 @@ struct virtnet_ctl {\n \trte_iova_t virtio_net_hdr_mem;  /**< hdr for each xmit packet */\n \tuint16_t port_id;               /**< Device port identifier. */\n \tconst struct rte_memzone *mz;   /**< mem zone to populate CTL ring. */\n+\trte_spinlock_t sl;              /**< spinlock for control queue. */\n };\n \n int virtio_rxq_vec_setup(struct virtnet_rx *rxvq);\n",
    "prefixes": [
        "dpdk-dev",
        "v5",
        "1/3"
    ]
}