Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 32738,
    "url": "http://patches.dpdk.org/api/patches/32738/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20171226092500.53594-1-zhiyong.yang@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20171226092500.53594-1-zhiyong.yang@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20171226092500.53594-1-zhiyong.yang@intel.com",
    "date": "2017-12-26T09:25:00",
    "name": "[dpdk-dev] net/virtio: remove unnecessary macro definitions",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "8b10f27325f943fbc9e9b041ea7047eed0167beb",
    "submitter": {
        "id": 540,
        "url": "http://patches.dpdk.org/api/people/540/?format=api",
        "name": "Yang, Zhiyong",
        "email": "zhiyong.yang@intel.com"
    },
    "delegate": {
        "id": 355,
        "url": "http://patches.dpdk.org/api/users/355/?format=api",
        "username": "yliu",
        "first_name": "Yuanhan",
        "last_name": "Liu",
        "email": "yuanhan.liu@linux.intel.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20171226092500.53594-1-zhiyong.yang@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/32738/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/32738/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3F9951B3F9;\n\tTue, 26 Dec 2017 10:37:41 +0100 (CET)",
            "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id A1D2E1B3F6\n\tfor <dev@dpdk.org>; Tue, 26 Dec 2017 10:37:39 +0100 (CET)",
            "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t26 Dec 2017 01:37:37 -0800",
            "from unknown (HELO dpdk5.bj.intel.com) ([172.16.182.198])\n\tby FMSMGA003.fm.intel.com with ESMTP; 26 Dec 2017 01:37:36 -0800"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.45,459,1508828400\"; d=\"scan'208\";a=\"14610704\"",
        "From": "Zhiyong Yang <zhiyong.yang@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "yliu@fridaylinux.org, maxime.coquelin@redhat.com,\n\tZhiyong Yang <zhiyong.yang@intel.com>",
        "Date": "Tue, 26 Dec 2017 17:25:00 +0800",
        "Message-Id": "<20171226092500.53594-1-zhiyong.yang@intel.com>",
        "X-Mailer": "git-send-email 2.13.3",
        "Subject": "[dpdk-dev] [PATCH] net/virtio: remove unnecessary macro definitions",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "DPDK has already the definition of Ethernet numeric link speeds in Mbps in\nthe file Rte_ethdev.h, it is unnecessary to rededine virtio specific link\nspeeds macros again.\n\nSigned-off-by: Zhiyong Yang <zhiyong.yang@intel.com>\n---\n drivers/net/virtio/virtio_ethdev.c | 2 +-\n drivers/net/virtio/virtio_ethdev.h | 5 -----\n 2 files changed, 1 insertion(+), 6 deletions(-)",
    "diff": "diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c\nindex e0328f61d..db89cc32d 100644\n--- a/drivers/net/virtio/virtio_ethdev.c\n+++ b/drivers/net/virtio/virtio_ethdev.c\n@@ -1965,7 +1965,7 @@ virtio_dev_link_update(struct rte_eth_dev *dev, __rte_unused int wait_to_complet\n \tvirtio_dev_atomic_read_link_status(dev, &link);\n \told = link;\n \tlink.link_duplex = ETH_LINK_FULL_DUPLEX;\n-\tlink.link_speed  = SPEED_10G;\n+\tlink.link_speed  = ETH_SPEED_NUM_10G;\n \n \tif (hw->started == 0) {\n \t\tlink.link_status = ETH_LINK_DOWN;\ndiff --git a/drivers/net/virtio/virtio_ethdev.h b/drivers/net/virtio/virtio_ethdev.h\nindex 2039bc547..6387a44f9 100644\n--- a/drivers/net/virtio/virtio_ethdev.h\n+++ b/drivers/net/virtio/virtio_ethdev.h\n@@ -38,11 +38,6 @@\n \n #include \"virtio_pci.h\"\n \n-#define SPEED_10\t10\n-#define SPEED_100\t100\n-#define SPEED_1000\t1000\n-#define SPEED_10G\t10000\n-\n #ifndef PAGE_SIZE\n #define PAGE_SIZE 4096\n #endif\n",
    "prefixes": [
        "dpdk-dev"
    ]
}