Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/32208/?format=api
http://patches.dpdk.org/api/patches/32208/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1513166759-13466-11-git-send-email-hemant.agrawal@nxp.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1513166759-13466-11-git-send-email-hemant.agrawal@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1513166759-13466-11-git-send-email-hemant.agrawal@nxp.com", "date": "2017-12-13T12:05:51", "name": "[dpdk-dev,10/18] net/dpaa: change Tx HW budget to 7", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "33f42974ea61a40bce6771909af1456992d5e222", "submitter": { "id": 477, "url": "http://patches.dpdk.org/api/people/477/?format=api", "name": "Hemant Agrawal", "email": "hemant.agrawal@nxp.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1513166759-13466-11-git-send-email-hemant.agrawal@nxp.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/32208/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/32208/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6D54D1B1B5;\n\tWed, 13 Dec 2017 13:07:20 +0100 (CET)", "from NAM02-SN1-obe.outbound.protection.outlook.com\n\t(mail-sn1nam02on0051.outbound.protection.outlook.com [104.47.36.51])\n\tby dpdk.org (Postfix) with ESMTP id 15E141B195\n\tfor <dev@dpdk.org>; Wed, 13 Dec 2017 13:07:17 +0100 (CET)", "from MWHPR03CA0047.namprd03.prod.outlook.com (10.174.173.164) by\n\tCY1PR03MB2362.namprd03.prod.outlook.com (10.166.207.149) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.302.9; Wed, 13 Dec 2017 12:07:15 +0000", "from BN1AFFO11FD016.protection.gbl (2a01:111:f400:7c10::120) by\n\tMWHPR03CA0047.outlook.office365.com (2603:10b6:301:3b::36) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n\t15.20.302.9 via Frontend Transport; Wed, 13 Dec 2017 12:07:15 +0000", "from tx30smr01.am.freescale.net (192.88.168.50) by\n\tBN1AFFO11FD016.mail.protection.outlook.com (10.58.52.76) with\n\tMicrosoft SMTP Server (version=TLS1_0,\n\tcipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.282.5\n\tvia Frontend Transport; Wed, 13 Dec 2017 12:07:08 +0000", "from bf-netperf1.ap.freescale.net (bf-netperf1.ap.freescale.net\n\t[10.232.134.28])\n\tby tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id\n\tvBDC6t9U008652; Wed, 13 Dec 2017 05:07:13 -0700" ], "Authentication-Results": "spf=fail (sender IP is 192.88.168.50)\n\tsmtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed)\n\theader.d=none;nxp.com; dmarc=fail action=none header.from=nxp.com;", "Received-SPF": "Fail (protection.outlook.com: domain of nxp.com does not\n\tdesignate 192.88.168.50 as permitted sender)\n\treceiver=protection.outlook.com; \n\tclient-ip=192.88.168.50; helo=tx30smr01.am.freescale.net;", "From": "Hemant Agrawal <hemant.agrawal@nxp.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@intel.com>, Nipun Gupta <nipun.gupta@nxp.com>", "Date": "Wed, 13 Dec 2017 17:35:51 +0530", "Message-ID": "<1513166759-13466-11-git-send-email-hemant.agrawal@nxp.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1513166759-13466-1-git-send-email-hemant.agrawal@nxp.com>", "References": "<1513166759-13466-1-git-send-email-hemant.agrawal@nxp.com>", "X-EOPAttributedMessage": "0", "X-Matching-Connectors": "131576404283269314;\n\t(91ab9b29-cfa4-454e-5278-08d120cd25b8); ()", "X-Forefront-Antispam-Report": "CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI;\n\tSFV:NSPM;\n\tSFS:(10009020)(7966004)(336005)(346002)(376002)(39380400002)(39860400002)(2980300002)(1110001)(1109001)(339900001)(199004)(189003)(51234002)(47776003)(106466001)(575784001)(104016004)(2351001)(105606002)(86362001)(8936002)(5660300001)(8676002)(50226002)(68736007)(81156014)(356003)(81166006)(305945005)(54906003)(50466002)(85426001)(48376002)(36756003)(2950100002)(498600001)(316002)(4326008)(6916009)(16586007)(6666003)(77096006)(53936002)(97736004)(51416003)(76176011)(2906002)(8656006);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR03MB2362;\n\tH:tx30smr01.am.freescale.net; \n\tFPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; ", "X-Microsoft-Exchange-Diagnostics": [ "1; BN1AFFO11FD016;\n\t1:0P9TDr/kS0ltvW1euIuj4fh3n80ZDrwtVeboK6D/FRIGRHEQqjlOanmW+q/jnRlhOLVmwvTDp+8iheTffmQWQGn7o03ztt0sXy+VhF7SJVuP0SHxPueEsQVhBDeQPM8K", "1; CY1PR03MB2362;\n\t3:KcnX9n118nrFtHZbKXr5V2s4rfIHdBWRJ7d197FKqZDXYSC3rlKISrw6EzHQ174w7Py/n4UXrieF3VqNJwiuoyuV+V8TjMTXONL97KD+EaWXSGaavsJOUj4IB6D+iXvsj48US8IMBJ+bbkkGKRXmyzOC22L0bqm5ltBCKgNtUjXM0xRdvoIsRC23X+9CpS7w7rDHlQHzil3g2x6/T5iVsZrBcptaubxeaRdG7w/gkZ847A2w3xYKlKMev98gvVlcOv1zsJpvmwcNJN3vINcj1Y6rncm2z7xUB/7XcQFSl5Okyd9I2lSwwRA5WiPee+3GCPxFHEDdlxVqpzapZ3q3NkOgHev2v1caPPrPHWgbSe0=;\n\t25:Z7AXRsWcT+X0PROTrhlFI7mupux9XZG0dTN0iFZP2jVFHiw/m5/oNUQ8GIip/68FBCDhzeYYlclzMiucL6tSSH8u0m4L5l5zGO7Md3KQbkNHX1ujAY2jqG3bCmZXvSSnA8sZimWXvBenCBtYhQ5vMnKRFowzrl3WNwpk53TZJd02jaYxqZLzB6NRTQ7rn5gf8lvT8qyRSLsqlDhevoz6GnEUbDnWKMf1iT6fkFwBw2sjWX1HYybL33s5Dseny9m8fK2IsN4tuhzCyd3WfImyfN3exm8PskRtQH59zsGrtiD9ywEXy3kRmpN6LNc69QtikUuiaBtmpI6bBlPfJLSilVFo2FOvzGMg6RGvcSwbfDY=", "1; CY1PR03MB2362;\n\t31:cCwjZu54HNh6KEbERU2PZGDNXLUScb8fmUqf2KZPYrAleGcROZW2EWNiD/EWMURwB6EXQRaXxwsR4fAqUbIYFjPQ5KMGmG8ZzjsTx607hSEd1YJtISWD2PaFhJQbFsaKGzuigNGfCTbm0CFpCHOc0U1FMpiOm/dyfoVAAbw8NpQU8iLlujtE4OCWGud1YS6e4uiHgQY4dXk4dzp08C7pXv/JdrdMn6sJ4C2cfP1Ui24=;\n\t4:F4sLayz1rZA3KXUOjqLVDRuNA+nLrhdx0emw1U1urZM50lzB5aWL9INDNawIPlV0U7ZfLk4Lg0KU+b4niifjKRHyL7tfKmN+frS1RlGs+y3hTXmOI0qofC9UrGJMQmrNANWWTJSJ2uUW2B7J8bN12LBc/G0fWVrP6/WSlM8Po+4AK62HrsyWKLqM1u6hbacwCMpnolIOMKrxb6wYWPLdAQu8IP6VTJaXN3yhOfL5cDeM7ORjckw42Nk8O+DkpsHouojEN4tf+o9B6NvICWXDJNnJMjZPYltL0Ube6PkQsu0q/GgrDStXFpk3A5DJ7PU7", "=?us-ascii?Q?1; CY1PR03MB2362;\n\t23:WG/pFBQPLu+i7k/TXmXAxUWgj4NINzEpZslk0ZQhS?=\n\tg7reVVIWS1VIYdpJuqhRWQ2THM5ZMPrMTI4rYLOY4ccWsWxtvWBz3Io1t3rRs7kpweWCJtCPLwi6s4Kk4yRms98vBKglzHGaCXsNTzyrN68AjcY9Hdrx++FSsE5Qg9zzMSKy/q//8jhX6LU5jH6jDaBB+/44Jp3c+y9h/Waq+WrfKfDPpqD1rKQ4kg2m8hwYDzci/3Im8uFa4n7XGN70BPF4YPAaGnf3vJSAzVYkHa1Vl/3x9ggwPgZT/CS4+KKCXrNdqxDB+Vt2B8z86zVJBhGURLRf0fD6smouknQFCU183Tvad/y5yh9nDeANZIjSSEryXHcAp/RbOVtx4AD8EE7ERMxBLlP14J3x5kRkEYWBZKRGFx/bzWuoWlLN1d5y3WMDJO8WTmggdurKhnPaxJiZluSbRiVrk1trnPhaOoDvT4Rgz+H5Pn5DdyNDHzOi704E5YZHIAPhDYFow/+0933JFCgbj1i0/tmc56m2jeqMfWrTY3N6wH4TpXHrkh+fvmP9ZdE5yixGM4SDrMM4KkeUPN65sGAYKfUBerpbpjSP0HUNfc19UwOKvDrwky5t0lZjMuN71cZsrbxhhgJgKbG6pgOIbJZGnocDIqXaVuUXwmH7QRWgogejVXNVgtypaGdMgQzdAPHksljxGnpFEE57YHhRlN0VE8wU96JBwwnrq01wHi1Un+4xwHLUUP0nXsEF5Vxc0xOG18bU7pb9uhr6WhYaWpDEmXAcNY3wjcvpih525TBPf/KEVMStxMP7OG0n+zIOnJ/tlYIht0rxY4YkEcWv2V5NzYOsHt4HJtgvDvGUlqHqJBF43HZC0ZheK3q8n4P2UDm+wd5oy8NWu+SopbQhLwP8K/B9LIn4JUqRFVPE8KIMafmmnNaa6jaR6l6Zduhprz7BoCzq5/RcygOl0dm84D1YbGwz4Xk95kfEtYV3iJpAjA0IMnXHHHK61vifFNQZsC3eYVb0JMH7B2yc8wI7Q6LcXE+lNRruF5BszAKTULDdqgtuwNJz13n4b9AzUW53gCr8zfO36eAKOW5nTG9GT8YYTF3bgP9uYk60V43tWJmcpvFpAjaRzH6aEecP0vubRn4jge9FnemedXh", "1; CY1PR03MB2362;\n\t6:5g0N9GRa+/35kCcNEeKdrRmshEgFuwkX24tHQy1VZPHifZ3+MF+hSk8j9KVAJQTVqNmZPIc28aGHpx7jGrtPUV9NWIfdy7FPyVLNSPsZzBPqbEKUR5sa4zLUGMpqw3XGaF1O4OZP0HWrO/YWUamJUfqX44HzZn7+Zp8Ib69WkVDKqEYt6Rt23VATr3kzJ3oaYdFM3jzZkrPyGbaWZmmygQF8K4wuHinaADfxcDbmvAgL+2bjeDJe1QpzMJOFYrYILeVByjln0i6Arn6fqkeOeUOA7TMrDi6QhR5EmF7o9lMNS4CR/mUhGBDYyF1ck5FP219SBac2ekoXJah6fCMHglEKSw40TEuyAlSXytTvuWA=;\n\t5:aMPbFxiBcsOXuKNJI4dgbAH/sxmLHRnl9OdcLDnV6aaLwh65IV5RLGvn6gaGeepdTazD/QZ+cRi39mlg54DQQHvkEh6PG7tEo+IU1986fwx6PZED7JtZbkGRCyOpz9VjGFqWRvbhfzKbFsJtM856cG6EIah0HF4zuVTddjKcVDs=;\n\t24:WW3o5iQUXfQWK6iF1W4Gn+X7sB0zsZJoDg0ixNlsG7CMATg6tCP8OxZ9wENduyErwvCONNi2ZEgW0rS6RqrIsgfclVBiqySLaSqqPVflbiQ=;\n\t7:3gDvjbMDFGoo6E54nd615tnXvUvGoGdhr/rrRr+aqdRXup3GGy0vSxBcQowCbTe6aK0Hm1hQ2d33/EM85ITryIGrMnV3ttgDSOKeqw1Tlxm9QLD9Z4hqYo8XI9VrTlbdxfPdIQIfDYyBb1zkWD5q3ZcrpWlYZmC7saRbSzyj0KanrJtbFxBfWdfD1ZXI/etsN02NdsK24VLakHZB0Kz4KrlGtWtDI+U81El+PU5C10PlHC52yWNJdZawa8AkpB2J" ], "MIME-Version": "1.0", "Content-Type": "text/plain", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "1419a9f5-7267-45ba-a0c2-08d542220897", "X-Microsoft-Antispam": "UriScan:; BCL:0; PCL:0;\n\tRULEID:(4534020)(4628075)(201703131517081)(5600026)(4604075)(2017052603307);\n\tSRVR:CY1PR03MB2362; ", "X-MS-TrafficTypeDiagnostic": "CY1PR03MB2362:", "X-Microsoft-Antispam-PRVS": "<CY1PR03MB2362D130BF8D29F07139F89C89350@CY1PR03MB2362.namprd03.prod.outlook.com>", "X-Exchange-Antispam-Report-Test": "UriScan:(185117386973197);", "X-Exchange-Antispam-Report-CFA-Test": "BCL:0; PCL:0;\n\tRULEID:(6095135)(2401047)(5005006)(8121501046)(3231023)(3002001)(93006095)(93001095)(10201501046)(6055026)(6096035)(20161123556025)(20161123561025)(20161123559100)(20161123565025)(20161123563025)(201703131430075)(201703131441075)(201703131448075)(201703131433075)(201703161259150)(201708071742011);\n\tSRVR:CY1PR03MB2362; BCL:0; PCL:0;\n\tRULEID:(100000803101)(100110400095)(400006); \n\tSRVR:CY1PR03MB2362; ", "X-Forefront-PRVS": "052017CAF1", "SpamDiagnosticOutput": "1:99", "SpamDiagnosticMetadata": "NSPM", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "13 Dec 2017 12:07:08.1553\n\t(UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "1419a9f5-7267-45ba-a0c2-08d542220897", "X-MS-Exchange-CrossTenant-Id": "5afe0b00-7697-4969-b663-5eab37d5f47e", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;\n\tIp=[192.88.168.50]; \n\tHelo=[tx30smr01.am.freescale.net]", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "CY1PR03MB2362", "Subject": "[dpdk-dev] [PATCH 10/18] net/dpaa: change Tx HW budget to 7", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Nipun Gupta <nipun.gupta@nxp.com>\n\nchange the TX budget to 7 to sync best with the hw.\n\nSigned-off-by: Nipun Gupta <nipun.gupta@nxp.com>\nAcked-by: Hemant Agrawal <hemant.agrawal@nxp.com>\n---\n drivers/net/dpaa/dpaa_ethdev.h | 2 +-\n drivers/net/dpaa/dpaa_rxtx.c | 5 +++--\n 2 files changed, 4 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/dpaa/dpaa_ethdev.h b/drivers/net/dpaa/dpaa_ethdev.h\nindex b26e411..95d745e 100644\n--- a/drivers/net/dpaa/dpaa_ethdev.h\n+++ b/drivers/net/dpaa/dpaa_ethdev.h\n@@ -67,7 +67,7 @@\n #define DPAA_MAX_MAC_FILTER (MEMAC_NUM_OF_PADDRS + 1)\n \n /*Maximum number of slots available in TX ring*/\n-#define MAX_TX_RING_SLOTS\t8\n+#define DPAA_TX_BURST_SIZE\t7\n \n #ifndef VLAN_TAG_SIZE\n #define VLAN_TAG_SIZE 4 /** < Vlan Header Length */\ndiff --git a/drivers/net/dpaa/dpaa_rxtx.c b/drivers/net/dpaa/dpaa_rxtx.c\nindex c0cfec9..1b0ca9a 100644\n--- a/drivers/net/dpaa/dpaa_rxtx.c\n+++ b/drivers/net/dpaa/dpaa_rxtx.c\n@@ -695,7 +695,7 @@ dpaa_eth_queue_tx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)\n \tstruct rte_mbuf *mbuf, *mi = NULL;\n \tstruct rte_mempool *mp;\n \tstruct dpaa_bp_info *bp_info;\n-\tstruct qm_fd fd_arr[MAX_TX_RING_SLOTS];\n+\tstruct qm_fd fd_arr[DPAA_TX_BURST_SIZE];\n \tuint32_t frames_to_send, loop, i = 0;\n \tuint16_t state;\n \tint ret;\n@@ -709,7 +709,8 @@ dpaa_eth_queue_tx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)\n \tDPAA_DP_LOG(DEBUG, \"Transmitting %d buffers on queue: %p\", nb_bufs, q);\n \n \twhile (nb_bufs) {\n-\t\tframes_to_send = (nb_bufs >> 3) ? MAX_TX_RING_SLOTS : nb_bufs;\n+\t\tframes_to_send = (nb_bufs > DPAA_TX_BURST_SIZE) ?\n+\t\t\t\tDPAA_TX_BURST_SIZE : nb_bufs;\n \t\tfor (loop = 0; loop < frames_to_send; loop++, i++) {\n \t\t\tmbuf = bufs[i];\n \t\t\tif (RTE_MBUF_DIRECT(mbuf)) {\n", "prefixes": [ "dpdk-dev", "10/18" ] }{ "id": 32208, "url": "