Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 32123,
    "url": "http://patches.dpdk.org/api/patches/32123/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/c19854dcdd6724fd96c9cee685181ac429db23bc.1513081087.git.shahafs@mellanox.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<c19854dcdd6724fd96c9cee685181ac429db23bc.1513081087.git.shahafs@mellanox.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/c19854dcdd6724fd96c9cee685181ac429db23bc.1513081087.git.shahafs@mellanox.com",
    "date": "2017-12-12T12:26:22",
    "name": "[dpdk-dev,v2,05/39] examples/l3fwd: move to ethdev offloads API",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "7e7bff24d1ee460f885ad3fe0634f62c5bcadc6e",
    "submitter": {
        "id": 634,
        "url": "http://patches.dpdk.org/api/people/634/?format=api",
        "name": "Shahaf Shuler",
        "email": "shahafs@mellanox.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/c19854dcdd6724fd96c9cee685181ac429db23bc.1513081087.git.shahafs@mellanox.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/32123/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/32123/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 04C081B19E;\n\tTue, 12 Dec 2017 13:27:33 +0100 (CET)",
            "from EUR01-HE1-obe.outbound.protection.outlook.com\n\t(mail-he1eur01on0040.outbound.protection.outlook.com [104.47.0.40])\n\tby dpdk.org (Postfix) with ESMTP id 35A5E1B161\n\tfor <dev@dpdk.org>; Tue, 12 Dec 2017 13:27:30 +0100 (CET)",
            "from mellanox.com (82.166.227.17) by\n\tVI1PR05MB3149.eurprd05.prod.outlook.com (2603:10a6:802:1b::14) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.302.9;\n\tTue, 12 Dec 2017 12:27:27 +0000"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n\ts=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=Lg8cVeCofuJchzcUnniZFVF//bN3W4QVi1sndUD32vU=;\n\tb=jfpE6jmtv1/VuPnW6mT1DX0WeWjcpUqQa813rVc78NSKewmTCQl3KJSIuKk3JeSeKyjfY6IPjXcVE6WsF8v0k/HC71e8oa6cYPfdgi35EFgQrwEVmkPNSlTTwmpQ4X1k6qx+3ajy758Yv94ZQgwJuzONR8vObWln3DczkpGj2Lc=",
        "Authentication-Results": "spf=none (sender IP is )\n\tsmtp.mailfrom=shahafs@mellanox.com; ",
        "From": "Shahaf Shuler <shahafs@mellanox.com>",
        "To": "dev@dpdk.org, konstantin.ananyev@intel.com, radu.nicolau@intel.com,\n\tarybchenko@solarflare.com",
        "Date": "Tue, 12 Dec 2017 14:26:22 +0200",
        "Message-Id": "<c19854dcdd6724fd96c9cee685181ac429db23bc.1513081087.git.shahafs@mellanox.com>",
        "X-Mailer": "git-send-email 2.12.0",
        "In-Reply-To": "<cover.1513081087.git.shahafs@mellanox.com>",
        "References": "<20171123121419.144132-1-shahafs@mellanox.com>\n\t<cover.1513081087.git.shahafs@mellanox.com>",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain",
        "X-Originating-IP": "[82.166.227.17]",
        "X-ClientProxiedBy": "HE1P191CA0010.EURP191.PROD.OUTLOOK.COM\n\t(2603:10a6:3:cf::20)\n\tTo VI1PR05MB3149.eurprd05.prod.outlook.com\n\t(2603:10a6:802:1b::14)",
        "X-MS-PublicTrafficType": "Email",
        "X-MS-Office365-Filtering-Correlation-Id": "44847a7b-8ba1-4d8c-fa67-08d5415bb5ac",
        "X-MS-Office365-Filtering-HT": "Tenant",
        "X-Microsoft-Antispam": "UriScan:; BCL:0; PCL:0;\n\tRULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603307);\n\tSRVR:VI1PR05MB3149; ",
        "X-Microsoft-Exchange-Diagnostics": [
            "1; VI1PR05MB3149;\n\t3:d+81IpqnpHnrK0u+3tUx461abmUsvr00JE7KFwFrvXhjIOfdyJFnnnxWXhq7YC1bhI8Z3UTDGnTEus4uKgBCIeNANJldyLPlx/suRF4a4qz1jhcQJLxb5HKB/hcjbrz31Tu6flcPgaiw+B18xiUR5mPrhl3DhQVFlkULjeoVV4F4p9nurQ/7cjmXbM6l5vLaW+1sHgHo3oZ7ZMDcPZyNXXgMmzkN1WgA4E04JPtI2BaLBp4+UDaYDMZUgsMfdFWO;\n\t25:UNuHiUcOhS81r2bV0f+x/NsRou/2MR+QdSLy73wJ7gHCiAhEbALK2af1Msbt3MfBSYb0l1SSzMFBnP5Rtq38RCvS4FWBVa5Cl1519F6z7AB9pihYVPm0Qc2i18i3zOhTLiPdKvVUBE00m4zeE+gGNYjFRamtZ1P5qsntMxW8naQFx/OEoRfTx8ahIlNnuGAJZ2HNAl/P7OPcqTedp53LnykanU4UimRTNXnn+O0/seJejQ8sfBnwiJMZHOcmEp3l0LXlZJYDhRL8mOLw96wn7jVPKa5gJxFOv2f5TuIvjk0lflygsFmGcALwqOfZxgmvu+tMofWgHKYE4y8ntYi2pg==;\n\t31:HsoFlIVjRJ15JnZ0p1d59rhFiIzMT+s82oKQvT5Ftghrthj749cinQ7gfYavpUJ7/c4zjRPdsBAvnw8CUGdsC/eiIJg3f1E14Y97VoJ2PXNdQJqX6/YFtNM9kkplwLXdtKQ3QG+1BFvoD/QRdJFRXMZLfiBLkYiGGxeXGAj542+52tmJ65ULPL+clX1OCkml39ISyQTkUl3tZP1B/nMR/XlYZNKHUE+YdJSDJoeds5Y=",
            "1; VI1PR05MB3149;\n\t20:TWSQG43ELy8B8dODWB+0yEdjs/I77jqHSl3W/EeZ0GCWMjw406jyQRgQKOvwY6IRsDVIA+D4pqksm0QyjemjrMtvkpj//JJLGwNCUAebt018nE01e3+8B8oycG9NwOqMrygx0SfVOVpziuL8H9cT41uVjo97cWAjdRYXn3G2bVLGQbtzt0y3QPac/WbdXWdJnPh3Wol+I+MbtWTqBcCSYu3pKIdbHu2YdZ/pEvBY/OsWGC3SrOStfDsKQanF/8FL3E/Jkf7hrQER4aKMXS0ByQSydEyeglvIgFGuT2BQzvWDlZyX4NuhDot+woOv0Hy+h69jcC//oJqzMI7L3fNrwoQ5icuxKgXl3imw2/ZixGoioMpntnQ5twJFlO2EtRPVj0QhHJlWGGpGswSXz/ixtKR+pbtgsLmaXgpUctfOXMKdKQspNZslLLlQY7ZThVJ30qmUxl+NhlVkL6sVGSxxGD1Kb0BdxMZ94BVvrX6e6eSsvUHi3ZfwoFRlAm51fUi+;\n\t4:DiIsjbJq2OYPzGFDsGMKDxyjaAOfVcwQH3TtydEvhWECtaZ6sfTXoPrBD+O5MBIH6xZefAPy/zfQJ/svKvE5fKuGIy/FR9zMarz0blQydOzyq9LvwjdJ9elAP+u7pJ2JtFeiG9XTjaFmqqsp7S+KpGC3QRq2AJCebIwNXrqr0UrZlQZUMhABcTgJqTuP5ur/njdEfg3DxmZAs5WP6dpb5Ozk+R0+QCbgJogcMaBkh56/FdbVpOEeJ9/+wRyEujZkdU+zjq18XamJXy+RNgDCpg==",
            "=?us-ascii?Q?1; VI1PR05MB3149;\n\t23:IObqY+B54hQ8MGKBpx5fubM49malN+IsltnzdDXH7?=\n\tsGlHl0k2Sch+5QIBnTD3IqGaTxcpcJ0AJ4KOHPM/qErAsbBU2obONXFumLn5PNOIp3ae//IFqERKFIZpv/yqw7gnauynby+ZfAeYFksGkUytk6rII1d2GV2OjlRTtPqzjdJm9g1SnZ3Hg6Ptwey3PkBqXe6+x74j945MIasUu1+q1XjzFI70C0KzsAqOND0L6jACjz2iRRxtllAY7CUJMBcVDqtjfp8dumTPrTGslgzn7nn91gYNDzVYzoLMVgkZfEdsXm1+F54AxVrGUZXyVsVrYYDw8i/uXCU5FTQs9s8JkJeFv1SByvQhOs+T8ehC0hoOXWvf9ZRqCkIelhZwD/5sLPE21LK/GSDUWTY3lVE6j6A+vBeUMrfrKAHyYm2tUswURR77viQ0Ovkpffd+kzetIDQY+urmqUa3Kk4z3ZLQQrhPxqw7XB/SjKKOVjvc1OzNzQKFSRNMI3wvmfKDlZdGLiVaKtZyGfU1/Gibs4ByXYbmrAqJGIa5KWXwIeakwNtHuRFwk4RN1CyOK9baSIIuYjNRjQ1QqGCJg75YRhkqPUVTFT7KAkl9+pcAevLw+jZbPjn6M0d5fAlz4R4Vvk/R08O3fC9PfzspTU8xMBVvWv3YZtjOpZ1e5UvZtfVJaKTkPfOFs0oxs41/xPVEeATAUg+E2Um6/H7JJDI0oPg3N3PhwFDHT+/bpZHzlPOSvK2xgILouNKpy93NJqbbhF8X7MN+M7JQ+7I1u71VVdd4jzXhozm8/R9TGs1lEJuJ6b36p8FmeiwL/FeHMXo0NCkXPj588vCLu/vaooluRzE7aiL9XQt0yH4JGMgGZzCyRq+g1HZJD7HIHaqcowHYA4pX+bqSJHL9mwPXGO9mIzDzk7yJEpDPJJiDcMSd43HTw9F8wrPEK9c+ySh89mc3Nh9xzNoDn0SnsRYZHY2f5xRHcMryrZB5eLQnjr7GrN0bX35moqF2lBdDV3pOVltYCGnTMRJQF9Yc7qYLkEM6kSTuAbPw4Fkrd7acpPjJtADE81EbIKUa0O/z4xtSvcVvMKB",
            "1; VI1PR05MB3149;\n\t6:8hNL/duq2t1n7G4l35fx9+/WvmcRGqzl2z9sdMDA16OT6UDlAZ7w+eSF123FpEpl4GlyScm9WfdpQIkN/EOkfKcLoVew9Km45/aH0O/S64UuJ3g2/Y0q5O+dV0u4C65qa+erT0V8i/BjZt9A+9gYc3yXlrFXLwmTnxYhbjeyF0op3v+uQXPfaWnbVF79JhZ3c8PUGY4HJMaFakyDkHVEsMOEI5X2OzSlunN7LcQQAennYQwn7N0qvLNeZe1Ydm/oJn0/tjPkqkdgCzsj9e3gQIuC3doc/Hqo5aJPU4YvS174HmAZjofhPliGyqWwmfwsI5HmnTGo5UvfpvCZNDOlrB74jQxpCTC7yGc8FpiGnb4=;\n\t5:VeMOLFOUV2G2wk5WtAuQvj5VKhPkwRihGVF7Z8eGdf/Jkim8vtFZ3+p4GDRxokHJOwmk8zi/15h+I/X0vMxBfcpme+VfloFqOZrP1ItwGOEElJ7KHioKBWz+ODflz3iZdHD8JW/00XQ9LASKIkfStFsk5JclvH1942dpf9PHr5Q=;\n\t24:SQ/hjeBsUtrTPZO4OSs5aTUmtdSUfLThKEQfAioMpq3Qq/OCMLaitogmrsNPjV7A91UjE3hal6Dk4wuKUWS4zT5mtjeRob/RPXnbwiFjf08=;\n\t7:BaWkiTEhFI6Rg3O2Nc81Ron3sBy3a+U4VhETkhe+YXfjG9U1gxp1SLHuyD7vTenmzAaBeRBKNfoSBlDCTpiRQI0MOTm/qPW7Ka4iJT0v3aknZD4fb3UX3F6ll34w1UyORivBExe6LSaxijUYULlol7Qj485BREAK1D+eZTfG7/k7aTt4lfcvYxxxbydQgDSVUW6DHPTR0vf7AAaXSy5XR/IkSPzFxJINfwwiyAPnaxnIto+nQKgxMPkHMOnMxgtA"
        ],
        "X-MS-TrafficTypeDiagnostic": "VI1PR05MB3149:",
        "X-Microsoft-Antispam-PRVS": "<VI1PR05MB3149673FA91B42E8F643CFB5C3340@VI1PR05MB3149.eurprd05.prod.outlook.com>",
        "X-Exchange-Antispam-Report-Test": "UriScan:;",
        "X-Exchange-Antispam-Report-CFA-Test": "BCL:0; PCL:0;\n\tRULEID:(6040450)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3002001)(3231023)(6055026)(6041248)(20161123564025)(20161123558100)(20161123562025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(6072148)(201708071742011);\n\tSRVR:VI1PR05MB3149; BCL:0; PCL:0; RULEID:(100000803101)(100110400095);\n\tSRVR:VI1PR05MB3149; ",
        "X-Forefront-PRVS": "051900244E",
        "X-Forefront-Antispam-Report": "SFV:NSPM;\n\tSFS:(10009020)(346002)(376002)(39860400002)(366004)(189003)(199004)(7736002)(8936002)(305945005)(66066001)(3846002)(5660300001)(47776003)(6116002)(2906002)(69596002)(68736007)(48376002)(33026002)(2950100002)(50466002)(81166006)(21086003)(81156014)(6666003)(8676002)(106356001)(105586002)(118296001)(97736004)(478600001)(51416003)(25786009)(316002)(52116002)(7696005)(50226002)(86362001)(55016002)(36756003)(59450400001)(76176011)(16586007)(53936002)(16526018);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB3149; H:mellanox.com; FPR:;\n\tSPF:None; \n\tPTR:InfoNoRecords; MX:1; A:1; LANG:en; ",
        "Received-SPF": "None (protection.outlook.com: mellanox.com does not designate\n\tpermitted sender hosts)",
        "SpamDiagnosticOutput": "1:99",
        "SpamDiagnosticMetadata": "NSPM",
        "X-OriginatorOrg": "Mellanox.com",
        "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "12 Dec 2017 12:27:27.9884\n\t(UTC)",
        "X-MS-Exchange-CrossTenant-Network-Message-Id": "44847a7b-8ba1-4d8c-fa67-08d5415bb5ac",
        "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted",
        "X-MS-Exchange-CrossTenant-Id": "a652971c-7d2e-4d9b-a6a4-d149256f461b",
        "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "VI1PR05MB3149",
        "Subject": "[dpdk-dev] [PATCH v2 05/39] examples/l3fwd: move to ethdev offloads\n\tAPI",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Ethdev offloads API has changed since:\n\ncommit ce17eddefc20 (\"ethdev: introduce Rx queue offloads API\")\ncommit cba7f53b717d (\"ethdev: introduce Tx queue offloads API\")\n\nThis commit support the new API.\n\nSigned-off-by: Shahaf Shuler <shahafs@mellanox.com>\n---\n examples/l3fwd/main.c | 40 ++++++++++++++++++++++++++++++----------\n 1 file changed, 30 insertions(+), 10 deletions(-)",
    "diff": "diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c\nindex 6229568..3bdf4d5 100644\n--- a/examples/l3fwd/main.c\n+++ b/examples/l3fwd/main.c\n@@ -149,11 +149,9 @@ struct lcore_params {\n \t\t.mq_mode = ETH_MQ_RX_RSS,\n \t\t.max_rx_pkt_len = ETHER_MAX_LEN,\n \t\t.split_hdr_size = 0,\n-\t\t.header_split   = 0, /**< Header Split disabled */\n-\t\t.hw_ip_checksum = 1, /**< IP checksum offload enabled */\n-\t\t.hw_vlan_filter = 0, /**< VLAN filtering disabled */\n-\t\t.jumbo_frame    = 0, /**< Jumbo Frame Support disabled */\n-\t\t.hw_strip_crc   = 1, /**< CRC stripped by hardware */\n+\t\t.ignore_offload_bitfield = 1,\n+\t\t.offloads = (DEV_RX_OFFLOAD_CRC_STRIP |\n+\t\t\t     DEV_RX_OFFLOAD_CHECKSUM),\n \t},\n \t.rx_adv_conf = {\n \t\t.rss_conf = {\n@@ -163,6 +161,7 @@ struct lcore_params {\n \t},\n \t.txmode = {\n \t\t.mq_mode = ETH_MQ_TX_NONE,\n+\t\t.offloads = DEV_TX_OFFLOAD_MBUF_FAST_FREE,\n \t},\n };\n \n@@ -612,7 +611,8 @@ enum {\n \t\t\t};\n \n \t\t\tprintf(\"%s\\n\", str8);\n-\t\t\tport_conf.rxmode.jumbo_frame = 1;\n+\t\t\tport_conf.rxmode.offloads |= DEV_RX_OFFLOAD_JUMBO_FRAME;\n+\t\t\tport_conf.txmode.offloads |= DEV_TX_OFFLOAD_MULTI_SEGS;\n \n \t\t\t/*\n \t\t\t * if no max-pkt-len set, use the default\n@@ -908,6 +908,22 @@ enum {\n \t\t\tn_tx_queue = MAX_TX_QUEUE_PER_PORT;\n \t\tprintf(\"Creating queues: nb_rxq=%d nb_txq=%u... \",\n \t\t\tnb_rx_queue, (unsigned)n_tx_queue );\n+\n+\t\trte_eth_dev_info_get(portid, &dev_info);\n+\t\tif ((dev_info.rx_offload_capa & port_conf.rxmode.offloads) !=\n+\t\t    port_conf.rxmode.offloads) {\n+\t\t\tprintf(\"Some Rx offloads are not supported \"\n+\t\t\t       \"by port %d: requested 0x%lx supported 0x%lx\\n\",\n+\t\t\t       portid, port_conf.rxmode.offloads,\n+\t\t\t       dev_info.rx_offload_capa);\n+\t\t}\n+\t\tif ((dev_info.tx_offload_capa & port_conf.txmode.offloads) !=\n+\t\t    port_conf.txmode.offloads) {\n+\t\t\tprintf(\"Some Tx offloads are not supported \"\n+\t\t\t       \"by port %d: requested 0x%lx supported 0x%lx\\n\",\n+\t\t\t       portid, port_conf.txmode.offloads,\n+\t\t\t       dev_info.tx_offload_capa);\n+\t\t}\n \t\tret = rte_eth_dev_configure(portid, nb_rx_queue,\n \t\t\t\t\t(uint16_t)n_tx_queue, &port_conf);\n \t\tif (ret < 0)\n@@ -955,10 +971,9 @@ enum {\n \t\t\tprintf(\"txq=%u,%d,%d \", lcore_id, queueid, socketid);\n \t\t\tfflush(stdout);\n \n-\t\t\trte_eth_dev_info_get(portid, &dev_info);\n \t\t\ttxconf = &dev_info.default_txconf;\n-\t\t\tif (port_conf.rxmode.jumbo_frame)\n-\t\t\t\ttxconf->txq_flags = 0;\n+\t\t\ttxconf->txq_flags = ETH_TXQ_FLAGS_IGNORE;\n+\t\t\ttxconf->offloads = port_conf.txmode.offloads;\n \t\t\tret = rte_eth_tx_queue_setup(portid, queueid, nb_txd,\n \t\t\t\t\t\t     socketid, txconf);\n \t\t\tif (ret < 0)\n@@ -984,6 +999,8 @@ enum {\n \t\tfflush(stdout);\n \t\t/* init RX queues */\n \t\tfor(queue = 0; queue < qconf->n_rx_queue; ++queue) {\n+\t\t\tstruct rte_eth_rxconf rxq_conf;\n+\n \t\t\tportid = qconf->rx_queue_list[queue].port_id;\n \t\t\tqueueid = qconf->rx_queue_list[queue].queue_id;\n \n@@ -996,9 +1013,12 @@ enum {\n \t\t\tprintf(\"rxq=%d,%d,%d \", portid, queueid, socketid);\n \t\t\tfflush(stdout);\n \n+\t\t\trte_eth_dev_info_get(portid, &dev_info);\n+\t\t\trxq_conf = dev_info.default_rxconf;\n+\t\t\trxq_conf.offloads = port_conf.rxmode.offloads;\n \t\t\tret = rte_eth_rx_queue_setup(portid, queueid, nb_rxd,\n \t\t\t\t\tsocketid,\n-\t\t\t\t\tNULL,\n+\t\t\t\t\t&rxq_conf,\n \t\t\t\t\tpktmbuf_pool[socketid]);\n \t\t\tif (ret < 0)\n \t\t\t\trte_exit(EXIT_FAILURE,\n",
    "prefixes": [
        "dpdk-dev",
        "v2",
        "05/39"
    ]
}