Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/32044/?format=api
{ "id": 32044, "url": "http://patches.dpdk.org/api/patches/32044/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20171208171435.29875-4-nhorman@tuxdriver.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20171208171435.29875-4-nhorman@tuxdriver.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20171208171435.29875-4-nhorman@tuxdriver.com", "date": "2017-12-08T17:14:34", "name": "[dpdk-dev,PATCHv2,3/4] Makefiles: Add experimental tag check and warnings to trigger on use", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f46f0cbd90189949d7a8a5c220f238c8fd40da11", "submitter": { "id": 32, "url": "http://patches.dpdk.org/api/people/32/?format=api", "name": "Neil Horman", "email": "nhorman@tuxdriver.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20171208171435.29875-4-nhorman@tuxdriver.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/32044/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/32044/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 72E671B1C0;\n\tFri, 8 Dec 2017 18:15:40 +0100 (CET)", "from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])\n\tby dpdk.org (Postfix) with ESMTP id AEAE51B1BB\n\tfor <dev@dpdk.org>; Fri, 8 Dec 2017 18:15:37 +0100 (CET)", "from cpe-2606-a000-111b-423c-e874-da8e-c543-d863.dyn6.twc.com\n\t([2606:a000:111b:423c:e874:da8e:c543:d863]\n\thelo=hmswarspite.think-freely.org)\n\tby smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63)\n\t(envelope-from <nhorman@tuxdriver.com>)\n\tid 1eNMF9-0002qI-FU; Fri, 08 Dec 2017 12:15:32 -0500", "from hmswarspite.think-freely.org (localhost [127.0.0.1])\n\tby hmswarspite.think-freely.org (8.15.2/8.15.2) with ESMTP id\n\tvB8HEo4C030001; Fri, 8 Dec 2017 12:14:50 -0500", "(from nhorman@localhost)\n\tby hmswarspite.think-freely.org (8.15.2/8.15.2/Submit) id\n\tvB8HEonP030000; Fri, 8 Dec 2017 12:14:50 -0500" ], "From": "Neil Horman <nhorman@tuxdriver.com>", "To": "dev@dpdk.org", "Cc": "Neil Horman <nhorman@tuxdriver.com>,\n\tThomas Monjalon <thomas@monjalon.net>, \n\t\"Mcnamara, John\" <john.mcnamara@intel.com>", "Date": "Fri, 8 Dec 2017 12:14:34 -0500", "Message-Id": "<20171208171435.29875-4-nhorman@tuxdriver.com>", "X-Mailer": "git-send-email 2.14.3", "In-Reply-To": "<20171208171435.29875-1-nhorman@tuxdriver.com>", "References": "<20171201185628.16261-1-nhorman@tuxdriver.com>\n\t<20171208171435.29875-1-nhorman@tuxdriver.com>", "X-Spam-Score": "-2.9 (--)", "X-Spam-Status": "No", "Subject": "[dpdk-dev] [PATCHv2 3/4] Makefiles: Add experimental tag check and\n\twarnings to trigger on use", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add checks during build to ensure that all symbols in the EXPERIMENTAL\nversion map section have __experimental tags on their definitions, and\nenable the warnings needed to announce their use. Also add a\nALLOW_EXPERIMENTAL_FUNCTIONS variable check to allow for in-tree dpdk\nlibraries to override those checks.\n\nSigned-off-by: Neil Horman <nhorman@tuxdriver.com>\nCC: Thomas Monjalon <thomas@monjalon.net>\nCC: \"Mcnamara, John\" <john.mcnamara@intel.com>\n---\n app/test-eventdev/Makefile | 2 ++\n app/test-pmd/Makefile | 2 ++\n drivers/event/sw/Makefile | 2 ++\n drivers/net/failsafe/Makefile | 2 ++\n drivers/net/ixgbe/Makefile | 2 ++\n examples/eventdev_pipeline_sw_pmd/Makefile | 2 ++\n examples/flow_classify/Makefile | 2 ++\n examples/ipsec-secgw/Makefile | 2 ++\n examples/service_cores/Makefile | 2 ++\n lib/librte_eal/bsdapp/eal/Makefile | 2 ++\n lib/librte_eal/linuxapp/Makefile | 2 ++\n lib/librte_eal/linuxapp/eal/Makefile | 4 ++++\n lib/librte_eventdev/Makefile | 3 +++\n lib/librte_security/Makefile | 3 +++\n mk/internal/rte.compile-pre.mk | 14 ++++++++++++--\n mk/toolchain/clang/rte.vars.mk | 2 +-\n mk/toolchain/gcc/rte.vars.mk | 2 +-\n mk/toolchain/icc/rte.vars.mk | 2 +-\n 18 files changed, 47 insertions(+), 5 deletions(-)", "diff": "diff --git a/app/test-eventdev/Makefile b/app/test-eventdev/Makefile\nindex dcb2ac476..e68870828 100644\n--- a/app/test-eventdev/Makefile\n+++ b/app/test-eventdev/Makefile\n@@ -32,6 +32,8 @@ include $(RTE_SDK)/mk/rte.vars.mk\n \n APP = dpdk-test-eventdev\n \n+ALLOW_EXPERIMENTAL_FUNCTIONS := 1\n+\n CFLAGS += -O3\n CFLAGS += $(WERROR_FLAGS)\n \ndiff --git a/app/test-pmd/Makefile b/app/test-pmd/Makefile\nindex d21308fcd..f0262a369 100644\n--- a/app/test-pmd/Makefile\n+++ b/app/test-pmd/Makefile\n@@ -33,6 +33,8 @@ include $(RTE_SDK)/mk/rte.vars.mk\n \n ifeq ($(CONFIG_RTE_TEST_PMD),y)\n \n+ALLOW_EXPERIMENTAL_FUNCTIONS := 1\n+\n #\n # library name\n #\ndiff --git a/drivers/event/sw/Makefile b/drivers/event/sw/Makefile\nindex 2f2b67bac..0711ce46e 100644\n--- a/drivers/event/sw/Makefile\n+++ b/drivers/event/sw/Makefile\n@@ -33,6 +33,8 @@ include $(RTE_SDK)/mk/rte.vars.mk\n # library name\n LIB = librte_pmd_sw_event.a\n \n+ALLOW_EXPERIMENTAL_FUNCTIONS := 1\n+\n # build flags\n CFLAGS += -O3\n CFLAGS += $(WERROR_FLAGS)\ndiff --git a/drivers/net/failsafe/Makefile b/drivers/net/failsafe/Makefile\nindex ea2a8fe46..795da9d56 100644\n--- a/drivers/net/failsafe/Makefile\n+++ b/drivers/net/failsafe/Makefile\n@@ -36,6 +36,8 @@ LIB = librte_pmd_failsafe.a\n \n EXPORT_MAP := rte_pmd_failsafe_version.map\n \n+ALLOW_EXPERIMENTAL_FUNCTIONS := 1\n+\n LIBABIVER := 1\n \n # Sources are stored in SRCS-y\ndiff --git a/drivers/net/ixgbe/Makefile b/drivers/net/ixgbe/Makefile\nindex 511a64eb0..b8431600a 100644\n--- a/drivers/net/ixgbe/Makefile\n+++ b/drivers/net/ixgbe/Makefile\n@@ -36,6 +36,8 @@ include $(RTE_SDK)/mk/rte.vars.mk\n #\n LIB = librte_pmd_ixgbe.a\n \n+ALLOW_EXPERIMENTAL_FUNCTIONS := 1\n+\n CFLAGS += -O3\n CFLAGS += $(WERROR_FLAGS)\n \ndiff --git a/examples/eventdev_pipeline_sw_pmd/Makefile b/examples/eventdev_pipeline_sw_pmd/Makefile\nindex de4e22c88..4272caf93 100644\n--- a/examples/eventdev_pipeline_sw_pmd/Makefile\n+++ b/examples/eventdev_pipeline_sw_pmd/Makefile\n@@ -32,6 +32,8 @@ ifeq ($(RTE_SDK),)\n $(error \"Please define RTE_SDK environment variable\")\n endif\n \n+ALLOW_EXPERIMENTAL_FUNCTIONS := 1\n+\n # Default target, can be overridden by command line or environment\n RTE_TARGET ?= x86_64-native-linuxapp-gcc\n \ndiff --git a/examples/flow_classify/Makefile b/examples/flow_classify/Makefile\nindex eecdde14c..b04747c40 100644\n--- a/examples/flow_classify/Makefile\n+++ b/examples/flow_classify/Makefile\n@@ -33,6 +33,8 @@ ifeq ($(RTE_SDK),)\n $(error \"Please define RTE_SDK environment variable\")\n endif\n \n+ALLOW_EXPERIMENTAL_FUNCTIONS := 1\n+\n # Default target, can be overridden by command line or environment\n RTE_TARGET ?= x86_64-native-linuxapp-gcc\n \ndiff --git a/examples/ipsec-secgw/Makefile b/examples/ipsec-secgw/Makefile\nindex 9fd33cb7f..90a4feca1 100644\n--- a/examples/ipsec-secgw/Makefile\n+++ b/examples/ipsec-secgw/Makefile\n@@ -33,6 +33,8 @@ ifeq ($(RTE_SDK),)\n \t$(error \"Please define RTE_SDK environment variable\")\n endif\n \n+ALLOW_EXPERIMENTAL_FUNCTIONS := 1\n+\n # Default target, can be overridden by command line or environment\n RTE_TARGET ?= x86_64-native-linuxapp-gcc\n \ndiff --git a/examples/service_cores/Makefile b/examples/service_cores/Makefile\nindex bd4a345dc..ba731e259 100644\n--- a/examples/service_cores/Makefile\n+++ b/examples/service_cores/Makefile\n@@ -32,6 +32,8 @@ ifeq ($(RTE_SDK),)\n $(error \"Please define RTE_SDK environment variable\")\n endif\n \n+ALLOW_EXPERIMENTAL_FUNCTIONS := 1\n+\n # Default target, can be overridden by command line or environment\n RTE_TARGET ?= x86_64-native-linuxapp-gcc\n \ndiff --git a/lib/librte_eal/bsdapp/eal/Makefile b/lib/librte_eal/bsdapp/eal/Makefile\nindex afa117de4..936010cd6 100644\n--- a/lib/librte_eal/bsdapp/eal/Makefile\n+++ b/lib/librte_eal/bsdapp/eal/Makefile\n@@ -33,6 +33,8 @@ include $(RTE_SDK)/mk/rte.vars.mk\n \n LIB = librte_eal.a\n \n+ALLOW_EXPERIMENTAL_FUNCTIONS := 1\n+\n ARCH_DIR ?= $(RTE_ARCH)\n VPATH += $(RTE_SDK)/lib/librte_eal/common\n VPATH += $(RTE_SDK)/lib/librte_eal/common/arch/$(ARCH_DIR)\ndiff --git a/lib/librte_eal/linuxapp/Makefile b/lib/librte_eal/linuxapp/Makefile\nindex 2ebdf3139..11ee59e42 100644\n--- a/lib/librte_eal/linuxapp/Makefile\n+++ b/lib/librte_eal/linuxapp/Makefile\n@@ -31,6 +31,8 @@\n \n include $(RTE_SDK)/mk/rte.vars.mk\n \n+ALLOW_EXPERIMENTAL_FUNCTIONS := 2\n+\n DIRS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += eal\n DIRS-$(CONFIG_RTE_EAL_IGB_UIO) += igb_uio\n DIRS-$(CONFIG_RTE_KNI_KMOD) += kni\ndiff --git a/lib/librte_eal/linuxapp/eal/Makefile b/lib/librte_eal/linuxapp/eal/Makefile\nindex 5a7b8b2ac..36d17efb6 100644\n--- a/lib/librte_eal/linuxapp/eal/Makefile\n+++ b/lib/librte_eal/linuxapp/eal/Makefile\n@@ -34,6 +34,10 @@ include $(RTE_SDK)/mk/rte.vars.mk\n LIB = librte_eal.a\n \n ARCH_DIR ?= $(RTE_ARCH)\n+\n+#Allow the use of experimental functions without warning\n+ALLOW_EXPERIMENTAL_FUNCTIONS := 1\n+\n EXPORT_MAP := ../../rte_eal_version.map\n VPATH += $(RTE_SDK)/lib/librte_eal/common/arch/$(ARCH_DIR)\n \ndiff --git a/lib/librte_eventdev/Makefile b/lib/librte_eventdev/Makefile\nindex 5ac22cde7..e37de2820 100644\n--- a/lib/librte_eventdev/Makefile\n+++ b/lib/librte_eventdev/Makefile\n@@ -36,6 +36,9 @@ LIB = librte_eventdev.a\n # library version\n LIBABIVER := 3\n \n+# Allow the use of experimental functions\n+ALLOW_EXPERIMENTAL_FUNCTIONS := 1\n+\n # build flags\n CFLAGS += -O3\n CFLAGS += $(WERROR_FLAGS)\ndiff --git a/lib/librte_security/Makefile b/lib/librte_security/Makefile\nindex bb93ec33d..c2815fab8 100644\n--- a/lib/librte_security/Makefile\n+++ b/lib/librte_security/Makefile\n@@ -36,6 +36,9 @@ LIB = librte_security.a\n # library version\n LIBABIVER := 1\n \n+# Allow the use of experimental functions without warnings\n+ALLOW_EXPERIMENTAL_FUNCTIONS := 1\n+\n # build flags\n CFLAGS += -O3\n CFLAGS += $(WERROR_FLAGS)\ndiff --git a/mk/internal/rte.compile-pre.mk b/mk/internal/rte.compile-pre.mk\nindex da8dda498..dea7f01a2 100644\n--- a/mk/internal/rte.compile-pre.mk\n+++ b/mk/internal/rte.compile-pre.mk\n@@ -72,18 +72,27 @@ CMDS-all := $(CMDS-y) $(CMDS-n) $(CMDS-)\n \n -include $(DEPS-y) $(CMDS-y)\n \n+ifdef ALLOW_EXPERIMENTAL_FUNCTIONS\n+EXPERIMENTAL_CFLAGS := $(subst 1, -Wno-deprecated-declarations -Wno-deprecated -Wno-error=deprecated-declarations -Wno-error=deprecated, $(ALLOW_EXPERIMENTAL_FUNCTIONS))\n+else\n+EXPERIMENTAL_CFLAGS :=\n+endif\n+\n # command to compile a .c file to generate an object\n ifeq ($(USE_HOST),1)\n C_TO_O = $(HOSTCC) -Wp,-MD,$(call obj2dep,$(@)).tmp $(HOST_CPPFLAGS) $(HOST_CFLAGS) \\\n-\t$(CFLAGS_$(@)) $(HOST_EXTRA_CPPFLAGS) $(HOST_EXTRA_CFLAGS) -o $@ -c $<\n+\t$(CFLAGS_$(@)) $(HOST_EXTRA_CPPFLAGS) $(HOST_EXTRA_CFLAGS) $(EXPERIMENTAL_CFLAGS) -o $@ -c $<\n C_TO_O_STR = $(subst ','\\'',$(C_TO_O)) #'# fix syntax highlight\n C_TO_O_DISP = $(if $(V),\"$(C_TO_O_STR)\",\" HOSTCC $(@)\")\n else\n C_TO_O = $(CC) -Wp,-MD,$(call obj2dep,$(@)).tmp $(CPPFLAGS) $(CFLAGS) \\\n-\t$(CFLAGS_$(@)) $(EXTRA_CPPFLAGS) $(EXTRA_CFLAGS) -o $@ -c $<\n+\t$(CFLAGS_$(@)) $(EXTRA_CPPFLAGS) $(EXTRA_CFLAGS) $(EXPERIMENTAL_CFLAGS) -o $@ -c $<\n C_TO_O_STR = $(subst ','\\'',$(C_TO_O)) #'# fix syntax highlight\n C_TO_O_DISP = $(if $(V),\"$(C_TO_O_STR)\",\" CC $(@)\")\n endif\n+EXPERIMENTAL_CHECK = $(RTE_SDK)/buildtools/experimentalsyms.sh\n+CHECK_EXPERIMENTAL = $(EXPERIMENTAL_CHECK) $(SRCDIR)/$(EXPORT_MAP) $@\n+\n PMDINFO_GEN = $(RTE_SDK_BIN)/app/dpdk-pmdinfogen $@ $@.pmd.c\n PMDINFO_CC = $(CC) $(CPPFLAGS) $(CFLAGS) -c -o $@.pmd.o $@.pmd.c\n PMDINFO_LD = $(CROSS)ld $(LDFLAGS) -r -o $@.o $@.pmd.o $@\n@@ -100,6 +109,7 @@ C_TO_O_DO = @set -e; \\\n \techo $(C_TO_O_DISP); \\\n \t$(C_TO_O) && \\\n \t$(PMDINFO_TO_O) && \\\n+\t$(CHECK_EXPERIMENTAL) && \\\n \techo $(C_TO_O_CMD) > $(call obj2cmd,$(@)) && \\\n \tsed 's,'$@':,dep_'$@' =,' $(call obj2dep,$(@)).tmp > $(call obj2dep,$(@)) && \\\n \trm -f $(call obj2dep,$(@)).tmp\ndiff --git a/mk/toolchain/clang/rte.vars.mk b/mk/toolchain/clang/rte.vars.mk\nindex dde922d22..3cfe92545 100644\n--- a/mk/toolchain/clang/rte.vars.mk\n+++ b/mk/toolchain/clang/rte.vars.mk\n@@ -67,7 +67,7 @@ WERROR_FLAGS := -W -Wall -Wstrict-prototypes -Wmissing-prototypes\n WERROR_FLAGS += -Wmissing-declarations -Wold-style-definition -Wpointer-arith\n WERROR_FLAGS += -Wnested-externs -Wcast-qual\n WERROR_FLAGS += -Wformat-nonliteral -Wformat-security\n-WERROR_FLAGS += -Wundef -Wwrite-strings\n+WERROR_FLAGS += -Wundef -Wwrite-strings -Wdeprecated\n \n ifeq ($(RTE_DEVEL_BUILD),y)\n WERROR_FLAGS += -Werror\ndiff --git a/mk/toolchain/gcc/rte.vars.mk b/mk/toolchain/gcc/rte.vars.mk\nindex 3b907e201..3356a37c8 100644\n--- a/mk/toolchain/gcc/rte.vars.mk\n+++ b/mk/toolchain/gcc/rte.vars.mk\n@@ -75,7 +75,7 @@ WERROR_FLAGS := -W -Wall -Wstrict-prototypes -Wmissing-prototypes\n WERROR_FLAGS += -Wmissing-declarations -Wold-style-definition -Wpointer-arith\n WERROR_FLAGS += -Wcast-align -Wnested-externs -Wcast-qual\n WERROR_FLAGS += -Wformat-nonliteral -Wformat-security\n-WERROR_FLAGS += -Wundef -Wwrite-strings\n+WERROR_FLAGS += -Wundef -Wwrite-strings -Wdeprecated\n \n ifeq ($(RTE_DEVEL_BUILD),y)\n WERROR_FLAGS += -Werror\ndiff --git a/mk/toolchain/icc/rte.vars.mk b/mk/toolchain/icc/rte.vars.mk\nindex 33a8ba79e..58940602e 100644\n--- a/mk/toolchain/icc/rte.vars.mk\n+++ b/mk/toolchain/icc/rte.vars.mk\n@@ -73,7 +73,7 @@ TOOLCHAIN_ASFLAGS =\n WERROR_FLAGS := -Wall -w2 -diag-disable 271 -diag-warning 1478\n WERROR_FLAGS += -diag-disable 13368 -diag-disable 15527\n WERROR_FLAGS += -diag-disable 188\n-WERROR_FLAGS += -diag-disable 11074 -diag-disable 11076\n+WERROR_FLAGS += -diag-disable 11074 -diag-disable 11076 -Wdeprecated\n \n ifeq ($(RTE_DEVEL_BUILD),y)\n WERROR_FLAGS += -Werror-all\n", "prefixes": [ "dpdk-dev", "PATCHv2", "3/4" ] }