Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/32043/?format=api
http://patches.dpdk.org/api/patches/32043/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20171208171435.29875-2-nhorman@tuxdriver.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20171208171435.29875-2-nhorman@tuxdriver.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20171208171435.29875-2-nhorman@tuxdriver.com", "date": "2017-12-08T17:14:32", "name": "[dpdk-dev,PATCHv2,1/4] buildtools: Add tool to check EXPERIMENTAL api exports", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d99fcb5a7065ec78a906a825e0ebe538ee8786f7", "submitter": { "id": 32, "url": "http://patches.dpdk.org/api/people/32/?format=api", "name": "Neil Horman", "email": "nhorman@tuxdriver.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20171208171435.29875-2-nhorman@tuxdriver.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/32043/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/32043/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 873DF1B1BB;\n\tFri, 8 Dec 2017 18:15:39 +0100 (CET)", "from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])\n\tby dpdk.org (Postfix) with ESMTP id 51D281B1B4\n\tfor <dev@dpdk.org>; Fri, 8 Dec 2017 18:15:36 +0100 (CET)", "from cpe-2606-a000-111b-423c-e874-da8e-c543-d863.dyn6.twc.com\n\t([2606:a000:111b:423c:e874:da8e:c543:d863]\n\thelo=hmswarspite.think-freely.org)\n\tby smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63)\n\t(envelope-from <nhorman@tuxdriver.com>)\n\tid 1eNMF8-0002qG-GS; Fri, 08 Dec 2017 12:15:31 -0500", "from hmswarspite.think-freely.org (localhost [127.0.0.1])\n\tby hmswarspite.think-freely.org (8.15.2/8.15.2) with ESMTP id\n\tvB8HEnJ8029992; Fri, 8 Dec 2017 12:14:49 -0500", "(from nhorman@localhost)\n\tby hmswarspite.think-freely.org (8.15.2/8.15.2/Submit) id\n\tvB8HEluM029991; Fri, 8 Dec 2017 12:14:47 -0500" ], "From": "Neil Horman <nhorman@tuxdriver.com>", "To": "dev@dpdk.org", "Cc": "Neil Horman <nhorman@tuxdriver.com>,\n\tThomas Monjalon <thomas@monjalon.net>, \n\t\"Mcnamara, John\" <john.mcnamara@intel.com>", "Date": "Fri, 8 Dec 2017 12:14:32 -0500", "Message-Id": "<20171208171435.29875-2-nhorman@tuxdriver.com>", "X-Mailer": "git-send-email 2.14.3", "In-Reply-To": "<20171208171435.29875-1-nhorman@tuxdriver.com>", "References": "<20171201185628.16261-1-nhorman@tuxdriver.com>\n\t<20171208171435.29875-1-nhorman@tuxdriver.com>", "X-Spam-Score": "-2.9 (--)", "X-Spam-Status": "No", "Subject": "[dpdk-dev] [PATCHv2 1/4] buildtools: Add tool to check EXPERIMENTAL\n\tapi exports", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This tools reads the given version map for a directory, and checks to\nensure that, for each symbol listed in the export list, the corresponding\ndefinition is tagged as __experimental, erroring out if its not. In this\nway, we can ensure that the EXPERIMENTAL api is kept in sync with the tags\n\nSigned-off-by: Neil Horman <nhorman@tuxdriver.com>\nCC: Thomas Monjalon <thomas@monjalon.net>\nCC: \"Mcnamara, John\" <john.mcnamara@intel.com>\n---\n buildtools/experimentalsyms.sh | 35 +++++++++++++++++++++++++++++++++++\n 1 file changed, 35 insertions(+)\n create mode 100755 buildtools/experimentalsyms.sh", "diff": "diff --git a/buildtools/experimentalsyms.sh b/buildtools/experimentalsyms.sh\nnew file mode 100755\nindex 000000000..7342ec9b3\n--- /dev/null\n+++ b/buildtools/experimentalsyms.sh\n@@ -0,0 +1,35 @@\n+#!/bin/sh\n+\n+MAPFILE=$1\n+OBJFILE=$2\n+\n+if [ -d $MAPFILE ]\n+then\n+\texit 0\n+fi\n+\n+if [ -d $OBJFILE ]\n+then\n+\texit 0\n+fi\n+\n+for i in `awk 'BEGIN {found=0}\n+\t\t/.*EXPERIMENTAL.*/ {found=1}\n+\t\t/.*}.*;/ {found=0}\n+\t\t/.*;/ {if (found == 1) print $1}' $MAPFILE`\n+do\n+\tSYM=`echo $i | sed -e\"s/;//\"`\n+\tobjdump -t $OBJFILE | grep -q \"\\.text.*$SYM\"\n+\tIN_TEXT=$?\n+\tobjdump -t $OBJFILE | grep -q \"\\.text\\.experimental.*$SYM\"\n+\tIN_EXP=$?\n+\tif [ $IN_TEXT -eq 0 -a $IN_EXP -ne 0 ]\n+\tthen\n+\t\techo \"$SYM is not flagged as experimental\"\n+\t\techo \"but is listed in version map\"\n+\t\techo \"Please add __experimental to the definition of $SYM\"\n+\t\texit 1\n+\tfi\n+done\n+exit 0\n+\n", "prefixes": [ "dpdk-dev", "PATCHv2", "1/4" ] }{ "id": 32043, "url": "