Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/31310/?format=api
{ "id": 31310, "url": "http://patches.dpdk.org/api/patches/31310/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20171109174628.44636-1-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20171109174628.44636-1-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20171109174628.44636-1-ajit.khaparde@broadcom.com", "date": "2017-11-09T17:46:27", "name": "[dpdk-dev,1/2] net/bnxt: fix duplicate creation of ntuple filter", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "812bb223b8fdfb9013c483cca11537a80d8133cc", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20171109174628.44636-1-ajit.khaparde@broadcom.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/31310/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/31310/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A52FB1B5E5;\n\tThu, 9 Nov 2017 18:46:39 +0100 (CET)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id AE1B41B5E4\n\tfor <dev@dpdk.org>; Thu, 9 Nov 2017 18:46:37 +0100 (CET)", "from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net\n\t[10.75.224.233])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 2FE7F30C026;\n\tThu, 9 Nov 2017 09:46:33 -0800 (PST)", "from C02PT1RBG8WP.vpn.broadcom.net (unknown [135.141.126.157])\n\tby mail-irv-17.broadcom.com (Postfix) with ESMTP id 3E94981EAE;\n\tThu, 9 Nov 2017 09:46:32 -0800 (PST)" ], "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com", "Date": "Thu, 9 Nov 2017 11:46:27 -0600", "Message-Id": "<20171109174628.44636-1-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.13.6 (Apple Git-96)", "Subject": "[dpdk-dev] [PATCH 1/2] net/bnxt: fix duplicate creation of ntuple\n\tfilter", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Prevent the creation of duplicate 5tuple filters.\nFixes: b7435d660a8c (\"net/bnxt: add ntuple filtering support\")\n\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_ethdev.c | 36 ++++++++++++++++++++----------------\n 1 file changed, 20 insertions(+), 16 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex e8c7d0e7c..dc437b480 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -1956,25 +1956,29 @@ parse_ntuple_filter(struct bnxt *bp,\n }\n \n static struct bnxt_filter_info*\n-bnxt_match_ntuple_filter(struct bnxt_vnic_info *vnic,\n+bnxt_match_ntuple_filter(struct bnxt *bp,\n \t\t\t struct bnxt_filter_info *bfilter)\n {\n \tstruct bnxt_filter_info *mfilter = NULL;\n+\tint i;\n \n-\tSTAILQ_FOREACH(mfilter, &vnic->filter, next) {\n-\t\tif (bfilter->src_ipaddr[0] == mfilter->src_ipaddr[0] &&\n-\t\t bfilter->src_ipaddr_mask[0] ==\n-\t\t mfilter->src_ipaddr_mask[0] &&\n-\t\t bfilter->src_port == mfilter->src_port &&\n-\t\t bfilter->src_port_mask == mfilter->src_port_mask &&\n-\t\t bfilter->dst_ipaddr[0] == mfilter->dst_ipaddr[0] &&\n-\t\t bfilter->dst_ipaddr_mask[0] ==\n-\t\t mfilter->dst_ipaddr_mask[0] &&\n-\t\t bfilter->dst_port == mfilter->dst_port &&\n-\t\t bfilter->dst_port_mask == mfilter->dst_port_mask &&\n-\t\t bfilter->flags == mfilter->flags &&\n-\t\t bfilter->enables == mfilter->enables)\n-\t\t\treturn mfilter;\n+\tfor (i = bp->nr_vnics - 1; i >= 0; i--) {\n+\t\tstruct bnxt_vnic_info *vnic = &bp->vnic_info[i];\n+\t\tSTAILQ_FOREACH(mfilter, &vnic->filter, next) {\n+\t\t\tif (bfilter->src_ipaddr[0] == mfilter->src_ipaddr[0] &&\n+\t\t\t bfilter->src_ipaddr_mask[0] ==\n+\t\t\t mfilter->src_ipaddr_mask[0] &&\n+\t\t\t bfilter->src_port == mfilter->src_port &&\n+\t\t\t bfilter->src_port_mask == mfilter->src_port_mask &&\n+\t\t\t bfilter->dst_ipaddr[0] == mfilter->dst_ipaddr[0] &&\n+\t\t\t bfilter->dst_ipaddr_mask[0] ==\n+\t\t\t mfilter->dst_ipaddr_mask[0] &&\n+\t\t\t bfilter->dst_port == mfilter->dst_port &&\n+\t\t\t bfilter->dst_port_mask == mfilter->dst_port_mask &&\n+\t\t\t bfilter->flags == mfilter->flags &&\n+\t\t\t bfilter->enables == mfilter->enables)\n+\t\t\t\treturn mfilter;\n+\t\t}\n \t}\n \treturn NULL;\n }\n@@ -2023,7 +2027,7 @@ bnxt_cfg_ntuple_filter(struct bnxt *bp,\n \tbfilter->ethertype = 0x800;\n \tbfilter->enables |= NTUPLE_FLTR_ALLOC_INPUT_EN_ETHERTYPE;\n \n-\tmfilter = bnxt_match_ntuple_filter(vnic, bfilter);\n+\tmfilter = bnxt_match_ntuple_filter(bp, bfilter);\n \n \tif (mfilter != NULL && filter_op == RTE_ETH_FILTER_ADD) {\n \t\tRTE_LOG(ERR, PMD, \"filter exists.\");\n", "prefixes": [ "dpdk-dev", "1/2" ] }