Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 31048,
    "url": "http://patches.dpdk.org/api/patches/31048/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20171031094456.24912-1-zhiyong.yang@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20171031094456.24912-1-zhiyong.yang@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20171031094456.24912-1-zhiyong.yang@intel.com",
    "date": "2017-10-31T09:44:56",
    "name": "[dpdk-dev] net/virtio: fix use_msix get the wrong value",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "080b052b870fb759b8f60b9f0be3bc2136a2b709",
    "submitter": {
        "id": 540,
        "url": "http://patches.dpdk.org/api/people/540/?format=api",
        "name": "Yang, Zhiyong",
        "email": "zhiyong.yang@intel.com"
    },
    "delegate": {
        "id": 355,
        "url": "http://patches.dpdk.org/api/users/355/?format=api",
        "username": "yliu",
        "first_name": "Yuanhan",
        "last_name": "Liu",
        "email": "yuanhan.liu@linux.intel.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20171031094456.24912-1-zhiyong.yang@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/31048/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/31048/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 919151B267;\n\tTue, 31 Oct 2017 10:55:57 +0100 (CET)",
            "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id ECCCA1B264\n\tfor <dev@dpdk.org>; Tue, 31 Oct 2017 10:55:55 +0100 (CET)",
            "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t31 Oct 2017 02:55:54 -0700",
            "from unknown (HELO dpdk5.bj.intel.com) ([172.16.182.182])\n\tby fmsmga002.fm.intel.com with ESMTP; 31 Oct 2017 02:55:53 -0700"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos; i=\"5.44,323,1505804400\"; d=\"scan'208\";\n\ta=\"1237643688\"",
        "From": "Zhiyong Yang <zhiyong.yang@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "yliu@fridaylinux.org, maxime.coquelin@redhat.com,\n\tZhiyong Yang <zhiyong.yang@intel.com>",
        "Date": "Tue, 31 Oct 2017 17:44:56 +0800",
        "Message-Id": "<20171031094456.24912-1-zhiyong.yang@intel.com>",
        "X-Mailer": "git-send-email 2.13.3",
        "Subject": "[dpdk-dev] [PATCH] net/virtio: fix use_msix get the wrong value",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "When running l3fwd-power to test virtio rxq interrupt using vfio\npci noiommu mode, startup fails. In the function virtio_read_caps,\nthe code if (flags & PCI_MSIX_ENABLE) intends to double check\nif vfio msix is enabled or not. However, it is indeed not valid.\nCome back to l3fwd-power, use_msix is not assigned to the right\nvalue \"1\". The patch fixes the issue.\n\nFixes: cb482cb3a305 (\"net/virtio: fix MAC address read\")\nSigned-off-by: Zhiyong Yang <zhiyong.yang@intel.com>\n---\n drivers/net/virtio/virtio_pci.c | 11 +----------\n 1 file changed, 1 insertion(+), 10 deletions(-)",
    "diff": "diff --git a/drivers/net/virtio/virtio_pci.c b/drivers/net/virtio/virtio_pci.c\nindex 55b717c03..be5b07a58 100644\n--- a/drivers/net/virtio/virtio_pci.c\n+++ b/drivers/net/virtio/virtio_pci.c\n@@ -580,8 +580,6 @@ get_cfg_addr(struct rte_pci_device *dev, struct virtio_pci_cap *cap)\n \treturn base + offset;\n }\n \n-#define PCI_MSIX_ENABLE 0x8000\n-\n static int\n virtio_read_caps(struct rte_pci_device *dev, struct virtio_hw *hw)\n {\n@@ -609,14 +607,7 @@ virtio_read_caps(struct rte_pci_device *dev, struct virtio_hw *hw)\n \t\t}\n \n \t\tif (cap.cap_vndr == PCI_CAP_ID_MSIX) {\n-\t\t\t/* Transitional devices would also have this capability,\n-\t\t\t * that's why we also check if msix is enabled.\n-\t\t\t * 1st byte is cap ID; 2nd byte is the position of next\n-\t\t\t * cap; next two bytes are the flags.\n-\t\t\t */\n-\t\t\tuint16_t flags = ((uint16_t *)&cap)[1];\n-\n-\t\t\tif (flags & PCI_MSIX_ENABLE)\n+\t\t\tif (dev->intr_handle.type == RTE_INTR_HANDLE_VFIO_MSIX)\n \t\t\t\thw->use_msix = 1;\n \t\t}\n \n",
    "prefixes": [
        "dpdk-dev"
    ]
}