Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/30722/?format=api
{ "id": 30722, "url": "http://patches.dpdk.org/api/patches/30722/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/d4ed88d2ba0c9905b832d2d6577368b49ac73564.1508768946.git.nelio.laranjeiro@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<d4ed88d2ba0c9905b832d2d6577368b49ac73564.1508768946.git.nelio.laranjeiro@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/d4ed88d2ba0c9905b832d2d6577368b49ac73564.1508768946.git.nelio.laranjeiro@6wind.com", "date": "2017-10-23T14:49:56", "name": "[dpdk-dev,v2,6/7] net/mlx5: fix reception when VLAN is added", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "eeaec0445e6dd5d5a40265fa1c4ab5d233fbf3b2", "submitter": { "id": 243, "url": "http://patches.dpdk.org/api/people/243/?format=api", "name": "Nélio Laranjeiro", "email": "nelio.laranjeiro@6wind.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/d4ed88d2ba0c9905b832d2d6577368b49ac73564.1508768946.git.nelio.laranjeiro@6wind.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/30722/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/30722/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6D8A31B666;\n\tMon, 23 Oct 2017 16:50:31 +0200 (CEST)", "from mail-wm0-f65.google.com (mail-wm0-f65.google.com\n\t[74.125.82.65]) by dpdk.org (Postfix) with ESMTP id 85D9E1B642\n\tfor <dev@dpdk.org>; Mon, 23 Oct 2017 16:50:18 +0200 (CEST)", "by mail-wm0-f65.google.com with SMTP id p75so10059604wmg.3\n\tfor <dev@dpdk.org>; Mon, 23 Oct 2017 07:50:18 -0700 (PDT)", "from laranjeiro-vm.dev.6wind.com.\n\t(host.78.145.23.62.rev.coltfrance.com. [62.23.145.78])\n\tby smtp.gmail.com with ESMTPSA id\n\ts196sm4908234wmb.26.2017.10.23.07.50.17\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 23 Oct 2017 07:50:17 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:in-reply-to:references;\n\tbh=XBPm7uUiHS7TPuxqXkPM4vsV4jdDDEPhueoeLtjfNmM=;\n\tb=KfAOiG67Ju/9OwDnMjRX/flMgqMhUIZMTH94vvstV9hQzte1JpzjzM46kX3XOkbhW/\n\t9p1wKLCqGSLrtsMv94SRjZ/b+Az9+Y+5nV/CRtvcbDSiACgi+yzdQ1NlZ1eNUBUPHx/x\n\tafvLx4vF1dTP2UyvaQQm/jOUhsybbwg1e+fHcasrgy+v/EWwc+ORnJEIrgyZUS6Pd6YF\n\tjqTM4dBEl8y8CjZwVapXf8oq3xfR2n6/nHCcZwKMPwDrINnBoA80FIixr9iamdroC3iz\n\tVx5tbn8qaLiaphoWw9eCuDDEMBFSKU1DOe5OcHEzy1rq2lu+cGj6Sd7UqihbHkdZvecJ\n\txUDA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:in-reply-to:references;\n\tbh=XBPm7uUiHS7TPuxqXkPM4vsV4jdDDEPhueoeLtjfNmM=;\n\tb=bjW1e0nce5HSRsYWq+cNRNTs1E7QYZDTe/3BkgH6PGTzWdvoGiF3Bnl9DshuWw+O9n\n\t8NNm1SVKpqaLH53jtW3prlg+u+jLmsMwL0O1zNeRuyL+HOdAu/hymd5TX7rwasQxO8l1\n\t7arf/uU4DPBuQGBSRe++g7XUHwO51Urw1E2HlYuhwkT/3MoyAWrbN7K1NFztcx6vnjr8\n\tLcMsfpMtgwZkOltX22Dd/8mtTEzT+FjJiIRDy5PJiDgkBT9zcR4Wus5Q1MA+Ef8eRoW8\n\tpw2hp3tdUJZs3ltvSgXrIycG6lTIiZ77L+hdwWpQy4hjKgz+kdH1wXDiUho3IR5SireJ\n\tVCUw==", "X-Gm-Message-State": "AMCzsaVSy4AfZYLKUmDE9N487JAIbuJlHj90t4VfXP2iKxJz7pMwM38O\n\t9WJoykmNno8si1N2kxv4TzJsDqz2GQ==", "X-Google-Smtp-Source": "ABhQp+SdFnVAsBTp+cxAlARg+eYrFL3z/srQP6rpodHiGjTO9WOcz5j4O3TqFfBFyrwtsDRJ28k67g==", "X-Received": "by 10.28.216.137 with SMTP id p131mr5284017wmg.50.1508770218049; \n\tMon, 23 Oct 2017 07:50:18 -0700 (PDT)", "From": "Nelio Laranjeiro <nelio.laranjeiro@6wind.com>", "To": "dev@dpdk.org", "Cc": "Yongseok Koh <yskoh@mellanox.com>,\n\tAdrien Mazarguil <adrien.mazarguil@6wind.com>", "Date": "Mon, 23 Oct 2017 16:49:56 +0200", "Message-Id": "<d4ed88d2ba0c9905b832d2d6577368b49ac73564.1508768946.git.nelio.laranjeiro@6wind.com>", "X-Mailer": "git-send-email 2.11.0", "In-Reply-To": [ "<cover.1508768946.git.nelio.laranjeiro@6wind.com>", "<cover.1508768946.git.nelio.laranjeiro@6wind.com>" ], "References": [ "<cover.1508768946.git.nelio.laranjeiro@6wind.com>", "<cover.1508417257.git.nelio.laranjeiro@6wind.com>\n\t<cover.1508768946.git.nelio.laranjeiro@6wind.com>" ], "Subject": "[dpdk-dev] [PATCH v2 6/7] net/mlx5: fix reception when VLAN is added", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When VLAN is enabled in the Rx side, only packets matching this VLAN are\nexpected, this also includes the broadcast and all multicast packets.\n\nFixes: 272733b5ebfd (\"net/mlx5: use flow to enable unicast traffic\")\nFixes: 6a6b6828fe6a (\"net/mlx5: use flow to enable all multi mode\")\n\nSigned-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>\n---\n drivers/net/mlx5/mlx5_trigger.c | 125 +++++++++++++++++++++-------------------\n 1 file changed, 66 insertions(+), 59 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_trigger.c b/drivers/net/mlx5/mlx5_trigger.c\nindex 29167badd..9b62c0e6a 100644\n--- a/drivers/net/mlx5/mlx5_trigger.c\n+++ b/drivers/net/mlx5/mlx5_trigger.c\n@@ -251,6 +251,29 @@ mlx5_dev_stop(struct rte_eth_dev *dev)\n int\n priv_dev_traffic_enable(struct priv *priv, struct rte_eth_dev *dev)\n {\n+\tstruct rte_flow_item_eth bcast = {\n+\t\t.dst.addr_bytes = \"\\xff\\xff\\xff\\xff\\xff\\xff\",\n+\t};\n+\tstruct rte_flow_item_eth ipv6_multi_spec = {\n+\t\t.dst.addr_bytes = \"\\x33\\x33\\x00\\x00\\x00\\x00\",\n+\t};\n+\tstruct rte_flow_item_eth ipv6_multi_mask = {\n+\t\t.dst.addr_bytes = \"\\xff\\xff\\x00\\x00\\x00\\x00\",\n+\t};\n+\tstruct rte_flow_item_eth unicast = {\n+\t\t.src.addr_bytes = \"\\x00\\x00\\x00\\x00\\x00\\x00\",\n+\t};\n+\tstruct rte_flow_item_eth unicast_mask = {\n+\t\t.dst.addr_bytes = \"\\xff\\xff\\xff\\xff\\xff\\xff\",\n+\t};\n+\tconst unsigned int vlan_filter_n = priv->vlan_filter_n;\n+\tconst struct ether_addr cmp = {\n+\t\t.addr_bytes = \"\\x00\\x00\\x00\\x00\\x00\\x00\",\n+\t};\n+\tunsigned int i;\n+\tunsigned int j;\n+\tint ret;\n+\n \tif (priv->isolated)\n \t\treturn 0;\n \tif (dev->data->promiscuous) {\n@@ -261,75 +284,59 @@ priv_dev_traffic_enable(struct priv *priv, struct rte_eth_dev *dev)\n \t\t};\n \n \t\tclaim_zero(mlx5_ctrl_flow(dev, &promisc, &promisc));\n-\t} else if (dev->data->all_multicast) {\n+\t\treturn 0;\n+\t}\n+\tif (dev->data->all_multicast) {\n \t\tstruct rte_flow_item_eth multicast = {\n \t\t\t.dst.addr_bytes = \"\\x01\\x00\\x00\\x00\\x00\\x00\",\n-\t\t\t.src.addr_bytes = \"\\x01\\x00\\x00\\x00\\x00\\x00\",\n+\t\t\t.src.addr_bytes = \"\\x00\\x00\\x00\\x00\\x00\\x00\",\n \t\t\t.type = 0,\n \t\t};\n \n \t\tclaim_zero(mlx5_ctrl_flow(dev, &multicast, &multicast));\n-\t} else {\n-\t\tstruct rte_flow_item_eth bcast = {\n-\t\t\t.dst.addr_bytes = \"\\xff\\xff\\xff\\xff\\xff\\xff\",\n-\t\t};\n-\t\tstruct rte_flow_item_eth ipv6_multi_spec = {\n-\t\t\t.dst.addr_bytes = \"\\x33\\x33\\x00\\x00\\x00\\x00\",\n-\t\t};\n-\t\tstruct rte_flow_item_eth ipv6_multi_mask = {\n-\t\t\t.dst.addr_bytes = \"\\xff\\xff\\x00\\x00\\x00\\x00\",\n-\t\t};\n-\t\tstruct rte_flow_item_eth unicast = {\n-\t\t\t.src.addr_bytes = \"\\x00\\x00\\x00\\x00\\x00\\x00\",\n-\t\t};\n-\t\tstruct rte_flow_item_eth unicast_mask = {\n-\t\t\t.dst.addr_bytes = \"\\xff\\xff\\xff\\xff\\xff\\xff\",\n-\t\t};\n-\t\tconst unsigned int vlan_filter_n = priv->vlan_filter_n;\n-\t\tconst struct ether_addr cmp = {\n-\t\t\t.addr_bytes = \"\\x00\\x00\\x00\\x00\\x00\\x00\",\n-\t\t};\n-\t\tunsigned int i;\n-\t\tunsigned int j;\n-\t\tunsigned int unicast_flow = 0;\n-\t\tint ret;\n-\n-\t\tfor (i = 0; i != MLX5_MAX_MAC_ADDRESSES; ++i) {\n-\t\t\tstruct ether_addr *mac = &dev->data->mac_addrs[i];\n+\t}\n+\tfor (i = 0; i != MLX5_MAX_MAC_ADDRESSES; ++i) {\n+\t\tstruct ether_addr *mac = &dev->data->mac_addrs[i];\n \n-\t\t\tif (!memcmp(mac, &cmp, sizeof(*mac)))\n-\t\t\t\tcontinue;\n-\t\t\tmemcpy(&unicast.dst.addr_bytes,\n-\t\t\t mac->addr_bytes,\n-\t\t\t ETHER_ADDR_LEN);\n-\t\t\tfor (j = 0; j != vlan_filter_n; ++j) {\n-\t\t\t\tuint16_t vlan = priv->vlan_filter[j];\n+\t\tif (!memcmp(mac, &cmp, sizeof(*mac)))\n+\t\t\tcontinue;\n+\t\tmemcpy(&unicast.dst.addr_bytes,\n+\t\t mac->addr_bytes,\n+\t\t ETHER_ADDR_LEN);\n+\t\tfor (j = 0; j != vlan_filter_n; ++j) {\n+\t\t\tuint16_t vlan = priv->vlan_filter[j];\n \n-\t\t\t\tstruct rte_flow_item_vlan vlan_spec = {\n-\t\t\t\t\t.tci = rte_cpu_to_be_16(vlan),\n-\t\t\t\t};\n-\t\t\t\tstruct rte_flow_item_vlan vlan_mask = {\n-\t\t\t\t\t.tci = 0xffff,\n-\t\t\t\t};\n+\t\t\tstruct rte_flow_item_vlan vlan_spec = {\n+\t\t\t\t.tci = rte_cpu_to_be_16(vlan),\n+\t\t\t};\n+\t\t\tstruct rte_flow_item_vlan vlan_mask = {\n+\t\t\t\t.tci = 0xffff,\n+\t\t\t};\n \n-\t\t\t\tret = mlx5_ctrl_flow_vlan(dev, &unicast,\n-\t\t\t\t\t\t\t &unicast_mask,\n-\t\t\t\t\t\t\t &vlan_spec,\n-\t\t\t\t\t\t\t &vlan_mask);\n-\t\t\t\tif (ret)\n-\t\t\t\t\tgoto error;\n-\t\t\t\tunicast_flow = 1;\n-\t\t\t}\n-\t\t\tif (!vlan_filter_n) {\n-\t\t\t\tret = mlx5_ctrl_flow(dev, &unicast,\n-\t\t\t\t\t\t &unicast_mask);\n-\t\t\t\tif (ret)\n-\t\t\t\t\tgoto error;\n-\t\t\t\tunicast_flow = 1;\n-\t\t\t}\n+\t\t\tret = mlx5_ctrl_flow_vlan(dev, &unicast,\n+\t\t\t\t\t\t &unicast_mask,\n+\t\t\t\t\t\t &vlan_spec,\n+\t\t\t\t\t\t &vlan_mask);\n+\t\t\tif (ret)\n+\t\t\t\tgoto error;\n+\t\t\tret = mlx5_ctrl_flow_vlan(dev, &bcast, &bcast,\n+\t\t\t\t\t\t &vlan_spec, &vlan_mask);\n+\t\t\tif (ret)\n+\t\t\t\tgoto error;\n+\t\t\tret = mlx5_ctrl_flow_vlan(dev, &ipv6_multi_spec,\n+\t\t\t\t\t\t &ipv6_multi_mask,\n+\t\t\t\t\t\t &vlan_spec, &vlan_mask);\n+\t\t\tif (ret)\n+\t\t\t\tgoto error;\n \t\t}\n-\t\tif (!unicast_flow)\n-\t\t\treturn 0;\n+\t\tif (!vlan_filter_n) {\n+\t\t\tret = mlx5_ctrl_flow(dev, &unicast,\n+\t\t\t\t\t &unicast_mask);\n+\t\t\tif (ret)\n+\t\t\t\tgoto error;\n+\t\t}\n+\t}\n+\tif (!dev->data->all_multicast && !vlan_filter_n) {\n \t\tret = mlx5_ctrl_flow(dev, &bcast, &bcast);\n \t\tif (ret)\n \t\t\tgoto error;\n", "prefixes": [ "dpdk-dev", "v2", "6/7" ] }