Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/30515/?format=api
{ "id": 30515, "url": "http://patches.dpdk.org/api/patches/30515/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20171018095019.42807-1-zhiyong.yang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20171018095019.42807-1-zhiyong.yang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20171018095019.42807-1-zhiyong.yang@intel.com", "date": "2017-10-18T09:50:19", "name": "[dpdk-dev] examples/l2fwd-crypto: fix port id type", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a3d27c17972b398955fcf4d616b39194e9deb4c0", "submitter": { "id": 540, "url": "http://patches.dpdk.org/api/people/540/?format=api", "name": "Yang, Zhiyong", "email": "zhiyong.yang@intel.com" }, "delegate": { "id": 22, "url": "http://patches.dpdk.org/api/users/22/?format=api", "username": "pdelarag", "first_name": "Pablo", "last_name": "de Lara Guarch", "email": "pablo.de.lara.guarch@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20171018095019.42807-1-zhiyong.yang@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/30515/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/30515/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 470B71B3D9;\n\tWed, 18 Oct 2017 11:50:25 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id EBFB21B397\n\tfor <dev@dpdk.org>; Wed, 18 Oct 2017 11:50:23 +0200 (CEST)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t18 Oct 2017 02:50:22 -0700", "from unknown (HELO dpdk5.bj.intel.com) ([172.16.182.182])\n\tby fmsmga005.fm.intel.com with ESMTP; 18 Oct 2017 02:50:21 -0700" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.43,395,1503385200\"; d=\"scan'208\";a=\"163966322\"", "From": "Zhiyong Yang <zhiyong.yang@intel.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com,\n\tZhiyong Yang <zhiyong.yang@intel.com>", "Date": "Wed, 18 Oct 2017 17:50:19 +0800", "Message-Id": "<20171018095019.42807-1-zhiyong.yang@intel.com>", "X-Mailer": "git-send-email 2.13.3", "Subject": "[dpdk-dev] [PATCH] examples/l2fwd-crypto: fix port id type", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Fix port id issue and remove unnecessary cast.\n\nFixes: f8244c6399d9 (\"ethdev: increase port id range\")\nSigned-off-by: Zhiyong Yang <zhiyong.yang@intel.com>\n---\n examples/l2fwd-crypto/main.c | 30 ++++++++++++++++--------------\n 1 file changed, 16 insertions(+), 14 deletions(-)", "diff": "diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c\nindex 7dfcba421..3408938aa 100644\n--- a/examples/l2fwd-crypto/main.c\n+++ b/examples/l2fwd-crypto/main.c\n@@ -647,7 +647,7 @@ l2fwd_simple_forward(struct rte_mbuf *m, unsigned int portid,\n \tif (options->mac_updating)\n \t\tl2fwd_mac_updating(m, dst_port);\n \n-\tl2fwd_send_packet(m, (uint8_t) dst_port);\n+\tl2fwd_send_packet(m, dst_port);\n }\n \n /** Generate random key */\n@@ -719,7 +719,8 @@ l2fwd_main_loop(struct l2fwd_crypto_options *options)\n \n \tunsigned lcore_id = rte_lcore_id();\n \tuint64_t prev_tsc = 0, diff_tsc, cur_tsc, timer_tsc = 0;\n-\tunsigned i, j, portid, nb_rx, len;\n+\tunsigned int i, j, nb_rx, len;\n+\tuint16_t portid;\n \tstruct lcore_queue_conf *qconf = &lcore_queue_conf[lcore_id];\n \tconst uint64_t drain_tsc = (rte_get_tsc_hz() + US_PER_S - 1) /\n \t\t\tUS_PER_S * BURST_TX_DRAIN_US;\n@@ -884,7 +885,7 @@ l2fwd_main_loop(struct l2fwd_crypto_options *options)\n \t\t\t\t\tcontinue;\n \t\t\t\tl2fwd_send_burst(&lcore_queue_conf[lcore_id],\n \t\t\t\t\t\t qconf->pkt_buf[portid].len,\n-\t\t\t\t\t\t (uint8_t) portid);\n+\t\t\t\t\t\t portid);\n \t\t\t\tqconf->pkt_buf[portid].len = 0;\n \t\t\t}\n \n@@ -918,7 +919,7 @@ l2fwd_main_loop(struct l2fwd_crypto_options *options)\n \n \t\t\tcparams = &port_cparams[i];\n \n-\t\t\tnb_rx = rte_eth_rx_burst((uint8_t) portid, 0,\n+\t\t\tnb_rx = rte_eth_rx_burst(portid, 0,\n \t\t\t\t\t\t pkts_burst, MAX_PKT_BURST);\n \n \t\t\tport_statistics[portid].rx += nb_rx;\n@@ -2342,7 +2343,7 @@ initialize_cryptodevs(struct l2fwd_crypto_options *options, unsigned nb_ports,\n static int\n initialize_ports(struct l2fwd_crypto_options *options)\n {\n-\tuint8_t last_portid, portid;\n+\tuint16_t last_portid, portid;\n \tunsigned enabled_portcount = 0;\n \tunsigned nb_ports = rte_eth_dev_count();\n \n@@ -2363,12 +2364,12 @@ initialize_ports(struct l2fwd_crypto_options *options)\n \t\t\tcontinue;\n \n \t\t/* init port */\n-\t\tprintf(\"Initializing port %u... \", (unsigned) portid);\n+\t\tprintf(\"Initializing port %u... \", portid);\n \t\tfflush(stdout);\n \t\tretval = rte_eth_dev_configure(portid, 1, 1, &port_conf);\n \t\tif (retval < 0) {\n \t\t\tprintf(\"Cannot configure device: err=%d, port=%u\\n\",\n-\t\t\t\t retval, (unsigned) portid);\n+\t\t\t\t retval, portid);\n \t\t\treturn -1;\n \t\t}\n \n@@ -2376,7 +2377,7 @@ initialize_ports(struct l2fwd_crypto_options *options)\n \t\t\t\t\t\t\t &nb_txd);\n \t\tif (retval < 0) {\n \t\t\tprintf(\"Cannot adjust number of descriptors: err=%d, port=%u\\n\",\n-\t\t\t\tretval, (unsigned) portid);\n+\t\t\t\tretval, portid);\n \t\t\treturn -1;\n \t\t}\n \n@@ -2387,7 +2388,7 @@ initialize_ports(struct l2fwd_crypto_options *options)\n \t\t\t\t\t NULL, l2fwd_pktmbuf_pool);\n \t\tif (retval < 0) {\n \t\t\tprintf(\"rte_eth_rx_queue_setup:err=%d, port=%u\\n\",\n-\t\t\t\t\tretval, (unsigned) portid);\n+\t\t\t\t\tretval, portid);\n \t\t\treturn -1;\n \t\t}\n \n@@ -2398,7 +2399,7 @@ initialize_ports(struct l2fwd_crypto_options *options)\n \t\t\t\tNULL);\n \t\tif (retval < 0) {\n \t\t\tprintf(\"rte_eth_tx_queue_setup:err=%d, port=%u\\n\",\n-\t\t\t\tretval, (unsigned) portid);\n+\t\t\t\tretval, portid);\n \n \t\t\treturn -1;\n \t\t}\n@@ -2407,7 +2408,7 @@ initialize_ports(struct l2fwd_crypto_options *options)\n \t\tretval = rte_eth_dev_start(portid);\n \t\tif (retval < 0) {\n \t\t\tprintf(\"rte_eth_dev_start:err=%d, port=%u\\n\",\n-\t\t\t\t\tretval, (unsigned) portid);\n+\t\t\t\t\tretval, portid);\n \t\t\treturn -1;\n \t\t}\n \n@@ -2416,7 +2417,7 @@ initialize_ports(struct l2fwd_crypto_options *options)\n \t\trte_eth_macaddr_get(portid, &l2fwd_ports_eth_addr[portid]);\n \n \t\tprintf(\"Port %u, MAC address: %02X:%02X:%02X:%02X:%02X:%02X\\n\\n\",\n-\t\t\t\t(unsigned) portid,\n+\t\t\t\tportid,\n \t\t\t\tl2fwd_ports_eth_addr[portid].addr_bytes[0],\n \t\t\t\tl2fwd_ports_eth_addr[portid].addr_bytes[1],\n \t\t\t\tl2fwd_ports_eth_addr[portid].addr_bytes[2],\n@@ -2493,7 +2494,8 @@ main(int argc, char **argv)\n \tstruct lcore_queue_conf *qconf;\n \tstruct l2fwd_crypto_options options;\n \n-\tuint8_t nb_ports, nb_cryptodevs, portid, cdev_id;\n+\tuint8_t nb_cryptodevs, cdev_id;\n+\tuint16_t nb_ports, portid;\n \tunsigned lcore_id, rx_lcore_id;\n \tint ret, enabled_cdevcount, enabled_portcount;\n \tuint8_t enabled_cdevs[RTE_CRYPTO_MAX_DEVS] = {0};\n@@ -2570,7 +2572,7 @@ main(int argc, char **argv)\n \t\tqconf->rx_port_list[qconf->nb_rx_ports] = portid;\n \t\tqconf->nb_rx_ports++;\n \n-\t\tprintf(\"Lcore %u: RX port %u\\n\", rx_lcore_id, (unsigned)portid);\n+\t\tprintf(\"Lcore %u: RX port %u\\n\", rx_lcore_id, portid);\n \t}\n \n \t/* Enable Crypto devices */\n", "prefixes": [ "dpdk-dev" ] }