Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/30351/?format=api
{ "id": 30351, "url": "http://patches.dpdk.org/api/patches/30351/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/8b28426c813b6811a15ee18d51d44dae748b04c8.1507896510.git.nelio.laranjeiro@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<8b28426c813b6811a15ee18d51d44dae748b04c8.1507896510.git.nelio.laranjeiro@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/8b28426c813b6811a15ee18d51d44dae748b04c8.1507896510.git.nelio.laranjeiro@6wind.com", "date": "2017-10-13T12:09:45", "name": "[dpdk-dev,2/2] app/testpmd: fix RSS structure initialisation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "6f78f885003dab72b5c6e13984ced96940baac02", "submitter": { "id": 243, "url": "http://patches.dpdk.org/api/people/243/?format=api", "name": "Nélio Laranjeiro", "email": "nelio.laranjeiro@6wind.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/8b28426c813b6811a15ee18d51d44dae748b04c8.1507896510.git.nelio.laranjeiro@6wind.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/30351/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/30351/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A896F1B674;\n\tFri, 13 Oct 2017 14:10:13 +0200 (CEST)", "from mail-wm0-f47.google.com (mail-wm0-f47.google.com\n\t[74.125.82.47]) by dpdk.org (Postfix) with ESMTP id C160A1B65D\n\tfor <dev@dpdk.org>; Fri, 13 Oct 2017 14:10:10 +0200 (CEST)", "by mail-wm0-f47.google.com with SMTP id 196so27800065wma.1\n\tfor <dev@dpdk.org>; Fri, 13 Oct 2017 05:10:10 -0700 (PDT)", "from laranjeiro-vm.dev.6wind.com.\n\t(host.78.145.23.62.rev.coltfrance.com. [62.23.145.78])\n\tby smtp.gmail.com with ESMTPSA id\n\tr123sm802284wmf.41.2017.10.13.05.10.09\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 13 Oct 2017 05:10:09 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:in-reply-to:references;\n\tbh=S1+CykoHg2nMD8y3QlaLImN7gAUwmoX/K/mxIJ95As4=;\n\tb=TtJLjveorecsCtd6MfMKaQpzZIfIxbIHeH1bDEMh69FeLRVxlAZSiYk2PKVvUuHV7W\n\twS7MHp6V08INJxNQUeeCKNM1PizCPJ3PwTseg5ocASls/mb2u8espHEayTwRq4cHBopS\n\tpmXyDh6Kq1jrd+nVoO4sGYiMnjzd3sSPOC1Qq93a3JgIz3/w4gP86//dSh/0G7Z8KLTg\n\tSuIZHO2AQ0+sfaqRormYTeP6ygPWFblnTjDjzvGPI1QDNtbLkBQxmFepiFOthK1QxiiM\n\tWfLs7crT9zjZcw0+BI0hWyxjzCa3yjHgX4pU/0SZliN4pTzKteLbqedgPayKfgWCHjL0\n\t/Ciw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:in-reply-to:references;\n\tbh=S1+CykoHg2nMD8y3QlaLImN7gAUwmoX/K/mxIJ95As4=;\n\tb=KFvfRV3OfrdmINs0c5wPXJhK+NtmiLbkV1X5CCzaj3ykUelghNrXb5Y7lCo8ERzAi3\n\tuwqzsqTc64Ll3vmecnoYLKWKi+Yla6ooK4zZApBFJps6xbTiKQtsiCYYwTfRLqSSRfte\n\tpdj8tzOBe6A8NJtS+mOFQ/kDo0obzo27T6YdOI/nZAfrhQHFptYJQ25iLJHiHQdLPBvo\n\tIYSefaLUct4iDVD03zdHlc7lt8EGhLpa8v1rdXzYaO4moMbTIBGtjQO3PZeCIiUTEef1\n\tRAlPi8C+hsnH55/HYz0h7hCrcwECncz8ZSVstIPX3vXsQrRo7J3fglifLllEQQewn5uz\n\tClkQ==", "X-Gm-Message-State": "AMCzsaXLrwh+ox2dFMbIed8DZMDbWYQrHVnIcI3fcR+qcQoXcIBETQUA\n\tqSMiNZAbkWyLJP3Pz9+17vMwKuK24Q==", "X-Google-Smtp-Source": "AOwi7QC0xcBr6IRnPP+TuvxxZ+if5TuBOQ8vCnqzVctBKruiuyw8kzT6nltTldJBOBG6WgsbqkOXTw==", "X-Received": "by 10.223.173.165 with SMTP id w34mr1255783wrc.22.1507896610039; \n\tFri, 13 Oct 2017 05:10:10 -0700 (PDT)", "From": "Nelio Laranjeiro <nelio.laranjeiro@6wind.com>", "To": "dev@dpdk.org", "Cc": "Yongseok Koh <yskoh@mellanox.com>,\n\tAdrien Mazarguil <adrien.mazarguil@6wind.com>, ivan.boule@6wind.com, \n\tstable@dpdk.org", "Date": "Fri, 13 Oct 2017 14:09:45 +0200", "Message-Id": "<8b28426c813b6811a15ee18d51d44dae748b04c8.1507896510.git.nelio.laranjeiro@6wind.com>", "X-Mailer": "git-send-email 2.11.0", "In-Reply-To": [ "<b014d4116d1fe8ce46a641f00e7a2a8ac8b9e61f.1507896510.git.nelio.laranjeiro@6wind.com>", "<b014d4116d1fe8ce46a641f00e7a2a8ac8b9e61f.1507896510.git.nelio.laranjeiro@6wind.com>" ], "References": [ "<b014d4116d1fe8ce46a641f00e7a2a8ac8b9e61f.1507896510.git.nelio.laranjeiro@6wind.com>", "<b014d4116d1fe8ce46a641f00e7a2a8ac8b9e61f.1507896510.git.nelio.laranjeiro@6wind.com>" ], "Subject": "[dpdk-dev] [PATCH 2/2] app/testpmd: fix RSS structure initialisation", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Struct rss_conf.rss_key_len is not initialised forcing the user to verify\nthe rss_conf.rss_key pointer to know if the key is present or not.\nrss_conf.rss_key_len should have a valid length according to the size of\nthe rss_key pointed.\n\nFixes: 560e02ee5237 (\"app/testpmd: configure RSS without restart\")\nCc: ivan.boule@6wind.com\nCc: stable@dpdk.org\n\nSigned-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>\nAcked-by: Yongseok Koh <yskoh@mellanox.com>\n---\n app/test-pmd/cmdline.c | 2 +-\n drivers/net/mlx5/mlx5_rss.c | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c\nindex 120460452..abbe52ad6 100644\n--- a/app/test-pmd/cmdline.c\n+++ b/app/test-pmd/cmdline.c\n@@ -1750,7 +1750,7 @@ cmd_config_rss_parsed(void *parsed_result,\n \t\t\t__attribute__((unused)) void *data)\n {\n \tstruct cmd_config_rss *res = parsed_result;\n-\tstruct rte_eth_rss_conf rss_conf;\n+\tstruct rte_eth_rss_conf rss_conf = { .rss_key_len = 0, };\n \tint diag;\n \tuint8_t i;\n \ndiff --git a/drivers/net/mlx5/mlx5_rss.c b/drivers/net/mlx5/mlx5_rss.c\nindex ad6d9ab70..dd9ddf2e0 100644\n--- a/drivers/net/mlx5/mlx5_rss.c\n+++ b/drivers/net/mlx5/mlx5_rss.c\n@@ -72,7 +72,7 @@ mlx5_rss_hash_update(struct rte_eth_dev *dev,\n \tint ret = 0;\n \n \tpriv_lock(priv);\n-\tif (rss_conf->rss_key_len) {\n+\tif (rss_conf->rss_key && rss_conf->rss_key_len) {\n \t\tpriv->rss_conf.rss_key = rte_realloc(priv->rss_conf.rss_key,\n \t\t\t\t\t\t rss_conf->rss_key_len, 0);\n \t\tif (!priv->rss_conf.rss_key) {\n", "prefixes": [ "dpdk-dev", "2/2" ] }