Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/30301/?format=api
{ "id": 30301, "url": "http://patches.dpdk.org/api/patches/30301/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20171012131554.1533-7-luca.boccassi@gmail.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20171012131554.1533-7-luca.boccassi@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20171012131554.1533-7-luca.boccassi@gmail.com", "date": "2017-10-12T13:15:54", "name": "[dpdk-dev,v8,6/6] mk: install symlinks before build step", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "4ac84073890e33c67b8cdec4ae3104860aac5910", "submitter": { "id": 566, "url": "http://patches.dpdk.org/api/people/566/?format=api", "name": "Luca Boccassi", "email": "luca.boccassi@gmail.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20171012131554.1533-7-luca.boccassi@gmail.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/30301/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/30301/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 50CD91B37F;\n\tThu, 12 Oct 2017 15:16:48 +0200 (CEST)", "from mail-wm0-f67.google.com (mail-wm0-f67.google.com\n\t[74.125.82.67]) by dpdk.org (Postfix) with ESMTP id 41D5D1B324\n\tfor <dev@dpdk.org>; Thu, 12 Oct 2017 15:16:47 +0200 (CEST)", "by mail-wm0-f67.google.com with SMTP id q124so13139463wmb.0\n\tfor <dev@dpdk.org>; Thu, 12 Oct 2017 06:16:47 -0700 (PDT)", "from localhost ([213.251.34.151]) by smtp.gmail.com with ESMTPSA id\n\ti6sm10438726edk.3.2017.10.12.06.16.45\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 12 Oct 2017 06:16:45 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=UnRK+OqDCqwk0KqNckkvhUMdx+9OQoDnEuWKIMpRhaU=;\n\tb=Vtr5Z0PMy53TcDR9CKAlNz2USF/NAAlBQfHAeNDv4yAuEYRcqLIUg11LP7NDJyRiGS\n\t45MC6aLT+jGl4LjF1jjddgAvz4vwR8/rf4FA60NLw/tCYmCKo3Vx8VrG8kb7QqeXeuzG\n\tf/Rr3DRy9LEz3XUncrL/mr321vSN59gNNuduzGhiC3GsI1HtimjN0AkRhxftLbOTDxNe\n\twbSVpEvxol/Hrysq32ZTS/O599f1br3vAbOsftNyXfQ7gTY0BLHqnngiYWhdneeNAmxy\n\tlaZ/r0t8GyR1RwOVq41ONqAwxpllwMIR2DMepimApOjGnEWr8PmR/vc6NhK0Fjw9yeK5\n\tDyTA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=UnRK+OqDCqwk0KqNckkvhUMdx+9OQoDnEuWKIMpRhaU=;\n\tb=fF/3+oncoNuHCGHl9ooh8LZVMLTnaITq6jRIu5cBjpMQ68ADtpPTRx9sOSJbnowAyC\n\txQemNnBdjWC+RagZI1dA88KOBLRI3QJu8uvLN/MU8IAxbtmJmNlQM7DOISnOWLXje5Ap\n\t7IptdR3XY9DDM3Z2/ZncVSmfPmSjxMFPp0ouU67HPiXI6+Hvu1KwTkdTHEltfkOKvOLd\n\tOTEGFNy0pRV7Yf0ep8a7BhD2Kz8Rmu7osQfpDgqusRA3Y50S17oHtrTnbZZarbWyNRYe\n\tzRRz2SV0weYTKCbMsaQJCpoBV/PspzRquvFx6E0lCAHnWXDRRXK/2Pr12AllRXDlc4Fm\n\t1VDA==", "X-Gm-Message-State": "AMCzsaV7f3Fu7pPt7btJUuMWH2to3ozA1AcUJX98oz5/+gdvQ6g4XtiH\n\t4mopxPPvLfMCGBk3lz7OBcNBd+B4", "X-Google-Smtp-Source": "AOwi7QCoYV1lkMwNeGWGMKSrr7eDXH5uYkNBysXzuObKtnfVCM11Qryz6yzqg1Jmq93J6pWvLfgBJw==", "X-Received": "by 10.80.151.71 with SMTP id d7mr2812474edb.236.1507814206664;\n\tThu, 12 Oct 2017 06:16:46 -0700 (PDT)", "From": "luca.boccassi@gmail.com", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, thomas@monjalon.net,\n\tLuca Boccassi <luca.boccassi@gmail.com>", "Date": "Thu, 12 Oct 2017 14:15:54 +0100", "Message-Id": "<20171012131554.1533-7-luca.boccassi@gmail.com>", "X-Mailer": "git-send-email 2.11.0", "In-Reply-To": "<20171012131554.1533-1-luca.boccassi@gmail.com>", "References": "<20170905205159.8606-1-luca.boccassi@gmail.com>\n\t<20171012131554.1533-1-luca.boccassi@gmail.com>", "Subject": "[dpdk-dev] [PATCH v8 6/6] mk: install symlinks before build step", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Luca Boccassi <luca.boccassi@gmail.com>\n\nA race condition can happen during parallel builds, where a header\nmight be installed in RTE_OUT/include before CFLAGS is recursively\nexpanded. This causes GCC to sometimes pick the header path as\nSRCDIR/... and sometimes as RTE_OUT/include/... making the build\nunreproducible, as the full path is used for the expansion of\n__FILE__ and in the DWARF directory listing.\n\nInstalling all symlinks before all builds solves the problem. It is\nstill suboptimal, as the (fixed) path recorded in the DWARF dir\nlisting will include the user-configurable build output directory,\nand thus will result in a different binary between different users\ndespite all other conditions being equal, but it is a simpler\napproach that will anyway be obsolete once the build system is\nswitched to Meson.\n\nSuggested-by: Ferruh Yigit <ferruh.yigit@intel.com>\nSigned-off-by: Luca Boccassi <luca.boccassi@gmail.com>\n---\n mk/rte.lib.mk | 8 +++++++-\n 1 file changed, 7 insertions(+), 1 deletion(-)", "diff": "diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk\nindex 13115d146..4767ce4f2 100644\n--- a/mk/rte.lib.mk\n+++ b/mk/rte.lib.mk\n@@ -59,14 +59,20 @@ endif\n \n \n _BUILD = $(LIB)\n-_INSTALL = $(INSTALL-FILES-y) $(SYMLINK-FILES-y) $(RTE_OUTPUT)/lib/$(LIB)\n+PREINSTALL = $(SYMLINK-FILES-y)\n+_INSTALL = $(INSTALL-FILES-y) $(RTE_OUTPUT)/lib/$(LIB)\n _CLEAN = doclean\n \n .PHONY: all\n all: install\n \n .PHONY: install\n+ifeq ($(SYMLINK-FILES-y),)\n install: build _postinstall\n+else\n+install: _preinstall build _postinstall\n+build: _preinstall\n+endif\n \n _postinstall: build\n \n", "prefixes": [ "dpdk-dev", "v8", "6/6" ] }