Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/30201/?format=api
{ "id": 30201, "url": "http://patches.dpdk.org/api/patches/30201/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/c811b0896c26d5b435dcb6d2fc70d6f3c9091901.1507796100.git.gaetan.rivet@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<c811b0896c26d5b435dcb6d2fc70d6f3c9091901.1507796100.git.gaetan.rivet@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/c811b0896c26d5b435dcb6d2fc70d6f3c9091901.1507796100.git.gaetan.rivet@6wind.com", "date": "2017-10-12T08:21:16", "name": "[dpdk-dev,v2,09/18] devargs: make parsing variadic", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "78de3e249a17644d68a0c2a79dffcec2105b45c8", "submitter": { "id": 269, "url": "http://patches.dpdk.org/api/people/269/?format=api", "name": "Gaëtan Rivet", "email": "gaetan.rivet@6wind.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/c811b0896c26d5b435dcb6d2fc70d6f3c9091901.1507796100.git.gaetan.rivet@6wind.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/30201/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/30201/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 02A071B1F1;\n\tThu, 12 Oct 2017 10:22:00 +0200 (CEST)", "from mail-wm0-f47.google.com (mail-wm0-f47.google.com\n\t[74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 9E49B1B1B2\n\tfor <dev@dpdk.org>; Thu, 12 Oct 2017 10:21:52 +0200 (CEST)", "by mail-wm0-f47.google.com with SMTP id b189so10781802wmd.4\n\tfor <dev@dpdk.org>; Thu, 12 Oct 2017 01:21:52 -0700 (PDT)", "from bidouze.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com.\n\t[62.23.145.78]) by smtp.gmail.com with ESMTPSA id\n\t200sm19424728wmu.44.2017.10.12.01.21.50\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tThu, 12 Oct 2017 01:21:50 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:in-reply-to:references;\n\tbh=O0HDpyKLtTwLaYsqKb0GUS052IrEzfb2mLu4xSqlUkE=;\n\tb=lE/Y3pbH6rGER1xXCu+hU/yeDnOM4ObU1K5Hc3a7mb5pLGJown+9wW5nD4wONrnS89\n\tShBy2T7r7hgeo4bAc1qKaHD0FwffEkjXP+Qa8I4ibBG++UtivPG53mzvT7ykD9jX2vsV\n\tX6QoWIbLo6LtJkl4GJY5zKu6gD11a5VbWuhGNTq4w5xRlVdYAd9G4wBEfl3we/adbm6H\n\tRkX330/GQt7Gqmm3PhL+YHKhJZe/EyKF0qqGMQbpOX9ea46ToKniT1JLfqV9KKbg8wj9\n\t/gkeqOxeQ78MbeTJHHPwPx0aeMo98aLh06EU/ebIzpKlJwmk637a9QvSzBu51TdE3YaK\n\t4ntQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:in-reply-to:references;\n\tbh=O0HDpyKLtTwLaYsqKb0GUS052IrEzfb2mLu4xSqlUkE=;\n\tb=S4P+xaGK5Ch+tNhSmjeF2ZPx2TFVBPZI0Q4SgkXzanS78hQ4SWe6Q5BPUFWG3Mlc0B\n\t6XksRc8y6iXJl8n8YaCEmz/TfU3njvOqesfZoZpvta3TFMEfHQ7zxhgbXIrI1f5Lx7sS\n\trxhz2ZE38F7dES4Ewz1+HZqRQ0CBu9XCd3nizt8T4Up77Z+Jx0qoHFK6kt/NR2IgMOTX\n\tQT02yvQpfG2agD+njQEIz7N4a+kvE/Lt7Z5k714MbD3uaTty5yzZpOo0QwYO3aLtBpD5\n\ta01gV4ytLcOrBuDrsZWiGb12GcD77CdksHlB6ra0zC0SGmy8Ie7MLNBYILJt/z2GcMDo\n\t+lhA==", "X-Gm-Message-State": "AMCzsaUo48rV+8oTkHvvnb4xPVzIOHaIDzgEsNGlrxv0Dtd5TRzu+XSi\n\txLgmNujKNtJpJ6RwOgbWLYSg09zS", "X-Google-Smtp-Source": "AOwi7QB3/gwab8q3caxy2BBbObF/Uj4Iz8bdNQZv3TU8InuQIDtj7BSxbxSJVvphdf8olMhrlm5CGg==", "X-Received": "by 10.223.171.236 with SMTP id s99mr1257684wrc.27.1507796511788; \n\tThu, 12 Oct 2017 01:21:51 -0700 (PDT)", "From": "Gaetan Rivet <gaetan.rivet@6wind.com>", "To": "dev@dpdk.org", "Cc": "Gaetan Rivet <gaetan.rivet@6wind.com>", "Date": "Thu, 12 Oct 2017 10:21:16 +0200", "Message-Id": "<c811b0896c26d5b435dcb6d2fc70d6f3c9091901.1507796100.git.gaetan.rivet@6wind.com>", "X-Mailer": "git-send-email 2.1.4", "In-Reply-To": [ "<cover.1507796100.git.gaetan.rivet@6wind.com>", "<cover.1507796100.git.gaetan.rivet@6wind.com>" ], "References": [ "<cover.1503676587.git.gaetan.rivet@6wind.com>\n\t<cover.1507796100.git.gaetan.rivet@6wind.com>", "<cover.1507796100.git.gaetan.rivet@6wind.com>" ], "Subject": "[dpdk-dev] [PATCH v2 09/18] devargs: make parsing variadic", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "rte_eal_devargs_parse can be used by EAL subsystems, drivers,\napplications alike.\n\nDevice parameters may be presented with different structure each time;\nas a single declaration string or several strings each describing\ndifferent parts of the declaration.\n\nTo simplify the use of this parsing facility, its parameters are made\nvariadic.\n\nSigned-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>\n---\n drivers/net/failsafe/failsafe_args.c | 2 +-\n lib/librte_eal/common/eal_common_dev.c | 33 ++++-------------------------\n lib/librte_eal/common/eal_common_devargs.c | 15 ++++++++++---\n lib/librte_eal/common/include/rte_devargs.h | 25 +++++++++++-----------\n 4 files changed, 30 insertions(+), 45 deletions(-)", "diff": "diff --git a/drivers/net/failsafe/failsafe_args.c b/drivers/net/failsafe/failsafe_args.c\nindex cfc83e3..08ce4ad 100644\n--- a/drivers/net/failsafe/failsafe_args.c\n+++ b/drivers/net/failsafe/failsafe_args.c\n@@ -88,7 +88,7 @@ fs_parse_device(struct sub_device *sdev, char *args)\n \n \td = &sdev->devargs;\n \tDEBUG(\"%s\", args);\n-\tret = rte_eal_devargs_parse(args, d);\n+\tret = rte_eal_devargs_parse(d, \"%s\", args);\n \tif (ret) {\n \t\tDEBUG(\"devargs parsing failed with code %d\", ret);\n \t\treturn ret;\ndiff --git a/lib/librte_eal/common/eal_common_dev.c b/lib/librte_eal/common/eal_common_dev.c\nindex e251275..b965e56 100644\n--- a/lib/librte_eal/common/eal_common_dev.c\n+++ b/lib/librte_eal/common/eal_common_dev.c\n@@ -127,29 +127,12 @@ int rte_eal_dev_detach(struct rte_device *dev)\n \treturn ret;\n }\n \n-static char *\n-full_dev_name(const char *bus, const char *dev, const char *args)\n-{\n-\tchar *name;\n-\tsize_t len;\n-\n-\tlen = snprintf(NULL, 0, \"%s:%s,%s\", bus, dev, args) + 1;\n-\tname = calloc(1, len);\n-\tif (name == NULL) {\n-\t\tRTE_LOG(ERR, EAL, \"Could not allocate full device name\\n\");\n-\t\treturn NULL;\n-\t}\n-\tsnprintf(name, len, \"%s:%s,%s\", bus, dev, args);\n-\treturn name;\n-}\n-\n int rte_eal_hotplug_add(const char *busname, const char *devname,\n \t\t\tconst char *devargs)\n {\n \tstruct rte_bus *bus;\n \tstruct rte_device *dev;\n \tstruct rte_devargs *da;\n-\tchar *name;\n \tint ret;\n \n \tbus = rte_bus_find_by_name(busname);\n@@ -164,17 +147,12 @@ int rte_eal_hotplug_add(const char *busname, const char *devname,\n \t\treturn -ENOTSUP;\n \t}\n \n-\tname = full_dev_name(busname, devname, devargs);\n-\tif (name == NULL)\n+\tda = calloc(1, sizeof(*da));\n+\tif (da == NULL)\n \t\treturn -ENOMEM;\n \n-\tda = calloc(1, sizeof(*da));\n-\tif (da == NULL) {\n-\t\tret = -ENOMEM;\n-\t\tgoto err_name;\n-\t}\n-\n-\tret = rte_eal_devargs_parse(name, da);\n+\tret = rte_eal_devargs_parse(da, \"%s:%s,%s\",\n+\t\t\t\t busname, devname, devargs);\n \tif (ret)\n \t\tgoto err_devarg;\n \n@@ -200,7 +178,6 @@ int rte_eal_hotplug_add(const char *busname, const char *devname,\n \t\t\tdev->name);\n \t\tgoto err_devarg;\n \t}\n-\tfree(name);\n \treturn 0;\n \n err_devarg:\n@@ -208,8 +185,6 @@ int rte_eal_hotplug_add(const char *busname, const char *devname,\n \t\tfree(da->args);\n \t\tfree(da);\n \t}\n-err_name:\n-\tfree(name);\n \treturn ret;\n }\n \ndiff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/common/eal_common_devargs.c\nindex 0f81f22..a21cc1a 100644\n--- a/lib/librte_eal/common/eal_common_devargs.c\n+++ b/lib/librte_eal/common/eal_common_devargs.c\n@@ -39,6 +39,7 @@\n \n #include <stdio.h>\n #include <string.h>\n+#include <stdarg.h>\n \n #include <rte_dev.h>\n #include <rte_devargs.h>\n@@ -89,15 +90,23 @@ bus_name_cmp(const struct rte_bus *bus, const void *name)\n }\n \n int\n-rte_eal_devargs_parse(const char *dev, struct rte_devargs *da)\n+rte_eal_devargs_parse(struct rte_devargs *da, const char *format, ...)\n {\n \tstruct rte_bus *bus = NULL;\n+\tva_list ap;\n+\tva_start(ap, format);\n+\tchar dev[vsnprintf(NULL, 0, format, ap) + 1];\n \tconst char *devname;\n \tconst size_t maxlen = sizeof(da->name);\n \tsize_t i;\n \n-\tif (dev == NULL || da == NULL)\n+\tva_end(ap);\n+\tif (da == NULL)\n \t\treturn -EINVAL;\n+\n+\tva_start(ap, format);\n+\tvsnprintf(dev, sizeof(dev), format, ap);\n+\tva_end(ap);\n \t/* Retrieve eventual bus info */\n \tdo {\n \t\tdevname = dev;\n@@ -166,7 +175,7 @@ rte_eal_devargs_add(const char *devargs_str)\n \tif (devargs == NULL)\n \t\tgoto fail;\n \n-\tif (rte_eal_devargs_parse(dev, devargs))\n+\tif (rte_eal_devargs_parse(devargs, \"%s\", dev))\n \t\tgoto fail;\n \tTAILQ_INSERT_TAIL(&devargs_list, devargs, next);\n \treturn 0;\ndiff --git a/lib/librte_eal/common/include/rte_devargs.h b/lib/librte_eal/common/include/rte_devargs.h\nindex 5f4ad33..1fe03d6 100644\n--- a/lib/librte_eal/common/include/rte_devargs.h\n+++ b/lib/librte_eal/common/include/rte_devargs.h\n@@ -108,18 +108,20 @@ int rte_eal_parse_devargs_str(const char *devargs_str,\n * in argument. Store which bus will handle the device, its name\n * and the eventual device parameters.\n *\n- * @param dev\n- * The device declaration string.\n+ * The device string is built with a printf-like syntax.\n+ *\n * @param da\n * The devargs structure holding the device information.\n+ * @param format\n+ * Format string describing a device.\n *\n * @return\n * - 0 on success.\n * - Negative errno on error.\n */\n int\n-rte_eal_devargs_parse(const char *dev,\n-\t\t struct rte_devargs *da);\n+rte_eal_devargs_parse(struct rte_devargs *da,\n+\t\t const char *format, ...);\n \n /**\n * Insert an rte_devargs in the global list.\n@@ -137,15 +139,14 @@ rte_eal_devargs_insert(struct rte_devargs *da);\n /**\n * Add a device to the user device list\n *\n- * For PCI devices, the format of arguments string is \"PCI_ADDR\" or\n- * \"PCI_ADDR,key=val,key2=val2,...\". Examples: \"08:00.1\", \"0000:5:00.0\",\n- * \"04:00.0,arg=val\".\n+ * The format is\n *\n- * For virtual devices, the format of arguments string is \"DRIVER_NAME*\"\n- * or \"DRIVER_NAME*,key=val,key2=val2,...\". Examples: \"net_ring\",\n- * \"net_ring0\", \"net_pmdAnything,arg=0:arg2=1\". The validity of the\n- * driver name is not checked by this function, it is done when probing\n- * the drivers.\n+ * bus:device_identifier,arg1=val1,arg2=val2\n+ *\n+ * Examples:\n+ *\n+ * pci:0000:05.00.0,arg=val\n+ * vdev:net_ring0\n *\n * @param devargs_str\n * The arguments as given by the user.\n", "prefixes": [ "dpdk-dev", "v2", "09/18" ] }