Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/30186/?format=api
{ "id": 30186, "url": "http://patches.dpdk.org/api/patches/30186/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/258d20848b6da73dd6ae63a9ce511490b1395220.1507795823.git.gaetan.rivet@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<258d20848b6da73dd6ae63a9ce511490b1395220.1507795823.git.gaetan.rivet@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/258d20848b6da73dd6ae63a9ce511490b1395220.1507795823.git.gaetan.rivet@6wind.com", "date": "2017-10-12T08:17:14", "name": "[dpdk-dev,v4,14/16] pci: make specialized parsing functions private", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "13fbd7bc3769eca293b98c8fe4ad86c2ba2515f2", "submitter": { "id": 269, "url": "http://patches.dpdk.org/api/people/269/?format=api", "name": "Gaëtan Rivet", "email": "gaetan.rivet@6wind.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/258d20848b6da73dd6ae63a9ce511490b1395220.1507795823.git.gaetan.rivet@6wind.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/30186/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/30186/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A4C731B202;\n\tThu, 12 Oct 2017 10:18:02 +0200 (CEST)", "from mail-wm0-f53.google.com (mail-wm0-f53.google.com\n\t[74.125.82.53]) by dpdk.org (Postfix) with ESMTP id 1282E1B1AA\n\tfor <dev@dpdk.org>; Thu, 12 Oct 2017 10:17:49 +0200 (CEST)", "by mail-wm0-f53.google.com with SMTP id 196so22787903wma.1\n\tfor <dev@dpdk.org>; Thu, 12 Oct 2017 01:17:49 -0700 (PDT)", "from bidouze.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com.\n\t[62.23.145.78]) by smtp.gmail.com with ESMTPSA id\n\t25sm16711227wrv.8.2017.10.12.01.17.47\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tThu, 12 Oct 2017 01:17:47 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:in-reply-to:references;\n\tbh=CKP+LH3rMSHFVJPR5Wnl18huK/pUzWv/RZgJIodYcjY=;\n\tb=HCnDYqq5BV9PuOMFUKRM+zD+lbcuDXt1+mlk5BX/gbNYNGQq14iUUofuGqE+wLFAdy\n\tltBi17e7dQT3kvC4zdwkQKLghaD9c3nTiDX43017wCbQBHcck6VywpsXayNKPtv9D/JR\n\turc1RyXAVGlUeo0N506l5zIvsVZecptQY5ymbD2n2UbbXuaiH1hVGMMhqG4LM5KuHdHO\n\tmnMwDNKXJ7uuDt33U7M4kZxtLN9Pw8vs6zRS0bIR23xVd3JRiUWevC6e9q2O6h7O3xhx\n\tD2iMUj1W6FAXU9z725VTveXwPEi39kEgCpFq5pXqra5PdIwfgT7Rob0erdwdjE/FlRss\n\tFoDQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:in-reply-to:references;\n\tbh=CKP+LH3rMSHFVJPR5Wnl18huK/pUzWv/RZgJIodYcjY=;\n\tb=luLOkkODRYqciQRqTtSxR4VTBOA0YeBFr7Fsz5StlFfKQBHR7AdJaPHNyMDDFspF1W\n\t7ywEPTcIoOQd5567xCmCD/FYVHMx6P3OXEVWjlJDMCWimz+ms4JrXlR+kVuw+5oCtIrM\n\tCsTkemFiqtAlR6RQCuIjQvTL+KIokRcLfF1NlNo1onnzsZ/cdsRxQXineOaHc4Huoqgi\n\t0Hro0IkfFubOuKKqGgvknEBstX2kOLmZjiBCEJu1pUtXu8UJ4I4+PnJisg8UYGzZ/W6m\n\tqwPAZyC1XqcUKFFuSMqoGwg42b6YiUzMc6BHtL+AsDM0zjmdr6rJTRRDnAUejVoPuCBq\n\tzoyg==", "X-Gm-Message-State": "AMCzsaWddH1SPv395Cp0Wijk5XT7xwRraaGwFms/2pzo9FsqBFxBN7CK\n\th+lSs1gHYvVJiRtqVnDMGAruZMv5", "X-Google-Smtp-Source": "AOwi7QAXrQ7csRz3SLZu/CKnncghZUghn+Zr/k+2Ujovd656HPB8Vko3BkGEe/qxETlMqri6oLIOtw==", "X-Received": "by 10.28.218.207 with SMTP id r198mr1066181wmg.14.1507796268344; \n\tThu, 12 Oct 2017 01:17:48 -0700 (PDT)", "From": "Gaetan Rivet <gaetan.rivet@6wind.com>", "To": "dev@dpdk.org", "Cc": "Gaetan Rivet <gaetan.rivet@6wind.com>", "Date": "Thu, 12 Oct 2017 10:17:14 +0200", "Message-Id": "<258d20848b6da73dd6ae63a9ce511490b1395220.1507795823.git.gaetan.rivet@6wind.com>", "X-Mailer": "git-send-email 2.1.4", "In-Reply-To": [ "<cover.1507795823.git.gaetan.rivet@6wind.com>", "<cover.1507795823.git.gaetan.rivet@6wind.com>" ], "References": [ "<cover.1506352670.git.gaetan.rivet@6wind.com>\n\t<cover.1507795823.git.gaetan.rivet@6wind.com>", "<cover.1507795823.git.gaetan.rivet@6wind.com>" ], "Subject": "[dpdk-dev] [PATCH v4 14/16] pci: make specialized parsing functions\n\tprivate", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Do not expose the minute implementations of PCI parsing.\nThis leaves only the all-purpose pci_addr_parse, which is simpler to\nuse.\n\nSigned-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>\n---\n lib/librte_pci/include/rte_pci.h | 29 -----------------------------\n lib/librte_pci/rte_pci.c | 28 ++++++++++++++--------------\n lib/librte_pci/rte_pci_version.map | 2 --\n 3 files changed, 14 insertions(+), 45 deletions(-)", "diff": "diff --git a/lib/librte_pci/include/rte_pci.h b/lib/librte_pci/include/rte_pci.h\nindex 9e79557..ea0897c 100644\n--- a/lib/librte_pci/include/rte_pci.h\n+++ b/lib/librte_pci/include/rte_pci.h\n@@ -151,21 +151,6 @@ TAILQ_HEAD(mapped_pci_res_list, mapped_pci_resource);\n int eal_parse_pci_BDF(const char *input, struct rte_pci_addr *dev_addr);\n \n /**\n- * Utility function to produce a PCI Bus-Device-Function value\n- * given a string representation. Assumes that the BDF is provided without\n- * a domain prefix (i.e. domain returned is always 0)\n- *\n- * @param input\n- *\tThe input string to be parsed. Should have the format XX:XX.X\n- * @param dev_addr\n- *\tThe PCI Bus-Device-Function address to be returned.\n- *\tDomain will always be returned as 0\n- * @return\n- * 0 on success, negative on error.\n- */\n-int pci_bdf_parse(const char *input, struct rte_pci_addr *dev_addr);\n-\n-/**\n * @deprecated\n * Utility function to produce a PCI Bus-Device-Function value\n * given a string representation. Assumes that the BDF is provided including\n@@ -181,20 +166,6 @@ int pci_bdf_parse(const char *input, struct rte_pci_addr *dev_addr);\n int eal_parse_pci_DomBDF(const char *input, struct rte_pci_addr *dev_addr);\n \n /**\n- * Utility function to produce a PCI Bus-Device-Function value\n- * given a string representation. Assumes that the BDF is provided including\n- * a domain prefix.\n- *\n- * @param input\n- *\tThe input string to be parsed. Should have the format XXXX:XX:XX.X\n- * @param dev_addr\n- *\tThe PCI Bus-Device-Function address to be returned\n- * @return\n- * 0 on success, negative on error.\n- */\n-int pci_dbdf_parse(const char *input, struct rte_pci_addr *dev_addr);\n-\n-/**\n * @deprecated\n * Utility function to write a pci device name, this device name can later be\n * used to retrieve the corresponding rte_pci_addr using eal_parse_pci_*\ndiff --git a/lib/librte_pci/rte_pci.c b/lib/librte_pci/rte_pci.c\nindex 7ba472c..1307a18 100644\n--- a/lib/librte_pci/rte_pci.c\n+++ b/lib/librte_pci/rte_pci.c\n@@ -70,13 +70,7 @@ get_u8_pciaddr_field(const char *in, void *_u8, char dlm)\n \treturn end + 1;\n }\n \n-int\n-eal_parse_pci_BDF(const char *input, struct rte_pci_addr *dev_addr)\n-{\n-\treturn pci_bdf_parse(input, dev_addr);\n-}\n-\n-int\n+static int\n pci_bdf_parse(const char *input, struct rte_pci_addr *dev_addr)\n {\n \tconst char *in = input;\n@@ -94,13 +88,7 @@ pci_bdf_parse(const char *input, struct rte_pci_addr *dev_addr)\n \treturn 0;\n }\n \n-int\n-eal_parse_pci_DomBDF(const char *input, struct rte_pci_addr *dev_addr)\n-{\n-\treturn pci_dbdf_parse(input, dev_addr);\n-}\n-\n-int\n+static int\n pci_dbdf_parse(const char *input, struct rte_pci_addr *dev_addr)\n {\n \tconst char *in = input;\n@@ -125,6 +113,18 @@ pci_dbdf_parse(const char *input, struct rte_pci_addr *dev_addr)\n \treturn 0;\n }\n \n+int\n+eal_parse_pci_BDF(const char *input, struct rte_pci_addr *dev_addr)\n+{\n+\treturn pci_bdf_parse(input, dev_addr);\n+}\n+\n+int\n+eal_parse_pci_DomBDF(const char *input, struct rte_pci_addr *dev_addr)\n+{\n+\treturn pci_dbdf_parse(input, dev_addr);\n+}\n+\n void\n rte_pci_device_name(const struct rte_pci_addr *addr,\n \t\t char *output, size_t size)\ndiff --git a/lib/librte_pci/rte_pci_version.map b/lib/librte_pci/rte_pci_version.map\nindex 5f50f98..b5c9ec2 100644\n--- a/lib/librte_pci/rte_pci_version.map\n+++ b/lib/librte_pci/rte_pci_version.map\n@@ -5,8 +5,6 @@ DPDK_17.11 {\n \teal_parse_pci_DomBDF;\n \tpci_addr_cmp;\n \tpci_addr_parse;\n-\tpci_bdf_parse;\n-\tpci_dbdf_parse;\n \tpci_device_name;\n \tpci_map_resource;\n \tpci_unmap_resource;\n", "prefixes": [ "dpdk-dev", "v4", "14/16" ] }