Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 30087,
    "url": "http://patches.dpdk.org/api/patches/30087/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20171011043935.16813-1-zhiyong.yang@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20171011043935.16813-1-zhiyong.yang@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20171011043935.16813-1-zhiyong.yang@intel.com",
    "date": "2017-10-11T04:39:35",
    "name": "[dpdk-dev] net/virtio: fix wrong TX pkt length stats",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "e68cf24f5fd2d47dc615e57a8fbd3fbdb546135d",
    "submitter": {
        "id": 540,
        "url": "http://patches.dpdk.org/api/people/540/?format=api",
        "name": "Yang, Zhiyong",
        "email": "zhiyong.yang@intel.com"
    },
    "delegate": {
        "id": 355,
        "url": "http://patches.dpdk.org/api/users/355/?format=api",
        "username": "yliu",
        "first_name": "Yuanhan",
        "last_name": "Liu",
        "email": "yuanhan.liu@linux.intel.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20171011043935.16813-1-zhiyong.yang@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/30087/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/30087/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 853CF1B1BE;\n\tWed, 11 Oct 2017 06:39:42 +0200 (CEST)",
            "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id BBFAE1B1B9\n\tfor <dev@dpdk.org>; Wed, 11 Oct 2017 06:39:40 +0200 (CEST)",
            "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby fmsmga105.fm.intel.com with ESMTP; 10 Oct 2017 21:39:39 -0700",
            "from unknown (HELO dpdk5.bj.intel.com) ([172.16.182.182])\n\tby fmsmga004.fm.intel.com with ESMTP; 10 Oct 2017 21:39:37 -0700"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.43,359,1503385200\"; d=\"scan'208\";a=\"321854191\"",
        "From": "Zhiyong Yang <zhiyong.yang@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "yliu@fridaylinux.org, maxime.coquelin@redhat.com, jianfeng.tan@intel.com,\n\tZhiyong Yang <zhiyong.yang@intel.com>",
        "Date": "Wed, 11 Oct 2017 12:39:35 +0800",
        "Message-Id": "<20171011043935.16813-1-zhiyong.yang@intel.com>",
        "X-Mailer": "git-send-email 2.13.3",
        "Subject": "[dpdk-dev] [PATCH] net/virtio: fix wrong TX pkt length stats",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "In the function virtqueue_enqueue_xmit(), when can_push == 1 is true,\nvtnet_hdr_size is added to pkt_len by calling rte_pktmbuf_prepend.\nSo, virtio header len should be subtracted before calling stats\nfunction.\n\nFixes: 58169a9c8153 (\"net/virtio: support Tx checksum offload\")\n\nSigned-off-by: Zhiyong Yang <zhiyong.yang@intel.com>\n---\n drivers/net/virtio/virtio_rxtx.c | 6 ++++++\n 1 file changed, 6 insertions(+)",
    "diff": "diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c\nindex 609b4138a..bf14f9a99 100644\n--- a/drivers/net/virtio/virtio_rxtx.c\n+++ b/drivers/net/virtio/virtio_rxtx.c\n@@ -1079,6 +1079,12 @@ virtio_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)\n \t\t/* Enqueue Packet buffers */\n \t\tvirtqueue_enqueue_xmit(txvq, txm, slots, use_indirect, can_push);\n \n+\t\t/* In function virtqueue_enqueue_xmit(), when can_push == 1\n+\t\t * is true, vtnet_hdr_size is added to pkt_len of mbuf. So, it\n+\t\t * should be subtracted before calling stats function.\n+\t\t */\n+\t\tif (can_push == 1)\n+\t\t\ttxm->pkt_len -= txvq->vq->hw->vtnet_hdr_size;\n \t\ttxvq->stats.bytes += txm->pkt_len;\n \t\tvirtio_update_packet_stats(&txvq->stats, txm);\n \t}\n",
    "prefixes": [
        "dpdk-dev"
    ]
}