Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 29758,
    "url": "http://patches.dpdk.org/api/patches/29758/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20171005150646.3188-3-ajit.khaparde@broadcom.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20171005150646.3188-3-ajit.khaparde@broadcom.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20171005150646.3188-3-ajit.khaparde@broadcom.com",
    "date": "2017-10-05T15:06:44",
    "name": "[dpdk-dev,v2,2/4] net/bnxt: fix number of mac addresses for VMDQ support",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "6b7faa0cb132b24c53026bd0b271c695e8d0e6fa",
    "submitter": {
        "id": 501,
        "url": "http://patches.dpdk.org/api/people/501/?format=api",
        "name": "Ajit Khaparde",
        "email": "ajit.khaparde@broadcom.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20171005150646.3188-3-ajit.khaparde@broadcom.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/29758/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/29758/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 71B761B239;\n\tThu,  5 Oct 2017 17:06:54 +0200 (CEST)",
            "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 797071B1AB\n\tfor <dev@dpdk.org>; Thu,  5 Oct 2017 17:06:51 +0200 (CEST)",
            "from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net\n\t[10.75.224.233])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 554F630C00D;\n\tThu,  5 Oct 2017 08:06:50 -0700 (PDT)",
            "from C02PT1RBG8WP.wifi.broadcom.net (c02pt1rbg8wp.wifi.broadcom.net\n\t[10.45.51.51])\n\tby mail-irv-17.broadcom.com (Postfix) with ESMTP id E0CEC81EAD;\n\tThu,  5 Oct 2017 08:06:49 -0700 (PDT)"
        ],
        "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>",
        "To": "dev@dpdk.org",
        "Cc": "ferruh.yigit@intel.com",
        "Date": "Thu,  5 Oct 2017 10:06:44 -0500",
        "Message-Id": "<20171005150646.3188-3-ajit.khaparde@broadcom.com>",
        "X-Mailer": "git-send-email 2.13.5 (Apple Git-94)",
        "In-Reply-To": "<20171005150646.3188-1-ajit.khaparde@broadcom.com>",
        "References": "<20171005142803.2143-1-ajit.khaparde@broadcom.com>\n\t<20171005150646.3188-1-ajit.khaparde@broadcom.com>",
        "Subject": "[dpdk-dev] [PATCH v2 2/4] net/bnxt: fix number of mac addresses for\n\tVMDQ support",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "We were hardcoding the max MAC addresses to 32, while the HW\ncan support more than that. This was restricting the number of VMDQ\npools that we could support. Use the value obtained from FW instead.\n\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_ethdev.c |  6 +++---\n drivers/net/bnxt/bnxt_hwrm.c   |  2 +-\n drivers/net/bnxt/bnxt_rxq.c    | 23 +++++++++++++++++++----\n 3 files changed, 23 insertions(+), 8 deletions(-)",
    "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex ad90f7520..c559a9db8 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -416,7 +416,7 @@ static void bnxt_dev_info_get_op(struct rte_eth_dev *eth_dev,\n \tdev_info->pci_dev = RTE_ETH_DEV_TO_PCI(eth_dev);\n \n \t/* MAC Specifics */\n-\tdev_info->max_mac_addrs = MAX_NUM_MAC_ADDR;\n+\tdev_info->max_mac_addrs = bp->max_l2_ctx;\n \tdev_info->max_hash_mac_addrs = 0;\n \n \t/* PF/VF specifics */\n@@ -2525,11 +2525,11 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev)\n \t\tgoto error_free;\n \t}\n \teth_dev->data->mac_addrs = rte_zmalloc(\"bnxt_mac_addr_tbl\",\n-\t\t\t\t\tETHER_ADDR_LEN * MAX_NUM_MAC_ADDR, 0);\n+\t\t\t\t\tETHER_ADDR_LEN * bp->max_l2_ctx, 0);\n \tif (eth_dev->data->mac_addrs == NULL) {\n \t\tRTE_LOG(ERR, PMD,\n \t\t\t\"Failed to alloc %u bytes needed to store MAC addr tbl\",\n-\t\t\tETHER_ADDR_LEN * MAX_NUM_MAC_ADDR);\n+\t\t\tETHER_ADDR_LEN * bp->max_l2_ctx);\n \t\trc = -ENOMEM;\n \t\tgoto error_free;\n \t}\ndiff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c\nindex d379850bb..e66994a76 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.c\n+++ b/drivers/net/bnxt/bnxt_hwrm.c\n@@ -259,7 +259,7 @@ int bnxt_hwrm_cfa_l2_set_rx_mask(struct bnxt *bp,\n \t * by ethtool.\n \t */\n \tif (vnic->flags & BNXT_VNIC_INFO_BCAST)\n-\t\tmask = HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_BCAST;\n+\t\tmask |= HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_BCAST;\n \tif (vnic->flags & BNXT_VNIC_INFO_UNTAGGED)\n \t\tmask |= HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_VLAN_NONVLAN;\n \tif (vnic->flags & BNXT_VNIC_INFO_PROMISC)\ndiff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c\nindex 0c4e0f6ec..bfa5308ad 100644\n--- a/drivers/net/bnxt/bnxt_rxq.c\n+++ b/drivers/net/bnxt/bnxt_rxq.c\n@@ -60,6 +60,8 @@ void bnxt_free_rxq_stats(struct bnxt_rx_queue *rxq)\n int bnxt_mq_rx_configure(struct bnxt *bp)\n {\n \tstruct rte_eth_conf *dev_conf = &bp->eth_dev->data->dev_conf;\n+\tconst struct rte_eth_vmdq_rx_conf *conf =\n+\t\t    &dev_conf->rx_adv_conf.vmdq_rx_conf;\n \tunsigned int i, j, nb_q_per_grp = 1, ring_idx = 0;\n \tint start_grp_id, end_grp_id = 1, rc = 0;\n \tstruct bnxt_vnic_info *vnic;\n@@ -102,9 +104,6 @@ int bnxt_mq_rx_configure(struct bnxt *bp)\n \t/* Multi-queue mode */\n \tif (dev_conf->rxmode.mq_mode & ETH_MQ_RX_VMDQ_DCB_RSS) {\n \t\t/* VMDq ONLY, VMDq+RSS, VMDq+DCB, VMDq+DCB+RSS */\n-\t\tconst struct rte_eth_vmdq_rx_conf *conf =\n-\t\t    &dev_conf->rx_adv_conf.vmdq_rx_conf;\n-\n \n \t\tswitch (dev_conf->rxmode.mq_mode) {\n \t\tcase ETH_MQ_RX_VMDQ_RSS:\n@@ -156,8 +155,13 @@ int bnxt_mq_rx_configure(struct bnxt *bp)\n \t\t\trxq = bp->eth_dev->data->rx_queues[ring_idx];\n \t\t\trxq->vnic = vnic;\n \t\t}\n-\t\tif (i == 0)\n+\t\tif (i == 0) {\n+\t\t\tif (dev_conf->rxmode.mq_mode & ETH_MQ_RX_VMDQ_DCB) {\n+\t\t\t\tbp->eth_dev->data->promiscuous = 1;\n+\t\t\t\tvnic->flags |= BNXT_VNIC_INFO_PROMISC;\n+\t\t\t}\n \t\t\tvnic->func_default = true;\n+\t\t}\n \t\tvnic->ff_pool_idx = i;\n \t\tvnic->start_grp_id = start_grp_id;\n \t\tvnic->end_grp_id = end_grp_id;\n@@ -172,6 +176,17 @@ int bnxt_mq_rx_configure(struct bnxt *bp)\n \t\t\trc = -ENOMEM;\n \t\t\tgoto err_out;\n \t\t}\n+\t\tfor (j = 0; j < conf->nb_pool_maps; j++) {\n+\t\t\tif (conf->pool_map[j].pools & (1UL << i)) {\n+\t\t\t\tRTE_LOG(ERR, PMD,\n+\t\t\t\t\t\"Add vlan %u to vmdq pool %u\\n\",\n+\t\t\t\t\tconf->pool_map[j].vlan_id, i);\n+\n+\t\t\t\tfilter->l2_ivlan = conf->pool_map[j].vlan_id;\n+\t\t\t\tfilter->enables |=\n+\t\t\t\tHWRM_CFA_L2_FILTER_ALLOC_INPUT_ENABLES_L2_OVLAN;\n+\t\t\t}\n+\t\t}\n \t\t/*\n \t\t * TODO: Configure & associate CFA rule for\n \t\t * each VNIC for each VMDq with MACVLAN, MACVLAN+TC\n",
    "prefixes": [
        "dpdk-dev",
        "v2",
        "2/4"
    ]
}