Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 29066,
    "url": "http://patches.dpdk.org/api/patches/29066/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20170921130404.4978-1-lma@semihalf.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20170921130404.4978-1-lma@semihalf.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20170921130404.4978-1-lma@semihalf.com",
    "date": "2017-09-21T13:04:04",
    "name": "[dpdk-dev] librte_eal: fix wrong assert for arm and ppc",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "024e6fbacbd70d8e17d1c6d44882bfc37158b082",
    "submitter": {
        "id": 841,
        "url": "http://patches.dpdk.org/api/people/841/?format=api",
        "name": "Lukasz Majczak",
        "email": "lma@semihalf.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20170921130404.4978-1-lma@semihalf.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/29066/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/29066/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3CFB91B1A2;\n\tThu, 21 Sep 2017 15:04:22 +0200 (CEST)",
            "from mail-lf0-f46.google.com (mail-lf0-f46.google.com\n\t[209.85.215.46]) by dpdk.org (Postfix) with ESMTP id 642847D4E\n\tfor <dev@dpdk.org>; Thu, 21 Sep 2017 15:04:21 +0200 (CEST)",
            "by mail-lf0-f46.google.com with SMTP id k23so5678147lfi.11\n\tfor <dev@dpdk.org>; Thu, 21 Sep 2017 06:04:21 -0700 (PDT)",
            "from deadpool.semihalf.local (31-172-191-173.noc.fibertech.net.pl.\n\t[31.172.191.173])\n\tby smtp.gmail.com with ESMTPSA id r2sm275133ljd.7.2017.09.21.06.04.19\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 21 Sep 2017 06:04:19 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=semihalf-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id;\n\tbh=s4QR2vuNfEs9YkowpVZxYYzbFU4F21gqxjol3odWhY4=;\n\tb=I3iONDvF+OJhlZUg73mXRael4zklTRXmohSsDCwJm6QWUEFAS+8pvKGM7ssPCI9lH9\n\tO8vC4MDeDnaE6V8/yAQfs3f8jpOtHrzZCVq6OpzpiNheqE+oKvCbVlUKuzssPFeYK8on\n\t6w7+6paC21qJQOqx8upbLQtxalD/WfQcDRKWmLSx1id0DivI8YUHkvblqsJY/MQhUQoD\n\tSFvji2LFe2brlJ9qjaS/URkFGB9ew+QCRZebkuNNLjkqAMldBQlaJlFVQQS48RdYEE9e\n\truWr7jhLVh4+YRIJCVUArvYgvv2PPXu0Wle1BWZZ8ZnaBSd2XhdIlgUzugvudhyIbtIH\n\t6XFA==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=s4QR2vuNfEs9YkowpVZxYYzbFU4F21gqxjol3odWhY4=;\n\tb=tjXMOGdOIwkFZo8Gtcl16n1Hr3q+rydHYC5j+plj/mmymjDklkT3hnKbiC4gvZ3qBx\n\tBV2nPqQ8Kd4EatuXgkDhy+IPJ4NDd5a6300y1+8xGuH4pvA0utMQRBdBr6YZ/46zWnEx\n\tQ1aU6uHo6Ki/6VmvTLwd4nNalZgcmNAoX7vfLyi6n9pd3jpFcq13nYe9Tex6ZDjAKEAo\n\tC80b+X1wf1PZ4Jz1IS5sPhX+5JLMP+GgrJlXrq73tQBFkesc7jVT+Xv0jO5l4EWE1IXH\n\tnt50EvOx8sIY75H0gQ7ETxv5DEAKEnZcxi7TO+CQYmdyOOZxW6KRldVmRVjX46BIYlt8\n\tp3HA==",
        "X-Gm-Message-State": "AHPjjUgbU6O1lywptGV2NSEzDjD13K77XsFyJauzl3uQ/TrvHpHS9MYj\n\tDUFil3SkNOmZhbbIRd4wwbBgQs4Hcmk=",
        "X-Google-Smtp-Source": "AOwi7QCrcGWwWwx8lohAKwh+3tMTaic02uealHFVYpbKo45Rn1Jnkjlxz+nP/JCLA6LCEKG17Zkolg==",
        "X-Received": "by 10.46.66.197 with SMTP id h66mr1004386ljf.108.1505999060563; \n\tThu, 21 Sep 2017 06:04:20 -0700 (PDT)",
        "From": "Lukasz Majczak <lma@semihalf.com>",
        "To": "viktorin@rehivetech.com,\n\tchaozhu@linux.vnet.ibm.com",
        "Cc": "dev@dpdk.org,\n\tLukasz Majczak <lma@semihalf.com>",
        "Date": "Thu, 21 Sep 2017 15:04:04 +0200",
        "Message-Id": "<20170921130404.4978-1-lma@semihalf.com>",
        "X-Mailer": "git-send-email 2.14.1",
        "Subject": "[dpdk-dev] [PATCH] librte_eal: fix wrong assert for arm and ppc",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The assertion of return value from the open() function is done against\n0, while it is a correct value - open() returns -1 in case of an error.\nIt causes problems while trying to run as a daemon, in which case, this\ncall to open() will return 0 as a valid descriptor.\n\nSigned-off-by: Lukasz Majczak <lma@semihalf.com>\n---\n lib/librte_eal/common/arch/arm/rte_cpuflags.c    | 2 +-\n lib/librte_eal/common/arch/ppc_64/rte_cpuflags.c | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/lib/librte_eal/common/arch/arm/rte_cpuflags.c b/lib/librte_eal/common/arch/arm/rte_cpuflags.c\nindex 5636e9c1d..88f1cbe37 100644\n--- a/lib/librte_eal/common/arch/arm/rte_cpuflags.c\n+++ b/lib/librte_eal/common/arch/arm/rte_cpuflags.c\n@@ -137,7 +137,7 @@ rte_cpu_get_features(hwcap_registers_t out)\n \t_Elfx_auxv_t auxv;\n \n \tauxv_fd = open(\"/proc/self/auxv\", O_RDONLY);\n-\tassert(auxv_fd);\n+\tassert(auxv_fd != -1);\n \twhile (read(auxv_fd, &auxv, sizeof(auxv)) == sizeof(auxv)) {\n \t\tif (auxv.a_type == AT_HWCAP) {\n \t\t\tout[REG_HWCAP] = auxv.a_un.a_val;\ndiff --git a/lib/librte_eal/common/arch/ppc_64/rte_cpuflags.c b/lib/librte_eal/common/arch/ppc_64/rte_cpuflags.c\nindex fcf96e045..970a61c5e 100644\n--- a/lib/librte_eal/common/arch/ppc_64/rte_cpuflags.c\n+++ b/lib/librte_eal/common/arch/ppc_64/rte_cpuflags.c\n@@ -108,7 +108,7 @@ rte_cpu_get_features(hwcap_registers_t out)\n \tElf64_auxv_t auxv;\n \n \tauxv_fd = open(\"/proc/self/auxv\", O_RDONLY);\n-\tassert(auxv_fd);\n+\tassert(auxv_fd != -1);\n \twhile (read(auxv_fd, &auxv,\n \t\tsizeof(Elf64_auxv_t)) == sizeof(Elf64_auxv_t)) {\n \t\tif (auxv.a_type == AT_HWCAP)\n",
    "prefixes": [
        "dpdk-dev"
    ]
}