Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 28902,
    "url": "http://patches.dpdk.org/api/patches/28902/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1505784633-1171-28-git-send-email-rasesh.mody@cavium.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1505784633-1171-28-git-send-email-rasesh.mody@cavium.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1505784633-1171-28-git-send-email-rasesh.mody@cavium.com",
    "date": "2017-09-19T01:30:07",
    "name": "[dpdk-dev,27/53] net/qede/base: prevent stop vport assert by malicious VF",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "a7a60c539e4589888cec382734e05d4fb563c709",
    "submitter": {
        "id": 569,
        "url": "http://patches.dpdk.org/api/people/569/?format=api",
        "name": "Mody, Rasesh",
        "email": "rasesh.mody@cavium.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1505784633-1171-28-git-send-email-rasesh.mody@cavium.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/28902/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/28902/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7FA281B255;\n\tTue, 19 Sep 2017 03:31:46 +0200 (CEST)",
            "from NAM02-CY1-obe.outbound.protection.outlook.com\n\t(mail-cys01nam02on0055.outbound.protection.outlook.com\n\t[104.47.37.55]) by dpdk.org (Postfix) with ESMTP id 64E611B1B0\n\tfor <dev@dpdk.org>; Tue, 19 Sep 2017 03:31:27 +0200 (CEST)",
            "from cavium.com (198.186.0.2) by\n\tSN4PR0701MB3838.namprd07.prod.outlook.com (2603:10b6:803:4f::13) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.11;\n\tTue, 19 Sep 2017 01:31:24 +0000"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=RR9qHQcDn6tKTTZg3wR+M0CR7uVzFdHri2Dci6gmMxc=;\n\tb=QPAs/RQaYPWDdKYjMNvQ/l96f63h+oAGDR+MT+rd2vrKxykrI5hvvurhGq2BTzyQOv1QZncYr5ckID8N69m1puhK8c5w5WXY+w3ibX1v8aTvEQTWMJfk4/a9qZ0uz24IRcyQNPigR5703ugrvK7SBmYkAqiY2Sn4LMq9snkYWDg=",
        "Authentication-Results": "spf=none (sender IP is )\n\tsmtp.mailfrom=Rasesh.Mody@cavium.com; ",
        "From": "Rasesh Mody <rasesh.mody@cavium.com>",
        "To": "dev@dpdk.org,\n\tferruh.yigit@intel.com",
        "Cc": "Rasesh Mody <rasesh.mody@cavium.com>,\n\tDept-EngDPDKDev@cavium.com",
        "Date": "Mon, 18 Sep 2017 18:30:07 -0700",
        "Message-Id": "<1505784633-1171-28-git-send-email-rasesh.mody@cavium.com>",
        "X-Mailer": "git-send-email 1.7.10.3",
        "In-Reply-To": "<1505784633-1171-1-git-send-email-rasesh.mody@cavium.com>",
        "References": "<1505784633-1171-1-git-send-email-rasesh.mody@cavium.com>",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain",
        "X-Originating-IP": "[198.186.0.2]",
        "X-ClientProxiedBy": "SN4PR0501CA0015.namprd05.prod.outlook.com\n\t(2603:10b6:803:40::28) To SN4PR0701MB3838.namprd07.prod.outlook.com\n\t(2603:10b6:803:4f::13)",
        "X-MS-PublicTrafficType": "Email",
        "X-MS-Office365-Filtering-Correlation-Id": "080d0bc6-f6bf-408d-0ffc-08d4fefe2414",
        "X-Microsoft-Antispam": "UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:SN4PR0701MB3838; ",
        "X-Microsoft-Exchange-Diagnostics": [
            "1; SN4PR0701MB3838;\n\t3:5b7OssE/1PK0x0bP1cjR22pB+lzNzVKU6pv8kqS4qRehrtOCyZhDdPP+nVyrp8KXsSDqjkIstO8+8KCGuF3PopsStGm1FsOf3z9to2fvCv5lobj/VciOW+iy2hAJkYM65br9eJvSoDZeRarcQBAZlDbzHmnukgburZF1JJ3VcHRqdPmJ3NDIWeDHl03dTjUrbYJZWbjBKtq/yqbypZ41N7rFYL4UaHM1cLeIr3GYD6y0Bml1HLyMKOI6R4xprNYk;\n\t25:rkr4NlwQRTRsSD56KJ0SG+teZgUZ03kAzG3PcI+P3mDtctsIi5/eHQC5T31Owe10gVAhDn2NfRx3M8zUeyZLb2pkAW3O3nFqPMjJAT2SuP+2eZJDcxUfM8QmtTej54Jrx2LjZYkwtEyzNV+M8i5JJ0WLC5ijh5bpgnJ6mon8rHYkHg1bvQzBerIzWknGObGxCz9qDYaOykExXYAhTPh2JCocMQQYwnXR58gK5GXm5NrTKnu3mvDyHgTpns/xn7U1hwRBIaNxH/zTG0KKIzXYLTHYoUmnkPt/nvri5bAuXK0kg98ktwGS9rHKSaoXlXrNb5YK7AZ6NmpJIwCWW3dj+w==;\n\t31:irNvRifNTlBAAf6eXrFUffQvSKeqKX7oDGER3Q9B1vTkKHpitwquAnKmHFgSJK8lWJp0JgXNUaM9b/FgKWGvjuqEhjj1RW9oTvH4uAnjr79Ltyeq+NvIeCuDqe37+vrAugjcPaj+PpSCzVgsZ7MHWA9/fMrQGZQJkaObo+yROAP2WVNBPJxwrQ7mCvzJQCSJVPpd0wsQ9aANVzbQ5LFGImmSpXl4ZCZCC4I5Sbup03k=",
            "1; SN4PR0701MB3838;\n\t20:7xM0/sGCvr/U0daNQF2wsINkNO0Dxcg66xR9qAITP0U6W+J5EFFiUxCzTmNcxqW7UiJV/PzCTnnl7xyxB65o5EmhyF5PRG0purQ0iEU4qACspwCHu38yDVo6tutjezK7AlRAFgzuOfHprFQeJLg1nc3F/cyf57HEhmbKu7o9/m+/S9zJipdyeAUzD7H7Ztf6UUrDPVgy9YJ7gjJr/KmY7dmjXAWMa+shzJBxyP1at3uxY1ZVy29gcOw+1g5f6AUgX6MUJz5tApLqOF6kdv4+3JP0sV4RCkZpkQPmpWEt5V4NBrL3vB0WC+6N56Na32nN/Iw6GX7RrCSYVCaAMGNH/HXQx/sKLd7KTM1Ix+R/l8oWmn64ZColPQVsMDBt7iU5h1iKP8hgVu3Gh1vIyij4mJP+ClG5l8UhK8TjYDCF1+Yc3WQRL2ov28UEAiJKRmeXJbWPqtk2s4owP/Nnsvb6nghznaoR7KkzDU4Jj59iAWEUuwfAlmKd9rjuQwhO4sHh;\n\t4:RO6R44FLiB3OAkrGbOqq3LcbtB5K3hCKUSy8wVWNEwf9WCGL7gcxrwUYoHSzXqdWYLTpx7ai0LONPQ2GXPTPIfOdKTYcN6bhxC90r8glcQVE2lJ89BnyAWixF1zn1RjbFKLypdT+Y10RlJdMbrpKUHTw+ovtmkStrw6XuAK+B5p5CqRsv7TbM9hmNG1r3DXB6lOp0En7dDNamsFjTJuG3O4qFjGt/QnPVHHg0SuFMpFkW8Lya77E3WOnXB6We1tD",
            "=?us-ascii?Q?1; SN4PR0701MB3838;\n\t23:H9mGUTA7OdTtk+slOO0FajoT3KqytltvOXJJVxf?=\n\tfVyfDWQUjzLVzA4RjyVMKmi91S+nQ7bYjCSe0QvomTClVt+SvP+wc5qt7wIRAh3Axg0kVqm14QevdFnKWhyxYlNYrMuwTwWQDtNL7gttVAFfD8pIh2Sygb/SASWsDYKpchN4d+EhC4o1I+SlBHGNgn3fR52gwDjAwRzWN0qXnmCjjCXGwc20x0tTvcfFWR/nUB2QgWtHIwWBfdt3zyrruMkJc1gJcFIQdbc+kvLB5SgIQ3Z+3eJ1YSiDwgOdeLKVWAambFLOERf7Buolx3k3Q6kDAQmMNMaeQzyWm+9w70B1gY5EVtL+CtX+rkCKD/xwBhqztNsqK/sn6mnhBI7vwNfxBpODanQYzdcJMmmSmsAj9D16sQntoayonvrbGaRAiwSTBzbXDTdApNhEqJ3iYj+VHjJ9VibWRTms6++9M7bCnsE/ZRgdf58dVK1Ro7Vzlmw7kS3KRna6DtfRD1G8CFAA8bljbxN8YHWQFY8tHkrmNLGUQbmlqSe9h0Q7QvvyL5IwjIpthvshDMBKThaoK2bUfj9fDBIOPjPKH8joIIQ5bHp+jSKUvjDgIv5XmR1g86QY8Z3zgZ4kLoDZSsIUZ4EQEjDbuulRgOiAq6tpQIYoPKc7bgaLiCX6DzGgwe47h+mK/BdLYKb0kSLOiab3d6cRqu6ckevKz1QVOSny6aJtz+MVthGGgOsExKJ+SdlNaVpucA0MJSqa9QDTJ3kLrtEqfoDnA+ooqdz4gDjL7ogGmFaurZAn0ASzLgKHnlpOJV8EKctYrYML6tIUTVA9tOo4WGeNMsdc++xREYHK9MGhANzxbmwMHfzsifI+ngOWceLgcTlt0uUfjbmIgsa/bUVwm8UyZfGESt2B0OBwg/8s7qPkjfdXFSHxUAVJBQ27JCknxkbRs5OydLecemlaXxL3Pr1G+GDFB42vap7O/RdduRNsR0wuzdc/ZcR8+nEs3DOxCM+7hFx4M57tK6J7DNACO+4MThKmO+3HmZDY34/6XpSVbU1LrT0GubmWm0rXRoqEwuB1uLtG+sdwh+eLnC9qfYZoIhL2nOmJLCvqFehIwJleJbuYXJMb046BNnbvi7BA=",
            "1; SN4PR0701MB3838;\n\t6:eyU7wwAg3r1R+u9jVnd9VJI8NkYzeUeoCK9y8B6K6WaOxgOT00q7JWpPBE2f4gNhahhWjQ9kxrUq0QKGIfPzs4N8VKh/lTU/5AtNNMHmIcRo4naetpk06GpU//6eagnTY5kVVQHY5yfXtqFVImiDttaA3kmzJ7WxWTI+F+krl6FcanYwHs5RA4UqsRZOsBvWD4GkeKxjfvmjLJ8zMTDGKMW9W1uIyHA+OUnlOTwQHyv5TZZ9xDjbxBY/RPBxGRcYYXojt4OY6VA3B2ql7tlV/Gzgdy34JpGxADm4o7cNFBMrH1eufHpzsQv99xdROYg5xmRZamsnmj65HVhi8N/m4Q==;\n\t5:qjLH8swe6P7t5hNGvZboydcpoj4+2OiSmK4BBIHrdVD8mQVxOKl6baomm//RklKO2P/roKg46CDUjaOEt/Qu+zzWEbQ1dG/xd82yv2x948QnNocRucX3XmJXOrGgd7Wu4JtylrlmeQoGjEbVr0eFcQ==;\n\t24:sOJ/REZNi3yIPXLro1QIPYlnZ7807qZk0j/crHMIO9rAzopHqo9tUfQvZd6vhTgF/JKC/IBFtfIYH5J1GOjHQ7eZWckWUAAzGTu5MyaoR0M=;\n\t7:qCQesW9//GbDcDeXZgsT5SVRnajplIE9XPPHcRuJLiSUR76sJYchJkCIxjN2qNTfwhMWMO3LWcSC3kyO4vWOFGyUUemzvSnsKpOuOSmGk5zRW6Tx7FtLZshM9STDxKF0duKZsPNRhrcdPQbeodjPhc6RmlCmxNWVLWDroT4t1dXz+aimBAD3Zm1/jhZAkKVwFrbt9iS9ETf3vIT/pR3Ap7srJQj8jHqoa401l0dPrLk="
        ],
        "X-MS-TrafficTypeDiagnostic": "SN4PR0701MB3838:",
        "X-Exchange-Antispam-Report-Test": "UriScan:;",
        "X-Microsoft-Antispam-PRVS": "<SN4PR0701MB383817231562CBAB0E1DAAB69F600@SN4PR0701MB3838.namprd07.prod.outlook.com>",
        "X-Exchange-Antispam-Report-CFA-Test": "BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(10201501046)(93006095)(93001095)(3002001)(6041248)(20161123555025)(20161123562025)(20161123558100)(20161123560025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:SN4PR0701MB3838; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:SN4PR0701MB3838; ",
        "X-Forefront-PRVS": "04359FAD81",
        "X-Forefront-Antispam-Report": "SFV:NSPM;\n\tSFS:(10009020)(6009001)(376002)(346002)(199003)(189002)(48376002)(33646002)(68736007)(316002)(21086003)(16526017)(16586007)(72206003)(36756003)(478600001)(97736004)(86362001)(66066001)(25786009)(69596002)(47776003)(50986999)(81166006)(8936002)(50226002)(8676002)(5660300001)(7736002)(53936002)(305945005)(81156014)(55016002)(50466002)(76176999)(6116002)(3846002)(2950100002)(101416001)(4326008)(4720700003)(2906002)(107886003)(6666003)(189998001)(106356001)(5003940100001)(105586002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:SN4PR0701MB3838; H:cavium.com; FPR:;\n\tSPF:None; \n\tPTR:InfoNoRecords; A:1; MX:1; LANG:en; ",
        "Received-SPF": "None (protection.outlook.com: cavium.com does not designate\n\tpermitted sender hosts)",
        "SpamDiagnosticOutput": "1:99",
        "SpamDiagnosticMetadata": "NSPM",
        "X-OriginatorOrg": "cavium.com",
        "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "19 Sep 2017 01:31:24.3869\n\t(UTC)",
        "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted",
        "X-MS-Exchange-CrossTenant-Id": "711e4ccf-2e9b-4bcf-a551-4094005b6194",
        "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "SN4PR0701MB3838",
        "Subject": "[dpdk-dev] [PATCH 27/53] net/qede/base: prevent stop vport assert\n\tby malicious VF",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "PF checks upon stop-vport from VF whether it's legal, but if it's not it\nwould STILL send the request to FW, which might cause it to assert.\n\nSigned-off-by: Rasesh Mody <rasesh.mody@cavium.com>\n---\n drivers/net/qede/base/ecore_sriov.c |    3 +++\n 1 file changed, 3 insertions(+)",
    "diff": "diff --git a/drivers/net/qede/base/ecore_sriov.c b/drivers/net/qede/base/ecore_sriov.c\nindex a70ca30..792cf75 100644\n--- a/drivers/net/qede/base/ecore_sriov.c\n+++ b/drivers/net/qede/base/ecore_sriov.c\n@@ -2121,6 +2121,8 @@ static void ecore_iov_vf_mbx_stop_vport(struct ecore_hwfn *p_hwfn,\n \t\t\t  \"VF [%02x] - considered malicious;\"\n \t\t\t  \" Unable to stop RX/TX queuess\\n\",\n \t\t\t  vf->abs_vf_id);\n+\t\tstatus = PFVF_STATUS_MALICIOUS;\n+\t\tgoto out;\n \t}\n \n \trc = ecore_sp_vport_stop(p_hwfn, vf->opaque_fid, vf->vport_id);\n@@ -2134,6 +2136,7 @@ static void ecore_iov_vf_mbx_stop_vport(struct ecore_hwfn *p_hwfn,\n \tvf->configured_features = 0;\n \tOSAL_MEMSET(&vf->shadow_config, 0, sizeof(vf->shadow_config));\n \n+out:\n \tecore_iov_prepare_resp(p_hwfn, p_ptt, vf, CHANNEL_TLV_VPORT_TEARDOWN,\n \t\t\t       sizeof(struct pfvf_def_resp_tlv), status);\n }\n",
    "prefixes": [
        "dpdk-dev",
        "27/53"
    ]
}