Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/28688/?format=api
{ "id": 28688, "url": "http://patches.dpdk.org/api/patches/28688/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20170913072249.29797-3-pablo.de.lara.guarch@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20170913072249.29797-3-pablo.de.lara.guarch@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20170913072249.29797-3-pablo.de.lara.guarch@intel.com", "date": "2017-09-13T07:22:44", "name": "[dpdk-dev,v2,2/7] app/crypto-perf: parse AEAD data from vectors", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e43979e26b062665f689b6e3bcc008202e415d0b", "submitter": { "id": 9, "url": "http://patches.dpdk.org/api/people/9/?format=api", "name": "De Lara Guarch, Pablo", "email": "pablo.de.lara.guarch@intel.com" }, "delegate": { "id": 22, "url": "http://patches.dpdk.org/api/users/22/?format=api", "username": "pdelarag", "first_name": "Pablo", "last_name": "de Lara Guarch", "email": "pablo.de.lara.guarch@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20170913072249.29797-3-pablo.de.lara.guarch@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/28688/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/28688/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id F2AF11B192;\n\tWed, 13 Sep 2017 17:22:32 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id 27A881B19B;\n\tWed, 13 Sep 2017 17:22:30 +0200 (CEST)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t13 Sep 2017 08:22:29 -0700", "from silpixa00399464.ir.intel.com (HELO\n\tsilpixa00399464.ger.corp.intel.com) ([10.237.222.157])\n\tby fmsmga006.fm.intel.com with ESMTP; 13 Sep 2017 08:22:27 -0700" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.42,388,1500966000\"; d=\"scan'208\";a=\"151419308\"", "From": "Pablo de Lara <pablo.de.lara.guarch@intel.com>", "To": "declan.doherty@intel.com, akhil.goyal@nxp.com, hemant.agrawal@nxp.com,\n\tjerin.jacob@caviumnetworks.com, fiona.trahe@intel.com,\n\tdeepak.k.jain@intel.com, john.griffin@intel.com", "Cc": "dev@dpdk.org, Pablo de Lara <pablo.de.lara.guarch@intel.com>,\n\tstable@dpdk.org", "Date": "Wed, 13 Sep 2017 08:22:44 +0100", "Message-Id": "<20170913072249.29797-3-pablo.de.lara.guarch@intel.com>", "X-Mailer": "git-send-email 2.9.4", "In-Reply-To": "<20170913072249.29797-1-pablo.de.lara.guarch@intel.com>", "References": "<20170818080520.43088-1-pablo.de.lara.guarch@intel.com>\n\t<20170913072249.29797-1-pablo.de.lara.guarch@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 2/7] app/crypto-perf: parse AEAD data from\n\tvectors", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Since DPDK 17.08, there is specific parameters\nfor AEAD algorithm, like AES-GCM. When verifying\ncrypto operations with test vectors, the parser\nwas not reading AEAD data (such as IV or key).\n\nFixes: 8a5b494a7f99 (\"app/test-crypto-perf: add AEAD parameters\")\nCc: stable@dpdk.org\n\nSigned-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>\n---\n app/test-crypto-perf/cperf_test_vector_parsing.c | 55 ++++++++++++++++++++++++\n 1 file changed, 55 insertions(+)", "diff": "diff --git a/app/test-crypto-perf/cperf_test_vector_parsing.c b/app/test-crypto-perf/cperf_test_vector_parsing.c\nindex 148a604..3952632 100644\n--- a/app/test-crypto-perf/cperf_test_vector_parsing.c\n+++ b/app/test-crypto-perf/cperf_test_vector_parsing.c\n@@ -116,6 +116,20 @@ show_test_vector(struct cperf_test_vector *test_vector)\n \t\tprintf(\"\\n\");\n \t}\n \n+\tif (test_vector->aead_key.data) {\n+\t\tprintf(\"\\naead_key =\\n\");\n+\t\tfor (i = 0; i < test_vector->aead_key.length; ++i) {\n+\t\t\tif ((i % wrap == 0) && (i != 0))\n+\t\t\t\tprintf(\"\\n\");\n+\t\t\tif (i == (uint32_t)(test_vector->aead_key.length - 1))\n+\t\t\t\tprintf(\"0x%02x\", test_vector->aead_key.data[i]);\n+\t\t\telse\n+\t\t\t\tprintf(\"0x%02x, \",\n+\t\t\t\t\ttest_vector->aead_key.data[i]);\n+\t\t}\n+\t\tprintf(\"\\n\");\n+\t}\n+\n \tif (test_vector->cipher_iv.data) {\n \t\tprintf(\"\\ncipher_iv =\\n\");\n \t\tfor (i = 0; i < test_vector->cipher_iv.length; ++i) {\n@@ -142,6 +156,19 @@ show_test_vector(struct cperf_test_vector *test_vector)\n \t\tprintf(\"\\n\");\n \t}\n \n+\tif (test_vector->aead_iv.data) {\n+\t\tprintf(\"\\naead_iv =\\n\");\n+\t\tfor (i = 0; i < test_vector->aead_iv.length; ++i) {\n+\t\t\tif ((i % wrap == 0) && (i != 0))\n+\t\t\t\tprintf(\"\\n\");\n+\t\t\tif (i == (uint32_t)(test_vector->aead_iv.length - 1))\n+\t\t\t\tprintf(\"0x%02x\", test_vector->aead_iv.data[i]);\n+\t\t\telse\n+\t\t\t\tprintf(\"0x%02x, \", test_vector->aead_iv.data[i]);\n+\t\t}\n+\t\tprintf(\"\\n\");\n+\t}\n+\n \tif (test_vector->ciphertext.data) {\n \t\tprintf(\"\\nciphertext =\\n\");\n \t\tfor (i = 0; i < test_vector->ciphertext.length; ++i) {\n@@ -345,6 +372,20 @@ parse_entry(char *entry, struct cperf_test_vector *vector,\n \t\t\tvector->auth_key.length = opts->auth_key_sz;\n \t\t}\n \n+\t} else if (strstr(key_token, \"aead_key\")) {\n+\t\trte_free(vector->aead_key.data);\n+\t\tvector->aead_key.data = data;\n+\t\tif (tc_found)\n+\t\t\tvector->aead_key.length = data_length;\n+\t\telse {\n+\t\t\tif (opts->aead_key_sz > data_length) {\n+\t\t\t\tprintf(\"Global aead_key shorter than \"\n+\t\t\t\t\t\"aead_key_sz\\n\");\n+\t\t\t\treturn -1;\n+\t\t\t}\n+\t\t\tvector->aead_key.length = opts->aead_key_sz;\n+\t\t}\n+\n \t} else if (strstr(key_token, \"cipher_iv\")) {\n \t\trte_free(vector->cipher_iv.data);\n \t\tvector->cipher_iv.data = data;\n@@ -373,6 +414,20 @@ parse_entry(char *entry, struct cperf_test_vector *vector,\n \t\t\tvector->auth_iv.length = opts->auth_iv_sz;\n \t\t}\n \n+\t} else if (strstr(key_token, \"aead_iv\")) {\n+\t\trte_free(vector->aead_iv.data);\n+\t\tvector->aead_iv.data = data;\n+\t\tif (tc_found)\n+\t\t\tvector->aead_iv.length = data_length;\n+\t\telse {\n+\t\t\tif (opts->aead_iv_sz > data_length) {\n+\t\t\t\tprintf(\"Global aead iv shorter than \"\n+\t\t\t\t\t\"aead_iv_sz\\n\");\n+\t\t\t\treturn -1;\n+\t\t\t}\n+\t\t\tvector->aead_iv.length = opts->aead_iv_sz;\n+\t\t}\n+\n \t} else if (strstr(key_token, \"ciphertext\")) {\n \t\trte_free(vector->ciphertext.data);\n \t\tvector->ciphertext.data = data;\n", "prefixes": [ "dpdk-dev", "v2", "2/7" ] }