Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 28588,
    "url": "http://patches.dpdk.org/api/patches/28588/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20170911151333.5727-2-olivier.matz@6wind.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20170911151333.5727-2-olivier.matz@6wind.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20170911151333.5727-2-olivier.matz@6wind.com",
    "date": "2017-09-11T15:13:24",
    "name": "[dpdk-dev,01/10] net/bnxt: fix compilation with -Og",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "ab8c9fedd3b043746a36069e899af164b85d241d",
    "submitter": {
        "id": 8,
        "url": "http://patches.dpdk.org/api/people/8/?format=api",
        "name": "Olivier Matz",
        "email": "olivier.matz@6wind.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20170911151333.5727-2-olivier.matz@6wind.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/28588/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/28588/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E0EF21B1A7;\n\tMon, 11 Sep 2017 17:13:57 +0200 (CEST)",
            "from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com\n\t[62.23.145.76]) by dpdk.org (Postfix) with ESMTP id D17E6199B0\n\tfor <dev@dpdk.org>; Mon, 11 Sep 2017 17:13:51 +0200 (CEST)",
            "from glumotte.dev.6wind.com (unknown [10.16.0.195])\n\tby proxy.6wind.com (Postfix) with ESMTP id A2D20CF329\n\tfor <dev@dpdk.org>; Mon, 11 Sep 2017 17:09:57 +0200 (CEST)"
        ],
        "From": "Olivier Matz <olivier.matz@6wind.com>",
        "To": "dev@dpdk.org",
        "Date": "Mon, 11 Sep 2017 17:13:24 +0200",
        "Message-Id": "<20170911151333.5727-2-olivier.matz@6wind.com>",
        "X-Mailer": "git-send-email 2.11.0",
        "In-Reply-To": "<20170911151333.5727-1-olivier.matz@6wind.com>",
        "References": "<20170911151333.5727-1-olivier.matz@6wind.com>",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain; charset=UTF-8",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH 01/10] net/bnxt: fix compilation with -Og",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The compilation with gcc-6.3.0 and EXTRA_CFLAGS=-Og gives the following\nerror:\n\n  CC rte_pmd_bnxt.o\n  rte_pmd_bnxt.c: In function ‘rte_pmd_bnxt_set_all_queues_drop_en’:\n  rte_pmd_bnxt.c:116:6: error: ‘rc’ may be used uninitialized in this\n                        function [-Werror=maybe-uninitialized]\n    int rc;\n        ^~\n\nThis can happen if both bp->nr_vnics and bp->pf.active_vfs are 0.\nFix it by initializing rc to -EINVAL.\n\nFixes: 49947a13ba9e (\"net/bnxt: support Tx loopback, set VF MAC and queues drop\")\n\nSigned-off-by: Olivier Matz <olivier.matz@6wind.com>\n---\n drivers/net/bnxt/rte_pmd_bnxt.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/net/bnxt/rte_pmd_bnxt.c b/drivers/net/bnxt/rte_pmd_bnxt.c\nindex c343d9033..484a1cb63 100644\n--- a/drivers/net/bnxt/rte_pmd_bnxt.c\n+++ b/drivers/net/bnxt/rte_pmd_bnxt.c\n@@ -113,7 +113,7 @@ int rte_pmd_bnxt_set_all_queues_drop_en(uint8_t port, uint8_t on)\n \tstruct rte_eth_dev *eth_dev;\n \tstruct bnxt *bp;\n \tuint32_t i;\n-\tint rc;\n+\tint rc = -EINVAL;\n \n \tRTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV);\n \n",
    "prefixes": [
        "dpdk-dev",
        "01/10"
    ]
}