Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/28444/?format=api
{ "id": 28444, "url": "http://patches.dpdk.org/api/patches/28444/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20170907121347.16208-2-olivier.matz@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20170907121347.16208-2-olivier.matz@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20170907121347.16208-2-olivier.matz@6wind.com", "date": "2017-09-07T12:13:38", "name": "[dpdk-dev,v2,01/10] net/virtio: revert \"do not claim to support LRO\"", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d1f34e038bd583b562e59aacac3a1b857498a683", "submitter": { "id": 8, "url": "http://patches.dpdk.org/api/people/8/?format=api", "name": "Olivier Matz", "email": "olivier.matz@6wind.com" }, "delegate": { "id": 355, "url": "http://patches.dpdk.org/api/users/355/?format=api", "username": "yliu", "first_name": "Yuanhan", "last_name": "Liu", "email": "yuanhan.liu@linux.intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20170907121347.16208-2-olivier.matz@6wind.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/28444/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/28444/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 52445199B6;\n\tThu, 7 Sep 2017 14:14:03 +0200 (CEST)", "from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com\n\t[62.23.145.76]) by dpdk.org (Postfix) with ESMTP id 320F1199B1;\n\tThu, 7 Sep 2017 14:14:01 +0200 (CEST)", "from glumotte.dev.6wind.com (unknown [10.16.0.195])\n\tby proxy.6wind.com (Postfix) with ESMTP id E1580CD5C1;\n\tThu, 7 Sep 2017 14:10:16 +0200 (CEST)" ], "From": "Olivier Matz <olivier.matz@6wind.com>", "To": "dev@dpdk.org,\n\tyliu@fridaylinux.org,\n\tmaxime.coquelin@redhat.com", "Cc": "stephen@networkplumber.org,\n\tstable@dpdk.org", "Date": "Thu, 7 Sep 2017 14:13:38 +0200", "Message-Id": "<20170907121347.16208-2-olivier.matz@6wind.com>", "X-Mailer": "git-send-email 2.11.0", "In-Reply-To": "<20170907121347.16208-1-olivier.matz@6wind.com>", "References": "<20170831134015.1383-1-olivier.matz@6wind.com>\n\t<20170907121347.16208-1-olivier.matz@6wind.com>", "Subject": "[dpdk-dev] [PATCH v2 01/10] net/virtio: revert \"do not claim to\n\tsupport LRO\"", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This reverts\ncommit 701a64622c26 (\"net/virtio: do not claim to support LRO\")\n\nSetting rxmode->enable_lro is a way to tell the host that the guest is\nok to receive tso packets. From the guest point of view, it is like\nenabling LRO on a physical driver.\n\nFixes: 701a64622c26 (\"net/virtio: do not claim to support LRO\")\nCc: stable@dpdk.org\n\nSigned-off-by: Olivier Matz <olivier.matz@6wind.com>\n---\n drivers/net/virtio/virtio_ethdev.c | 21 +++++++++++++++++++--\n 1 file changed, 19 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c\nindex e320811ed..eb2d95acd 100644\n--- a/drivers/net/virtio/virtio_ethdev.c\n+++ b/drivers/net/virtio/virtio_ethdev.c\n@@ -1659,9 +1659,11 @@ virtio_dev_configure(struct rte_eth_dev *dev)\n {\n \tconst struct rte_eth_rxmode *rxmode = &dev->data->dev_conf.rxmode;\n \tstruct virtio_hw *hw = dev->data->dev_private;\n+\tuint64_t req_features;\n \tint ret;\n \n \tPMD_INIT_LOG(DEBUG, \"configure\");\n+\treq_features = VIRTIO_PMD_DEFAULT_GUEST_FEATURES;\n \n \tif (dev->data->dev_conf.intr_conf.rxq) {\n \t\tret = virtio_init_device(dev, hw->req_guest_features);\n@@ -1675,10 +1677,23 @@ virtio_dev_configure(struct rte_eth_dev *dev)\n \t\t\t \"virtio does not support IP checksum\");\n \t\treturn -ENOTSUP;\n \t}\n+\tif (rxmode->enable_lro)\n+\t\treq_features |=\n+\t\t\t(1ULL << VIRTIO_NET_F_GUEST_TSO4) |\n+\t\t\t(1ULL << VIRTIO_NET_F_GUEST_TSO6);\n \n-\tif (rxmode->enable_lro) {\n+\t/* if request features changed, reinit the device */\n+\tif (req_features != hw->req_guest_features) {\n+\t\tret = virtio_init_device(dev, req_features);\n+\t\tif (ret < 0)\n+\t\t\treturn ret;\n+\t}\n+\n+\tif (rxmode->enable_lro &&\n+\t\t(!vtpci_with_feature(hw, VIRTIO_NET_F_GUEST_TSO4) ||\n+\t\t\t!vtpci_with_feature(hw, VIRTIO_NET_F_GUEST_TSO4))) {\n \t\tPMD_DRV_LOG(NOTICE,\n-\t\t\t \"virtio does not support Large Receive Offload\");\n+\t\t\t\"Large Receive Offload not available on this host\");\n \t\treturn -ENOTSUP;\n \t}\n \n@@ -1904,6 +1919,8 @@ virtio_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)\n \t}\n \ttso_mask = (1ULL << VIRTIO_NET_F_GUEST_TSO4) |\n \t\t(1ULL << VIRTIO_NET_F_GUEST_TSO6);\n+\tif ((host_features & tso_mask) == tso_mask)\n+\t\tdev_info->rx_offload_capa |= DEV_RX_OFFLOAD_TCP_LRO;\n \n \tdev_info->tx_offload_capa = 0;\n \tif (hw->guest_features & (1ULL << VIRTIO_NET_F_CSUM)) {\n", "prefixes": [ "dpdk-dev", "v2", "01/10" ] }