Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 28348,
    "url": "http://patches.dpdk.org/api/patches/28348/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1504603017-17657-1-git-send-email-wei.dai@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1504603017-17657-1-git-send-email-wei.dai@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1504603017-17657-1-git-send-email-wei.dai@intel.com",
    "date": "2017-09-05T09:16:57",
    "name": "[dpdk-dev] net/ixgbe: fix adding multiple mirror type in a rule",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "98e02d6666399219e3a4495b5de33ab44cf35b81",
    "submitter": {
        "id": 490,
        "url": "http://patches.dpdk.org/api/people/490/?format=api",
        "name": "Wei Dai",
        "email": "wei.dai@intel.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1504603017-17657-1-git-send-email-wei.dai@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/28348/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/28348/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 09BA2376C;\n\tTue,  5 Sep 2017 11:29:20 +0200 (CEST)",
            "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id 20A3C100F;\n\tTue,  5 Sep 2017 11:29:17 +0200 (CEST)",
            "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t05 Sep 2017 02:29:17 -0700",
            "from dpdk6.bj.intel.com ([172.16.182.87])\n\tby orsmga001.jf.intel.com with ESMTP; 05 Sep 2017 02:29:15 -0700"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos; i=\"5.41,479,1498546800\"; d=\"scan'208\";\n\ta=\"1169207691\"",
        "From": "Wei Dai <wei.dai@intel.com>",
        "To": "wenzhuo.lu@intel.com, konstantin.ananyev@intel.com, jingjing.wu@intel.com",
        "Cc": "dev@dpdk.org,\n\tWei Dai <wei.dai@intel.com>,\n\tstable@dpdk.org",
        "Date": "Tue,  5 Sep 2017 17:16:57 +0800",
        "Message-Id": "<1504603017-17657-1-git-send-email-wei.dai@intel.com>",
        "X-Mailer": "git-send-email 2.7.5",
        "Subject": "[dpdk-dev] [PATCH] net/ixgbe: fix adding multiple mirror type in a\n\trule",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "mirror rule_type can be a bit OR result of multiple mirror type of\na rule. Before the commit which introduced this issue, the code\nsupported adding multiple mirror type in a rule.\n\nFixes: 7ba29a76b196 (\"ethdev: rename and extend the mirror type\")\nCc: stable@dpdk.org\n\nSigned-off-by: Wei Dai <wei.dai@intel.com>\n---\n drivers/net/ixgbe/ixgbe_ethdev.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex 22171d8..858230d 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -5450,13 +5450,13 @@ ixgbe_mirror_rule_set(struct rte_eth_dev *dev,\n \tIXGBE_WRITE_REG(hw, IXGBE_MRCTL(rule_id), mr_ctl);\n \n \t/* write pool mirrror control  register */\n-\tif (mirror_conf->rule_type == ETH_MIRROR_VIRTUAL_POOL_UP) {\n+\tif (mirror_conf->rule_type & ETH_MIRROR_VIRTUAL_POOL_UP) {\n \t\tIXGBE_WRITE_REG(hw, IXGBE_VMRVM(rule_id), mp_lsb);\n \t\tIXGBE_WRITE_REG(hw, IXGBE_VMRVM(rule_id + rule_mr_offset),\n \t\t\t\tmp_msb);\n \t}\n \t/* write VLAN mirrror control  register */\n-\tif (mirror_conf->rule_type == ETH_MIRROR_VLAN) {\n+\tif (mirror_conf->rule_type & ETH_MIRROR_VLAN) {\n \t\tIXGBE_WRITE_REG(hw, IXGBE_VMRVLAN(rule_id), mv_lsb);\n \t\tIXGBE_WRITE_REG(hw, IXGBE_VMRVLAN(rule_id + rule_mr_offset),\n \t\t\t\tmv_msb);\n",
    "prefixes": [
        "dpdk-dev"
    ]
}