Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/28328/?format=api
{ "id": 28328, "url": "http://patches.dpdk.org/api/patches/28328/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1504533353-38337-1-git-send-email-matan@mellanox.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1504533353-38337-1-git-send-email-matan@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1504533353-38337-1-git-send-email-matan@mellanox.com", "date": "2017-09-04T13:55:53", "name": "[dpdk-dev,v3] net/mlx5: support device removal event", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "0294758bc280d81bef0eb1fa2d3bb6b5548d13d2", "submitter": { "id": 796, "url": "http://patches.dpdk.org/api/people/796/?format=api", "name": "Matan Azrad", "email": "matan@mellanox.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1504533353-38337-1-git-send-email-matan@mellanox.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/28328/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/28328/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 73F0D58F6;\n\tMon, 4 Sep 2017 15:56:17 +0200 (CEST)", "from EUR02-HE1-obe.outbound.protection.outlook.com\n\t(mail-eopbgr10066.outbound.protection.outlook.com [40.107.1.66])\n\tby dpdk.org (Postfix) with ESMTP id 49F4B37A0\n\tfor <dev@dpdk.org>; Mon, 4 Sep 2017 15:56:15 +0200 (CEST)", "from mellanox.com (37.142.13.130) by\n\tHE1PR0502MB3050.eurprd05.prod.outlook.com (2603:10a6:3:d9::15) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.13.10;\n\tMon, 4 Sep 2017 13:56:12 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n\ts=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=jHGOX6rXYJwtHIcBCYslLzB5lxWd9FPCS8dZyoxE8nw=;\n\tb=VPHT0w44WD/vng4ZHscixv09ApZgHpyZ2jraC6Ior+ccUdVFLXI9Kv6K7MXF7ya50MlcK8yhdrWrAqXKdoY428Ynye8kXhv+YPuVkRHExqjqjxhz8erLnX3cDF5RPkkBRMx06jp1idwEWQrnPJR7o/YmWvjJmug1k8aJoFApEY4=", "Authentication-Results": "spf=none (sender IP is )\n\tsmtp.mailfrom=matan@mellanox.com; ", "From": "Matan Azrad <matan@mellanox.com>", "To": "Nelio Laranjeiro <nelio.laranjeiro@6wind.com>", "Cc": "dev@dpdk.org", "Date": "Mon, 4 Sep 2017 16:55:53 +0300", "Message-Id": "<1504533353-38337-1-git-send-email-matan@mellanox.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<20170904124943.2pep4kbglu4q5qg4@localhost>", "References": "<20170904124943.2pep4kbglu4q5qg4@localhost>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[37.142.13.130]", "X-ClientProxiedBy": "HE1PR0402CA0038.eurprd04.prod.outlook.com\n\t(2603:10a6:7:7c::27) To HE1PR0502MB3050.eurprd05.prod.outlook.com\n\t(2603:10a6:3:d9::15)", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "d316141a-7f59-4476-a5e9-08d4f39cb46a", "X-MS-Office365-Filtering-HT": "Tenant", "X-Microsoft-Antispam": "UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:HE1PR0502MB3050; ", "X-Microsoft-Exchange-Diagnostics": [ "1; HE1PR0502MB3050;\n\t3:8JQsHkRhAkL7zx2ukwnvEvt6Pjhuf4bO2IoEGrJssViNKUGSt0CiENdAyjDFkhBhUZ3/maGICBJ+QVo4m0UKI7je0QS+ipqfv62qQh2oSSVLYj86RmRnqslEVWRi5mpG94IBZIPyIql3ibaMjG8yX5BGppmRcVybQRHnNzyV7HWJIyTCZ0LkA9QlJ6ngcPVwQUaySgLEKF2uXbzCVUBS6eqzNPvLlyXZswq/P8wUjgwBdrKXOpp1nIgaSEA/Ljsp;\n\t25:VIXwYZbYOs7TJFIXD1RZ2xdbGyi5qQLiCLK1rHdKBUDAIB2y/JocfcGqmds5MQEUeIoAEHUg61H7e2JTHmASBYzQNfoy0DeEoM7s11souVyjZul9MBySF+J+cxn3ZUFW18YfUhLr5Dk1KfQfF2lL9w3hEVlfWTankxfxZET0FChYAUKA9RuJ/CJ32TAglXGtWpDJkMndzAiyYcIsXoEpm4tVyjNZtcrknjuRxmoNu3s7j4KI86So8HsN9E8CdLN5hkdI/SPhWBTK0UlObY36xWtZpAQcKcprqc4UUhc2Pqj0MNNIxgFIwwZYyra1YhX2J3Ajt6Rtquim5sOnJkGpbg==;\n\t31:7nC9Or6WAskWZMRbGT+jy+9k+NyIFAjFPUshJY8Gtvn+vl4E4sQ3Oo4JRW0TtXu7BvGrFEo1HifcAFxVWSlmKw1uYgz2EkWIOE2TNP+HLcjpPOMOFv6k8O/bGzuaMdfHYWdFsWQYx+af7AOfPH0HbvTBIObHHAne2HprvutUAScu5Yz6DkVkvQ87mVg69Td/63cULzVlgFMtaYPElGaFow4F6SiVpGGWYhWRbz+BrWM=", "1; HE1PR0502MB3050;\n\t20:Wxrv9PV9u9OF1yiu+uVx5bG0FSkn7RboTcY4TvBMLKlUoBskKV6lKHjUWS+MJldUY1ZcImFmD0NKbTAWpWWF4JXp6nvTAO49VoFAN/J5h37r2vBZL5mG6hrzZnKskCYhOkvkv4mX8vH5rjK4uYv0op6PSKJSNRxub+uHSu0kcwNs/PNsM+VYAEDX1rrdD184azhW0LOlO9Frmu3zf9xGRlgyCViO1PMGYpRixYUT2WNg9qsyHXL6aQBFdk4A2LKF8YoKCxu45E0e5JI4uktf/piWFZZtwnzF1ectR0No9oOWQnDoDdEUFnUnD3XgwwGkE5pxe7Qguo9k1YvNdR2wuaFoR4Fg1rh9tZlorwF2x0w6emy9pvYQPQfh9UcyzfSB6ebTbKmR27RSce0+2qI/bldr03p42B3FwcUMxBWwqGdE8CC08+HJuZhMuSx5j/gEzPI0o0yGD8OvTsB8Pw/FN3ArNXdqZKATvO0SG1M84AMjNhclminKX4ASMltNOT1r;\n\t4:y0uHLP83toN3dbjq7gOpxlAp2tLC1fIeHOvPduOcD5iEQg5+ox+QD0hjp4XdXFwz9IhfZQ7V4M5dDcXkwOBokg+7Z3p5pgfjwI0JtjT7/vEseq3VFnllPrf+2nPafqi3EXWEDyhEzsnJprRWiykhvN6PVEJfXJgXDR6H816wovZOTTNd+0i/3KsGWIqNlKUhrEx0IfY06qc45PiPlv161pQxmosc1Br3nfzEDtoikwo5kXIa2QJHf8+UX5Hjo35QbmoBs0CZJQS58khad5LHGo+6Kfze1OzI2stP27JDUuM=", "=?us-ascii?Q?1; HE1PR0502MB3050;\n\t23:ePdr2aXKT2pDiZsSaeTd2Mu0eMrPtqefsN0LXZR?=\n\tuqFl7uo7HkS35IjlKjFaek5FS38A2aXvHP0ulehrtIS6x0DoQCfZbjWNbzAoNw9Xi4ajaHJg9JDZQHROMcNATt2Ii9+0fVqzUvjiYgvi1uj5WoujpaxTqExycLYURfi+OLp6gTxg6+ts+qEZSH3FxtRYw+WxyhmGAp5geGafxomomweEGj72A7yMdbsmSdeWDfoCoyT8XsDCjK/hu9qkCfUO9x6LTM8hXs13q/OqP2uc4k7ol3b1RbnJ72ffIxsRJs4ABuQzs7y8rxZEW84lZ+nTrePB7gRsU163IadaHWz4AsPHMSaH+6LBNxaPsIIkHFwpQXQEl78CY6sTK7sJwQvFieBtOuL2cmsO0zN1Pkfjy08PJgTQcJme7Xyz9eKUnscGzvcFIMp+Z5KepX3h9+fYC82MhVlsYdQ8KN4KIGIM4x1tePXln/pVJjeK+1P6OEvdI4G8QBpPKFpZaFMTWpQBXRHKvgzW1c8wWugULDrpdrU4uc/VACyvJoIPtld7cTUAzix0fCmxaI0KdXxfnMsA4wQX+4j+QPQwtsP5TCPuFseHOQYbkeR+FOUP+hUE/6Ko3a11/uAbECY3tEcDHjWRqjxiR6nqqPJ30c1rOfGlqw1rjUERfqkOXTxAbkpKd83eYKaUHtq6hNuGI6f4v2uX4eWk7DSJpaNzOthI7SaQ1+k17OsUf+Pdi64eAvFETu+ps+PjwhUCZEfkv1SxUgwqM1NSmo8WvjBwN4b951pIFjoZPIV2dQD+jc1ffpUwYVdJC0z9KwjnY1t6onr4vpNOEUqS/Oh1q5msFFjK5a23/DVG3KojMWvtK4vF73wwJ+5zhCXBVIyU2WU4cOpuCsmFKVIT4ubkN5cJqrTvHYum2qiRHc+ircYY3uJl5A/9FfBV/gc59jG/PGE0pZ9F+qJWFurhGmb6YX5a59HnSVhZJHLQMpZ4vhypO0eUJbWoblIXDdFkZ0Mjt+4YijNhQfIfgjLAsJzNMUyrYsIJRVm6h3w1Y94WNkVpPgIIBbRDc9ubNXBDjIT2Zlg8Zk9nGoZKZSC14/g7Y2AYrYz8TpNrbWBPyJ6HxYEOILPZZzTR5mwy4HBQGJAXDr8kx5vb5Nrvs", "1; HE1PR0502MB3050;\n\t6:shryq/KyqBaP7npMWumuNlyuf2sXMMK2fVpZYZYMRICz1Umi/Dae4r6rYMZ32/yd/6/8gXY4lvx3cpag8E6oUTq0UeRjuiiVCggbLvOFEzatHplJSSibtOMvdtH7YmLfRCpnJpMxkIcZSk02xaufEE/lJMYouTaGeJ/Qhczzaj+ex6U5Ff0zdzwwiNdS0u3zzjXvgDvZvuz/pvbt42kB3rjZ3vE3tQT17K5JHf7gKYpO3UfMcFR3wHFhZjtfio2bC862IR9FEMPGOJQDanWXI7dGr0uxGKjljn8Z2oHaQSfJq2DPxE73JOYYfMKnSk2JhCZq2PP+nlc4RyPXap8jEA==;\n\t5:LKef7k8iZAKBPv+vyJM/4EnvIbEh/fM9KTmAZPJomnu0Mswoss5PLHiIbftaROONGQA6BjlfyeRx25ZI/QHEfwGJ+eaagfn620oAsKMl2/s8qFSBfzg9d0HJj8FA0jwkY86mro5LN62P2QezKCqaBA==;\n\t24:8zacQCyZU4IBDYV8FcAqOobgGbdDvUC77MCgypi5YXaFYv2Uw2lo56+tzDstR48Keh5Knevx9kDqikbMCGbjwITrGhq8Y7V/mmcxLBt70fg=;\n\t7:pfHri6W0PlwkBD9KAqV388K2Tq+2asOPLPdK44AnYkV29rIQ9hrSIBz8dmNsewCwoEHAVScm+X8JrGb/RG9QXZFacitcSqO5C9Paf+yHWFmoN/IhN2IbFSiO3DpaReEUJGv8Hng1wRIzBna7BPOUki/p4Us3C0FGhVjW0aO/yFy4pW2d+FsZ4BKNsOuINWLT91akkW1OXQMK86MuBwcCpEI+jfYmk4aGLXGaeedbLEA=" ], "X-MS-TrafficTypeDiagnostic": "HE1PR0502MB3050:", "X-LD-Processed": "a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr", "X-Exchange-Antispam-Report-Test": "UriScan:(788757137089);", "X-Microsoft-Antispam-PRVS": "<HE1PR0502MB30502C36DD5BFC4117C7C81CD2910@HE1PR0502MB3050.eurprd05.prod.outlook.com>", "X-Exchange-Antispam-Report-CFA-Test": "BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(10201501046)(100000703101)(100105400095)(6055026)(6041248)(20161123555025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123558100)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:HE1PR0502MB3050; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:HE1PR0502MB3050; ", "X-Forefront-PRVS": "0420213CCD", "X-Forefront-Antispam-Report": "SFV:NSPM;\n\tSFS:(10009020)(7370300001)(4630300001)(6009001)(39860400002)(199003)(189002)(25786009)(5660300001)(110136004)(33026002)(53936002)(478600001)(2950100002)(6916009)(50466002)(48376002)(6666003)(189998001)(55016002)(4326008)(21086003)(68736007)(47776003)(86362001)(69596002)(36756003)(7350300001)(7736002)(305945005)(42186005)(5003940100001)(33646002)(2906002)(6116002)(3846002)(105586002)(97736004)(50986999)(76176999)(81156014)(8676002)(101416001)(81166006)(106356001)(50226002)(66066001);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0502MB3050; H:mellanox.com; FPR:;\n\tSPF:None; \n\tPTR:InfoNoRecords; A:1; MX:1; LANG:en; ", "Received-SPF": "None (protection.outlook.com: mellanox.com does not designate\n\tpermitted sender hosts)", "SpamDiagnosticOutput": "1:99", "SpamDiagnosticMetadata": "NSPM", "X-OriginatorOrg": "Mellanox.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "04 Sep 2017 13:56:12.8262\n\t(UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "HE1PR0502MB3050", "Subject": "[dpdk-dev] [PATCH v3] net/mlx5: support device removal event", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Extend the LSC event handling to support the device removal as well.\nThe Verbs library may send several related events, which are\ndifferent from LSC event.\n\nThe mlx5 event handling has been made capable of receiving and\nsignaling several event types at once.\n\nThis support includes next:\n1. Removal event detection according to the user configuration.\n2. Calling to all registered mlx5 removal callbacks.\n3. Capabilities extension to include removal interrupt handling.\n\nSigned-off-by: Matan Azrad <matan@mellanox.com>\n---\n drivers/net/mlx5/mlx5.c | 2 +-\n drivers/net/mlx5/mlx5_ethdev.c | 103 +++++++++++++++++++++++++++++------------\n 2 files changed, 74 insertions(+), 31 deletions(-)\n\nChanges:\nV2:\nReplace link status update function name.\nadd inconsistent link workaround comment.\n\nV3:\nFix indentations.\nAccurate inconsistent link comment.", "diff": "diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c\nindex bd66a7c..1a3d7f1 100644\n--- a/drivers/net/mlx5/mlx5.c\n+++ b/drivers/net/mlx5/mlx5.c\n@@ -865,7 +865,7 @@ static struct rte_pci_driver mlx5_driver = {\n \t},\n \t.id_table = mlx5_pci_id_map,\n \t.probe = mlx5_pci_probe,\n-\t.drv_flags = RTE_PCI_DRV_INTR_LSC,\n+\t.drv_flags = RTE_PCI_DRV_INTR_LSC | RTE_PCI_DRV_INTR_RMV,\n };\n \n /**\ndiff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c\nindex 57f6237..cdbd723 100644\n--- a/drivers/net/mlx5/mlx5_ethdev.c\n+++ b/drivers/net/mlx5/mlx5_ethdev.c\n@@ -1112,47 +1112,84 @@ mlx5_ibv_device_to_pci_addr(const struct ibv_device *device,\n }\n \n /**\n- * Link status handler.\n+ * Update the link status.\n *\n * @param priv\n * Pointer to private structure.\n- * @param dev\n- * Pointer to the rte_eth_dev structure.\n *\n * @return\n- * Nonzero if the callback process can be called immediately.\n+ * Zero if the callback process can be called immediately.\n */\n static int\n-priv_dev_link_status_handler(struct priv *priv, struct rte_eth_dev *dev)\n+priv_link_status_update(struct priv *priv)\n+{\n+\tstruct rte_eth_link *link = &priv->dev->data->dev_link;\n+\n+\tmlx5_link_update(priv->dev, 0);\n+\tif (((link->link_speed == 0) && link->link_status) ||\n+\t\t((link->link_speed != 0) && !link->link_status)) {\n+\t\t/*\n+\t\t * Inconsistent status.\n+\t\t * The link status is read from Ethtool through an IOCTL,\n+\t\t * but as the application may work in polling mode it\n+\t\t * may get the port event before the Kernel driver had\n+\t\t * time to process it. PMD then request the link from\n+\t\t * the kernel but the event is still not processed (due\n+\t\t * to more urgent interrupts) and finally the PMD may\n+\t\t * get an inconsistent link.\n+\t\t * Setting alarm for later checking.\n+\t\t */\n+\t\tif (!priv->pending_alarm) {\n+\t\t\tpriv->pending_alarm = 1;\n+\t\t\trte_eal_alarm_set(MLX5_ALARM_TIMEOUT_US,\n+\t\t\t\t\t mlx5_dev_link_status_handler,\n+\t\t\t\t\t priv->dev);\n+\t\t}\n+\t\treturn 1;\n+\t} else if (unlikely(priv->pending_alarm)) {\n+\t\t/* In case of link interrupt while link alarm was setting. */\n+\t\tpriv->pending_alarm = 0;\n+\t\trte_eal_alarm_cancel(mlx5_dev_link_status_handler, priv->dev);\n+\t}\n+\treturn 0;\n+}\n+\n+/**\n+ * Device status handler.\n+ *\n+ * @param priv\n+ * Pointer to private structure.\n+ * @param events\n+ * Pointer to event flags holder.\n+ *\n+ * @return\n+ * Events bitmap of callback process which can be called immediately.\n+ */\n+static uint32_t\n+priv_dev_status_handler(struct priv *priv)\n {\n \tstruct ibv_async_event event;\n-\tstruct rte_eth_link *link = &dev->data->dev_link;\n-\tint ret = 0;\n+\tuint32_t ret = 0;\n \n \t/* Read all message and acknowledge them. */\n \tfor (;;) {\n \t\tif (ibv_get_async_event(priv->ctx, &event))\n \t\t\tbreak;\n-\n-\t\tif (event.event_type != IBV_EVENT_PORT_ACTIVE &&\n-\t\t event.event_type != IBV_EVENT_PORT_ERR)\n+\t\tif ((event.event_type == IBV_EVENT_PORT_ACTIVE ||\n+\t\t\tevent.event_type == IBV_EVENT_PORT_ERR) &&\n+\t\t\t(priv->dev->data->dev_conf.intr_conf.lsc == 1))\n+\t\t\tret |= (1 << RTE_ETH_EVENT_INTR_LSC);\n+\t\telse if (event.event_type == IBV_EVENT_DEVICE_FATAL &&\n+\t\t\tpriv->dev->data->dev_conf.intr_conf.rmv == 1)\n+\t\t\tret |= (1 << RTE_ETH_EVENT_INTR_RMV);\n+\t\telse\n \t\t\tDEBUG(\"event type %d on port %d not handled\",\n \t\t\t event.event_type, event.element.port_num);\n \t\tibv_ack_async_event(&event);\n \t}\n-\tmlx5_link_update(dev, 0);\n-\tif (((link->link_speed == 0) && link->link_status) ||\n-\t ((link->link_speed != 0) && !link->link_status)) {\n-\t\tif (!priv->pending_alarm) {\n-\t\t\t/* Inconsistent status, check again later. */\n-\t\t\tpriv->pending_alarm = 1;\n-\t\t\trte_eal_alarm_set(MLX5_ALARM_TIMEOUT_US,\n-\t\t\t\t\t mlx5_dev_link_status_handler,\n-\t\t\t\t\t dev);\n-\t\t}\n-\t} else {\n-\t\tret = 1;\n-\t}\n+\tif (ret & (1 << RTE_ETH_EVENT_INTR_LSC))\n+\t\tif (priv_link_status_update(priv))\n+\t\t\tret &= ~(1 << RTE_ETH_EVENT_INTR_LSC);\n \treturn ret;\n }\n \n@@ -1172,9 +1209,9 @@ mlx5_dev_link_status_handler(void *arg)\n \tpriv_lock(priv);\n \tassert(priv->pending_alarm == 1);\n \tpriv->pending_alarm = 0;\n-\tret = priv_dev_link_status_handler(priv, dev);\n+\tret = priv_link_status_update(priv);\n \tpriv_unlock(priv);\n-\tif (ret)\n+\tif (!ret)\n \t\t_rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC, NULL,\n \t\t\t\t\t NULL);\n }\n@@ -1192,14 +1229,17 @@ mlx5_dev_interrupt_handler(void *cb_arg)\n {\n \tstruct rte_eth_dev *dev = cb_arg;\n \tstruct priv *priv = dev->data->dev_private;\n-\tint ret;\n+\tuint32_t events;\n \n \tpriv_lock(priv);\n-\tret = priv_dev_link_status_handler(priv, dev);\n+\tevents = priv_dev_status_handler(priv);\n \tpriv_unlock(priv);\n-\tif (ret)\n+\tif (events & (1 << RTE_ETH_EVENT_INTR_LSC))\n \t\t_rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC, NULL,\n \t\t\t\t\t NULL);\n+\tif (events & (1 << RTE_ETH_EVENT_INTR_RMV))\n+\t\t_rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_RMV, NULL,\n+\t\t\t\t\t NULL);\n }\n \n /**\n@@ -1213,7 +1253,8 @@ mlx5_dev_interrupt_handler(void *cb_arg)\n void\n priv_dev_interrupt_handler_uninstall(struct priv *priv, struct rte_eth_dev *dev)\n {\n-\tif (!dev->data->dev_conf.intr_conf.lsc)\n+\tif (!dev->data->dev_conf.intr_conf.lsc &&\n+\t\t!dev->data->dev_conf.intr_conf.rmv)\n \t\treturn;\n \trte_intr_callback_unregister(&priv->intr_handle,\n \t\t\t\t mlx5_dev_interrupt_handler,\n@@ -1238,7 +1279,8 @@ priv_dev_interrupt_handler_install(struct priv *priv, struct rte_eth_dev *dev)\n {\n \tint rc, flags;\n \n-\tif (!dev->data->dev_conf.intr_conf.lsc)\n+\tif (!dev->data->dev_conf.intr_conf.lsc &&\n+\t\t!dev->data->dev_conf.intr_conf.rmv)\n \t\treturn;\n \tassert(priv->ctx->async_fd > 0);\n \tflags = fcntl(priv->ctx->async_fd, F_GETFL);\n@@ -1246,6 +1288,7 @@ priv_dev_interrupt_handler_install(struct priv *priv, struct rte_eth_dev *dev)\n \tif (rc < 0) {\n \t\tINFO(\"failed to change file descriptor async event queue\");\n \t\tdev->data->dev_conf.intr_conf.lsc = 0;\n+\t\tdev->data->dev_conf.intr_conf.rmv = 0;\n \t} else {\n \t\tpriv->intr_handle.fd = priv->ctx->async_fd;\n \t\tpriv->intr_handle.type = RTE_INTR_HANDLE_EXT;\n", "prefixes": [ "dpdk-dev", "v3" ] }