Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/27663/?format=api
{ "id": 27663, "url": "http://patches.dpdk.org/api/patches/27663/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20170818080728.43248-2-pablo.de.lara.guarch@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20170818080728.43248-2-pablo.de.lara.guarch@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20170818080728.43248-2-pablo.de.lara.guarch@intel.com", "date": "2017-08-18T08:07:24", "name": "[dpdk-dev,1/4] crypto/openssl: fix AEAD parameters", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "0fb0ed90f8e7a9e33926fb815b9f9a3ca916f899", "submitter": { "id": 9, "url": "http://patches.dpdk.org/api/people/9/?format=api", "name": "De Lara Guarch, Pablo", "email": "pablo.de.lara.guarch@intel.com" }, "delegate": { "id": 22, "url": "http://patches.dpdk.org/api/users/22/?format=api", "username": "pdelarag", "first_name": "Pablo", "last_name": "de Lara Guarch", "email": "pablo.de.lara.guarch@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20170818080728.43248-2-pablo.de.lara.guarch@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/27663/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/27663/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 8D3717D96;\n\tFri, 18 Aug 2017 18:07:12 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 8DCA211C5;\n\tFri, 18 Aug 2017 18:07:09 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t18 Aug 2017 09:07:08 -0700", "from silpixa00399464.ir.intel.com (HELO\n\tsilpixa00399464.ger.corp.intel.com) ([10.237.222.157])\n\tby fmsmga002.fm.intel.com with ESMTP; 18 Aug 2017 09:07:07 -0700" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.41,393,1498546800\"; d=\"scan'208\";\n\ta=\"1207260792\"", "From": "Pablo de Lara <pablo.de.lara.guarch@intel.com>", "To": "declan.doherty@intel.com", "Cc": "dev@dpdk.org, Pablo de Lara <pablo.de.lara.guarch@intel.com>,\n\tstable@dpdk.org", "Date": "Fri, 18 Aug 2017 09:07:24 +0100", "Message-Id": "<20170818080728.43248-2-pablo.de.lara.guarch@intel.com>", "X-Mailer": "git-send-email 2.9.4", "In-Reply-To": "<20170818080728.43248-1-pablo.de.lara.guarch@intel.com>", "References": "<20170818080728.43248-1-pablo.de.lara.guarch@intel.com>", "Subject": "[dpdk-dev] [PATCH 1/4] crypto/openssl: fix AEAD parameters", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When using AES-GCM with OpenSSL, cipher direction\nand authentication operation were being set incorrectly,\nas the PMD was looking at the cipher and authentication\ntransform, instead of the new AEAD.\n\nFixes: b79e4c00af0e (\"cryptodev: use AES-GCM/CCM as AEAD algorithms\")\nCc: stable@dpdk.org\n\nSigned-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>\n---\n drivers/crypto/openssl/rte_openssl_pmd.c | 15 +++++++++------\n 1 file changed, 9 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c b/drivers/crypto/openssl/rte_openssl_pmd.c\nindex 0bd5f98..2bc1570 100644\n--- a/drivers/crypto/openssl/rte_openssl_pmd.c\n+++ b/drivers/crypto/openssl/rte_openssl_pmd.c\n@@ -425,8 +425,15 @@ static int\n openssl_set_session_aead_parameters(struct openssl_session *sess,\n \t\tconst struct rte_crypto_sym_xform *xform)\n {\n-\t/* Select cipher direction */\n-\tsess->cipher.direction = xform->cipher.op;\n+\t/* Select cipher direction and auth operation */\n+\tif (xform->aead.op == RTE_CRYPTO_AEAD_OP_ENCRYPT) {\n+\t\tsess->cipher.direction = RTE_CRYPTO_CIPHER_OP_ENCRYPT;\n+\t\tsess->auth.operation = RTE_CRYPTO_AUTH_OP_GENERATE;\n+\t} else {\n+\t\tsess->cipher.direction = RTE_CRYPTO_CIPHER_OP_DECRYPT;\n+\t\tsess->auth.operation = RTE_CRYPTO_AUTH_OP_VERIFY;\n+\t}\n+\n \t/* Select cipher key */\n \tsess->cipher.key.length = xform->aead.key.length;\n \n@@ -434,10 +441,6 @@ openssl_set_session_aead_parameters(struct openssl_session *sess,\n \tsess->iv.offset = xform->aead.iv.offset;\n \tsess->iv.length = xform->aead.iv.length;\n \n-\t/* Select auth generate/verify */\n-\tsess->auth.operation = xform->auth.op;\n-\tsess->auth.algo = xform->auth.algo;\n-\n \t/* Select auth algo */\n \tswitch (xform->aead.algo) {\n \tcase RTE_CRYPTO_AEAD_AES_GCM:\n", "prefixes": [ "dpdk-dev", "1/4" ] }