Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 27652,
    "url": "http://patches.dpdk.org/api/patches/27652/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20170818072103.1416-6-pablo.de.lara.guarch@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20170818072103.1416-6-pablo.de.lara.guarch@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20170818072103.1416-6-pablo.de.lara.guarch@intel.com",
    "date": "2017-08-18T07:21:00",
    "name": "[dpdk-dev,5/8] crypto/snow3g: do not append digest",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "4c9dfbfd47e63b837358384be0d56cfd633a2578",
    "submitter": {
        "id": 9,
        "url": "http://patches.dpdk.org/api/people/9/?format=api",
        "name": "De Lara Guarch, Pablo",
        "email": "pablo.de.lara.guarch@intel.com"
    },
    "delegate": {
        "id": 22,
        "url": "http://patches.dpdk.org/api/users/22/?format=api",
        "username": "pdelarag",
        "first_name": "Pablo",
        "last_name": "de Lara Guarch",
        "email": "pablo.de.lara.guarch@intel.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20170818072103.1416-6-pablo.de.lara.guarch@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/27652/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/27652/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 32E6A7D4A;\n\tFri, 18 Aug 2017 17:21:09 +0200 (CEST)",
            "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 89A157D00\n\tfor <dev@dpdk.org>; Fri, 18 Aug 2017 17:21:03 +0200 (CEST)",
            "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t18 Aug 2017 08:20:53 -0700",
            "from silpixa00399464.ir.intel.com (HELO\n\tsilpixa00399464.ger.corp.intel.com) ([10.237.222.157])\n\tby fmsmga004.fm.intel.com with ESMTP; 18 Aug 2017 08:20:52 -0700"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.41,393,1498546800\"; d=\"scan'208\";a=\"301831047\"",
        "From": "Pablo de Lara <pablo.de.lara.guarch@intel.com>",
        "To": "declan.doherty@intel.com,\n\tjerin.jacob@caviumnetworks.com",
        "Cc": "dev@dpdk.org,\n\tPablo de Lara <pablo.de.lara.guarch@intel.com>",
        "Date": "Fri, 18 Aug 2017 08:21:00 +0100",
        "Message-Id": "<20170818072103.1416-6-pablo.de.lara.guarch@intel.com>",
        "X-Mailer": "git-send-email 2.9.4",
        "In-Reply-To": "<20170818072103.1416-1-pablo.de.lara.guarch@intel.com>",
        "References": "<20170818072103.1416-1-pablo.de.lara.guarch@intel.com>",
        "Subject": "[dpdk-dev] [PATCH 5/8] crypto/snow3g: do not append digest",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "When performing an authentication verification,\nthe PMD was using memory at the end of the input buffer,\nto store temporarily the digest.\nThis operation requires the buffer to have enough\ntailroom unnecessarily.\nInstead, memory is allocated for each queue pair, to store\ntemporarily the digest generated by the driver, so it can\nbe compared with the one provided in the crypto operation,\nwithout needing to touch the input buffer.\n\nSigned-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>\n---\n drivers/crypto/snow3g/rte_snow3g_pmd.c         | 22 ++++++++--------------\n drivers/crypto/snow3g/rte_snow3g_pmd_private.h |  7 +++++++\n 2 files changed, 15 insertions(+), 14 deletions(-)",
    "diff": "diff --git a/drivers/crypto/snow3g/rte_snow3g_pmd.c b/drivers/crypto/snow3g/rte_snow3g_pmd.c\nindex dad4506..2083699 100644\n--- a/drivers/crypto/snow3g/rte_snow3g_pmd.c\n+++ b/drivers/crypto/snow3g/rte_snow3g_pmd.c\n@@ -43,7 +43,6 @@\n #include \"rte_snow3g_pmd_private.h\"\n \n #define SNOW3G_IV_LENGTH 16\n-#define SNOW3G_DIGEST_LENGTH 4\n #define SNOW3G_MAX_BURST 8\n #define BYTE_LEN 8\n \n@@ -263,7 +262,7 @@ process_snow3g_cipher_op_bit(struct rte_crypto_op *op,\n \n /** Generate/verify hash from mbufs with same hash key. */\n static int\n-process_snow3g_hash_op(struct rte_crypto_op **ops,\n+process_snow3g_hash_op(struct snow3g_qp *qp, struct rte_crypto_op **ops,\n \t\tstruct snow3g_session *session,\n \t\tuint8_t num_ops)\n {\n@@ -289,8 +288,7 @@ process_snow3g_hash_op(struct rte_crypto_op **ops,\n \t\t\t\tsession->auth_iv_offset);\n \n \t\tif (session->auth_op == RTE_CRYPTO_AUTH_OP_VERIFY) {\n-\t\t\tdst = (uint8_t *)rte_pktmbuf_append(ops[i]->sym->m_src,\n-\t\t\t\t\tSNOW3G_DIGEST_LENGTH);\n+\t\t\tdst = (uint8_t *)&qp->temp_digest;\n \n \t\t\tsso_snow3g_f9_1_buffer(&session->pKeySched_hash,\n \t\t\t\t\tiv, src,\n@@ -299,10 +297,6 @@ process_snow3g_hash_op(struct rte_crypto_op **ops,\n \t\t\tif (memcmp(dst, ops[i]->sym->auth.digest.data,\n \t\t\t\t\tSNOW3G_DIGEST_LENGTH) != 0)\n \t\t\t\tops[i]->status = RTE_CRYPTO_OP_STATUS_AUTH_FAILED;\n-\n-\t\t\t/* Trim area used for digest from mbuf. */\n-\t\t\trte_pktmbuf_trim(ops[i]->sym->m_src,\n-\t\t\t\t\tSNOW3G_DIGEST_LENGTH);\n \t\t} else  {\n \t\t\tdst = ops[i]->sym->auth.digest.data;\n \n@@ -346,16 +340,16 @@ process_ops(struct rte_crypto_op **ops, struct snow3g_session *session,\n \t\t\t\tsession, num_ops);\n \t\tbreak;\n \tcase SNOW3G_OP_ONLY_AUTH:\n-\t\tprocessed_ops = process_snow3g_hash_op(ops, session,\n+\t\tprocessed_ops = process_snow3g_hash_op(qp, ops, session,\n \t\t\t\tnum_ops);\n \t\tbreak;\n \tcase SNOW3G_OP_CIPHER_AUTH:\n \t\tprocessed_ops = process_snow3g_cipher_op(ops, session,\n \t\t\t\tnum_ops);\n-\t\tprocess_snow3g_hash_op(ops, session, processed_ops);\n+\t\tprocess_snow3g_hash_op(qp, ops, session, processed_ops);\n \t\tbreak;\n \tcase SNOW3G_OP_AUTH_CIPHER:\n-\t\tprocessed_ops = process_snow3g_hash_op(ops, session,\n+\t\tprocessed_ops = process_snow3g_hash_op(qp, ops, session,\n \t\t\t\tnum_ops);\n \t\tprocess_snow3g_cipher_op(ops, session, processed_ops);\n \t\tbreak;\n@@ -403,15 +397,15 @@ process_op_bit(struct rte_crypto_op *op, struct snow3g_session *session,\n \t\t\t\tsession);\n \t\tbreak;\n \tcase SNOW3G_OP_ONLY_AUTH:\n-\t\tprocessed_op = process_snow3g_hash_op(&op, session, 1);\n+\t\tprocessed_op = process_snow3g_hash_op(qp, &op, session, 1);\n \t\tbreak;\n \tcase SNOW3G_OP_CIPHER_AUTH:\n \t\tprocessed_op = process_snow3g_cipher_op_bit(op, session);\n \t\tif (processed_op == 1)\n-\t\t\tprocess_snow3g_hash_op(&op, session, 1);\n+\t\t\tprocess_snow3g_hash_op(qp, &op, session, 1);\n \t\tbreak;\n \tcase SNOW3G_OP_AUTH_CIPHER:\n-\t\tprocessed_op = process_snow3g_hash_op(&op, session, 1);\n+\t\tprocessed_op = process_snow3g_hash_op(qp, &op, session, 1);\n \t\tif (processed_op == 1)\n \t\t\tprocess_snow3g_cipher_op_bit(op, session);\n \t\tbreak;\ndiff --git a/drivers/crypto/snow3g/rte_snow3g_pmd_private.h b/drivers/crypto/snow3g/rte_snow3g_pmd_private.h\nindex fba3cb8..7b9729f 100644\n--- a/drivers/crypto/snow3g/rte_snow3g_pmd_private.h\n+++ b/drivers/crypto/snow3g/rte_snow3g_pmd_private.h\n@@ -58,6 +58,8 @@\n #define SNOW3G_LOG_DBG(fmt, args...)\n #endif\n \n+#define SNOW3G_DIGEST_LENGTH 4\n+\n /** private data structure for each virtual SNOW 3G device */\n struct snow3g_private {\n \tunsigned max_nb_queue_pairs;\n@@ -78,6 +80,11 @@ struct snow3g_qp {\n \t/**< Session Mempool */\n \tstruct rte_cryptodev_stats qp_stats;\n \t/**< Queue pair statistics */\n+\tuint8_t temp_digest[SNOW3G_DIGEST_LENGTH];\n+\t/**< Buffer used to store the digest generated\n+\t * by the driver when verifying a digest provided\n+\t * by the user (using authentication verify operation)\n+\t */\n } __rte_cache_aligned;\n \n enum snow3g_operation {\n",
    "prefixes": [
        "dpdk-dev",
        "5/8"
    ]
}