Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/27641/?format=api
{ "id": 27641, "url": "http://patches.dpdk.org/api/patches/27641/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20170818125127.22346-3-shreyansh.jain@nxp.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20170818125127.22346-3-shreyansh.jain@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20170818125127.22346-3-shreyansh.jain@nxp.com", "date": "2017-08-18T12:51:23", "name": "[dpdk-dev,2/6] bus/fslmc: introduce new device type enumerator", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "cac6d52a2c3ccb1015b106110eb42989718672c4", "submitter": { "id": 497, "url": "http://patches.dpdk.org/api/people/497/?format=api", "name": "Shreyansh Jain", "email": "shreyansh.jain@nxp.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20170818125127.22346-3-shreyansh.jain@nxp.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/27641/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/27641/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 8ADD57D6E;\n\tFri, 18 Aug 2017 14:41:51 +0200 (CEST)", "from NAM03-DM3-obe.outbound.protection.outlook.com\n\t(mail-dm3nam03on0047.outbound.protection.outlook.com [104.47.41.47])\n\tby dpdk.org (Postfix) with ESMTP id 4A94A7D7F\n\tfor <dev@dpdk.org>; Fri, 18 Aug 2017 14:41:49 +0200 (CEST)", "from CY1PR03CA0034.namprd03.prod.outlook.com (10.174.128.44) by\n\tDM5PR03MB3324.namprd03.prod.outlook.com (10.174.241.145) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id\n\t15.1.1362.18; Fri, 18 Aug 2017 12:41:48 +0000", "from BY2FFO11FD036.protection.gbl (2a01:111:f400:7c0c::133) by\n\tCY1PR03CA0034.outlook.office365.com (2603:10b6:600::44) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id\n\t15.1.1362.18 via Frontend Transport; Fri, 18 Aug 2017 12:41:48 +0000", "from tx30smr01.am.freescale.net (192.88.168.50) by\n\tBY2FFO11FD036.mail.protection.outlook.com (10.1.14.221) with\n\tMicrosoft SMTP Server (version=TLS1_0,\n\tcipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1341.15\n\tvia Frontend Transport; Fri, 18 Aug 2017 12:41:47 +0000", "from Tophie.ap.freescale.net ([10.232.14.39])\n\tby tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id\n\tv7ICfeCI028231; Fri, 18 Aug 2017 05:41:45 -0700" ], "Authentication-Results": "spf=fail (sender IP is 192.88.168.50)\n\tsmtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed)\n\theader.d=none;nxp.com; dmarc=fail action=none header.from=nxp.com;", "Received-SPF": "Fail (protection.outlook.com: domain of nxp.com does not\n\tdesignate 192.88.168.50 as permitted sender)\n\treceiver=protection.outlook.com; \n\tclient-ip=192.88.168.50; helo=tx30smr01.am.freescale.net;", "From": "Shreyansh Jain <shreyansh.jain@nxp.com>", "To": "<dev@dpdk.org>", "CC": "<hemant.agrawal@nxp.com>, <thomas@monjalon.net>, Shreyansh Jain\n\t<shreyansh.jain@nxp.com>", "Date": "Fri, 18 Aug 2017 18:21:23 +0530", "Message-ID": "<20170818125127.22346-3-shreyansh.jain@nxp.com>", "X-Mailer": "git-send-email 2.9.3", "In-Reply-To": "<20170818125127.22346-1-shreyansh.jain@nxp.com>", "References": "<20170818125127.22346-1-shreyansh.jain@nxp.com>", "X-EOPAttributedMessage": "0", "X-Matching-Connectors": "131475337078513058;\n\t(91ab9b29-cfa4-454e-5278-08d120cd25b8); ()", "X-Forefront-Antispam-Report": "CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI;\n\tSFV:NSPM;\n\tSFS:(10009020)(6009001)(336005)(39380400002)(39860400002)(2980300002)(1109001)(1110001)(339900001)(189002)(199003)(6666003)(76176999)(2950100002)(6916009)(50986999)(85426001)(77096006)(189998001)(68736007)(5003940100001)(305945005)(356003)(86362001)(8936002)(50226002)(8676002)(81156014)(81166006)(106466001)(105606002)(2351001)(36756003)(33646002)(48376002)(50466002)(5660300001)(2906002)(104016004)(8656003)(1076002)(110136004)(97736004)(498600001)(53936002)(54906002)(4326008)(626005)(47776003);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR03MB3324;\n\tH:tx30smr01.am.freescale.net; \n\tFPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; ", "X-Microsoft-Exchange-Diagnostics": [ "1; BY2FFO11FD036;\n\t1:zG0T0oSrVjkT4lxUC1KPIzzDy7aZ5AAL0pAiI4fGiLWIibi8t4TGOWM5jTtClLbjiwZd28S5VO5tqSlFW6wT/s0WknBRWzTGZ4+y+alOq8YYAlCPC7KeryRDPQOl2vcB", "1; DM5PR03MB3324;\n\t3:b9UB/g5+NzP6E01guNvxuFpVuLKtGjgJksuaSyA/6UlTjMsIcGORA6UaeGyvQ0awveuIUTncIESuC5q0o0TAzZ/lQ2tZyziWwLtK6mhwJrj0VXTWUdqZ4FcJQ8rFaQ6Ctxhdx251+gz6kGXDaudfur28rW80yui84pIO3IH814tBNmntotJUzdTbCj0qgGDIf3ZJq8xbqP/RAH+pHF8JY+aWCrOfqYWGZy8jDPpFrNjcwvdBLgjbWFdj/VUziuypD4V2qRhQ/uXhAwZH5vRrkl4x/PG4velV+T0b15DnvJsmvQtCnISRkdFB1LbAEHZ0U8Ekf7iD9sk8pzo3ltpSKIpTlSqvGxzRAWr2m30ShDQ=;\n\t25:+3bZtMkiI+rIEdL726kSO0okNEJNil0gR+YF2u1vGhpVCawNzTFbl4+64ufnb10PG2bzYI9USscdWubntyBg9rWDhYY0IBaXUcPbl02Fr/lFzwRduqtCq9J7k+0GUn5Rm1xFYL4grZx7g7gsdPGdNmVrhtlqpMOGmKBha3S2mYo72NAd2oyivqkOHfj93mGGikDu/qvY/EGPqicXblmolJqjfioDf7dXFZDcnXsJm5eqRzS0/sxMpqK4Mo6w+Y4eJZvIFk9sTkAvNEUUyujMofGECV+Y6KYy3senwprdmteqYbs6G/0D1jaLEQzLQ4jfIUt1TSRab2CG2Zet0QyFIg==", "1; DM5PR03MB3324;\n\t31:DxmTJ+BOcPemBLRWF3eSFX5Gx9rduYFUHTl1gw9DFkb/fsU1CifqTiPPN5csbb53QK39ooF9oX9KPrwlhZsojG1R1omcAu3dfVIQprIhezNroUOt4P1ji4aRHWw3X1K0QQl9d6ojF/uPl074+8VN/f8CLl8rA7nxW/me/VuRe1ksfyVipSkQ6e5K76stjhXQlVyPpfyBCnFtQrPJBTlMD8NuLd+z4eevFbu8AOLS9LM=;\n\t4:SdWfO54+QOTbDNJNzmVSO5YodGPVBEUqgGBQiTmkyiKCMXIFkyZRR+timCaBTCQIw95rXHgL8mbSxEr3t47bsxebWDG2T8vkNpjFaeuRZpYoVOZp1TxcmYjSve/gdNG4pzPbIg8LCYE3QerE7fwzdIlD/FEAbnJoMRX+FmgOfpo+YalhBml1fC6NT4SFJEy2gaNbHnGYMBLf2CilXEPHwV7OvngXb8wXeZ7uJZ2Lne0O7/eQIwYWweze/WGK2+an+l1QMCTMAMhVUB+cjxqN2YX2dwpDGMeclHOafMXZp+c=", "=?us-ascii?Q?1; DM5PR03MB3324;\n\t23:z+rfLS0jr98iApB7FDOygj3nYtVlMADEO05Uu2phL?=\n\tHqVf29LTIyyOXzzBv5vQLgGIkW5eCe0EZicpz/6H8S3t4+vr6RbFEdmSQDRUh+llJ5PN9Ik06jxAgYLvakMaFob07zhBlX0Z+JQTxpK9dIYKpWh/0nh4lWQqORoXWQgfIHagcU5F0z3iKZQEENr/a65wcX+HoxiR2uSrHRJhaaqhGnaeY+AmsIslviDeCLlMO9oWhza/lr2NiKkqNXCT0A1tR6MPshUm46hgnmdhi21wr41lTsEUJ/HHmpDYZF/DroVM7soa+Rfbse9ETEL9mY51JE2h/mgt10FN5EC+llrBwjaagsstR8G7QmIv9KDD2K9v1qzhUbHFWYk2oauwoMMIbTgLO9Nv7M0NRVu09KVqOhyqyVB9YZTL+1lNl+kli8MoXwNz4HSHqfdpNNdhdMzP2us88l5jQ/soof1NMg/JQgnlIsBdLhpMLbyVzTEmfFKGf6f0QGH8IYB9JtXbHRUNv3mcthJz/U8//6RUB+oiqXe/iZkCHUV3TA4VeARmwMRKhPwMSOysF4YXe1jA1uumLpkO0juvB/gTav5HSZcx+zr9MbMr2fYtpyld3awYhNN33AO82D1BrCB/OWWAcOidqQORkJHfh4CHr35mS93yA58Zg8roBzFVpUzz3/5u7UDd/C3w4u/9/YtLJSJNNbujs6/DGsr7yMXc+5d7L7fw9DBeadxfebEJvHaBSATMpI31qIwr8t9JmIr+Da55vaqN5keVD9POYP9xHUcWdPqN8RqXNskhnPw63GLs2OJv3Y9mQY4XPjgrz35v2g6noge7F2u04RxJdqyvnkuULslpLtQU4+iTfJu+F7HGOWXK+9AZMTXX+ad6UXNNClrLOi/TWG2UZfMtSkXBttN0WaRWR1rn3SKIWjjg1dFfaF6IIuEUAwh1puGZGlENLsqcA7IY23DmhqlaB6THRdzAMjA/DKQWAd9NuBIWzBbugbNI+e4LN9TK4EZVtWQhnQ6Jg+F8m9D37ZYf7plPAXV2qCBCRettHBq3A+f3xVJn2BF1wSclD2SOqH1aRB2TbcS2K2COa3I/T1nKl4zSiNcYpGTTEKQVH7PEqW1Bmg5EY6wmTB3yUQaHCHHy4B20nuy6LTC", "1; DM5PR03MB3324;\n\t6:w8/N+n80pB9aKIn05zs+E3qt9fzHg17vMs3AXUa5YgOWLYNeLIC0jKnv0Nov9StMjCbfxz1mZ+bU2cRaK11uUYbyb1JUtXQVrMbKfZYV/B/U9Decbw6ChmGXrM3fvvLGLcvVuDNzm9p59bPpXsD6kIWCajv6xMZXPT0R4zAWeHIhRyxPPjjaKKZAqo/1L3Ge77tHA4kLH+/YM+Szs5am2S3REf2kHbFPknSqcb6082nvJVu14zkllDDxExlGZVYfoV2tScDurnqS+JI7eynLx+FpB4lFXMQX+CAE0sexhMcEtw2InexDYv3IRDefwCg+vW7hk1SUGb7IdNLFTYg2hw==;\n\t5:A8jBVZ4gC+QD+3epsadBzY+IutuDq9BkZ7GNhwSQDTAiqDPC8i1gEJncjnwd9ZQTtrKQx+vmTPg0Y3o1D+u+88dbRIlORR0qKWPSsljL0OqS7lUwML0uchBW6fDRJrLy82+RJoQ6GJIhJX7gWpF6MQ==;\n\t24:fQdDdHxLYoZShUbUMNGJ8nAyzyCpvzKh5es14ozJ7sGsdhyuG3ovrWHxA9SrCiIhJ9T2NBOFBrDPZUx+ZSl466zc5WpRcqcvsIdqSoOE+T8=;\n\t7:bhzAhfSQ6/EO/yoaUzhIIhfFLW+Fd4427fonpYRH94nlZXkg9lypjfjp4HLp0PQqA/5WZSxLWWND6gfrB4qA3MtVyNmBapYe2BGJbk5EOqxphUEDu0f39syEibpkiOdq0oDbj//sbcGKyXfHAO7GehN4OAJhy5YFwX+njwjbp6FCHddVoVqVD5M/Hgw2eBHYM5nhV2dXVZQVAEphyeADGToHbYxtHJWfky4qviZuP2Q=" ], "MIME-Version": "1.0", "Content-Type": "text/plain", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "2806db28-2218-455f-1da2-08d4e6367dc1", "X-Microsoft-Antispam": "UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(300000503095)(300135400095)(2017052603031)(201703131430075)(201703131517081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:DM5PR03MB3324; ", "X-MS-TrafficTypeDiagnostic": "DM5PR03MB3324:", "X-Exchange-Antispam-Report-Test": "UriScan:(185117386973197);", "X-Microsoft-Antispam-PRVS": "<DM5PR03MB3324DCA1DB3042BC90D371DF90800@DM5PR03MB3324.namprd03.prod.outlook.com>", "X-Exchange-Antispam-Report-CFA-Test": "BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(601004)(2401047)(13018025)(8121501046)(5005006)(13016025)(3002001)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(6055026)(6096035)(20161123561025)(20161123565025)(201703131430075)(201703131433075)(201703131448075)(201703161259150)(201703151042153)(20161123563025)(20161123559100)(20161123556025)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:DM5PR03MB3324; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:DM5PR03MB3324; ", "X-Forefront-PRVS": "040359335D", "SpamDiagnosticOutput": "1:99", "SpamDiagnosticMetadata": "NSPM", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "18 Aug 2017 12:41:47.6641\n\t(UTC)", "X-MS-Exchange-CrossTenant-Id": "5afe0b00-7697-4969-b663-5eab37d5f47e", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;\n\tIp=[192.88.168.50]; \n\tHelo=[tx30smr01.am.freescale.net]", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DM5PR03MB3324", "Subject": "[dpdk-dev] [PATCH 2/6] bus/fslmc: introduce new device type\n\tenumerator", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Existing devices and drivers depended on device ID rather than type.\nA new enumerator for all DPAA2 devices is introduced in this patch.\n\nAt this point, the probe would not be able to link DPAA2 devices\nwith the driver and I/O would not work. Subsequent patches will\nfix this.\n\nSigned-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>\n---\n drivers/bus/fslmc/fslmc_vfio.c | 6 +++---\n drivers/bus/fslmc/rte_bus_fslmc_version.map | 7 +++++++\n drivers/bus/fslmc/rte_fslmc.h | 24 ++++++++++++++++++++----\n 3 files changed, 30 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/bus/fslmc/fslmc_vfio.c b/drivers/bus/fslmc/fslmc_vfio.c\nindex 3423b57..3b452e1 100644\n--- a/drivers/bus/fslmc/fslmc_vfio.c\n+++ b/drivers/bus/fslmc/fslmc_vfio.c\n@@ -288,8 +288,8 @@ dpaa2_compare_dpaa2_dev(const struct rte_dpaa2_device *dev,\n \t\t\t const struct rte_dpaa2_device *dev2)\n {\n \t/*not the same family device */\n-\tif (dev->dev_type != DPAA2_MC_DPNI_DEVID ||\n-\t\t\tdev->dev_type != DPAA2_MC_DPSECI_DEVID)\n+\tif (dev->dev_type != DPAA2_ETH ||\n+\t\t\tdev->dev_type != DPAA2_CRYPTO)\n \t\treturn -1;\n \n \tif (dev->object_id == dev2->object_id)\n@@ -506,7 +506,7 @@ int fslmc_vfio_process_group(void)\n \t\t\t/* store hw_id of dpni/dpseci device */\n \t\t\tdev->object_id = object_id;\n \t\t\tdev->dev_type = (strcmp(object_type, \"dpseci\")) ?\n-\t\t\t\tDPAA2_MC_DPNI_DEVID : DPAA2_MC_DPSECI_DEVID;\n+\t\t\t\tDPAA2_ETH : DPAA2_CRYPTO;\n \n \t\t\tsprintf(dev->name, \"%s.%d\", object_type, object_id);\n \t\t\tdev->device.name = dev->name;\ndiff --git a/drivers/bus/fslmc/rte_bus_fslmc_version.map b/drivers/bus/fslmc/rte_bus_fslmc_version.map\nindex 3cdf14e..6ac256d 100644\n--- a/drivers/bus/fslmc/rte_bus_fslmc_version.map\n+++ b/drivers/bus/fslmc/rte_bus_fslmc_version.map\n@@ -77,3 +77,10 @@ DPDK_17.08 {\n \trte_global_active_dqs_list;\n \n } DPDK_17.05;\n+\n+DPDK_17.11 {\n+\tglobal:\n+\n+\trte_dpaa2_dev_type;\n+\n+} DPDK_17.08;\ndiff --git a/drivers/bus/fslmc/rte_fslmc.h b/drivers/bus/fslmc/rte_fslmc.h\nindex e60d6eb..ff7a49e 100644\n--- a/drivers/bus/fslmc/rte_fslmc.h\n+++ b/drivers/bus/fslmc/rte_fslmc.h\n@@ -56,6 +56,8 @@ extern \"C\" {\n #include <rte_dev.h>\n #include <rte_bus.h>\n \n+#define FSLMC_OBJECT_MAX_LEN 32 /**< Length of each device on bus */\n+\n struct rte_dpaa2_driver;\n \n /* DPAA2 Device and Driver lists for FSLMC bus */\n@@ -64,6 +66,20 @@ TAILQ_HEAD(rte_fslmc_driver_list, rte_dpaa2_driver);\n \n extern struct rte_fslmc_bus rte_fslmc_bus;\n \n+enum rte_dpaa2_dev_type {\n+\t/* Devices backed by DPDK driver */\n+\tDPAA2_ETH,\t/**< DPNI type device*/\n+\tDPAA2_CRYPTO,\t/**< DPSECI type device */\n+\tDPAA2_CON,\t/**< DPCONC type device */\n+\t/* Devices not backed by a DPDK driver: DPIO, DPBP, DPCI, DPMCP */\n+\tDPAA2_BPOOL,\t/**< DPBP type device */\n+\tDPAA2_IO,\t/**< DPIO type device */\n+\tDPAA2_CI,\t/**< DPCI type device */\n+\tDPAA2_MPORTAL, /**< DPMCP type device */\n+\t/* Unknown device placeholder */\n+\tDPAA2_UNKNOWN\n+};\n+\n /**\n * A structure describing a DPAA2 device.\n */\n@@ -74,11 +90,11 @@ struct rte_dpaa2_device {\n \t\tstruct rte_eth_dev *eth_dev; /**< ethernet device */\n \t\tstruct rte_cryptodev *cryptodev; /**< Crypto Device */\n \t};\n-\tuint16_t dev_type; /**< Device Type */\n-\tuint16_t object_id; /**< DPAA2 Object ID */\n+\tenum rte_dpaa2_dev_type dev_type; /**< Device Type */\n+\tuint16_t object_id; /**< DPAA2 Object ID */\n \tstruct rte_intr_handle intr_handle; /**< Interrupt handle */\n \tstruct rte_dpaa2_driver *driver; /**< Associated driver */\n-\tchar name[32]; /**< DPAA2 Object name*/\n+\tchar name[FSLMC_OBJECT_MAX_LEN]; /**< DPAA2 Object name*/\n };\n \n typedef int (*rte_dpaa2_probe_t)(struct rte_dpaa2_driver *dpaa2_drv,\n@@ -93,7 +109,7 @@ struct rte_dpaa2_driver {\n \tstruct rte_driver driver; /**< Inherit core driver. */\n \tstruct rte_fslmc_bus *fslmc_bus; /**< FSLMC bus reference */\n \tuint32_t drv_flags; /**< Flags for controlling device.*/\n-\tuint16_t drv_type; /**< Driver Type */\n+\tenum rte_dpaa2_dev_type drv_type; /**< Driver Type */\n \trte_dpaa2_probe_t probe;\n \trte_dpaa2_remove_t remove;\n };\n", "prefixes": [ "dpdk-dev", "2/6" ] }