Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/27498/?format=api
{ "id": 27498, "url": "http://patches.dpdk.org/api/patches/27498/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1502308684-28031-1-git-send-email-gage.eads@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1502308684-28031-1-git-send-email-gage.eads@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1502308684-28031-1-git-send-email-gage.eads@intel.com", "date": "2017-08-09T19:58:04", "name": "[dpdk-dev] eventdev: ease single-link queue config requirements", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b4ce3b8750baa0466145ed7ed07467ec2a21b26e", "submitter": { "id": 586, "url": "http://patches.dpdk.org/api/people/586/?format=api", "name": "Eads, Gage", "email": "gage.eads@intel.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1502308684-28031-1-git-send-email-gage.eads@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/27498/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/27498/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id AE3B42A5D;\n\tWed, 9 Aug 2017 21:58:54 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id C48A328C3\n\tfor <dev@dpdk.org>; Wed, 9 Aug 2017 21:58:52 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga105.fm.intel.com with ESMTP; 09 Aug 2017 12:58:51 -0700", "from txasoft-yocto.an.intel.com (HELO txasoft-yocto.an.intel.com.)\n\t([10.123.72.111])\n\tby orsmga002.jf.intel.com with ESMTP; 09 Aug 2017 12:58:50 -0700" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.41,349,1498546800\"; d=\"scan'208\";a=\"121798485\"", "From": "Gage Eads <gage.eads@intel.com>", "To": "dev@dpdk.org", "Cc": "jerin.jacob@caviumnetworks.com, nipun.gupta@nxp.com,\n\themant.agrawal@nxp.com, harry.van.haaren@intel.com,\n\tbruce.richardson@intel.com", "Date": "Wed, 9 Aug 2017 14:58:04 -0500", "Message-Id": "<1502308684-28031-1-git-send-email-gage.eads@intel.com>", "X-Mailer": "git-send-email 2.7.4", "Subject": "[dpdk-dev] [PATCH] eventdev: ease single-link queue config\n\trequirements", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Events sent through single-link queues are naturally in-order and\natomic, without reordering or atomic scheduling. Logically the\nnb_atomic_flows and nb_atomic_order_sequences arguments don't apply to a\nsingle link queue, but applications must set these (depending on the queue\nconfig type) to bypass the is_valid_{ordered, atomic}_queue_conf() checks\nin the eventdev layer.\n\nThis commit updates those is_valid_* functions to ignore queues with the\nSINGLE_LINK flag, to simplify their configuration.\n\nSigned-off-by: Gage Eads <gage.eads@intel.com>\n---\n examples/eventdev_pipeline_sw_pmd/main.c | 6 +-----\n lib/librte_eventdev/rte_eventdev.c | 8 ++++++--\n test/test/test_eventdev_sw.c | 4 ----\n 3 files changed, 7 insertions(+), 11 deletions(-)", "diff": "diff --git a/examples/eventdev_pipeline_sw_pmd/main.c b/examples/eventdev_pipeline_sw_pmd/main.c\nindex dd75cb7..09b90c3 100644\n--- a/examples/eventdev_pipeline_sw_pmd/main.c\n+++ b/examples/eventdev_pipeline_sw_pmd/main.c\n@@ -696,11 +696,7 @@ setup_eventdev(struct prod_data *prod_data,\n \t};\n \tconst struct rte_event_queue_conf tx_q_conf = {\n \t\t\t.priority = RTE_EVENT_DEV_PRIORITY_HIGHEST,\n-\t\t\t.event_queue_cfg =\n-\t\t\t\t\tRTE_EVENT_QUEUE_CFG_ATOMIC_ONLY |\n-\t\t\t\t\tRTE_EVENT_QUEUE_CFG_SINGLE_LINK,\n-\t\t\t.nb_atomic_flows = 1024,\n-\t\t\t.nb_atomic_order_sequences = 1024,\n+\t\t\t.event_queue_cfg = RTE_EVENT_QUEUE_CFG_SINGLE_LINK,\n \t};\n \n \tstruct port_link worker_queues[MAX_NUM_STAGES];\ndiff --git a/lib/librte_eventdev/rte_eventdev.c b/lib/librte_eventdev/rte_eventdev.c\nindex bbb3805..46bf24c 100644\n--- a/lib/librte_eventdev/rte_eventdev.c\n+++ b/lib/librte_eventdev/rte_eventdev.c\n@@ -519,7 +519,9 @@ rte_event_queue_default_conf_get(uint8_t dev_id, uint8_t queue_id,\n static inline int\n is_valid_atomic_queue_conf(const struct rte_event_queue_conf *queue_conf)\n {\n-\tif (queue_conf && (\n+\tif (queue_conf &&\n+\t\t!(queue_conf->event_queue_cfg &\n+\t\t RTE_EVENT_QUEUE_CFG_SINGLE_LINK) && (\n \t\t((queue_conf->event_queue_cfg &\n \t\t\tRTE_EVENT_QUEUE_CFG_TYPE_MASK)\n \t\t\t== RTE_EVENT_QUEUE_CFG_ALL_TYPES) ||\n@@ -535,7 +537,9 @@ is_valid_atomic_queue_conf(const struct rte_event_queue_conf *queue_conf)\n static inline int\n is_valid_ordered_queue_conf(const struct rte_event_queue_conf *queue_conf)\n {\n-\tif (queue_conf && (\n+\tif (queue_conf &&\n+\t\t!(queue_conf->event_queue_cfg &\n+\t\t RTE_EVENT_QUEUE_CFG_SINGLE_LINK) && (\n \t\t((queue_conf->event_queue_cfg &\n \t\t\tRTE_EVENT_QUEUE_CFG_TYPE_MASK)\n \t\t\t== RTE_EVENT_QUEUE_CFG_ALL_TYPES) ||\ndiff --git a/test/test/test_eventdev_sw.c b/test/test/test_eventdev_sw.c\nindex ba8c053..7219886 100644\n--- a/test/test/test_eventdev_sw.c\n+++ b/test/test/test_eventdev_sw.c\n@@ -267,8 +267,6 @@ create_directed_qids(struct test *t, int num_qids, const uint8_t ports[])\n \tstatic const struct rte_event_queue_conf conf = {\n \t\t\t.priority = RTE_EVENT_DEV_PRIORITY_NORMAL,\n \t\t\t.event_queue_cfg = RTE_EVENT_QUEUE_CFG_SINGLE_LINK,\n-\t\t\t.nb_atomic_flows = 1024,\n-\t\t\t.nb_atomic_order_sequences = 1024,\n \t};\n \n \tfor (i = t->nb_qids; i < t->nb_qids + num_qids; i++) {\n@@ -1334,8 +1332,6 @@ port_single_lb_reconfig(struct test *t)\n \tstatic const struct rte_event_queue_conf conf_single_link = {\n \t\t.priority = RTE_EVENT_DEV_PRIORITY_NORMAL,\n \t\t.event_queue_cfg = RTE_EVENT_QUEUE_CFG_SINGLE_LINK,\n-\t\t.nb_atomic_flows = 1024,\n-\t\t.nb_atomic_order_sequences = 1024,\n \t};\n \tif (rte_event_queue_setup(evdev, 1, &conf_single_link) < 0) {\n \t\tprintf(\"%d: error creating qid\\n\", __LINE__);\n", "prefixes": [ "dpdk-dev" ] }