Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 27337,
    "url": "http://patches.dpdk.org/api/patches/27337/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/4000051201bbc57f045ef760283598f2d0fd2683.1501598384.git.adrien.mazarguil@6wind.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<4000051201bbc57f045ef760283598f2d0fd2683.1501598384.git.adrien.mazarguil@6wind.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/4000051201bbc57f045ef760283598f2d0fd2683.1501598384.git.adrien.mazarguil@6wind.com",
    "date": "2017-08-01T16:54:08",
    "name": "[dpdk-dev,v1,21/48] net/mlx4: use standard QP attributes",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "16022bf4f6865968e145061c31c1e3d5c18cc7ba",
    "submitter": {
        "id": 165,
        "url": "http://patches.dpdk.org/api/people/165/?format=api",
        "name": "Adrien Mazarguil",
        "email": "adrien.mazarguil@6wind.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/4000051201bbc57f045ef760283598f2d0fd2683.1501598384.git.adrien.mazarguil@6wind.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/27337/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/27337/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id B7477A1A6;\n\tTue,  1 Aug 2017 18:55:48 +0200 (CEST)",
            "from mail-wm0-f41.google.com (mail-wm0-f41.google.com\n\t[74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 6E279A100\n\tfor <dev@dpdk.org>; Tue,  1 Aug 2017 18:55:21 +0200 (CEST)",
            "by mail-wm0-f41.google.com with SMTP id m85so20313019wma.1\n\tfor <dev@dpdk.org>; Tue, 01 Aug 2017 09:55:21 -0700 (PDT)",
            "from 6wind.com (host.78.145.23.62.rev.coltfrance.com.\n\t[62.23.145.78]) by smtp.gmail.com with ESMTPSA id\n\tt33sm32556895wrc.50.2017.08.01.09.55.18\n\t(version=TLS1_2 cipher=AES128-SHA bits=128/128);\n\tTue, 01 Aug 2017 09:55:19 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=syA7UtHj8C4U9f+95bs5e2LolaRwNKn3h4rB1r+606g=;\n\tb=JfOOBqVhBwej8WD7Sr6JshK56mhftUwbjAvY6yKPcxR/7J3gRDwZE79mizd/fU7kff\n\tVUGljRXENx1Kq+4VNL+A7kC7uPRgTsLDFcDHIveaJfpAxvlNkQLG9Ui0rRsOV1SLR8db\n\t3CF+w4OO+YuroN4Vf1WNSFyY3g2R4BcvL6cb1x3OTFbxauEsDnmtjbMEfUdvP/DUNmmW\n\tojsGVaXfI5dtrW8dkMF4NCYN1PpbS0frhC1GDkRdoUJUv8QSkZXdE0d8bM2Hgqri4J4r\n\tvTw9gI/GzcMn9Qq6KUYiBJeCErfAWsgWqPTrzNVP7c/ZDIrUe9WWKodogfRBFxFrzeuY\n\tWXcQ==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=syA7UtHj8C4U9f+95bs5e2LolaRwNKn3h4rB1r+606g=;\n\tb=nbtLUy/J7CJ8H90uNGtZLp2hy2TwRkMcYw+DgwRyt660r5B8bqaUMG+FsNO8AftyhL\n\tWgYH+eh3VgahkFXR/4xjt7E96DvURz8lLq9N5Tl1w7FTCxGobxu5gvE5jtZ/HDLW2rwh\n\tO079ivTILzEQZPlw+XdE+oT5dsuAFapyPMxiEeJbOLpgfKSWgkfNYYknui1rWuYbZ+4u\n\tWdeE1s34OOBmk+oUsgUTvkl6VPRwbXJKTg2ZxnA1u42Jm6xlAAq0T5hG4pnoawdd6BT+\n\tpGWYklPiMzcg5vfsAoMo/SXe8Uc+7FAvj7jp3g8UIUmJ9HAEsE0i0ngnaqEq46i9jGgI\n\tx+6Q==",
        "X-Gm-Message-State": "AIVw113NOIxFP9O5+OIjAlRXZAtpcka3fBDg1TfjmHBN5MLZpvUEXUN4\n\t2ZcUFal2VU96Z90RgjQ=",
        "X-Received": "by 10.28.72.212 with SMTP id v203mr1800498wma.2.1501606520979;\n\tTue, 01 Aug 2017 09:55:20 -0700 (PDT)",
        "From": "Adrien Mazarguil <adrien.mazarguil@6wind.com>",
        "To": "dev@dpdk.org",
        "Cc": "Moti Haimovsky <motih@mellanox.com>",
        "Date": "Tue,  1 Aug 2017 18:54:08 +0200",
        "Message-Id": "<4000051201bbc57f045ef760283598f2d0fd2683.1501598384.git.adrien.mazarguil@6wind.com>",
        "X-Mailer": "git-send-email 2.1.4",
        "In-Reply-To": "<cover.1501598383.git.adrien.mazarguil@6wind.com>",
        "References": "<cover.1501598383.git.adrien.mazarguil@6wind.com>",
        "Subject": "[dpdk-dev] [PATCH v1 21/48] net/mlx4: use standard QP attributes",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The Verbs API used to set QP attributes is deprecated. Revert to the\nstandard API since it actually supports the remaining ones.\n\nSigned-off-by: Moti Haimovsky <motih@mellanox.com>\nSigned-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>\n---\n drivers/net/mlx4/mlx4.c | 25 +++++++++++--------------\n 1 file changed, 11 insertions(+), 14 deletions(-)",
    "diff": "diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c\nindex 227c02c..773ba62 100644\n--- a/drivers/net/mlx4/mlx4.c\n+++ b/drivers/net/mlx4/mlx4.c\n@@ -1178,7 +1178,7 @@ txq_setup(struct rte_eth_dev *dev, struct txq *txq, uint16_t desc,\n \t\tstruct ibv_exp_qp_init_attr init;\n \t\tstruct ibv_exp_res_domain_init_attr rd;\n \t\tstruct ibv_exp_cq_init_attr cq;\n-\t\tstruct ibv_exp_qp_attr mod;\n+\t\tstruct ibv_qp_attr mod;\n \t} attr;\n \tenum ibv_exp_query_intf_status status;\n \tint ret = 0;\n@@ -1251,14 +1251,13 @@ txq_setup(struct rte_eth_dev *dev, struct txq *txq, uint16_t desc,\n \t}\n \t/* ibv_create_qp() updates this value. */\n \ttmpl.max_inline = attr.init.cap.max_inline_data;\n-\tattr.mod = (struct ibv_exp_qp_attr){\n+\tattr.mod = (struct ibv_qp_attr){\n \t\t/* Move the QP to this state. */\n \t\t.qp_state = IBV_QPS_INIT,\n \t\t/* Primary port number. */\n \t\t.port_num = priv->port\n \t};\n-\tret = ibv_exp_modify_qp(tmpl.qp, &attr.mod,\n-\t\t\t\t(IBV_EXP_QP_STATE | IBV_EXP_QP_PORT));\n+\tret = ibv_modify_qp(tmpl.qp, &attr.mod, IBV_QP_STATE | IBV_QP_PORT);\n \tif (ret) {\n \t\tERROR(\"%p: QP state to IBV_QPS_INIT failed: %s\",\n \t\t      (void *)dev, strerror(ret));\n@@ -1270,17 +1269,17 @@ txq_setup(struct rte_eth_dev *dev, struct txq *txq, uint16_t desc,\n \t\t      (void *)dev, strerror(ret));\n \t\tgoto error;\n \t}\n-\tattr.mod = (struct ibv_exp_qp_attr){\n+\tattr.mod = (struct ibv_qp_attr){\n \t\t.qp_state = IBV_QPS_RTR\n \t};\n-\tret = ibv_exp_modify_qp(tmpl.qp, &attr.mod, IBV_EXP_QP_STATE);\n+\tret = ibv_modify_qp(tmpl.qp, &attr.mod, IBV_QP_STATE);\n \tif (ret) {\n \t\tERROR(\"%p: QP state to IBV_QPS_RTR failed: %s\",\n \t\t      (void *)dev, strerror(ret));\n \t\tgoto error;\n \t}\n \tattr.mod.qp_state = IBV_QPS_RTS;\n-\tret = ibv_exp_modify_qp(tmpl.qp, &attr.mod, IBV_EXP_QP_STATE);\n+\tret = ibv_modify_qp(tmpl.qp, &attr.mod, IBV_QP_STATE);\n \tif (ret) {\n \t\tERROR(\"%p: QP state to IBV_QPS_RTS failed: %s\",\n \t\t      (void *)dev, strerror(ret));\n@@ -1958,7 +1957,7 @@ rxq_setup(struct rte_eth_dev *dev, struct rxq *rxq, uint16_t desc,\n \t\t.mp = mp,\n \t\t.socket = socket\n \t};\n-\tstruct ibv_exp_qp_attr mod;\n+\tstruct ibv_qp_attr mod;\n \tunion {\n \t\tstruct ibv_exp_query_intf_params params;\n \t\tstruct ibv_exp_cq_init_attr cq;\n@@ -2046,15 +2045,13 @@ rxq_setup(struct rte_eth_dev *dev, struct rxq *rxq, uint16_t desc,\n \t\t      (void *)dev, strerror(ret));\n \t\tgoto error;\n \t}\n-\tmod = (struct ibv_exp_qp_attr){\n+\tmod = (struct ibv_qp_attr){\n \t\t/* Move the QP to this state. */\n \t\t.qp_state = IBV_QPS_INIT,\n \t\t/* Primary port number. */\n \t\t.port_num = priv->port\n \t};\n-\tret = ibv_exp_modify_qp(tmpl.qp, &mod,\n-\t\t\t\tIBV_EXP_QP_STATE |\n-\t\t\t\tIBV_EXP_QP_PORT);\n+\tret = ibv_modify_qp(tmpl.qp, &mod, IBV_QP_STATE | IBV_QP_PORT);\n \tif (ret) {\n \t\tERROR(\"%p: QP state to IBV_QPS_INIT failed: %s\",\n \t\t      (void *)dev, strerror(ret));\n@@ -2074,10 +2071,10 @@ rxq_setup(struct rte_eth_dev *dev, struct rxq *rxq, uint16_t desc,\n \t\t      strerror(ret));\n \t\tgoto error;\n \t}\n-\tmod = (struct ibv_exp_qp_attr){\n+\tmod = (struct ibv_qp_attr){\n \t\t.qp_state = IBV_QPS_RTR\n \t};\n-\tret = ibv_exp_modify_qp(tmpl.qp, &mod, IBV_EXP_QP_STATE);\n+\tret = ibv_modify_qp(tmpl.qp, &mod, IBV_QP_STATE);\n \tif (ret) {\n \t\tERROR(\"%p: QP state to IBV_QPS_RTR failed: %s\",\n \t\t      (void *)dev, strerror(ret));\n",
    "prefixes": [
        "dpdk-dev",
        "v1",
        "21/48"
    ]
}