Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 27331,
    "url": "http://patches.dpdk.org/api/patches/27331/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/4cf0652c62c38e867e96a30cf878557ef88a540a.1501598384.git.adrien.mazarguil@6wind.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<4cf0652c62c38e867e96a30cf878557ef88a540a.1501598384.git.adrien.mazarguil@6wind.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/4cf0652c62c38e867e96a30cf878557ef88a540a.1501598384.git.adrien.mazarguil@6wind.com",
    "date": "2017-08-01T16:54:07",
    "name": "[dpdk-dev,v1,20/48] net/mlx4: drop inline receive support",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "e5a18e60a62162f8114c2d714b85a0e5c08f9810",
    "submitter": {
        "id": 165,
        "url": "http://patches.dpdk.org/api/people/165/?format=api",
        "name": "Adrien Mazarguil",
        "email": "adrien.mazarguil@6wind.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/4cf0652c62c38e867e96a30cf878557ef88a540a.1501598384.git.adrien.mazarguil@6wind.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/27331/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/27331/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 2D5ADA182;\n\tTue,  1 Aug 2017 18:55:42 +0200 (CEST)",
            "from mail-wr0-f174.google.com (mail-wr0-f174.google.com\n\t[209.85.128.174]) by dpdk.org (Postfix) with ESMTP id 5944DA100\n\tfor <dev@dpdk.org>; Tue,  1 Aug 2017 18:55:19 +0200 (CEST)",
            "by mail-wr0-f174.google.com with SMTP id f21so9176975wrf.5\n\tfor <dev@dpdk.org>; Tue, 01 Aug 2017 09:55:19 -0700 (PDT)",
            "from 6wind.com (host.78.145.23.62.rev.coltfrance.com.\n\t[62.23.145.78]) by smtp.gmail.com with ESMTPSA id\n\tw136sm1718687wmd.45.2017.08.01.09.55.17\n\t(version=TLS1_2 cipher=AES128-SHA bits=128/128);\n\tTue, 01 Aug 2017 09:55:17 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=1V2Ariio45cSq7bky8tu2T2YvIChQy7DSR9cQ0dZDto=;\n\tb=wsaNYIcLAxMEJH+JrQGZAgvWg9Ii3Q6zSBEQ+DMEhs1SMNeKm2kXGvNYDPqt//Oi7Q\n\trl2VppuVfu9933RrD4g908x7iHd4kjYTNv/LAEKlaWaCCKFzVsiPdu1h8GHR5GcKGsfK\n\toBDzL0S3jkyihMMAITIXFJbafGoK1cc5Y+OzgdfuQ3wRRli1Wj85dVcXfmi5/7ikb97y\n\tov3QQJOgtEt5T6lYV30Le6D6CiGH5gDNnB8qBEXq62LxGnEKDI+aAjVhCCleGq/wvfJd\n\tJ8+J6cbvFt2e+KcDiigKcnWd8t74pqj6SNamBkapS29ihBOpu6226n2W9Q17dW0oNtY2\n\t00Vw==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=1V2Ariio45cSq7bky8tu2T2YvIChQy7DSR9cQ0dZDto=;\n\tb=M1YdUGNWwBoQ5hY0pVrsJyhuTGUwP6O0cqkn+58r+o2yRvWmZ6TiNPBThhObDEzbco\n\tpcnEuUCh679VCpqQNo4FxnFCuzrJkC5J8AeqenTI1UH91tgQpa62i1tVZlZJcdkqUrxY\n\tIVT6E9Fp+w9FQgssD4oJ2edujvVfUkx1V9JEtcI7P/vSPR7y6WOXVdk4/xAF9/ui0HSr\n\tZgbJr05bGXpf9zK8YHw89cQgGBITq+zTyChThn3ZXoZsne7i/4Mui63r67uIB+dN7CS4\n\trP9krZd8iUTzisy/qSk9cgTTII2SB9MwMLyOXWgSR/wzDeenu6sWZaG0AY1NT0K7re0d\n\tP2PQ==",
        "X-Gm-Message-State": "AIVw112ZXSXIYCvn8xj6WT5AhfkHH4s0pwZ9By805J1RavP4zen5Qpjo\n\tGAcg1f0rimYzl/JdRCM=",
        "X-Received": "by 10.223.139.219 with SMTP id\n\tw27mr14920547wra.146.1501606518615; \n\tTue, 01 Aug 2017 09:55:18 -0700 (PDT)",
        "From": "Adrien Mazarguil <adrien.mazarguil@6wind.com>",
        "To": "dev@dpdk.org",
        "Cc": "Moti Haimovsky <motih@mellanox.com>",
        "Date": "Tue,  1 Aug 2017 18:54:07 +0200",
        "Message-Id": "<4cf0652c62c38e867e96a30cf878557ef88a540a.1501598384.git.adrien.mazarguil@6wind.com>",
        "X-Mailer": "git-send-email 2.1.4",
        "In-Reply-To": "<cover.1501598383.git.adrien.mazarguil@6wind.com>",
        "References": "<cover.1501598383.git.adrien.mazarguil@6wind.com>",
        "Subject": "[dpdk-dev] [PATCH v1 20/48] net/mlx4: drop inline receive support",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The Verbs API used to implement inline receive is deprecated.\nSupport will be added back after refactoring the PMD.\n\nSigned-off-by: Moti Haimovsky <motih@mellanox.com>\nSigned-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>\n---\n drivers/net/mlx4/mlx4.c | 52 --------------------------------------------\n drivers/net/mlx4/mlx4.h |  1 -\n 2 files changed, 53 deletions(-)",
    "diff": "diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c\nindex 5546c0a..227c02c 100644\n--- a/drivers/net/mlx4/mlx4.c\n+++ b/drivers/net/mlx4/mlx4.c\n@@ -1925,8 +1925,6 @@ rxq_setup_qp(struct priv *priv, struct ibv_cq *cq, uint16_t desc,\n \t\t.res_domain = rd,\n \t};\n \n-\tattr.max_inl_recv = priv->inl_recv_size,\n-\tattr.comp_mask |= IBV_EXP_QP_INIT_ATTR_INL_RECV;\n \treturn ibv_exp_create_qp(priv->ctx, &attr);\n }\n \n@@ -2988,25 +2986,6 @@ priv_get_mac(struct priv *priv, uint8_t (*mac)[ETHER_ADDR_LEN])\n \treturn 0;\n }\n \n-/**\n- * Retrieve integer value from environment variable.\n- *\n- * @param[in] name\n- *   Environment variable name.\n- *\n- * @return\n- *   Integer value, 0 if the variable is not set.\n- */\n-static int\n-mlx4_getenv_int(const char *name)\n-{\n-\tconst char *val = getenv(name);\n-\n-\tif (val == NULL)\n-\t\treturn 0;\n-\treturn atoi(val);\n-}\n-\n static void\n mlx4_dev_link_status_handler(void *);\n static void\n@@ -3649,13 +3628,11 @@ mlx4_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev)\n \t\tstruct ibv_pd *pd = NULL;\n \t\tstruct priv *priv = NULL;\n \t\tstruct rte_eth_dev *eth_dev = NULL;\n-\t\tstruct ibv_exp_device_attr exp_device_attr;\n \t\tstruct ether_addr mac;\n \n \t\t/* If port is not enabled, skip. */\n \t\tif (!(conf.ports.enabled & (1 << i)))\n \t\t\tcontinue;\n-\t\texp_device_attr.comp_mask = IBV_EXP_DEVICE_ATTR_EXP_CAP_FLAGS;\n \n \t\tDEBUG(\"using port %u\", port);\n \n@@ -3708,35 +3685,6 @@ mlx4_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev)\n \t\tpriv->port = port;\n \t\tpriv->pd = pd;\n \t\tpriv->mtu = ETHER_MTU;\n-\t\tif (ibv_exp_query_device(ctx, &exp_device_attr)) {\n-\t\t\tERROR(\"ibv_exp_query_device() failed\");\n-\t\t\terr = ENODEV;\n-\t\t\tgoto port_error;\n-\t\t}\n-\n-\t\tpriv->inl_recv_size = mlx4_getenv_int(\"MLX4_INLINE_RECV_SIZE\");\n-\n-\t\tif (priv->inl_recv_size) {\n-\t\t\texp_device_attr.comp_mask =\n-\t\t\t\tIBV_EXP_DEVICE_ATTR_INLINE_RECV_SZ;\n-\t\t\tif (ibv_exp_query_device(ctx, &exp_device_attr)) {\n-\t\t\t\tINFO(\"Couldn't query device for inline-receive\"\n-\t\t\t\t     \" capabilities.\");\n-\t\t\t\tpriv->inl_recv_size = 0;\n-\t\t\t} else {\n-\t\t\t\tif ((unsigned)exp_device_attr.inline_recv_sz <\n-\t\t\t\t    priv->inl_recv_size) {\n-\t\t\t\t\tINFO(\"Max inline-receive (%d) <\"\n-\t\t\t\t\t     \" requested inline-receive (%u)\",\n-\t\t\t\t\t     exp_device_attr.inline_recv_sz,\n-\t\t\t\t\t     priv->inl_recv_size);\n-\t\t\t\t\tpriv->inl_recv_size =\n-\t\t\t\t\t\texp_device_attr.inline_recv_sz;\n-\t\t\t\t}\n-\t\t\t}\n-\t\t\tINFO(\"Set inline receive size to %u\",\n-\t\t\t     priv->inl_recv_size);\n-\t\t}\n \n \t\tpriv->vf = vf;\n \t\t/* Configure the first MAC address by default. */\ndiff --git a/drivers/net/mlx4/mlx4.h b/drivers/net/mlx4/mlx4.h\nindex 38c93f1..66efb98 100644\n--- a/drivers/net/mlx4/mlx4.h\n+++ b/drivers/net/mlx4/mlx4.h\n@@ -217,7 +217,6 @@ struct priv {\n \tunsigned int vf:1; /* This is a VF device. */\n \tunsigned int pending_alarm:1; /* An alarm is pending. */\n \tunsigned int isolated:1; /* Toggle isolated mode. */\n-\tunsigned int inl_recv_size; /* Inline recv size */\n \t/* RX/TX queues. */\n \tunsigned int rxqs_n; /* RX queues array size. */\n \tunsigned int txqs_n; /* TX queues array size. */\n",
    "prefixes": [
        "dpdk-dev",
        "v1",
        "20/48"
    ]
}