Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/27245/?format=api
{ "id": 27245, "url": "http://patches.dpdk.org/api/patches/27245/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1501241979-15767-1-git-send-email-xiaoyun.li@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1501241979-15767-1-git-send-email-xiaoyun.li@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1501241979-15767-1-git-send-email-xiaoyun.li@intel.com", "date": "2017-07-28T11:39:39", "name": "[dpdk-dev,v2] net/i40e: fix PF notify issue when VF not up", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b85ec6be2da655d5c07c7b2188c0dd2bd32db7d8", "submitter": { "id": 798, "url": "http://patches.dpdk.org/api/people/798/?format=api", "name": "Li, Xiaoyun", "email": "xiaoyun.li@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1501241979-15767-1-git-send-email-xiaoyun.li@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/27245/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/27245/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 6A0C79141;\n\tFri, 28 Jul 2017 05:50:30 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 3F2789135;\n\tFri, 28 Jul 2017 05:50:28 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t27 Jul 2017 20:50:27 -0700", "from dpdk-lixiaoyun.sh.intel.com ([10.67.111.94])\n\tby orsmga001.jf.intel.com with ESMTP; 27 Jul 2017 20:50:26 -0700" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.40,423,1496127600\"; d=\"scan'208\";\n\ta=\"1156250193\"", "From": "Xiaoyun Li <xiaoyun.li@intel.com>", "To": "jingjing.wu@intel.com", "Cc": "dev@dpdk.org,\n\tXiaoyun Li <xiaoyun.li@intel.com>,\n\tstable@dpdk.org", "Date": "Fri, 28 Jul 2017 19:39:39 +0800", "Message-Id": "<1501241979-15767-1-git-send-email-xiaoyun.li@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1500921763-115209-1-git-send-email-xiaoyun.li@intel.com>", "References": "<1500921763-115209-1-git-send-email-xiaoyun.li@intel.com>", "Subject": "[dpdk-dev] [PATCH v2] net/i40e: fix PF notify issue when VF not up", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch modifies PF notify error to warning when not starting\nup VF and modifies VF state to active when VF reset is completed.\n\nFixes: 4861cde46116 (\"i40e: new poll mode driver\")\nCc: stable@dpdk.org\n\nSigned-off-by: Xiaoyun Li <xiaoyun.li@intel.com>\n---\nv2 changes:\n* add VF state modification when VF reset is done.\n---\n drivers/net/i40e/i40e_pf.c | 33 +++++++++++++++++++--------------\n 1 file changed, 19 insertions(+), 14 deletions(-)", "diff": "diff --git a/drivers/net/i40e/i40e_pf.c b/drivers/net/i40e/i40e_pf.c\nindex b4cf57f..5d5d24a 100644\n--- a/drivers/net/i40e/i40e_pf.c\n+++ b/drivers/net/i40e/i40e_pf.c\n@@ -152,22 +152,23 @@ i40e_pf_host_vf_reset(struct i40e_pf_vf *vf, bool do_hw_reset)\n \t\tval |= I40E_VPGEN_VFRTRIG_VFSWR_MASK;\n \t\tI40E_WRITE_REG(hw, I40E_VPGEN_VFRTRIG(vf_id), val);\n \t\tI40E_WRITE_FLUSH(hw);\n-\t}\n \n #define VFRESET_MAX_WAIT_CNT 100\n-\t/* Wait until VF reset is done */\n-\tfor (i = 0; i < VFRESET_MAX_WAIT_CNT; i++) {\n-\t\trte_delay_us(10);\n-\t\tval = I40E_READ_REG(hw, I40E_VPGEN_VFRSTAT(vf_id));\n-\t\tif (val & I40E_VPGEN_VFRSTAT_VFRD_MASK)\n-\t\t\tbreak;\n-\t}\n+\t\t/* Wait until VF reset is done */\n+\t\tfor (i = 0; i < VFRESET_MAX_WAIT_CNT; i++) {\n+\t\t\trte_delay_us(10);\n+\t\t\tval = I40E_READ_REG(hw, I40E_VPGEN_VFRSTAT(vf_id));\n+\t\t\tif (val & I40E_VPGEN_VFRSTAT_VFRD_MASK) {\n+\t\t\t\tvf->state = I40E_VF_ACTIVE;\n+\t\t\t\tbreak;\n+\t\t\t}\n+\t\t}\n \n-\tif (i >= VFRESET_MAX_WAIT_CNT) {\n-\t\tPMD_DRV_LOG(ERR, \"VF reset timeout\");\n-\t\treturn -ETIMEDOUT;\n+\t\tif (i >= VFRESET_MAX_WAIT_CNT) {\n+\t\t\tPMD_DRV_LOG(ERR, \"VF reset timeout\");\n+\t\t\treturn -ETIMEDOUT;\n+\t\t}\n \t}\n-\n \t/* This is not first time to do reset, do cleanup job first */\n \tif (vf->vsi) {\n \t\t/* Disable queues */\n@@ -267,8 +268,12 @@ i40e_pf_host_send_msg_to_vf(struct i40e_pf_vf *vf,\n \tret = i40e_aq_send_msg_to_vf(hw, abs_vf_id, opcode, retval,\n \t\t\t\t\t\tmsg, msglen, NULL);\n \tif (ret) {\n-\t\tPMD_INIT_LOG(ERR, \"Fail to send message to VF, err %u\",\n-\t\t\t hw->aq.asq_last_status);\n+\t\tif (vf->state == I40E_VF_INACTIVE)\n+\t\t\tPMD_DRV_LOG(WARNING, \"Warning! VF %u is inactive now!\",\n+\t\t\t\tabs_vf_id);\n+\t\telse\n+\t\t\tPMD_INIT_LOG(ERR, \"Fail to send message to VF, err %u\",\n+\t\t\t\thw->aq.asq_last_status);\n \t}\n \n \treturn ret;\n", "prefixes": [ "dpdk-dev", "v2" ] }