Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 26961,
    "url": "http://patches.dpdk.org/api/patches/26961/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1e5819dd14c6c021b6aeadd36442a7c2c50c9b23.1500130635.git.gaetan.rivet@6wind.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1e5819dd14c6c021b6aeadd36442a7c2c50c9b23.1500130635.git.gaetan.rivet@6wind.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1e5819dd14c6c021b6aeadd36442a7c2c50c9b23.1500130635.git.gaetan.rivet@6wind.com",
    "date": "2017-07-15T17:57:40",
    "name": "[dpdk-dev,v10,11/11] net/failsafe: support flow API isolation mode",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "59e2cb2a2b1142f7df7beadefaccca117f4b7e17",
    "submitter": {
        "id": 269,
        "url": "http://patches.dpdk.org/api/people/269/?format=api",
        "name": "Gaëtan Rivet",
        "email": "gaetan.rivet@6wind.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1e5819dd14c6c021b6aeadd36442a7c2c50c9b23.1500130635.git.gaetan.rivet@6wind.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/26961/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/26961/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 75CE55A6E;\n\tSat, 15 Jul 2017 19:58:43 +0200 (CEST)",
            "from mail-wm0-f45.google.com (mail-wm0-f45.google.com\n\t[74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 3E52D5599\n\tfor <dev@dpdk.org>; Sat, 15 Jul 2017 19:58:08 +0200 (CEST)",
            "by mail-wm0-f45.google.com with SMTP id 70so15134163wmo.1\n\tfor <dev@dpdk.org>; Sat, 15 Jul 2017 10:58:08 -0700 (PDT)",
            "from bidouze.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com.\n\t[62.23.145.78]) by smtp.gmail.com with ESMTPSA id\n\tg82sm6342745wmg.8.2017.07.15.10.58.06\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tSat, 15 Jul 2017 10:58:06 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:in-reply-to:references;\n\tbh=9k2JGIXyLU+9NNHr8vY0RnmttnFtDMdSgfJxYnMWULE=;\n\tb=ZqqWQ/11GB3E/jCq5KQKiUNO0vwJa1eojW5mhdp9WeBg7r9SKyQ5wlanYXEpKYY5MW\n\tzAZm18z4+oOhBxIGAW/xZ3A3dH+6Vye631x2NprL0WlyPntJ6/Zgiq4qM4z5Kz3PBZhp\n\tv4rINKgkgTlwj7sdjNSCBOTyp+2Y6ww+dZEl6vp/ljlDDX3t/vkEqX6J22embfCWItq7\n\t2+tMbzXaJxv2cT5L+lNOvIS0ZXVKNRGgrVvP43vXN7zmUBZ6L6yukpItoRwDthqiMeZf\n\tguzyhn2OODem79f/0wX0AvNM7VYoZQl8CsPFQFo9jff1yQn9Og41cl5SHAQC7U8522BZ\n\tSZHQ==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:in-reply-to:references;\n\tbh=9k2JGIXyLU+9NNHr8vY0RnmttnFtDMdSgfJxYnMWULE=;\n\tb=MJYeruhmgvcRInpuPCS5uHcFY5DdodbQq0EJxIWfbvBF8LG5P2pq3ekaP6mwx5bGX1\n\tNavBviVZfs7ejucknweVDMT+QXq3OuCoq9QiX5w6+XOoOSMWvN9sVIAjcad7hlS//PS0\n\tcrCmiSJWClPomyvOlZGT+9sSh6U5uYlmelUTHmXktK1xsqP4AuHTJAYeATwf2s+Iv9UX\n\ta/PIy50hyieHqNPY246MxLpG6fCxMBJvgyVYD1pUnJmpEcsxYzbERkc9oZiFUDPFNs9h\n\tMrdKkp2aPQGHiGZlvh0BMfO1H4KrHtrToDP6bSkB4g4KmYF1Ip6GcL3T9yo+Nwe7BmD5\n\tRyKA==",
        "X-Gm-Message-State": "AIVw110M/m4Ti7OKy4vzjkMiuyUl6mbpNQ+l4rlMdDNKTsim+EFx/c2x\n\ta6AyXMacoEMnxhpnkS0=",
        "X-Received": "by 10.28.98.66 with SMTP id w63mr1534134wmb.34.1500141487605;\n\tSat, 15 Jul 2017 10:58:07 -0700 (PDT)",
        "From": "Gaetan Rivet <gaetan.rivet@6wind.com>",
        "To": "dev@dpdk.org",
        "Cc": "Gaetan Rivet <gaetan.rivet@6wind.com>",
        "Date": "Sat, 15 Jul 2017 19:57:40 +0200",
        "Message-Id": "<1e5819dd14c6c021b6aeadd36442a7c2c50c9b23.1500130635.git.gaetan.rivet@6wind.com>",
        "X-Mailer": "git-send-email 2.1.4",
        "In-Reply-To": [
            "<cover.1500130634.git.gaetan.rivet@6wind.com>",
            "<cover.1500130634.git.gaetan.rivet@6wind.com>"
        ],
        "References": [
            "<cover.1499815140.git.gaetan.rivet@6wind.com>\n\t<cover.1500130634.git.gaetan.rivet@6wind.com>",
            "<cover.1500130634.git.gaetan.rivet@6wind.com>"
        ],
        "Subject": "[dpdk-dev] [PATCH v10 11/11] net/failsafe: support flow API\n\tisolation mode",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>\n---\n drivers/net/failsafe/failsafe_ether.c   | 34 +++++++++++++++++++++++++++++++--\n drivers/net/failsafe/failsafe_flow.c    | 29 ++++++++++++++++++++++++++++\n drivers/net/failsafe/failsafe_private.h |  4 ++++\n 3 files changed, 65 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/drivers/net/failsafe/failsafe_ether.c b/drivers/net/failsafe/failsafe_ether.c\nindex a694b4d..c8b9c8a 100644\n--- a/drivers/net/failsafe/failsafe_ether.c\n+++ b/drivers/net/failsafe/failsafe_ether.c\n@@ -74,6 +74,28 @@ fs_flow_complain(struct rte_flow_error *error)\n }\n \n static int\n+eth_dev_flow_isolate_set(struct rte_eth_dev *dev,\n+\t\t\t struct sub_device *sdev)\n+{\n+\tstruct rte_flow_error ferror;\n+\tint ret;\n+\n+\tif (!PRIV(dev)->flow_isolated) {\n+\t\tDEBUG(\"Flow isolation already disabled\");\n+\t} else {\n+\t\tDEBUG(\"Enabling flow isolation\");\n+\t\tret = rte_flow_isolate(PORT_ID(sdev),\n+\t\t\t\t       PRIV(dev)->flow_isolated,\n+\t\t\t\t       &ferror);\n+\t\tif (ret) {\n+\t\t\tfs_flow_complain(&ferror);\n+\t\t\treturn ret;\n+\t\t}\n+\t}\n+\treturn 0;\n+}\n+\n+static int\n fs_eth_dev_conf_apply(struct rte_eth_dev *dev,\n \t\tstruct sub_device *sdev)\n {\n@@ -334,9 +356,17 @@ failsafe_eth_dev_state_sync(struct rte_eth_dev *dev)\n \tif (PRIV(dev)->state < DEV_ACTIVE)\n \t\treturn 0;\n \tinactive = 0;\n-\tFOREACH_SUBDEV(sdev, i, dev)\n-\t\tif (sdev->state == DEV_PROBED)\n+\tFOREACH_SUBDEV(sdev, i, dev) {\n+\t\tif (sdev->state == DEV_PROBED) {\n \t\t\tinactive |= UINT32_C(1) << i;\n+\t\t\tret = eth_dev_flow_isolate_set(dev, sdev);\n+\t\t\tif (ret) {\n+\t\t\t\tERROR(\"Could not apply configuration to sub_device %d\",\n+\t\t\t\t      i);\n+\t\t\t\tgoto err_remove;\n+\t\t\t}\n+\t\t}\n+\t}\n \tret = dev->dev_ops->dev_configure(dev);\n \tif (ret)\n \t\tgoto err_remove;\ndiff --git a/drivers/net/failsafe/failsafe_flow.c b/drivers/net/failsafe/failsafe_flow.c\nindex 8547e51..5217adf 100644\n--- a/drivers/net/failsafe/failsafe_flow.c\n+++ b/drivers/net/failsafe/failsafe_flow.c\n@@ -206,10 +206,39 @@ fs_flow_query(struct rte_eth_dev *dev,\n \treturn -1;\n }\n \n+static int\n+fs_flow_isolate(struct rte_eth_dev *dev,\n+\t\tint set,\n+\t\tstruct rte_flow_error *error)\n+{\n+\tstruct sub_device *sdev;\n+\tuint8_t i;\n+\tint ret;\n+\n+\tFOREACH_SUBDEV(sdev, i, dev) {\n+\t\tif (sdev->state < DEV_PROBED)\n+\t\t\tcontinue;\n+\t\tDEBUG(\"Calling rte_flow_isolate on sub_device %d\", i);\n+\t\tif (PRIV(dev)->flow_isolated != sdev->flow_isolated)\n+\t\t\tWARN(\"flow isolation mode of sub_device %d in incoherent state.\",\n+\t\t\t\ti);\n+\t\tret = rte_flow_isolate(PORT_ID(sdev), set, error);\n+\t\tif (ret) {\n+\t\t\tERROR(\"Operation rte_flow_isolate failed for sub_device %d\"\n+\t\t\t      \" with error %d\", i, ret);\n+\t\t\treturn ret;\n+\t\t}\n+\t\tsdev->flow_isolated = set;\n+\t}\n+\tPRIV(dev)->flow_isolated = set;\n+\treturn 0;\n+}\n+\n const struct rte_flow_ops fs_flow_ops = {\n \t.validate = fs_flow_validate,\n \t.create = fs_flow_create,\n \t.destroy = fs_flow_destroy,\n \t.flush = fs_flow_flush,\n \t.query = fs_flow_query,\n+\t.isolate = fs_flow_isolate,\n };\ndiff --git a/drivers/net/failsafe/failsafe_private.h b/drivers/net/failsafe/failsafe_private.h\nindex a9cddbc..1bff123 100644\n--- a/drivers/net/failsafe/failsafe_private.h\n+++ b/drivers/net/failsafe/failsafe_private.h\n@@ -108,6 +108,8 @@ struct sub_device {\n \tstruct rte_eth_dev *fs_dev;\n \t/* flag calling for recollection */\n \tvolatile unsigned int remove:1;\n+\t/* flow isolation state */\n+\tint flow_isolated:1;\n };\n \n struct fs_priv {\n@@ -139,6 +141,8 @@ struct fs_priv {\n \t */\n \tenum dev_state state;\n \tunsigned int pending_alarm:1; /* An alarm is pending */\n+\t/* flow isolation state */\n+\tint flow_isolated:1;\n };\n \n /* MISC */\n",
    "prefixes": [
        "dpdk-dev",
        "v10",
        "11/11"
    ]
}